window-basic-filters.cpp 34 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237
  1. /******************************************************************************
  2. Copyright (C) 2015 by Hugh Bailey <[email protected]>
  3. This program is free software: you can redistribute it and/or modify
  4. it under the terms of the GNU General Public License as published by
  5. the Free Software Foundation, either version 2 of the License, or
  6. (at your option) any later version.
  7. This program is distributed in the hope that it will be useful,
  8. but WITHOUT ANY WARRANTY; without even the implied warranty of
  9. MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  10. GNU General Public License for more details.
  11. You should have received a copy of the GNU General Public License
  12. along with this program. If not, see <http://www.gnu.org/licenses/>.
  13. ******************************************************************************/
  14. #include "properties-view.hpp"
  15. #include "window-namedialog.hpp"
  16. #include "window-basic-main.hpp"
  17. #include "window-basic-filters.hpp"
  18. #include "display-helpers.hpp"
  19. #include "qt-wrappers.hpp"
  20. #include "visibility-item-widget.hpp"
  21. #include "item-widget-helpers.hpp"
  22. #include "obs-app.hpp"
  23. #include "undo-stack-obs.hpp"
  24. #include <QMessageBox>
  25. #include <QCloseEvent>
  26. #include <obs-data.h>
  27. #include <obs.h>
  28. #include <util/base.h>
  29. #include <vector>
  30. #include <string>
  31. #include <QMenu>
  32. #include <QVariant>
  33. using namespace std;
  34. Q_DECLARE_METATYPE(OBSSource);
  35. OBSBasicFilters::OBSBasicFilters(QWidget *parent, OBSSource source_)
  36. : QDialog(parent),
  37. ui(new Ui::OBSBasicFilters),
  38. source(source_),
  39. addSignal(obs_source_get_signal_handler(source), "filter_add",
  40. OBSBasicFilters::OBSSourceFilterAdded, this),
  41. removeSignal(obs_source_get_signal_handler(source), "filter_remove",
  42. OBSBasicFilters::OBSSourceFilterRemoved, this),
  43. reorderSignal(obs_source_get_signal_handler(source),
  44. "reorder_filters", OBSBasicFilters::OBSSourceReordered,
  45. this),
  46. removeSourceSignal(obs_source_get_signal_handler(source), "remove",
  47. OBSBasicFilters::SourceRemoved, this),
  48. renameSourceSignal(obs_source_get_signal_handler(source), "rename",
  49. OBSBasicFilters::SourceRenamed, this),
  50. noPreviewMargin(13)
  51. {
  52. main = reinterpret_cast<OBSBasic *>(parent);
  53. setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
  54. ui->setupUi(this);
  55. UpdateFilters();
  56. ui->asyncFilters->setItemDelegate(
  57. new VisibilityItemDelegate(ui->asyncFilters));
  58. ui->effectFilters->setItemDelegate(
  59. new VisibilityItemDelegate(ui->effectFilters));
  60. const char *name = obs_source_get_name(source);
  61. setWindowTitle(QTStr("Basic.Filters.Title").arg(QT_UTF8(name)));
  62. #ifndef QT_NO_SHORTCUT
  63. ui->actionRemoveFilter->setShortcut(
  64. QApplication::translate("OBSBasicFilters", "Del", nullptr));
  65. #endif // QT_NO_SHORTCUT
  66. addAction(ui->actionRemoveFilter);
  67. addAction(ui->actionMoveUp);
  68. addAction(ui->actionMoveDown);
  69. installEventFilter(CreateShortcutFilter());
  70. connect(ui->asyncFilters->itemDelegate(),
  71. SIGNAL(closeEditor(QWidget *,
  72. QAbstractItemDelegate::EndEditHint)),
  73. this,
  74. SLOT(AsyncFilterNameEdited(
  75. QWidget *, QAbstractItemDelegate::EndEditHint)));
  76. connect(ui->effectFilters->itemDelegate(),
  77. SIGNAL(closeEditor(QWidget *,
  78. QAbstractItemDelegate::EndEditHint)),
  79. this,
  80. SLOT(EffectFilterNameEdited(
  81. QWidget *, QAbstractItemDelegate::EndEditHint)));
  82. QPushButton *close = ui->buttonBox->button(QDialogButtonBox::Close);
  83. connect(close, SIGNAL(clicked()), this, SLOT(close()));
  84. close->setDefault(true);
  85. ui->buttonBox->button(QDialogButtonBox::Reset)
  86. ->setText(QTStr("Defaults"));
  87. connect(ui->buttonBox->button(QDialogButtonBox::Reset),
  88. SIGNAL(clicked()), this, SLOT(ResetFilters()));
  89. uint32_t caps = obs_source_get_output_flags(source);
  90. bool audio = (caps & OBS_SOURCE_AUDIO) != 0;
  91. bool audioOnly = (caps & OBS_SOURCE_VIDEO) == 0;
  92. bool async = (caps & OBS_SOURCE_ASYNC) != 0;
  93. if (!async && !audio) {
  94. ui->asyncWidget->setVisible(false);
  95. ui->separatorLine->setVisible(false);
  96. }
  97. if (audioOnly) {
  98. ui->effectWidget->setVisible(false);
  99. ui->separatorLine->setVisible(false);
  100. }
  101. if (audioOnly || (audio && !async))
  102. ui->asyncLabel->setText(QTStr("Basic.Filters.AudioFilters"));
  103. auto addDrawCallback = [this]() {
  104. obs_display_add_draw_callback(ui->preview->GetDisplay(),
  105. OBSBasicFilters::DrawPreview,
  106. this);
  107. };
  108. enum obs_source_type type = obs_source_get_type(source);
  109. bool drawable_type = type == OBS_SOURCE_TYPE_INPUT ||
  110. type == OBS_SOURCE_TYPE_SCENE;
  111. if ((caps & OBS_SOURCE_VIDEO) != 0) {
  112. ui->rightLayout->setContentsMargins(0, 0, 0, 0);
  113. ui->preview->show();
  114. if (drawable_type)
  115. connect(ui->preview, &OBSQTDisplay::DisplayCreated,
  116. addDrawCallback);
  117. } else {
  118. ui->rightLayout->setContentsMargins(0, noPreviewMargin, 0, 0);
  119. ui->rightContainerLayout->insertStretch(1);
  120. ui->preview->hide();
  121. }
  122. QAction *renameAsync = new QAction(ui->asyncWidget);
  123. renameAsync->setShortcutContext(Qt::WidgetWithChildrenShortcut);
  124. connect(renameAsync, SIGNAL(triggered()), this,
  125. SLOT(RenameAsyncFilter()));
  126. ui->asyncWidget->addAction(renameAsync);
  127. QAction *renameEffect = new QAction(ui->effectWidget);
  128. renameEffect->setShortcutContext(Qt::WidgetWithChildrenShortcut);
  129. connect(renameEffect, SIGNAL(triggered()), this,
  130. SLOT(RenameEffectFilter()));
  131. ui->effectWidget->addAction(renameEffect);
  132. #ifdef __APPLE__
  133. renameAsync->setShortcut({Qt::Key_Return});
  134. renameEffect->setShortcut({Qt::Key_Return});
  135. #else
  136. renameAsync->setShortcut({Qt::Key_F2});
  137. renameEffect->setShortcut({Qt::Key_F2});
  138. #endif
  139. }
  140. OBSBasicFilters::~OBSBasicFilters()
  141. {
  142. ClearListItems(ui->asyncFilters);
  143. ClearListItems(ui->effectFilters);
  144. }
  145. void OBSBasicFilters::Init()
  146. {
  147. show();
  148. }
  149. inline OBSSource OBSBasicFilters::GetFilter(int row, bool async)
  150. {
  151. if (row == -1)
  152. return OBSSource();
  153. QListWidget *list = async ? ui->asyncFilters : ui->effectFilters;
  154. QListWidgetItem *item = list->item(row);
  155. if (!item)
  156. return OBSSource();
  157. QVariant v = item->data(Qt::UserRole);
  158. return v.value<OBSSource>();
  159. }
  160. void OBSBasicFilters::UpdatePropertiesView(int row, bool async)
  161. {
  162. if (view) {
  163. updatePropertiesSignal.Disconnect();
  164. ui->rightLayout->removeWidget(view);
  165. view->deleteLater();
  166. view = nullptr;
  167. }
  168. OBSSource filter = GetFilter(row, async);
  169. if (!filter)
  170. return;
  171. obs_data_t *settings = obs_source_get_settings(filter);
  172. auto filter_change = [](void *vp, obs_data_t *nd_old_settings,
  173. obs_data_t *new_settings) {
  174. obs_source_t *source = reinterpret_cast<obs_source_t *>(vp);
  175. obs_source_t *parent = obs_filter_get_parent(source);
  176. const char *source_name = obs_source_get_name(source);
  177. OBSBasic *main = OBSBasic::Get();
  178. obs_data_t *redo_wrapper = obs_data_create();
  179. obs_data_set_string(redo_wrapper, "name", source_name);
  180. obs_data_set_string(redo_wrapper, "settings",
  181. obs_data_get_json(new_settings));
  182. obs_data_set_string(redo_wrapper, "parent",
  183. obs_source_get_name(parent));
  184. obs_data_t *filter_settings = obs_source_get_settings(source);
  185. obs_data_t *old_settings =
  186. obs_data_get_defaults(filter_settings);
  187. obs_data_apply(old_settings, nd_old_settings);
  188. obs_data_t *undo_wrapper = obs_data_create();
  189. obs_data_set_string(undo_wrapper, "name", source_name);
  190. obs_data_set_string(undo_wrapper, "settings",
  191. obs_data_get_json(old_settings));
  192. obs_data_set_string(undo_wrapper, "parent",
  193. obs_source_get_name(parent));
  194. auto undo_redo = [](const std::string &data) {
  195. obs_data_t *dat =
  196. obs_data_create_from_json(data.c_str());
  197. obs_source_t *parent_source = obs_get_source_by_name(
  198. obs_data_get_string(dat, "parent"));
  199. const char *filter_name =
  200. obs_data_get_string(dat, "name");
  201. obs_source_t *filter = obs_source_get_filter_by_name(
  202. parent_source, filter_name);
  203. obs_data_t *settings = obs_data_create_from_json(
  204. obs_data_get_string(dat, "settings"));
  205. obs_source_update(filter, settings);
  206. obs_source_update_properties(filter);
  207. obs_data_release(dat);
  208. obs_data_release(settings);
  209. obs_source_release(filter);
  210. obs_source_release(parent_source);
  211. };
  212. std::string name = std::string(obs_source_get_name(source));
  213. std::string undo_data = obs_data_get_json(undo_wrapper);
  214. std::string redo_data = obs_data_get_json(redo_wrapper);
  215. main->undo_s.add_action(QTStr("Undo.Filters").arg(name.c_str()),
  216. undo_redo, undo_redo, undo_data,
  217. redo_data);
  218. obs_data_release(redo_wrapper);
  219. obs_data_release(undo_wrapper);
  220. obs_data_release(old_settings);
  221. obs_data_release(filter_settings);
  222. obs_source_update(source, new_settings);
  223. main->undo_s.enable();
  224. };
  225. auto disabled_undo = [](void *vp, obs_data_t *settings) {
  226. OBSBasic *main =
  227. reinterpret_cast<OBSBasic *>(App()->GetMainWindow());
  228. main->undo_s.disable();
  229. obs_source_t *source = reinterpret_cast<obs_source_t *>(vp);
  230. obs_source_update(source, settings);
  231. };
  232. view = new OBSPropertiesView(
  233. settings, filter,
  234. (PropertiesReloadCallback)obs_source_properties,
  235. (PropertiesUpdateCallback)filter_change,
  236. (PropertiesVisualUpdateCb)disabled_undo);
  237. updatePropertiesSignal.Connect(obs_source_get_signal_handler(filter),
  238. "update_properties",
  239. OBSBasicFilters::UpdateProperties, this);
  240. obs_data_release(settings);
  241. view->setMaximumHeight(250);
  242. view->setMinimumHeight(150);
  243. ui->rightLayout->addWidget(view);
  244. view->show();
  245. }
  246. void OBSBasicFilters::UpdateProperties(void *data, calldata_t *)
  247. {
  248. QMetaObject::invokeMethod(static_cast<OBSBasicFilters *>(data)->view,
  249. "ReloadProperties");
  250. }
  251. void OBSBasicFilters::AddFilter(OBSSource filter, bool focus)
  252. {
  253. uint32_t flags = obs_source_get_output_flags(filter);
  254. bool async = (flags & OBS_SOURCE_ASYNC) != 0;
  255. QListWidget *list = async ? ui->asyncFilters : ui->effectFilters;
  256. QListWidgetItem *item = new QListWidgetItem();
  257. Qt::ItemFlags itemFlags = item->flags();
  258. item->setFlags(itemFlags | Qt::ItemIsEditable);
  259. item->setData(Qt::UserRole, QVariant::fromValue(filter));
  260. list->addItem(item);
  261. if (focus)
  262. list->setCurrentItem(item);
  263. SetupVisibilityItem(list, item, filter);
  264. }
  265. void OBSBasicFilters::RemoveFilter(OBSSource filter)
  266. {
  267. uint32_t flags = obs_source_get_output_flags(filter);
  268. bool async = (flags & OBS_SOURCE_ASYNC) != 0;
  269. QListWidget *list = async ? ui->asyncFilters : ui->effectFilters;
  270. for (int i = 0; i < list->count(); i++) {
  271. QListWidgetItem *item = list->item(i);
  272. QVariant v = item->data(Qt::UserRole);
  273. OBSSource curFilter = v.value<OBSSource>();
  274. if (filter == curFilter) {
  275. DeleteListItem(list, item);
  276. break;
  277. }
  278. }
  279. const char *filterName = obs_source_get_name(filter);
  280. const char *sourceName = obs_source_get_name(source);
  281. if (!sourceName || !filterName)
  282. return;
  283. const char *filterId = obs_source_get_id(filter);
  284. blog(LOG_INFO, "User removed filter '%s' (%s) from source '%s'",
  285. filterName, filterId, sourceName);
  286. main->SaveProject();
  287. }
  288. struct FilterOrderInfo {
  289. int asyncIdx = 0;
  290. int effectIdx = 0;
  291. OBSBasicFilters *window;
  292. inline FilterOrderInfo(OBSBasicFilters *window_) : window(window_) {}
  293. };
  294. void OBSBasicFilters::ReorderFilter(QListWidget *list, obs_source_t *filter,
  295. size_t idx)
  296. {
  297. int count = list->count();
  298. for (int i = 0; i < count; i++) {
  299. QListWidgetItem *listItem = list->item(i);
  300. QVariant v = listItem->data(Qt::UserRole);
  301. OBSSource filterItem = v.value<OBSSource>();
  302. if (filterItem == filter) {
  303. if ((int)idx != i) {
  304. bool sel = (list->currentRow() == i);
  305. listItem = TakeListItem(list, i);
  306. if (listItem) {
  307. list->insertItem((int)idx, listItem);
  308. SetupVisibilityItem(list, listItem,
  309. filterItem);
  310. if (sel)
  311. list->setCurrentRow((int)idx);
  312. }
  313. }
  314. break;
  315. }
  316. }
  317. }
  318. void OBSBasicFilters::ReorderFilters()
  319. {
  320. FilterOrderInfo info(this);
  321. obs_source_enum_filters(
  322. source,
  323. [](obs_source_t *, obs_source_t *filter, void *p) {
  324. FilterOrderInfo *info =
  325. reinterpret_cast<FilterOrderInfo *>(p);
  326. uint32_t flags;
  327. bool async;
  328. flags = obs_source_get_output_flags(filter);
  329. async = (flags & OBS_SOURCE_ASYNC) != 0;
  330. if (async) {
  331. info->window->ReorderFilter(
  332. info->window->ui->asyncFilters, filter,
  333. info->asyncIdx++);
  334. } else {
  335. info->window->ReorderFilter(
  336. info->window->ui->effectFilters, filter,
  337. info->effectIdx++);
  338. }
  339. },
  340. &info);
  341. }
  342. void OBSBasicFilters::UpdateFilters()
  343. {
  344. if (!source)
  345. return;
  346. ClearListItems(ui->effectFilters);
  347. ClearListItems(ui->asyncFilters);
  348. obs_source_enum_filters(
  349. source,
  350. [](obs_source_t *, obs_source_t *filter, void *p) {
  351. OBSBasicFilters *window =
  352. reinterpret_cast<OBSBasicFilters *>(p);
  353. window->AddFilter(filter, false);
  354. },
  355. this);
  356. if (ui->asyncFilters->count() > 0) {
  357. ui->asyncFilters->setCurrentItem(ui->asyncFilters->item(0));
  358. } else if (ui->effectFilters->count() > 0) {
  359. ui->effectFilters->setCurrentItem(ui->effectFilters->item(0));
  360. }
  361. main->SaveProject();
  362. }
  363. static bool filter_compatible(bool async, uint32_t sourceFlags,
  364. uint32_t filterFlags)
  365. {
  366. bool filterVideo = (filterFlags & OBS_SOURCE_VIDEO) != 0;
  367. bool filterAsync = (filterFlags & OBS_SOURCE_ASYNC) != 0;
  368. bool filterAudio = (filterFlags & OBS_SOURCE_AUDIO) != 0;
  369. bool audio = (sourceFlags & OBS_SOURCE_AUDIO) != 0;
  370. bool audioOnly = (sourceFlags & OBS_SOURCE_VIDEO) == 0;
  371. bool asyncSource = (sourceFlags & OBS_SOURCE_ASYNC) != 0;
  372. if (async && ((audioOnly && filterVideo) || (!audio && !asyncSource)))
  373. return false;
  374. return (async && (filterAudio || filterAsync)) ||
  375. (!async && !filterAudio && !filterAsync);
  376. }
  377. QMenu *OBSBasicFilters::CreateAddFilterPopupMenu(bool async)
  378. {
  379. uint32_t sourceFlags = obs_source_get_output_flags(source);
  380. const char *type_str;
  381. bool foundValues = false;
  382. size_t idx = 0;
  383. struct FilterInfo {
  384. string type;
  385. string name;
  386. inline FilterInfo(const char *type_, const char *name_)
  387. : type(type_), name(name_)
  388. {
  389. }
  390. };
  391. vector<FilterInfo> types;
  392. while (obs_enum_filter_types(idx++, &type_str)) {
  393. const char *name = obs_source_get_display_name(type_str);
  394. uint32_t caps = obs_get_source_output_flags(type_str);
  395. if ((caps & OBS_SOURCE_DEPRECATED) != 0)
  396. continue;
  397. if ((caps & OBS_SOURCE_CAP_DISABLED) != 0)
  398. continue;
  399. if ((caps & OBS_SOURCE_CAP_OBSOLETE) != 0)
  400. continue;
  401. auto it = types.begin();
  402. for (; it != types.end(); ++it) {
  403. if (it->name >= name)
  404. break;
  405. }
  406. types.emplace(it, type_str, name);
  407. }
  408. QMenu *popup = new QMenu(QTStr("Add"), this);
  409. for (FilterInfo &type : types) {
  410. uint32_t filterFlags =
  411. obs_get_source_output_flags(type.type.c_str());
  412. if (!filter_compatible(async, sourceFlags, filterFlags))
  413. continue;
  414. QAction *popupItem =
  415. new QAction(QT_UTF8(type.name.c_str()), this);
  416. popupItem->setData(QT_UTF8(type.type.c_str()));
  417. connect(popupItem, SIGNAL(triggered(bool)), this,
  418. SLOT(AddFilterFromAction()));
  419. popup->addAction(popupItem);
  420. foundValues = true;
  421. }
  422. if (!foundValues) {
  423. delete popup;
  424. popup = nullptr;
  425. }
  426. return popup;
  427. }
  428. void OBSBasicFilters::AddNewFilter(const char *id)
  429. {
  430. if (id && *id) {
  431. obs_source_t *existing_filter;
  432. string name = obs_source_get_display_name(id);
  433. QString placeholder = QString::fromStdString(name);
  434. QString text{placeholder};
  435. int i = 2;
  436. while ((existing_filter = obs_source_get_filter_by_name(
  437. source, QT_TO_UTF8(text)))) {
  438. obs_source_release(existing_filter);
  439. text = QString("%1 %2").arg(placeholder).arg(i++);
  440. }
  441. bool success = NameDialog::AskForName(
  442. this, QTStr("Basic.Filters.AddFilter.Title"),
  443. QTStr("Basic.Filters.AddFilter.Text"), name, text);
  444. if (!success)
  445. return;
  446. if (name.empty()) {
  447. OBSMessageBox::warning(this,
  448. QTStr("NoNameEntered.Title"),
  449. QTStr("NoNameEntered.Text"));
  450. AddNewFilter(id);
  451. return;
  452. }
  453. existing_filter =
  454. obs_source_get_filter_by_name(source, name.c_str());
  455. if (existing_filter) {
  456. OBSMessageBox::warning(this, QTStr("NameExists.Title"),
  457. QTStr("NameExists.Text"));
  458. obs_source_release(existing_filter);
  459. AddNewFilter(id);
  460. return;
  461. }
  462. obs_data_t *wrapper = obs_data_create();
  463. obs_data_set_string(wrapper, "sname",
  464. obs_source_get_name(source));
  465. obs_data_set_string(wrapper, "fname", name.c_str());
  466. std::string scene_name = obs_source_get_name(
  467. reinterpret_cast<OBSBasic *>(App()->GetMainWindow())
  468. ->GetCurrentSceneSource());
  469. auto undo = [scene_name](const std::string &data) {
  470. obs_source_t *ssource =
  471. obs_get_source_by_name(scene_name.c_str());
  472. reinterpret_cast<OBSBasic *>(App()->GetMainWindow())
  473. ->SetCurrentScene(ssource, true);
  474. obs_source_release(ssource);
  475. obs_data_t *dat =
  476. obs_data_create_from_json(data.c_str());
  477. obs_source_t *source = obs_get_source_by_name(
  478. obs_data_get_string(dat, "sname"));
  479. obs_source_t *filter = obs_source_get_filter_by_name(
  480. source, obs_data_get_string(dat, "fname"));
  481. obs_source_filter_remove(source, filter);
  482. obs_data_release(dat);
  483. obs_source_release(source);
  484. obs_source_release(filter);
  485. };
  486. obs_data_t *rwrapper = obs_data_create();
  487. obs_data_set_string(rwrapper, "sname",
  488. obs_source_get_name(source));
  489. auto redo = [scene_name, id = std::string(id),
  490. name](const std::string &data) {
  491. obs_source_t *ssource =
  492. obs_get_source_by_name(scene_name.c_str());
  493. reinterpret_cast<OBSBasic *>(App()->GetMainWindow())
  494. ->SetCurrentScene(ssource, true);
  495. obs_source_release(ssource);
  496. obs_data_t *dat =
  497. obs_data_create_from_json(data.c_str());
  498. obs_source_t *source = obs_get_source_by_name(
  499. obs_data_get_string(dat, "sname"));
  500. obs_source_t *filter = obs_source_create(
  501. id.c_str(), name.c_str(), nullptr, nullptr);
  502. if (filter) {
  503. obs_source_filter_add(source, filter);
  504. obs_source_release(filter);
  505. }
  506. obs_data_release(dat);
  507. obs_source_release(source);
  508. };
  509. std::string undo_data(obs_data_get_json(wrapper));
  510. std::string redo_data(obs_data_get_json(rwrapper));
  511. main->undo_s.add_action(QTStr("Undo.Add").arg(name.c_str()),
  512. undo, redo, undo_data, redo_data);
  513. obs_data_release(wrapper);
  514. obs_data_release(rwrapper);
  515. obs_source_t *filter =
  516. obs_source_create(id, name.c_str(), nullptr, nullptr);
  517. if (filter) {
  518. const char *sourceName = obs_source_get_name(source);
  519. blog(LOG_INFO,
  520. "User added filter '%s' (%s) "
  521. "to source '%s'",
  522. name.c_str(), id, sourceName);
  523. obs_source_filter_add(source, filter);
  524. obs_source_release(filter);
  525. }
  526. }
  527. }
  528. void OBSBasicFilters::AddFilterFromAction()
  529. {
  530. QAction *action = qobject_cast<QAction *>(sender());
  531. if (!action)
  532. return;
  533. AddNewFilter(QT_TO_UTF8(action->data().toString()));
  534. }
  535. void OBSBasicFilters::closeEvent(QCloseEvent *event)
  536. {
  537. QDialog::closeEvent(event);
  538. if (!event->isAccepted())
  539. return;
  540. obs_display_remove_draw_callback(ui->preview->GetDisplay(),
  541. OBSBasicFilters::DrawPreview, this);
  542. main->SaveProject();
  543. }
  544. /* OBS Signals */
  545. void OBSBasicFilters::OBSSourceFilterAdded(void *param, calldata_t *data)
  546. {
  547. OBSBasicFilters *window = reinterpret_cast<OBSBasicFilters *>(param);
  548. obs_source_t *filter = (obs_source_t *)calldata_ptr(data, "filter");
  549. QMetaObject::invokeMethod(window, "AddFilter",
  550. Q_ARG(OBSSource, OBSSource(filter)));
  551. }
  552. void OBSBasicFilters::OBSSourceFilterRemoved(void *param, calldata_t *data)
  553. {
  554. OBSBasicFilters *window = reinterpret_cast<OBSBasicFilters *>(param);
  555. obs_source_t *filter = (obs_source_t *)calldata_ptr(data, "filter");
  556. QMetaObject::invokeMethod(window, "RemoveFilter",
  557. Q_ARG(OBSSource, OBSSource(filter)));
  558. }
  559. void OBSBasicFilters::OBSSourceReordered(void *param, calldata_t *data)
  560. {
  561. QMetaObject::invokeMethod(reinterpret_cast<OBSBasicFilters *>(param),
  562. "ReorderFilters");
  563. UNUSED_PARAMETER(data);
  564. }
  565. void OBSBasicFilters::SourceRemoved(void *param, calldata_t *data)
  566. {
  567. UNUSED_PARAMETER(data);
  568. QMetaObject::invokeMethod(static_cast<OBSBasicFilters *>(param),
  569. "close");
  570. }
  571. void OBSBasicFilters::SourceRenamed(void *param, calldata_t *data)
  572. {
  573. const char *name = calldata_string(data, "new_name");
  574. QString title = QTStr("Basic.Filters.Title").arg(QT_UTF8(name));
  575. QMetaObject::invokeMethod(static_cast<OBSBasicFilters *>(param),
  576. "setWindowTitle", Q_ARG(QString, title));
  577. }
  578. void OBSBasicFilters::DrawPreview(void *data, uint32_t cx, uint32_t cy)
  579. {
  580. OBSBasicFilters *window = static_cast<OBSBasicFilters *>(data);
  581. if (!window->source)
  582. return;
  583. uint32_t sourceCX = max(obs_source_get_width(window->source), 1u);
  584. uint32_t sourceCY = max(obs_source_get_height(window->source), 1u);
  585. int x, y;
  586. int newCX, newCY;
  587. float scale;
  588. GetScaleAndCenterPos(sourceCX, sourceCY, cx, cy, x, y, scale);
  589. newCX = int(scale * float(sourceCX));
  590. newCY = int(scale * float(sourceCY));
  591. gs_viewport_push();
  592. gs_projection_push();
  593. const bool previous = gs_set_linear_srgb(true);
  594. gs_ortho(0.0f, float(sourceCX), 0.0f, float(sourceCY), -100.0f, 100.0f);
  595. gs_set_viewport(x, y, newCX, newCY);
  596. obs_source_video_render(window->source);
  597. gs_set_linear_srgb(previous);
  598. gs_projection_pop();
  599. gs_viewport_pop();
  600. }
  601. /* Qt Slots */
  602. static bool QueryRemove(QWidget *parent, obs_source_t *source)
  603. {
  604. const char *name = obs_source_get_name(source);
  605. QString text = QTStr("ConfirmRemove.Text");
  606. text.replace("$1", QT_UTF8(name));
  607. QMessageBox remove_source(parent);
  608. remove_source.setText(text);
  609. QAbstractButton *Yes =
  610. remove_source.addButton(QTStr("Yes"), QMessageBox::YesRole);
  611. remove_source.addButton(QTStr("No"), QMessageBox::NoRole);
  612. remove_source.setIcon(QMessageBox::Question);
  613. remove_source.setWindowTitle(QTStr("ConfirmRemove.Title"));
  614. remove_source.exec();
  615. return Yes == remove_source.clickedButton();
  616. }
  617. void OBSBasicFilters::on_addAsyncFilter_clicked()
  618. {
  619. QScopedPointer<QMenu> popup(CreateAddFilterPopupMenu(true));
  620. if (popup)
  621. popup->exec(QCursor::pos());
  622. }
  623. void OBSBasicFilters::on_removeAsyncFilter_clicked()
  624. {
  625. OBSSource filter = GetFilter(ui->asyncFilters->currentRow(), true);
  626. if (filter) {
  627. if (QueryRemove(this, filter))
  628. delete_filter(filter);
  629. }
  630. }
  631. void OBSBasicFilters::on_moveAsyncFilterUp_clicked()
  632. {
  633. OBSSource filter = GetFilter(ui->asyncFilters->currentRow(), true);
  634. if (filter)
  635. obs_source_filter_set_order(source, filter, OBS_ORDER_MOVE_UP);
  636. }
  637. void OBSBasicFilters::on_moveAsyncFilterDown_clicked()
  638. {
  639. OBSSource filter = GetFilter(ui->asyncFilters->currentRow(), true);
  640. if (filter)
  641. obs_source_filter_set_order(source, filter,
  642. OBS_ORDER_MOVE_DOWN);
  643. }
  644. void OBSBasicFilters::on_asyncFilters_GotFocus()
  645. {
  646. UpdatePropertiesView(ui->asyncFilters->currentRow(), true);
  647. isAsync = true;
  648. }
  649. void OBSBasicFilters::on_asyncFilters_currentRowChanged(int row)
  650. {
  651. UpdatePropertiesView(row, true);
  652. }
  653. void OBSBasicFilters::on_addEffectFilter_clicked()
  654. {
  655. QScopedPointer<QMenu> popup(CreateAddFilterPopupMenu(false));
  656. if (popup)
  657. popup->exec(QCursor::pos());
  658. }
  659. void OBSBasicFilters::on_removeEffectFilter_clicked()
  660. {
  661. OBSSource filter = GetFilter(ui->effectFilters->currentRow(), false);
  662. if (filter) {
  663. if (QueryRemove(this, filter)) {
  664. delete_filter(filter);
  665. }
  666. }
  667. }
  668. void OBSBasicFilters::on_moveEffectFilterUp_clicked()
  669. {
  670. OBSSource filter = GetFilter(ui->effectFilters->currentRow(), false);
  671. if (filter)
  672. obs_source_filter_set_order(source, filter, OBS_ORDER_MOVE_UP);
  673. }
  674. void OBSBasicFilters::on_moveEffectFilterDown_clicked()
  675. {
  676. OBSSource filter = GetFilter(ui->effectFilters->currentRow(), false);
  677. if (filter)
  678. obs_source_filter_set_order(source, filter,
  679. OBS_ORDER_MOVE_DOWN);
  680. }
  681. void OBSBasicFilters::on_effectFilters_GotFocus()
  682. {
  683. UpdatePropertiesView(ui->effectFilters->currentRow(), false);
  684. isAsync = false;
  685. }
  686. void OBSBasicFilters::on_effectFilters_currentRowChanged(int row)
  687. {
  688. UpdatePropertiesView(row, false);
  689. }
  690. void OBSBasicFilters::on_actionRemoveFilter_triggered()
  691. {
  692. if (ui->asyncFilters->hasFocus())
  693. on_removeAsyncFilter_clicked();
  694. else if (ui->effectFilters->hasFocus())
  695. on_removeEffectFilter_clicked();
  696. }
  697. void OBSBasicFilters::on_actionMoveUp_triggered()
  698. {
  699. if (ui->asyncFilters->hasFocus())
  700. on_moveAsyncFilterUp_clicked();
  701. else if (ui->effectFilters->hasFocus())
  702. on_moveEffectFilterUp_clicked();
  703. }
  704. void OBSBasicFilters::on_actionMoveDown_triggered()
  705. {
  706. if (ui->asyncFilters->hasFocus())
  707. on_moveAsyncFilterDown_clicked();
  708. else if (ui->effectFilters->hasFocus())
  709. on_moveEffectFilterDown_clicked();
  710. }
  711. void OBSBasicFilters::CustomContextMenu(const QPoint &pos, bool async)
  712. {
  713. QListWidget *list = async ? ui->asyncFilters : ui->effectFilters;
  714. QListWidgetItem *item = list->itemAt(pos);
  715. QMenu popup(window());
  716. QPointer<QMenu> addMenu = CreateAddFilterPopupMenu(async);
  717. if (addMenu)
  718. popup.addMenu(addMenu);
  719. if (item) {
  720. const char *dulpicateSlot =
  721. async ? SLOT(DuplicateAsyncFilter())
  722. : SLOT(DuplicateEffectFilter());
  723. const char *renameSlot = async ? SLOT(RenameAsyncFilter())
  724. : SLOT(RenameEffectFilter());
  725. const char *removeSlot =
  726. async ? SLOT(on_removeAsyncFilter_clicked())
  727. : SLOT(on_removeEffectFilter_clicked());
  728. popup.addSeparator();
  729. popup.addAction(QTStr("Duplicate"), this, dulpicateSlot);
  730. popup.addSeparator();
  731. popup.addAction(QTStr("Rename"), this, renameSlot);
  732. popup.addAction(QTStr("Remove"), this, removeSlot);
  733. popup.addSeparator();
  734. QAction *copyAction = new QAction(QTStr("Copy"));
  735. connect(copyAction, SIGNAL(triggered()), this,
  736. SLOT(CopyFilter()));
  737. copyAction->setShortcut(QKeySequence(Qt::CTRL + Qt::Key_C));
  738. ui->effectWidget->addAction(copyAction);
  739. ui->asyncWidget->addAction(copyAction);
  740. popup.addAction(copyAction);
  741. }
  742. QAction *pasteAction = new QAction(QTStr("Paste"));
  743. pasteAction->setEnabled(main->copyFilter);
  744. connect(pasteAction, SIGNAL(triggered()), this, SLOT(PasteFilter()));
  745. pasteAction->setShortcut(QKeySequence(Qt::CTRL + Qt::Key_V));
  746. ui->effectWidget->addAction(pasteAction);
  747. ui->asyncWidget->addAction(pasteAction);
  748. popup.addAction(pasteAction);
  749. popup.exec(QCursor::pos());
  750. }
  751. void OBSBasicFilters::EditItem(QListWidgetItem *item, bool async)
  752. {
  753. if (editActive)
  754. return;
  755. Qt::ItemFlags flags = item->flags();
  756. OBSSource filter = item->data(Qt::UserRole).value<OBSSource>();
  757. const char *name = obs_source_get_name(filter);
  758. QListWidget *list = async ? ui->asyncFilters : ui->effectFilters;
  759. item->setText(QT_UTF8(name));
  760. item->setFlags(flags | Qt::ItemIsEditable);
  761. list->removeItemWidget(item);
  762. list->editItem(item);
  763. item->setFlags(flags);
  764. editActive = true;
  765. }
  766. void OBSBasicFilters::DuplicateItem(QListWidgetItem *item)
  767. {
  768. OBSSource filter = item->data(Qt::UserRole).value<OBSSource>();
  769. string name = obs_source_get_name(filter);
  770. obs_source_t *existing_filter;
  771. QString placeholder = QString::fromStdString(name);
  772. QString text{placeholder};
  773. int i = 2;
  774. while ((existing_filter = obs_source_get_filter_by_name(
  775. source, QT_TO_UTF8(text)))) {
  776. obs_source_release(existing_filter);
  777. text = QString("%1 %2").arg(placeholder).arg(i++);
  778. }
  779. bool success = NameDialog::AskForName(
  780. this, QTStr("Basic.Filters.AddFilter.Title"),
  781. QTStr("Basic.Filters.AddFilter.Text"), name, text);
  782. if (!success)
  783. return;
  784. if (name.empty()) {
  785. OBSMessageBox::warning(this, QTStr("NoNameEntered.Title"),
  786. QTStr("NoNameEntered.Text"));
  787. DuplicateItem(item);
  788. return;
  789. }
  790. existing_filter = obs_source_get_filter_by_name(source, name.c_str());
  791. if (existing_filter) {
  792. OBSMessageBox::warning(this, QTStr("NameExists.Title"),
  793. QTStr("NameExists.Text"));
  794. obs_source_release(existing_filter);
  795. DuplicateItem(item);
  796. return;
  797. }
  798. bool enabled = obs_source_enabled(filter);
  799. obs_source_t *new_filter =
  800. obs_source_duplicate(filter, name.c_str(), false);
  801. if (new_filter) {
  802. const char *sourceName = obs_source_get_name(source);
  803. const char *id = obs_source_get_id(new_filter);
  804. blog(LOG_INFO,
  805. "User duplicated filter '%s' (%s) from '%s' "
  806. "to source '%s'",
  807. name.c_str(), id, name.c_str(), sourceName);
  808. obs_source_set_enabled(new_filter, enabled);
  809. obs_source_filter_add(source, new_filter);
  810. obs_source_release(new_filter);
  811. }
  812. }
  813. void OBSBasicFilters::on_asyncFilters_customContextMenuRequested(
  814. const QPoint &pos)
  815. {
  816. CustomContextMenu(pos, true);
  817. }
  818. void OBSBasicFilters::on_effectFilters_customContextMenuRequested(
  819. const QPoint &pos)
  820. {
  821. CustomContextMenu(pos, false);
  822. }
  823. void OBSBasicFilters::RenameAsyncFilter()
  824. {
  825. EditItem(ui->asyncFilters->currentItem(), true);
  826. }
  827. void OBSBasicFilters::RenameEffectFilter()
  828. {
  829. EditItem(ui->effectFilters->currentItem(), false);
  830. }
  831. void OBSBasicFilters::DuplicateAsyncFilter()
  832. {
  833. DuplicateItem(ui->asyncFilters->currentItem());
  834. }
  835. void OBSBasicFilters::DuplicateEffectFilter()
  836. {
  837. DuplicateItem(ui->effectFilters->currentItem());
  838. }
  839. void OBSBasicFilters::FilterNameEdited(QWidget *editor, QListWidget *list)
  840. {
  841. QListWidgetItem *listItem = list->currentItem();
  842. OBSSource filter = listItem->data(Qt::UserRole).value<OBSSource>();
  843. QLineEdit *edit = qobject_cast<QLineEdit *>(editor);
  844. string name = QT_TO_UTF8(edit->text().trimmed());
  845. const char *prevName = obs_source_get_name(filter);
  846. bool sameName = (name == prevName);
  847. obs_source_t *foundFilter = nullptr;
  848. if (!sameName)
  849. foundFilter =
  850. obs_source_get_filter_by_name(source, name.c_str());
  851. if (foundFilter || name.empty() || sameName) {
  852. listItem->setText(QT_UTF8(prevName));
  853. if (foundFilter) {
  854. OBSMessageBox::information(window(),
  855. QTStr("NameExists.Title"),
  856. QTStr("NameExists.Text"));
  857. obs_source_release(foundFilter);
  858. } else if (name.empty()) {
  859. OBSMessageBox::information(window(),
  860. QTStr("NoNameEntered.Title"),
  861. QTStr("NoNameEntered.Text"));
  862. }
  863. } else {
  864. const char *sourceName = obs_source_get_name(source);
  865. blog(LOG_INFO,
  866. "User renamed filter '%s' on source '%s' to '%s'",
  867. prevName, sourceName, name.c_str());
  868. listItem->setText(QT_UTF8(name.c_str()));
  869. obs_source_set_name(filter, name.c_str());
  870. std::string scene_name = obs_source_get_name(
  871. reinterpret_cast<OBSBasic *>(App()->GetMainWindow())
  872. ->GetCurrentSceneSource());
  873. auto undo = [scene_name, prev = std::string(prevName),
  874. name](const std::string &data) {
  875. obs_source_t *ssource =
  876. obs_get_source_by_name(scene_name.c_str());
  877. reinterpret_cast<OBSBasic *>(App()->GetMainWindow())
  878. ->SetCurrentScene(ssource, true);
  879. obs_source_release(ssource);
  880. obs_source_t *source =
  881. obs_get_source_by_name(data.c_str());
  882. obs_source_t *filter = obs_source_get_filter_by_name(
  883. source, name.c_str());
  884. obs_source_set_name(filter, prev.c_str());
  885. obs_source_release(source);
  886. obs_source_release(filter);
  887. };
  888. auto redo = [scene_name, prev = std::string(prevName),
  889. name](const std::string &data) {
  890. obs_source_t *ssource =
  891. obs_get_source_by_name(scene_name.c_str());
  892. reinterpret_cast<OBSBasic *>(App()->GetMainWindow())
  893. ->SetCurrentScene(ssource, true);
  894. obs_source_release(ssource);
  895. obs_source_t *source =
  896. obs_get_source_by_name(data.c_str());
  897. obs_source_t *filter = obs_source_get_filter_by_name(
  898. source, prev.c_str());
  899. obs_source_set_name(filter, name.c_str());
  900. obs_source_release(source);
  901. obs_source_release(filter);
  902. };
  903. std::string undo_data(sourceName);
  904. std::string redo_data(sourceName);
  905. main->undo_s.add_action(QTStr("Undo.Rename").arg(name.c_str()),
  906. undo, redo, undo_data, redo_data);
  907. }
  908. listItem->setText(QString());
  909. SetupVisibilityItem(list, listItem, filter);
  910. editActive = false;
  911. }
  912. void OBSBasicFilters::AsyncFilterNameEdited(
  913. QWidget *editor, QAbstractItemDelegate::EndEditHint endHint)
  914. {
  915. FilterNameEdited(editor, ui->asyncFilters);
  916. UNUSED_PARAMETER(endHint);
  917. }
  918. void OBSBasicFilters::EffectFilterNameEdited(
  919. QWidget *editor, QAbstractItemDelegate::EndEditHint endHint)
  920. {
  921. FilterNameEdited(editor, ui->effectFilters);
  922. UNUSED_PARAMETER(endHint);
  923. }
  924. void OBSBasicFilters::ResetFilters()
  925. {
  926. QListWidget *list = isAsync ? ui->asyncFilters : ui->effectFilters;
  927. int row = list->currentRow();
  928. OBSSource filter = GetFilter(row, isAsync);
  929. if (!filter)
  930. return;
  931. obs_data_t *settings = obs_source_get_settings(filter);
  932. obs_data_clear(settings);
  933. obs_data_release(settings);
  934. if (!view->DeferUpdate())
  935. obs_source_update(filter, nullptr);
  936. view->RefreshProperties();
  937. }
  938. void OBSBasicFilters::CopyFilter()
  939. {
  940. OBSSource filter = nullptr;
  941. if (isAsync)
  942. filter = GetFilter(ui->asyncFilters->currentRow(), true);
  943. else
  944. filter = GetFilter(ui->effectFilters->currentRow(), false);
  945. main->copyFilter = OBSGetWeakRef(filter);
  946. }
  947. void OBSBasicFilters::PasteFilter()
  948. {
  949. OBSSource filter = OBSGetStrongRef(main->copyFilter);
  950. if (!filter)
  951. return;
  952. obs_data_array_t *undo_array = obs_source_backup_filters(source);
  953. obs_source_copy_single_filter(source, filter);
  954. obs_data_array_t *redo_array = obs_source_backup_filters(source);
  955. const char *filterName = obs_source_get_name(filter);
  956. const char *sourceName = obs_source_get_name(source);
  957. QString text =
  958. QTStr("Undo.Filters.Paste.Single").arg(filterName, sourceName);
  959. main->CreateFilterPasteUndoRedoAction(text, source, undo_array,
  960. redo_array);
  961. obs_data_array_release(undo_array);
  962. obs_data_array_release(redo_array);
  963. }
  964. void OBSBasicFilters::delete_filter(OBSSource filter)
  965. {
  966. obs_data_t *wrapper = obs_save_source(filter);
  967. std::string parent_name(obs_source_get_name(source));
  968. obs_data_set_string(wrapper, "undo_name", parent_name.c_str());
  969. std::string scene_name = obs_source_get_name(
  970. reinterpret_cast<OBSBasic *>(App()->GetMainWindow())
  971. ->GetCurrentSceneSource());
  972. auto undo = [scene_name](const std::string &data) {
  973. obs_source_t *ssource =
  974. obs_get_source_by_name(scene_name.c_str());
  975. reinterpret_cast<OBSBasic *>(App()->GetMainWindow())
  976. ->SetCurrentScene(ssource, true);
  977. obs_source_release(ssource);
  978. obs_data_t *dat = obs_data_create_from_json(data.c_str());
  979. obs_source_t *source = obs_get_source_by_name(
  980. obs_data_get_string(dat, "undo_name"));
  981. obs_source_t *filter = obs_load_source(dat);
  982. obs_source_filter_add(source, filter);
  983. obs_data_release(dat);
  984. obs_source_release(source);
  985. obs_source_release(filter);
  986. };
  987. obs_data_t *rwrapper = obs_data_create();
  988. obs_data_set_string(rwrapper, "fname", obs_source_get_name(filter));
  989. obs_data_set_string(rwrapper, "sname", parent_name.c_str());
  990. auto redo = [scene_name](const std::string &data) {
  991. obs_source_t *ssource =
  992. obs_get_source_by_name(scene_name.c_str());
  993. reinterpret_cast<OBSBasic *>(App()->GetMainWindow())
  994. ->SetCurrentScene(ssource, true);
  995. obs_source_release(ssource);
  996. obs_data_t *dat = obs_data_create_from_json(data.c_str());
  997. obs_source_t *source = obs_get_source_by_name(
  998. obs_data_get_string(dat, "sname"));
  999. obs_source_t *filter = obs_source_get_filter_by_name(
  1000. source, obs_data_get_string(dat, "fname"));
  1001. obs_source_filter_remove(source, filter);
  1002. obs_data_release(dat);
  1003. obs_source_release(filter);
  1004. obs_source_release(source);
  1005. };
  1006. std::string undo_data(obs_data_get_json(wrapper));
  1007. std::string redo_data(obs_data_get_json(rwrapper));
  1008. main->undo_s.add_action(
  1009. QTStr("Undo.Delete").arg(obs_source_get_name(filter)), undo,
  1010. redo, undo_data, redo_data, NULL);
  1011. obs_source_filter_remove(source, filter);
  1012. obs_data_release(wrapper);
  1013. obs_data_release(rwrapper);
  1014. }