CONTRIBUTING 2.9 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061
  1. Contributing Information:
  2. - Our bug tracker is located at (currently linked to forum accounts):
  3. https://obsproject.com/mantis/
  4. - Development forums are currently located at:
  5. https://obsproject.com/forum/list/general-development.21/
  6. - Development IRC channel is primarily #obs-dev on QuakeNet
  7. Contributing Guidelines:
  8. - Code and commits will be reviewed. Reviews will be blunt and honest, and
  9. your change probably won't go through the first time, or may be outright
  10. rejected. It may require many revisions before changes are finally
  11. accepted.
  12. - If you want to avoid doing a lot of work only to have it rejected, discuss
  13. what you want to change it in the main channels/forums/mailing lists before
  14. actually working on it. Open source requires thick skin. Please don't be
  15. discouraged if your changes don't go through, learn from it and get better.
  16. - Coding style is Linux-style KNF (kernel normal form). This means K&R, 80
  17. columns max, preferable maximum function length of approximately 42 lines, 8
  18. character width tabs, lower_case_names, etc. I chose this for the sake of
  19. the project. Don't argue about it, just do it. It takes no time to do.
  20. See https://www.kernel.org/doc/Documentation/CodingStyle for a general
  21. guideline (though not necessarily a rulebook, for example we allow the use
  22. of boolean return values instead of ints for failure).
  23. NOTE: C++ is an exception to the lower_case_only rule, CamelCase is
  24. encouraged (though not required) to distinguish it from C code. Just a
  25. personal and subjective stylistic thing on my part.
  26. - Commits are not just changes to code; they should also be treated as
  27. annotation to code. For that reason, do not put unrelated changes in a
  28. single commit. Separate out different changes in to different commits, and
  29. make separate pull requests for unrelated changes. Commits should be
  30. formatted with the 50/72 standard, and should be descriptive and concise.
  31. See http://chris.beams.io/posts/git-commit/ for a summary of how to make
  32. good commit messages.
  33. - Core code is C only (unless there's an operating system specific thing that
  34. absolutely requires another language).
  35. - Modules and UI may use C, C++, or Objective-C (for apple), though please try
  36. to use C unless an API you're using requires C++ or Objective-C (such as
  37. windows COM classes, or apple Objective-C APIs).
  38. - If you don't quite know what to work on and just want to help, the bug
  39. tracker has a list of things that need to be worked on.
  40. - Try to respect the wishes of the author(s)/maintainer(s). A good maintainer
  41. will always listen, and will often ask others on the project for their
  42. opinions, but don't expect things to be completely democratic.
  43. - Do not use dependencies for the sake of convenience. There's enough
  44. dependencies as it is. Use them only if you absolutely have to depend on
  45. them.