| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051 |
- From 870277eb767ecec9293c5dd5ba5bf1c912251e85 Mon Sep 17 00:00:00 2001
- From: Andy Lutomirski <[email protected]>
- Date: Thu, 2 Nov 2017 00:59:15 -0700
- Subject: [PATCH 103/242] x86/entry/32: Fix cpu_current_top_of_stack
- initialization at boot
- MIME-Version: 1.0
- Content-Type: text/plain; charset=UTF-8
- Content-Transfer-Encoding: 8bit
- CVE-2017-5754
- cpu_current_top_of_stack's initialization forgot about
- TOP_OF_KERNEL_STACK_PADDING. This bug didn't matter because the
- idle threads never enter user mode.
- Signed-off-by: Andy Lutomirski <[email protected]>
- Reviewed-by: Borislav Petkov <[email protected]>
- Cc: Borislav Petkov <[email protected]>
- Cc: Brian Gerst <[email protected]>
- Cc: Dave Hansen <[email protected]>
- Cc: Linus Torvalds <[email protected]>
- Cc: Peter Zijlstra <[email protected]>
- Cc: Thomas Gleixner <[email protected]>
- Link: http://lkml.kernel.org/r/e5e370a7e6e4fddd1c4e4cf619765d96bb874b21.1509609304.git.luto@kernel.org
- Signed-off-by: Ingo Molnar <[email protected]>
- (cherry picked from commit cd493a6deb8b78eca280d05f7fa73fd69403ae29)
- Signed-off-by: Andy Whitcroft <[email protected]>
- Signed-off-by: Kleber Sacilotto de Souza <[email protected]>
- (cherry picked from commit 258c98e7d4b8f1459772e656cd736c028a13add9)
- Signed-off-by: Fabian Grünbichler <[email protected]>
- ---
- arch/x86/kernel/smpboot.c | 3 +--
- 1 file changed, 1 insertion(+), 2 deletions(-)
- diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
- index d05006f6c31c..8ea3b18cbdc1 100644
- --- a/arch/x86/kernel/smpboot.c
- +++ b/arch/x86/kernel/smpboot.c
- @@ -961,8 +961,7 @@ void common_cpu_up(unsigned int cpu, struct task_struct *idle)
- #ifdef CONFIG_X86_32
- /* Stack for startup_32 can be just as for start_secondary onwards */
- irq_ctx_init(cpu);
- - per_cpu(cpu_current_top_of_stack, cpu) =
- - (unsigned long)task_stack_page(idle) + THREAD_SIZE;
- + per_cpu(cpu_current_top_of_stack, cpu) = task_top_of_stack(idle);
- #else
- initial_gs = per_cpu_offset(cpu);
- #endif
- --
- 2.14.2
|