0193-x86-mm-pti-Add-infrastructure-for-page-table-isolati.patch 9.6 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Thomas Gleixner <[email protected]>
  3. Date: Mon, 4 Dec 2017 15:07:36 +0100
  4. Subject: [PATCH] x86/mm/pti: Add infrastructure for page table isolation
  5. MIME-Version: 1.0
  6. Content-Type: text/plain; charset=UTF-8
  7. Content-Transfer-Encoding: 8bit
  8. CVE-2017-5754
  9. Add the initial files for kernel page table isolation, with a minimal init
  10. function and the boot time detection for this misfeature.
  11. Signed-off-by: Thomas Gleixner <[email protected]>
  12. Reviewed-by: Borislav Petkov <[email protected]>
  13. Cc: Andy Lutomirski <[email protected]>
  14. Cc: Boris Ostrovsky <[email protected]>
  15. Cc: Borislav Petkov <[email protected]>
  16. Cc: Brian Gerst <[email protected]>
  17. Cc: Dave Hansen <[email protected]>
  18. Cc: David Laight <[email protected]>
  19. Cc: Denys Vlasenko <[email protected]>
  20. Cc: Eduardo Valentin <[email protected]>
  21. Cc: Greg KH <[email protected]>
  22. Cc: H. Peter Anvin <[email protected]>
  23. Cc: Josh Poimboeuf <[email protected]>
  24. Cc: Juergen Gross <[email protected]>
  25. Cc: Linus Torvalds <[email protected]>
  26. Cc: Peter Zijlstra <[email protected]>
  27. Cc: Will Deacon <[email protected]>
  28. Cc: [email protected]
  29. Cc: [email protected]
  30. Cc: [email protected]
  31. Cc: [email protected]
  32. Signed-off-by: Ingo Molnar <[email protected]>
  33. (backported from commit aa8c6248f8c75acfd610fe15d8cae23cf70d9d09)
  34. Signed-off-by: Andy Whitcroft <[email protected]>
  35. Signed-off-by: Kleber Sacilotto de Souza <[email protected]>
  36. (cherry picked from commit 50da124a01ed7a59f9b2c9551f622c5a27d1caec)
  37. Signed-off-by: Fabian Grünbichler <[email protected]>
  38. ---
  39. Documentation/admin-guide/kernel-parameters.txt | 2 +
  40. arch/x86/mm/Makefile | 7 ++-
  41. arch/x86/entry/calling.h | 7 +++
  42. arch/x86/include/asm/pti.h | 14 +++++
  43. include/linux/pti.h | 11 ++++
  44. arch/x86/boot/compressed/pagetable.c | 3 +
  45. arch/x86/mm/init.c | 2 +
  46. arch/x86/mm/pti.c | 84 +++++++++++++++++++++++++
  47. init/main.c | 3 +
  48. 9 files changed, 130 insertions(+), 3 deletions(-)
  49. create mode 100644 arch/x86/include/asm/pti.h
  50. create mode 100644 include/linux/pti.h
  51. create mode 100644 arch/x86/mm/pti.c
  52. diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
  53. index 3510e255ef4c..e2a4608da5d2 100644
  54. --- a/Documentation/admin-guide/kernel-parameters.txt
  55. +++ b/Documentation/admin-guide/kernel-parameters.txt
  56. @@ -2677,6 +2677,8 @@
  57. steal time is computed, but won't influence scheduler
  58. behaviour
  59. + nopti [X86-64] Disable kernel page table isolation
  60. +
  61. nolapic [X86-32,APIC] Do not enable or use the local APIC.
  62. nolapic_timer [X86-32,APIC] Do not use the local APIC timer.
  63. diff --git a/arch/x86/mm/Makefile b/arch/x86/mm/Makefile
  64. index 76f5399a8356..7aa68fc18abe 100644
  65. --- a/arch/x86/mm/Makefile
  66. +++ b/arch/x86/mm/Makefile
  67. @@ -35,7 +35,8 @@ obj-$(CONFIG_AMD_NUMA) += amdtopology.o
  68. obj-$(CONFIG_ACPI_NUMA) += srat.o
  69. obj-$(CONFIG_NUMA_EMU) += numa_emulation.o
  70. -obj-$(CONFIG_X86_INTEL_MPX) += mpx.o
  71. -obj-$(CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS) += pkeys.o
  72. -obj-$(CONFIG_RANDOMIZE_MEMORY) += kaslr.o
  73. +obj-$(CONFIG_X86_INTEL_MPX) += mpx.o
  74. +obj-$(CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS) += pkeys.o
  75. +obj-$(CONFIG_RANDOMIZE_MEMORY) += kaslr.o
  76. +obj-$(CONFIG_PAGE_TABLE_ISOLATION) += pti.o
  77. diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h
  78. index dde6262be0a3..bb56f5346ae8 100644
  79. --- a/arch/x86/entry/calling.h
  80. +++ b/arch/x86/entry/calling.h
  81. @@ -204,18 +204,23 @@ For 32-bit we have the following conventions - kernel is built with
  82. .endm
  83. .macro SWITCH_TO_KERNEL_CR3 scratch_reg:req
  84. + ALTERNATIVE "jmp .Lend_\@", "", X86_FEATURE_PTI
  85. mov %cr3, \scratch_reg
  86. ADJUST_KERNEL_CR3 \scratch_reg
  87. mov \scratch_reg, %cr3
  88. +.Lend_\@:
  89. .endm
  90. .macro SWITCH_TO_USER_CR3 scratch_reg:req
  91. + ALTERNATIVE "jmp .Lend_\@", "", X86_FEATURE_PTI
  92. mov %cr3, \scratch_reg
  93. ADJUST_USER_CR3 \scratch_reg
  94. mov \scratch_reg, %cr3
  95. +.Lend_\@:
  96. .endm
  97. .macro SAVE_AND_SWITCH_TO_KERNEL_CR3 scratch_reg:req save_reg:req
  98. + ALTERNATIVE "jmp .Ldone_\@", "", X86_FEATURE_PTI
  99. movq %cr3, \scratch_reg
  100. movq \scratch_reg, \save_reg
  101. /*
  102. @@ -232,11 +237,13 @@ For 32-bit we have the following conventions - kernel is built with
  103. .endm
  104. .macro RESTORE_CR3 save_reg:req
  105. + ALTERNATIVE "jmp .Lend_\@", "", X86_FEATURE_PTI
  106. /*
  107. * The CR3 write could be avoided when not changing its value,
  108. * but would require a CR3 read *and* a scratch register.
  109. */
  110. movq \save_reg, %cr3
  111. +.Lend_\@:
  112. .endm
  113. #else /* CONFIG_PAGE_TABLE_ISOLATION=n: */
  114. diff --git a/arch/x86/include/asm/pti.h b/arch/x86/include/asm/pti.h
  115. new file mode 100644
  116. index 000000000000..0b5ef05b2d2d
  117. --- /dev/null
  118. +++ b/arch/x86/include/asm/pti.h
  119. @@ -0,0 +1,14 @@
  120. +// SPDX-License-Identifier: GPL-2.0
  121. +#ifndef _ASM_X86_PTI_H
  122. +#define _ASM_X86_PTI_H
  123. +#ifndef __ASSEMBLY__
  124. +
  125. +#ifdef CONFIG_PAGE_TABLE_ISOLATION
  126. +extern void pti_init(void);
  127. +extern void pti_check_boottime_disable(void);
  128. +#else
  129. +static inline void pti_check_boottime_disable(void) { }
  130. +#endif
  131. +
  132. +#endif /* __ASSEMBLY__ */
  133. +#endif /* _ASM_X86_PTI_H */
  134. diff --git a/include/linux/pti.h b/include/linux/pti.h
  135. new file mode 100644
  136. index 000000000000..0174883a935a
  137. --- /dev/null
  138. +++ b/include/linux/pti.h
  139. @@ -0,0 +1,11 @@
  140. +// SPDX-License-Identifier: GPL-2.0
  141. +#ifndef _INCLUDE_PTI_H
  142. +#define _INCLUDE_PTI_H
  143. +
  144. +#ifdef CONFIG_PAGE_TABLE_ISOLATION
  145. +#include <asm/pti.h>
  146. +#else
  147. +static inline void pti_init(void) { }
  148. +#endif
  149. +
  150. +#endif
  151. diff --git a/arch/x86/boot/compressed/pagetable.c b/arch/x86/boot/compressed/pagetable.c
  152. index 28029be47fbb..21d8839cdaa7 100644
  153. --- a/arch/x86/boot/compressed/pagetable.c
  154. +++ b/arch/x86/boot/compressed/pagetable.c
  155. @@ -15,6 +15,9 @@
  156. #define __pa(x) ((unsigned long)(x))
  157. #define __va(x) ((void *)((unsigned long)(x)))
  158. +/* No PAGE_TABLE_ISOLATION support needed either: */
  159. +#undef CONFIG_PAGE_TABLE_ISOLATION
  160. +
  161. #include "misc.h"
  162. /* These actually do the work of building the kernel identity maps. */
  163. diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
  164. index 020223420308..af75069fb116 100644
  165. --- a/arch/x86/mm/init.c
  166. +++ b/arch/x86/mm/init.c
  167. @@ -20,6 +20,7 @@
  168. #include <asm/kaslr.h>
  169. #include <asm/hypervisor.h>
  170. #include <asm/cpufeature.h>
  171. +#include <asm/pti.h>
  172. /*
  173. * We need to define the tracepoints somewhere, and tlb.c
  174. @@ -630,6 +631,7 @@ void __init init_mem_mapping(void)
  175. {
  176. unsigned long end;
  177. + pti_check_boottime_disable();
  178. probe_page_size_mask();
  179. setup_pcid();
  180. diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c
  181. new file mode 100644
  182. index 000000000000..375f23a758bc
  183. --- /dev/null
  184. +++ b/arch/x86/mm/pti.c
  185. @@ -0,0 +1,84 @@
  186. +/*
  187. + * Copyright(c) 2017 Intel Corporation. All rights reserved.
  188. + *
  189. + * This program is free software; you can redistribute it and/or modify
  190. + * it under the terms of version 2 of the GNU General Public License as
  191. + * published by the Free Software Foundation.
  192. + *
  193. + * This program is distributed in the hope that it will be useful, but
  194. + * WITHOUT ANY WARRANTY; without even the implied warranty of
  195. + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
  196. + * General Public License for more details.
  197. + *
  198. + * This code is based in part on work published here:
  199. + *
  200. + * https://github.com/IAIK/KAISER
  201. + *
  202. + * The original work was written by and and signed off by for the Linux
  203. + * kernel by:
  204. + *
  205. + * Signed-off-by: Richard Fellner <[email protected]>
  206. + * Signed-off-by: Moritz Lipp <[email protected]>
  207. + * Signed-off-by: Daniel Gruss <[email protected]>
  208. + * Signed-off-by: Michael Schwarz <[email protected]>
  209. + *
  210. + * Major changes to the original code by: Dave Hansen <[email protected]>
  211. + * Mostly rewritten by Thomas Gleixner <[email protected]> and
  212. + * Andy Lutomirsky <[email protected]>
  213. + */
  214. +#include <linux/kernel.h>
  215. +#include <linux/errno.h>
  216. +#include <linux/string.h>
  217. +#include <linux/types.h>
  218. +#include <linux/bug.h>
  219. +#include <linux/init.h>
  220. +#include <linux/spinlock.h>
  221. +#include <linux/mm.h>
  222. +#include <linux/uaccess.h>
  223. +
  224. +#include <asm/cpufeature.h>
  225. +#include <asm/hypervisor.h>
  226. +#include <asm/cmdline.h>
  227. +#include <asm/pti.h>
  228. +#include <asm/pgtable.h>
  229. +#include <asm/pgalloc.h>
  230. +#include <asm/tlbflush.h>
  231. +#include <asm/desc.h>
  232. +
  233. +#undef pr_fmt
  234. +#define pr_fmt(fmt) "Kernel/User page tables isolation: " fmt
  235. +
  236. +static void __init pti_print_if_insecure(const char *reason)
  237. +{
  238. + if (boot_cpu_has_bug(X86_BUG_CPU_INSECURE))
  239. + pr_info("%s\n", reason);
  240. +}
  241. +
  242. +void __init pti_check_boottime_disable(void)
  243. +{
  244. + if (hypervisor_is_type(X86_HYPER_XEN_PV)) {
  245. + pti_print_if_insecure("disabled on XEN PV.");
  246. + return;
  247. + }
  248. +
  249. + if (cmdline_find_option_bool(boot_command_line, "nopti")) {
  250. + pti_print_if_insecure("disabled on command line.");
  251. + return;
  252. + }
  253. +
  254. + if (!boot_cpu_has_bug(X86_BUG_CPU_INSECURE))
  255. + return;
  256. +
  257. + setup_force_cpu_cap(X86_FEATURE_PTI);
  258. +}
  259. +
  260. +/*
  261. + * Initialize kernel page table isolation
  262. + */
  263. +void __init pti_init(void)
  264. +{
  265. + if (!static_cpu_has(X86_FEATURE_PTI))
  266. + return;
  267. +
  268. + pr_info("enabled\n");
  269. +}
  270. diff --git a/init/main.c b/init/main.c
  271. index de1c495da782..bb0896c24c08 100644
  272. --- a/init/main.c
  273. +++ b/init/main.c
  274. @@ -75,6 +75,7 @@
  275. #include <linux/slab.h>
  276. #include <linux/perf_event.h>
  277. #include <linux/ptrace.h>
  278. +#include <linux/pti.h>
  279. #include <linux/blkdev.h>
  280. #include <linux/elevator.h>
  281. #include <linux/sched_clock.h>
  282. @@ -506,6 +507,8 @@ static void __init mm_init(void)
  283. ioremap_huge_init();
  284. /* Should be run before the first non-init thread is created */
  285. init_espfix_bsp();
  286. + /* Should be run after espfix64 is set up. */
  287. + pti_init();
  288. }
  289. asmlinkage __visible void __init start_kernel(void)
  290. --
  291. 2.14.2