Merge pull request #719 from dotnet/enable-docs-debug

Enable docs in debug

Rx.NET/Source/Directory.build.props

@@ -3,7 +3,7 @@
     <Product>$(AssemblyName) ($(TargetFramework))</Product>
     <Copyright>Copyright (c) .NET Foundation and Contributors.</Copyright>
     <MinClientVersion>2.12</MinClientVersion>
-    <GenerateDocumentationFile Condition=" '$(Configuration)' == 'Release' ">true</GenerateDocumentationFile>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <Authors>.NET Foundation and Contributors</Authors>
     <PackageIconUrl>http://go.microsoft.com/fwlink/?LinkId=261274</PackageIconUrl>
     <PackageProjectUrl>http://go.microsoft.com/fwlink/?LinkId=261273</PackageProjectUrl>

Rx.NET/Source/src/System.Reactive/Linq/Observable.Events.cs

@@ -3,6 +3,7 @@
 // See the LICENSE file in the project root for more information. 
 
 using System.Reactive.Concurrency;
+using System.Threading;
 
 namespace System.Reactive.Linq
 {

Rx.NET/Source/src/System.Reactive/Notification.cs

@@ -394,7 +394,7 @@ namespace System.Reactive
         {
             /// <summary>
             /// Complete notifications are stateless thus only one instance
-            /// can ever exist per type <see cref="T"/>.
+            /// can ever exist per type.
             /// </summary>
             internal static readonly Notification<T> Instance = new OnCompletedNotification();
 
@@ -654,20 +654,20 @@ namespace System.Reactive
 
         private sealed class NotificationToObservable : ObservableBase<T>
         {
-            private readonly IScheduler scheduler;
-            private readonly Notification<T> parent;
+            private readonly IScheduler _scheduler;
+            private readonly Notification<T> _parent;
 
             public NotificationToObservable(IScheduler scheduler, Notification<T> parent)
             {
-                this.scheduler = scheduler;
-                this.parent = parent;
+                _scheduler = scheduler;
+                _parent = parent;
             }
 
             protected override IDisposable SubscribeCore(IObserver<T> observer)
             {
-                return scheduler.Schedule((parent, observer), (scheduler, state) =>
+                return _scheduler.Schedule((_parent, observer), (scheduler, state) =>
                 {
-                    var parent = state.parent;
+                    var parent = state._parent;
                     var o = state.observer;
 
                     parent.Accept(o);

Rx.NET/Source/src/System.Reactive/Platforms/UWP/Concurrency/CoreDispatcherScheduler.cs

@@ -12,7 +12,7 @@ using Windows.UI.Xaml;
 namespace System.Reactive.Concurrency
 {
     /// <summary>
-    /// Represents an object that schedules units of work on a <see cref="Windows.UI.Core.CoreDispatcher"/>.
+    /// Represents an object that schedules units of work on a <see cref="CoreDispatcher"/>.
     /// </summary>
     /// <remarks>
     /// This scheduler type is typically used indirectly through the <see cref="System.Reactive.Linq.DispatcherObservable.ObserveOnDispatcher{TSource}(IObservable{TSource})"/> and <see cref="System.Reactive.Linq.DispatcherObservable.SubscribeOnDispatcher{TSource}(IObservable{TSource})"/> methods that use the current Dispatcher.
@@ -21,7 +21,7 @@ namespace System.Reactive.Concurrency
     public sealed class CoreDispatcherScheduler : LocalScheduler, ISchedulerPeriodic
     {
         /// <summary>
-        /// Constructs a <see cref="CoreDispatcherScheduler"/> that schedules units of work on the given <see cref="Windows.UI.Core.CoreDispatcher"/>.
+        /// Constructs a <see cref="CoreDispatcherScheduler"/> that schedules units of work on the given <see cref="CoreDispatcher"/>.
         /// </summary>
         /// <param name="dispatcher">Dispatcher to schedule work on.</param>
         /// <exception cref="ArgumentNullException"><paramref name="dispatcher"/> is <c>null</c>.</exception>
@@ -32,7 +32,7 @@ namespace System.Reactive.Concurrency
         }
 
         /// <summary>
-        /// Constructs a <see cref="CoreDispatcherScheduler"/> that schedules units of work on the given <see cref="Windows.UI.Core.CoreDispatcher"/> with the given priority.
+        /// Constructs a <see cref="CoreDispatcherScheduler"/> that schedules units of work on the given <see cref="CoreDispatcher"/> with the given priority.
         /// </summary>
         /// <param name="dispatcher">Dispatcher to schedule work on.</param>
         /// <param name="priority">Priority for scheduled units of work.</param>
@@ -44,7 +44,7 @@ namespace System.Reactive.Concurrency
         }
 
         /// <summary>
-        /// Gets the scheduler that schedules work on the <see cref="Windows.UI.Core.CoreDispatcher"/> associated with the current Window.
+        /// Gets the scheduler that schedules work on the <see cref="CoreDispatcher"/> associated with the current Window.
         /// </summary>
         public static CoreDispatcherScheduler Current
         {
@@ -61,7 +61,7 @@ namespace System.Reactive.Concurrency
         }
 
         /// <summary>
-        /// Gets the <see cref="Windows.UI.Core.CoreDispatcher"/> associated with the <see cref="CoreDispatcherScheduler"/>.
+        /// Gets the <see cref="CoreDispatcher"/> associated with the <see cref="CoreDispatcherScheduler"/>.
         /// </summary>
         public CoreDispatcher Dispatcher { get; }
 
@@ -130,7 +130,7 @@ namespace System.Reactive.Concurrency
         }
 
         /// <summary>
-        /// Schedules an action to be executed after <paramref name="dueTime"/> on the dispatcher, using a <see cref="Windows.UI.Xaml.DispatcherTimer"/> object.
+        /// Schedules an action to be executed after <paramref name="dueTime"/> on the dispatcher, using a <see cref="DispatcherTimer"/> object.
         /// </summary>
         /// <typeparam name="TState">The type of the state passed to the scheduled action.</typeparam>
         /// <param name="state">State passed to the action to be executed.</param>
@@ -194,7 +194,7 @@ namespace System.Reactive.Concurrency
         }
 
         /// <summary>
-        /// Schedules a periodic piece of work on the dispatcher, using a <see cref="Windows.UI.Xaml.DispatcherTimer"/> object.
+        /// Schedules a periodic piece of work on the dispatcher, using a <see cref="DispatcherTimer"/> object.
         /// </summary>
         /// <typeparam name="TState">The type of the state passed to the scheduled action.</typeparam>
         /// <param name="state">Initial state passed to the action upon the first iteration.</param>