Adding some missing ConfigureAwait(false) calls.

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/AsyncObservable.cs

@@ -30,7 +30,7 @@ namespace System.Reactive.Linq
             {
                 try
                 {
-                    return await source.SubscribeAsync(observer);
+                    return await source.SubscribeAsync(observer).ConfigureAwait(false);
                 }
                 catch (Exception ex)
                 {

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/Buffer.cs

@@ -325,7 +325,7 @@ namespace System.Reactive.Linq
 
                         await scheduler.Delay(timeSpan, ct).RendezVous(scheduler, ct);
                     }
-                }, timeSpan);
+                }, timeSpan).ConfigureAwait(false);
 
                 return (sink, timer);
             };
@@ -456,7 +456,7 @@ namespace System.Reactive.Linq
 
                         await scheduler.Delay(GetNextDue(), ct).RendezVous(scheduler, ct);
                     }
-                }, GetNextDue());
+                }, GetNextDue()).ConfigureAwait(false);
 
                 return (sink, timer);
             };
@@ -498,7 +498,7 @@ namespace System.Reactive.Linq
                                 await FlushAsync().ConfigureAwait(false);
                             }
                         }
-                    }, timeSpan);
+                    }, timeSpan).ConfigureAwait(false);
 
                     await timer.AssignAsync(d).ConfigureAwait(false);
                 }

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/FromEvent.cs

@@ -111,7 +111,7 @@ namespace System.Reactive.Linq
                     {
                         var handler = new Action<TEventArgs>(async e =>
                         {
-                            await observer.OnNextAsync(e);
+                            await observer.OnNextAsync(e).ConfigureAwait(false);
                         });
 
                         var converted = conversion(handler);

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/GroupJoin.cs

@@ -104,7 +104,7 @@ namespace System.Reactive.Linq
                         }
                         catch (Exception ex)
                         {
-                            await OnErrorAsync(ex);
+                            await OnErrorAsync(ex).ConfigureAwait(false);
                             return;
                         }
 
@@ -143,7 +143,7 @@ namespace System.Reactive.Linq
                         }
                         catch (Exception ex)
                         {
-                            await OnErrorAsync(ex);
+                            await OnErrorAsync(ex).ConfigureAwait(false);
                             return;
                         }
 

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/Join.cs

@@ -98,7 +98,7 @@ namespace System.Reactive.Linq
                         }
                         catch (Exception ex)
                         {
-                            await OnErrorAsync(ex);
+                            await OnErrorAsync(ex).ConfigureAwait(false);
                             return;
                         }
 
@@ -141,7 +141,7 @@ namespace System.Reactive.Linq
                                     }
                                     catch (Exception ex)
                                     {
-                                        await OnErrorAsync(ex);
+                                        await OnErrorAsync(ex).ConfigureAwait(false);
                                         return;
                                     }
 
@@ -229,7 +229,7 @@ namespace System.Reactive.Linq
                                     }
                                     catch (Exception ex)
                                     {
-                                        await OnErrorAsync(ex);
+                                        await OnErrorAsync(ex).ConfigureAwait(false);
                                         return;
                                     }
 

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/Merge.cs

@@ -21,7 +21,7 @@ namespace System.Reactive.Linq
             {
                 var (sink, cancel) = AsyncObserver.Merge(observer);
 
-                var subscription = await source.SubscribeSafeAsync(sink);
+                var subscription = await source.SubscribeSafeAsync(sink).ConfigureAwait(false);
 
                 return StableCompositeAsyncDisposable.Create(subscription, cancel);
             });
@@ -45,7 +45,7 @@ namespace System.Reactive.Linq
             {
                 using (await gate.LockAsync().ConfigureAwait(false))
                 {
-                    await observer.OnErrorAsync(ex);
+                    await observer.OnErrorAsync(ex).ConfigureAwait(false);
                 }
             };
 

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/SelectMany.cs

@@ -21,7 +21,7 @@ namespace System.Reactive.Linq
             {
                 var (sink, inner) = AsyncObserver.SelectMany(observer, selector);
 
-                var subscription = await source.SubscribeSafeAsync(sink);
+                var subscription = await source.SubscribeSafeAsync(sink).ConfigureAwait(false);
 
                 return StableCompositeAsyncDisposable.Create(subscription, inner);
             });
@@ -38,7 +38,7 @@ namespace System.Reactive.Linq
             {
                 var (sink, inner) = AsyncObserver.SelectMany(observer, selector);
 
-                var subscription = await source.SubscribeSafeAsync(sink);
+                var subscription = await source.SubscribeSafeAsync(sink).ConfigureAwait(false);
 
                 return StableCompositeAsyncDisposable.Create(subscription, inner);
             });
@@ -57,7 +57,7 @@ namespace System.Reactive.Linq
             {
                 var (sink, inner) = AsyncObserver.SelectMany(observer, collectionSelector, resultSelector);
 
-                var subscription = await source.SubscribeSafeAsync(sink);
+                var subscription = await source.SubscribeSafeAsync(sink).ConfigureAwait(false);
 
                 return StableCompositeAsyncDisposable.Create(subscription, inner);
             });
@@ -76,7 +76,7 @@ namespace System.Reactive.Linq
             {
                 var (sink, inner) = AsyncObserver.SelectMany(observer, collectionSelector, resultSelector);
 
-                var subscription = await source.SubscribeSafeAsync(sink);
+                var subscription = await source.SubscribeSafeAsync(sink).ConfigureAwait(false);
 
                 return StableCompositeAsyncDisposable.Create(subscription, inner);
             });
@@ -93,7 +93,7 @@ namespace System.Reactive.Linq
             {
                 var (sink, inner) = AsyncObserver.SelectMany(observer, selector);
 
-                var subscription = await source.SubscribeSafeAsync(sink);
+                var subscription = await source.SubscribeSafeAsync(sink).ConfigureAwait(false);
 
                 return StableCompositeAsyncDisposable.Create(subscription, inner);
             });
@@ -110,7 +110,7 @@ namespace System.Reactive.Linq
             {
                 var (sink, inner) = AsyncObserver.SelectMany(observer, selector);
 
-                var subscription = await source.SubscribeSafeAsync(sink);
+                var subscription = await source.SubscribeSafeAsync(sink).ConfigureAwait(false);
 
                 return StableCompositeAsyncDisposable.Create(subscription, inner);
             });
@@ -129,7 +129,7 @@ namespace System.Reactive.Linq
             {
                 var (sink, inner) = AsyncObserver.SelectMany(observer, collectionSelector, resultSelector);
 
-                var subscription = await source.SubscribeSafeAsync(sink);
+                var subscription = await source.SubscribeSafeAsync(sink).ConfigureAwait(false);
 
                 return StableCompositeAsyncDisposable.Create(subscription, inner);
             });
@@ -148,7 +148,7 @@ namespace System.Reactive.Linq
             {
                 var (sink, inner) = AsyncObserver.SelectMany(observer, collectionSelector, resultSelector);
 
-                var subscription = await source.SubscribeSafeAsync(sink);
+                var subscription = await source.SubscribeSafeAsync(sink).ConfigureAwait(false);
 
                 return StableCompositeAsyncDisposable.Create(subscription, inner);
             });
@@ -208,7 +208,7 @@ namespace System.Reactive.Linq
             {
                 using (await gate.LockAsync().ConfigureAwait(false))
                 {
-                    await observer.OnErrorAsync(ex);
+                    await observer.OnErrorAsync(ex).ConfigureAwait(false);
                 }
             };
 

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/Skip.cs

@@ -42,7 +42,7 @@ namespace System.Reactive.Linq
 
             return Create<TSource>(async observer =>
             {
-                var (sourceObserver, timer) = await AsyncObserver.Skip(observer, duration);
+                var (sourceObserver, timer) = await AsyncObserver.Skip(observer, duration).ConfigureAwait(false);
 
                 var subscription = await source.SubscribeSafeAsync(sourceObserver).ConfigureAwait(false);
 
@@ -68,7 +68,7 @@ namespace System.Reactive.Linq
 
             return Create<TSource>(async observer =>
             {
-                var (sourceObserver, timer) = await AsyncObserver.Skip(observer, duration);
+                var (sourceObserver, timer) = await AsyncObserver.Skip(observer, duration).ConfigureAwait(false);
 
                 var subscription = await source.SubscribeSafeAsync(sourceObserver).ConfigureAwait(false);
 
@@ -160,7 +160,7 @@ namespace System.Reactive.Linq
                             {
                                 open = true;
                             }
-                        }, duration)
+                        }, duration).ConfigureAwait(false)
                     );
             }
         }

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/SkipUntil.cs

@@ -25,6 +25,8 @@ namespace System.Reactive.Linq
                 var sourceTask = source.SubscribeSafeAsync(sourceObserver);
                 var untilTask = until.SubscribeSafeAsync(untilObserver);
 
+                // REVIEW: Consider concurrent subscriptions.
+
                 var d1 = await sourceTask.ConfigureAwait(false);
                 var d2 = await untilTask.ConfigureAwait(false);
 
@@ -41,7 +43,7 @@ namespace System.Reactive.Linq
 
             return Create<TSource>(async observer =>
             {
-                var (sourceObserver, timer) = await AsyncObserver.SkipUntil(observer, endTime);
+                var (sourceObserver, timer) = await AsyncObserver.SkipUntil(observer, endTime).ConfigureAwait(false);
 
                 var subscription = await source.SubscribeSafeAsync(sourceObserver).ConfigureAwait(false);
 
@@ -60,7 +62,7 @@ namespace System.Reactive.Linq
 
             return Create<TSource>(async observer =>
             {
-                var (sourceObserver, timer) = await AsyncObserver.SkipUntil(observer, endTime);
+                var (sourceObserver, timer) = await AsyncObserver.SkipUntil(observer, endTime).ConfigureAwait(false);
 
                 var subscription = await source.SubscribeSafeAsync(sourceObserver).ConfigureAwait(false);
 
@@ -182,7 +184,7 @@ namespace System.Reactive.Linq
                             {
                                 open = true;
                             }
-                        }, endTime)
+                        }, endTime).ConfigureAwait(false)
                     );
             }
         }

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/SkipWhile.cs

@@ -102,7 +102,7 @@ namespace System.Reactive.Linq
                     {
                         try
                         {
-                            open = !await predicate(x);
+                            open = !await predicate(x).ConfigureAwait(false);
                         }
                         catch (Exception ex)
                         {
@@ -174,7 +174,7 @@ namespace System.Reactive.Linq
                     {
                         try
                         {
-                            open = !await predicate(x, checked(i++));
+                            open = !await predicate(x, checked(i++)).ConfigureAwait(false);
                         }
                         catch (Exception ex)
                         {

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/StartAsync.cs

@@ -58,7 +58,7 @@ namespace System.Reactive.Linq
 
             return Create<TSource>(async observer =>
             {
-                var subscription = await task.ToAsyncObservable(scheduler).SubscribeAsync(observer);
+                var subscription = await task.ToAsyncObservable(scheduler).SubscribeAsync(observer).ConfigureAwait(false);
 
                 return StableCompositeAsyncDisposable.Create(cancel, subscription);
             });
@@ -111,7 +111,7 @@ namespace System.Reactive.Linq
 
             return Create<Unit>(async observer =>
             {
-                var subscription = await task.ToAsyncObservable(scheduler).SubscribeAsync(observer);
+                var subscription = await task.ToAsyncObservable(scheduler).SubscribeAsync(observer).ConfigureAwait(false);
 
                 return StableCompositeAsyncDisposable.Create(cancel, subscription);
             });

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/Switch.cs

@@ -18,7 +18,7 @@ namespace System.Reactive.Linq
             {
                 var (sink, cancel) = AsyncObserver.Switch(observer);
 
-                var subscription = await source.SubscribeSafeAsync(sink);
+                var subscription = await source.SubscribeSafeAsync(sink).ConfigureAwait(false);
 
                 return StableCompositeAsyncDisposable.Create(subscription, cancel);
             });

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/Take.cs

@@ -42,7 +42,7 @@ namespace System.Reactive.Linq
 
             return Create<TSource>(async observer =>
             {
-                var (sourceObserver, timer) = await AsyncObserver.Take(observer, duration);
+                var (sourceObserver, timer) = await AsyncObserver.Take(observer, duration).ConfigureAwait(false);
 
                 var subscription = await source.SubscribeSafeAsync(sourceObserver).ConfigureAwait(false);
 
@@ -68,7 +68,7 @@ namespace System.Reactive.Linq
 
             return Create<TSource>(async observer =>
             {
-                var (sourceObserver, timer) = await AsyncObserver.Take(observer, duration);
+                var (sourceObserver, timer) = await AsyncObserver.Take(observer, duration).ConfigureAwait(false);
 
                 var subscription = await source.SubscribeSafeAsync(sourceObserver).ConfigureAwait(false);
 
@@ -134,7 +134,7 @@ namespace System.Reactive.Linq
                             {
                                 await observer.OnCompletedAsync().RendezVous(scheduler, ct);
                             }
-                        }, duration)
+                        }, duration).ConfigureAwait(false)
                     );
             }
         }

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/TakeUntil.cs

@@ -25,6 +25,8 @@ namespace System.Reactive.Linq
                 var sourceTask = source.SubscribeSafeAsync(sourceObserver);
                 var untilTask = until.SubscribeSafeAsync(untilObserver);
 
+                // REVIEW: Consider concurrent subscriptions.
+
                 var d1 = await sourceTask.ConfigureAwait(false);
                 var d2 = await untilTask.ConfigureAwait(false);
 
@@ -41,7 +43,7 @@ namespace System.Reactive.Linq
 
             return Create<TSource>(async observer =>
             {
-                var (sourceObserver, timer) = await AsyncObserver.TakeUntil(observer, endTime);
+                var (sourceObserver, timer) = await AsyncObserver.TakeUntil(observer, endTime).ConfigureAwait(false);
 
                 var subscription = await source.SubscribeSafeAsync(sourceObserver).ConfigureAwait(false);
 
@@ -60,7 +62,7 @@ namespace System.Reactive.Linq
 
             return Create<TSource>(async observer =>
             {
-                var (sourceObserver, timer) = await AsyncObserver.TakeUntil(observer, endTime, scheduler);
+                var (sourceObserver, timer) = await AsyncObserver.TakeUntil(observer, endTime, scheduler).ConfigureAwait(false);
 
                 var subscription = await source.SubscribeSafeAsync(sourceObserver).ConfigureAwait(false);
 
@@ -152,7 +154,7 @@ namespace System.Reactive.Linq
                             {
                                 await observer.OnCompletedAsync().RendezVous(scheduler, ct);
                             }
-                        }, endTime)
+                        }, endTime).ConfigureAwait(false)
                     );
             }
         }

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/Using.cs

@@ -26,7 +26,7 @@ namespace System.Reactive.Linq
                 }
                 catch (Exception ex)
                 {
-                    await observer.OnErrorAsync(ex);
+                    await observer.OnErrorAsync(ex).ConfigureAwait(false);
                     return AsyncDisposable.Nop;
                 }
 
@@ -39,7 +39,7 @@ namespace System.Reactive.Linq
                 {
                     using (resource)
                     {
-                        await observer.OnErrorAsync(ex);
+                        await observer.OnErrorAsync(ex).ConfigureAwait(false);
                         return AsyncDisposable.Nop;
                     }
                 }
@@ -73,7 +73,7 @@ namespace System.Reactive.Linq
                 }
                 catch (Exception ex)
                 {
-                    await observer.OnErrorAsync(ex);
+                    await observer.OnErrorAsync(ex).ConfigureAwait(false);
                     return AsyncDisposable.Nop;
                 }
 
@@ -86,7 +86,7 @@ namespace System.Reactive.Linq
                 {
                     using (resource)
                     {
-                        await observer.OnErrorAsync(ex);
+                        await observer.OnErrorAsync(ex).ConfigureAwait(false);
                         return AsyncDisposable.Nop;
                     }
                 }
@@ -120,7 +120,7 @@ namespace System.Reactive.Linq
                 }
                 catch (Exception ex)
                 {
-                    await observer.OnErrorAsync(ex);
+                    await observer.OnErrorAsync(ex).ConfigureAwait(false);
                     return AsyncDisposable.Nop;
                 }
 
@@ -133,7 +133,7 @@ namespace System.Reactive.Linq
                 {
                     try
                     {
-                        await observer.OnErrorAsync(ex);
+                        await observer.OnErrorAsync(ex).ConfigureAwait(false);
                         return AsyncDisposable.Nop;
                     }
                     finally
@@ -175,7 +175,7 @@ namespace System.Reactive.Linq
                 }
                 catch (Exception ex)
                 {
-                    await observer.OnErrorAsync(ex);
+                    await observer.OnErrorAsync(ex).ConfigureAwait(false);
                     return AsyncDisposable.Nop;
                 }
 
@@ -188,7 +188,7 @@ namespace System.Reactive.Linq
                 {
                     try
                     {
-                        await observer.OnErrorAsync(ex);
+                        await observer.OnErrorAsync(ex).ConfigureAwait(false);
                         return AsyncDisposable.Nop;
                     }
                     finally

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/Window.cs

@@ -299,7 +299,7 @@ namespace System.Reactive.Linq
 
                         await scheduler.Delay(timeSpan, ct).RendezVous(scheduler, ct);
                     }
-                }, timeSpan);
+                }, timeSpan).ConfigureAwait(false);
 
                 await d.AddAsync(timer).ConfigureAwait(false);
 
@@ -435,7 +435,7 @@ namespace System.Reactive.Linq
 
                         await scheduler.Delay(GetNextDue(), ct).RendezVous(scheduler, ct);
                     }
-                }, GetNextDue());
+                }, GetNextDue()).ConfigureAwait(false);
 
                 await inner.AssignAsync(task).ConfigureAwait(false);
             }
@@ -538,7 +538,7 @@ namespace System.Reactive.Linq
                     }
 
                     await CreateTimer(newWindow).RendezVous(scheduler, ct);
-                }, timeSpan);
+                }, timeSpan).ConfigureAwait(false);
 
                 await inner.AssignAsync(task).ConfigureAwait(false);
             }
@@ -558,7 +558,7 @@ namespace System.Reactive.Linq
                 await d.AddAsync(subscription).ConfigureAwait(false);
                 await d.AddAsync(timer).ConfigureAwait(false);
 
-                var w = await CreateWindowAsync();
+                var w = await CreateWindowAsync().ConfigureAwait(false);
                 await CreateTimer(w).ConfigureAwait(false);
 
                 return

AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/WithLatestFrom.cs

@@ -21,8 +21,10 @@ namespace System.Reactive.Linq
             {
                 var (firstObserver, secondObserver) = AsyncObserver.WithLatestFrom(observer);
 
-                var firstSubscription = await first.SubscribeSafeAsync(firstObserver);
-                var secondSubscription = await second.SubscribeSafeAsync(secondObserver);
+                // REVIEW: Consider concurrent subscriptions.
+
+                var firstSubscription = await first.SubscribeSafeAsync(firstObserver).ConfigureAwait(false);
+                var secondSubscription = await second.SubscribeSafeAsync(secondObserver).ConfigureAwait(false);
 
                 return StableCompositeAsyncDisposable.Create(firstSubscription, secondSubscription);
             });
@@ -41,8 +43,10 @@ namespace System.Reactive.Linq
             {
                 var (firstObserver, secondObserver) = AsyncObserver.WithLatestFrom(observer, resultSelector);
 
-                var firstSubscription = await first.SubscribeSafeAsync(firstObserver);
-                var secondSubscription = await second.SubscribeSafeAsync(secondObserver);
+                // REVIEW: Consider concurrent subscriptions.
+
+                var firstSubscription = await first.SubscribeSafeAsync(firstObserver).ConfigureAwait(false);
+                var secondSubscription = await second.SubscribeSafeAsync(secondObserver).ConfigureAwait(false);
 
                 return StableCompositeAsyncDisposable.Create(firstSubscription, secondSubscription);
             });
@@ -61,8 +65,10 @@ namespace System.Reactive.Linq
             {
                 var (firstObserver, secondObserver) = AsyncObserver.WithLatestFrom(observer, resultSelector);
 
-                var firstSubscription = await first.SubscribeSafeAsync(firstObserver);
-                var secondSubscription = await second.SubscribeSafeAsync(secondObserver);
+                // REVIEW: Consider concurrent subscriptions.
+
+                var firstSubscription = await first.SubscribeSafeAsync(firstObserver).ConfigureAwait(false);
+                var secondSubscription = await second.SubscribeSafeAsync(secondObserver).ConfigureAwait(false);
 
                 return StableCompositeAsyncDisposable.Create(firstSubscription, secondSubscription);
             });