1
0
Эх сурвалжийг харах

Implement more Prepend overloads.

Bart De Smet 8 жил өмнө
parent
commit
9eaa572d2b

+ 130 - 12
AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/Prepend.cs

@@ -4,6 +4,7 @@
 
 using System.Collections.Generic;
 using System.Reactive.Concurrency;
+using System.Reactive.Disposables;
 using System.Threading.Tasks;
 
 namespace System.Reactive.Linq
@@ -30,7 +31,7 @@ namespace System.Reactive.Linq
             if (scheduler == null)
                 throw new ArgumentNullException(nameof(scheduler));
 
-            return Create<TSource>(async observer => await source.SubscribeSafeAsync(await AsyncObserver.Prepend(observer, value, scheduler).ConfigureAwait(false)).ConfigureAwait(false));
+            return Create<TSource>(observer => AsyncObserver.Prepend(observer, source, value, scheduler));
         }
 
         public static IAsyncObservable<TSource> Prepend<TSource>(this IAsyncObservable<TSource> source, params TSource[] values)
@@ -52,7 +53,7 @@ namespace System.Reactive.Linq
             if (values == null)
                 throw new ArgumentNullException(nameof(values));
 
-            return Create<TSource>(async observer => await source.SubscribeSafeAsync(await AsyncObserver.Prepend(observer, scheduler, values).ConfigureAwait(false)).ConfigureAwait(false));
+            return Create<TSource>(observer => AsyncObserver.Prepend(observer, source, scheduler, values));
         }
 
         public static IAsyncObservable<TSource> Prepend<TSource>(this IAsyncObservable<TSource> source, IEnumerable<TSource> values)
@@ -74,12 +75,14 @@ namespace System.Reactive.Linq
             if (values == null)
                 throw new ArgumentNullException(nameof(values));
 
-            return Create<TSource>(async observer => await source.SubscribeSafeAsync(await AsyncObserver.Prepend(observer, scheduler, values).ConfigureAwait(false)).ConfigureAwait(false));
+            return Create<TSource>(observer => AsyncObserver.Prepend(observer, source, scheduler, values));
         }
     }
 
     partial class AsyncObserver
     {
+        // REVIEW: There's some asymmetry on these overloads. Should standardize to Concat style.
+
         public static Task<IAsyncObserver<TSource>> Prepend<TSource>(IAsyncObserver<TSource> observer, TSource value)
         {
             if (observer == null)
@@ -89,20 +92,43 @@ namespace System.Reactive.Linq
 
             async Task<IAsyncObserver<TSource>> Core()
             {
-                await observer.OnNextAsync(value);
+                await observer.OnNextAsync(value).ConfigureAwait(false);
 
                 return observer;
             }
         }
 
-        public static Task<IAsyncObserver<TSource>> Prepend<TSource>(IAsyncObserver<TSource> observer, TSource value, IAsyncScheduler scheduler)
+        public static Task<IAsyncDisposable> Prepend<TSource>(IAsyncObserver<TSource> observer, IAsyncObservable<TSource> source, TSource value, IAsyncScheduler scheduler)
         {
             if (observer == null)
                 throw new ArgumentNullException(nameof(observer));
+            if (source == null)
+                throw new ArgumentNullException(nameof(source));
             if (scheduler == null)
                 throw new ArgumentNullException(nameof(scheduler));
 
-            throw new NotImplementedException();
+            return Core();
+
+            async Task<IAsyncDisposable> Core()
+            {
+                var subscription = new SingleAssignmentAsyncDisposable();
+
+                var task = await scheduler.ScheduleAsync(async ct =>
+                {
+                    if (ct.IsCancellationRequested)
+                        return;
+
+                    await observer.OnNextAsync(value).RendezVous(scheduler, ct);
+
+                    if (ct.IsCancellationRequested)
+                        return;
+
+                    var inner = await source.SubscribeSafeAsync(observer).ConfigureAwait(false);
+                    await subscription.AssignAsync(inner).RendezVous(scheduler, ct);
+                }).ConfigureAwait(false);
+
+                return StableCompositeAsyncDisposable.Create(task, subscription);
+            }
         }
 
         public static Task<IAsyncObserver<TSource>> Prepend<TSource>(IAsyncObserver<TSource> observer, params TSource[] values)
@@ -118,23 +144,49 @@ namespace System.Reactive.Linq
             {
                 foreach (var value in values)
                 {
-                    await observer.OnNextAsync(value);
+                    await observer.OnNextAsync(value).ConfigureAwait(false);
                 }
 
                 return observer;
             }
         }
 
-        public static Task<IAsyncObserver<TSource>> Prepend<TSource>(IAsyncObserver<TSource> observer, IAsyncScheduler scheduler, params TSource[] values)
+        public static Task<IAsyncDisposable> Prepend<TSource>(IAsyncObserver<TSource> observer, IAsyncObservable<TSource> source, IAsyncScheduler scheduler, params TSource[] values)
         {
             if (observer == null)
                 throw new ArgumentNullException(nameof(observer));
+            if (source == null)
+                throw new ArgumentNullException(nameof(source));
             if (scheduler == null)
                 throw new ArgumentNullException(nameof(scheduler));
             if (values == null)
                 throw new ArgumentNullException(nameof(values));
 
-            throw new NotImplementedException();
+            return Core();
+
+            async Task<IAsyncDisposable> Core()
+            {
+                var subscription = new SingleAssignmentAsyncDisposable();
+
+                var task = await scheduler.ScheduleAsync(async ct =>
+                {
+                    if (ct.IsCancellationRequested)
+                        return;
+
+                    for (var i = 0; i < values.Length && !ct.IsCancellationRequested; i++)
+                    {
+                        await observer.OnNextAsync(values[i]).RendezVous(scheduler, ct);
+                    }
+
+                    if (ct.IsCancellationRequested)
+                        return;
+
+                    var inner = await source.SubscribeSafeAsync(observer).ConfigureAwait(false);
+                    await subscription.AssignAsync(inner).RendezVous(scheduler, ct);
+                }).ConfigureAwait(false);
+
+                return StableCompositeAsyncDisposable.Create(task, subscription);
+            }
         }
 
         public static Task<IAsyncObserver<TSource>> Prepend<TSource>(IAsyncObserver<TSource> observer, IEnumerable<TSource> values)
@@ -150,23 +202,89 @@ namespace System.Reactive.Linq
             {
                 foreach (var value in values)
                 {
-                    await observer.OnNextAsync(value);
+                    await observer.OnNextAsync(value).ConfigureAwait(false);
                 }
 
                 return observer;
             }
         }
 
-        public static Task<IAsyncObserver<TSource>> Prepend<TSource>(IAsyncObserver<TSource> observer, IAsyncScheduler scheduler, IEnumerable<TSource> values)
+        public static Task<IAsyncDisposable> Prepend<TSource>(IAsyncObserver<TSource> observer, IAsyncObservable<TSource> source, IAsyncScheduler scheduler, IEnumerable<TSource> values)
         {
             if (observer == null)
                 throw new ArgumentNullException(nameof(observer));
+            if (source == null)
+                throw new ArgumentNullException(nameof(source));
             if (scheduler == null)
                 throw new ArgumentNullException(nameof(scheduler));
             if (values == null)
                 throw new ArgumentNullException(nameof(values));
 
-            throw new NotImplementedException();
+            return Core();
+
+            async Task<IAsyncDisposable> Core()
+            {
+                var subscription = new SingleAssignmentAsyncDisposable();
+
+                var task = await scheduler.ScheduleAsync(async ct =>
+                {
+                    if (ct.IsCancellationRequested)
+                        return;
+
+                    var e = default(IEnumerator<TSource>);
+
+                    try
+                    {
+                        e = values.GetEnumerator();
+                    }
+                    catch (Exception ex)
+                    {
+                        await observer.OnErrorAsync(ex).RendezVous(scheduler, ct);
+                        return;
+                    }
+
+                    using (e)
+                    {
+                        while (!ct.IsCancellationRequested)
+                        {
+                            var b = default(bool);
+                            var value = default(TSource);
+
+                            try
+                            {
+                                b = e.MoveNext();
+
+                                if (b)
+                                {
+                                    value = e.Current;
+                                }
+                            }
+                            catch (Exception ex)
+                            {
+                                await observer.OnErrorAsync(ex).RendezVous(scheduler, ct);
+                                return;
+                            }
+
+                            if (b)
+                            {
+                                await observer.OnNextAsync(value).RendezVous(scheduler, ct);
+                            }
+                            else
+                            {
+                                break;
+                            }
+                        }
+                    }
+
+                    if (ct.IsCancellationRequested)
+                        return;
+
+                    var inner = await source.SubscribeSafeAsync(observer).ConfigureAwait(false);
+                    await subscription.AssignAsync(inner).RendezVous(scheduler, ct);
+                }).ConfigureAwait(false);
+
+                return StableCompositeAsyncDisposable.Create(task, subscription);
+            }
         }
     }
 }