Răsfoiți Sursa

Adding REVIEW comments to SequenceEqual.

Bart De Smet 8 ani în urmă
părinte
comite
e3b319c4cb

+ 5 - 1
AsyncRx.NET/System.Reactive.Async.Linq/System/Reactive/Linq/Operators/SequenceEqual.cs

@@ -26,6 +26,8 @@ namespace System.Reactive.Linq
                 var firstTask = first.SubscribeSafeAsync(firstObserver);
                 var secondTask = second.SubscribeSafeAsync(secondObserver);
 
+                // REVIEW: Consider concurrent subscriptions.
+
                 var d1 = await firstTask.ConfigureAwait(false);
                 var d2 = await secondTask.ConfigureAwait(false);
 
@@ -44,11 +46,13 @@ namespace System.Reactive.Linq
 
             return Create<bool>(async observer =>
             {
-                var (firstObserver, secondObserver) = AsyncObserver.SequenceEqual<TSource>(observer, comparer);
+                var (firstObserver, secondObserver) = AsyncObserver.SequenceEqual(observer, comparer);
 
                 var firstTask = first.SubscribeSafeAsync(firstObserver);
                 var secondTask = second.SubscribeSafeAsync(secondObserver);
 
+                // REVIEW: Consider concurrent subscriptions.
+
                 var d1 = await firstTask.ConfigureAwait(false);
                 var d2 = await secondTask.ConfigureAwait(false);