Directory.build.props 6.1 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128
  1. <Project>
  2. <PropertyGroup>
  3. <Copyright>Copyright (c) .NET Foundation and Contributors.</Copyright>
  4. <MinClientVersion>2.12</MinClientVersion>
  5. <GenerateDocumentationFile>true</GenerateDocumentationFile>
  6. <Authors>.NET Foundation and Contributors</Authors>
  7. <PackageIcon>icon.png</PackageIcon>
  8. <PackageProjectUrl>https://github.com/dotnet/reactive</PackageProjectUrl>
  9. <PackageLicenseExpression>MIT</PackageLicenseExpression>
  10. <SignAssembly>true</SignAssembly>
  11. <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)ReactiveX.snk</AssemblyOriginatorKeyFile>
  12. <NoWarn>$(NoWarn);1701;1702;CS1591;NU5105</NoWarn>
  13. <DefaultLanguage>en-US</DefaultLanguage>
  14. <IncludeSymbols>false</IncludeSymbols>
  15. <IsTestProject>$(MSBuildProjectName.Contains('Tests'))</IsTestProject>
  16. <GeneratePackageOnBuild Condition=" '$(IsTestProject)' != 'true' and '$(CreatePackage)' == 'true' ">true</GeneratePackageOnBuild>
  17. <PackageOutputPath>$(MSBuildThisFileDirectory)artifacts</PackageOutputPath>
  18. <EmbedUntrackedSources>true</EmbedUntrackedSources>
  19. <PublishRepositoryUrl>true</PublishRepositoryUrl>
  20. <LangVersion>latest</LangVersion>
  21. </PropertyGroup>
  22. <PropertyGroup Condition="'$(Configuration)' != 'Debug'">
  23. <IncludeSymbols>true</IncludeSymbols>
  24. <SymbolPackageFormat>snupkg</SymbolPackageFormat>
  25. </PropertyGroup>
  26. <PropertyGroup Condition="'$(TF_BUILD)' == 'true'">
  27. <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
  28. </PropertyGroup>
  29. <ItemGroup>
  30. <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All"/>
  31. <!--
  32. Nerdbank.GitVersioning 3.6.128 injects a reference to a .proj file that doesn't work inside the
  33. UWP test runner project. We don't ship that as a NuGet package, so it doesn't matter what its
  34. version number is.
  35. -->
  36. <PackageReference
  37. Include="Nerdbank.GitVersioning"
  38. Version="3.6.143"
  39. PrivateAssets="all"
  40. Condition="$(ProjectName) != 'Tests.System.Reactive.Uwp.DeviceRunner'" />
  41. </ItemGroup>
  42. <ItemGroup>
  43. <None Include="$(MSBuildThisFileDirectory)../Resources/Artwork/Logo.png" Pack="true" PackagePath="\icon.png"/>
  44. </ItemGroup>
  45. <ItemGroup Condition="'$(IsTestProject)' == 'true'">
  46. <PackageReference Include="coverlet.collector" Version="3.2.0" />
  47. </ItemGroup>
  48. <PropertyGroup Condition="'$(TargetFramework)'=='uap10.0.18362'">
  49. <!--
  50. See 0003-uap-targets.md ADR in documentation for the reasons behind these settings.
  51. -->
  52. <NoStdLib>True</NoStdLib>
  53. <TargetPlatformMinVersion>10.0.18362</TargetPlatformMinVersion>
  54. <TargetPlatformVersion>10.0.18362.0</TargetPlatformVersion>
  55. <TargetPlatformIdentifier>UAP</TargetPlatformIdentifier>
  56. <TargetFrameworkMoniker>.NETCore,Version=v5.0</TargetFrameworkMoniker>
  57. <TargetFrameworkIdentifier>.NETCore</TargetFrameworkIdentifier>
  58. <TargetFrameworkVersion>v5.0</TargetFrameworkVersion>
  59. <NugetTargetMoniker>UAP,Version=v10.0</NugetTargetMoniker>
  60. <DefineConstants>$(DefineConstants);WINDOWS_UWP</DefineConstants>
  61. </PropertyGroup>
  62. <PropertyGroup>
  63. <AnalysisLevelDesign>7.0-default</AnalysisLevelDesign>
  64. <AnalysisLevelNaming>7.0-all</AnalysisLevelNaming>
  65. <AnalysisLevelPerformance>7.0-all</AnalysisLevelPerformance>
  66. <!-- Enable analyzers on older targets. -->
  67. <EnableNETAnalyzers>true</EnableNETAnalyzers>
  68. <!--
  69. Disabled diagnostics:
  70. CA1001 - types holding disposable fields should implement IDisposable. See next item.
  71. CA2213 - IDisposable types should Dispose any IDisposable fields. This rule finds over 600
  72. examples! These are all in subtle multithreaded or async code. Some of them appear
  73. not to be real problems. For example, there are places where schedulers retain
  74. references to IDisposable work items, but that IDisposable interfaces is only there
  75. to enable application code to cancel scheduled work, so it's not Rx's place to call
  76. Dispose. And there are more subtle cases where disposal is deferred to give threads
  77. a chance to shut down. Each of these likely needs individual review:
  78. https://github.com/dotnet/reactive/issues/1927
  79. IDE0028 - Suggests Collection expressions in place of construction, e.g. replaces new List<int>(x)
  80. [.. x]. To me, this is less readable, and it doesn't improve performance, as far as we know.
  81. Annoyingly, we don't seem to be able to configure this to apply only when it would not
  82. introduce a spread.
  83. IDE0056 - Use of index/range syntax - relevant types not available on all targets, so we can't
  84. IDE0057 do this.
  85. IDE0130 - Namespace does not match folder structure. Conforming to this would be a significant
  86. upheaval, and it's not clear that it would be an improvement.
  87. IDE0290 - Primary ctors. This diagnostic suggests them in a lot of places where we don't want
  88. them. E.g., in most types with multiple constructors I find I prefer not to have
  89. a primary ctor. Since this is all or nothing, we turn it off.
  90. IDE0305 - Suggests Collection expressions in place of .ToArray. E.g, wants to change this:
  91. _readyList.ToArray()
  92. to this:
  93. [.. readyList]
  94. This won't improve performance as far as we know (sometimes a reason for using that
  95. syntax), and it's not obviously an improvement in readability.
  96. IDE0306 - Suggests Collection expressions in place of construction, e.g. replaces new List<int>(x)
  97. [.. x]. To me, this is less readable, and it doesn't improve performance, as far as we know.
  98. CA1510 - use ArgumentNullException.ThrowIf (not available on all targets)
  99. CA1513 - use ObjectDisposedException.ThrowIf (not available on all targets)
  100. -->
  101. <NoWarn>$(NoWarn);CA1001;CA2213;CA1510;CA1513;IDE0028;IDE0056;IDE0057;IDE0130;IDE0290;IDE0305;IDE0306</NoWarn>
  102. </PropertyGroup>
  103. <ItemGroup>
  104. <GlobalAnalyzerConfigFiles Include="$(MSBuildThisFileDirectory)analyzers.globalconfig" />
  105. </ItemGroup>
  106. </Project>