Browse Source

fix: remove props optional symbol in params of table renderFilterDropdown (#2770)

pointhalo 6 months ago
parent
commit
472a7449d4

+ 10 - 10
content/show/table/index-en-US.md

@@ -1465,7 +1465,7 @@ You can call `setTempFilteredValue` to store the filter value when the user ente
 The reason for setting `tempFilteredValue` is that in scenarios where temporary filtered values need to be stored, there is no need to declare a state to save this temporary filtered value.
 
 ```typescript
-type RenderFilterDropdown = (props?: RenderFilterDropdownProps) => React.ReactNode;
+type RenderFilterDropdown = (props: RenderFilterDropdownProps) => React.ReactNode;
 interface RenderFilterDropdownProps {
      /** Temporary filter value, the initial value is `filteredValue` or `defaultFilteredValue` */
      tempFilteredValue: any[];
@@ -1850,21 +1850,21 @@ const expandData = {
     '0': [
         { key: 'DAU', value: '1,480,000' },
         { key: 'Day7 Retention Ratio', value: '98%' },
-        { key: 'Security Level', value: '3级' },
+        { key: 'Security Level', value: '3 级' },
         { key: 'Vertical label', value: <Tag style={{ margin: 0 }}>Designer</Tag> },
         { key: 'Certification', value: 'No Verified' },
     ],
     '1': [
         { key: 'DAU', value: '2,480,000' },
         { key: 'Day7 Retention Ratio', value: '90%' },
-        { key: 'Security Level', value: '1级' },
+        { key: 'Security Level', value: '1 级' },
         { key: 'Vertical label', value: <Tag style={{ margin: 0 }}>Template</Tag> },
         { key: 'Certification', value: 'Verified' },
     ],
     '2': [
         { key: 'DAU', value: '2,920,000' },
         { key: 'Day7 Retention Ratio', value: '98%' },
-        { key: 'Security Level', value: '2级' },
+        { key: 'Security Level', value: '2 级' },
         { key: 'Vertical label', value: <Tag style={{ margin: 0 }}>Docs</Tag> },
         { key: 'Certification', value: 'Verified' },
     ],
@@ -1996,21 +1996,21 @@ const expandData = {
     '0': [
         { key: 'DAU', value: '1,480,000' },
         { key: 'Day7 Retention Ratio', value: '98%' },
-        { key: 'Security Level', value: '3级' },
+        { key: 'Security Level', value: '3 级' },
         { key: 'Vertical label', value: <Tag style={{ margin: 0 }}>Designer</Tag> },
         { key: 'Certification', value: 'No Verified' },
     ],
     '1': [
         { key: 'DAU', value: '2,480,000' },
         { key: 'Day7 Retention Ratio', value: '90%' },
-        { key: 'Security Level', value: '1级' },
+        { key: 'Security Level', value: '1 级' },
         { key: 'Vertical label', value: <Tag style={{ margin: 0 }}>Template</Tag> },
         { key: 'Certification', value: 'Verified' },
     ],
     '2': [
         { key: 'DAU', value: '2,920,000' },
         { key: 'Day7 Retention Ratio', value: '98%' },
-        { key: 'Security Level', value: '2级' },
+        { key: 'Security Level', value: '2 级' },
         { key: 'Vertical label', value: <Tag style={{ margin: 0 }}>Docs</Tag> },
         { key: 'Certification', value: 'Verified' },
     ],
@@ -2143,21 +2143,21 @@ const expandData = {
     '0': [
         { key: 'DAU', value: '1,480,000' },
         { key: 'Day7 Retention Ratio', value: '98%' },
-        { key: 'Security Level', value: '3级' },
+        { key: 'Security Level', value: '3 级' },
         { key: 'Vertical label', value: <Tag style={{ margin: 0 }}>Designer</Tag> },
         { key: 'Certification', value: 'No Verified' },
     ],
     '1': [
         { key: 'DAU', value: '2,480,000' },
         { key: 'Day7 Retention Ratio', value: '90%' },
-        { key: 'Security Level', value: '1级' },
+        { key: 'Security Level', value: '1 级' },
         { key: 'Vertical label', value: <Tag style={{ margin: 0 }}>Template</Tag> },
         { key: 'Certification', value: 'Verified' },
     ],
     '2': [
         { key: 'DAU', value: '2,920,000' },
         { key: 'Day7 Retention Ratio', value: '98%' },
-        { key: 'Security Level', value: '2级' },
+        { key: 'Security Level', value: '2 级' },
         { key: 'Vertical label', value: <Tag style={{ margin: 0 }}>Docs</Tag> },
         { key: 'Certification', value: 'Verified' },
     ],

+ 1 - 1
content/show/table/index.md

@@ -1586,7 +1586,7 @@ render(App);
 设置 `tempFilteredValue` 的原因是在需要存储临时筛选值的场景,不需要自己声明一个 state 保存这个临时筛选值。
 
 ```typescript
-type RenderFilterDropdown = (props?: RenderFilterDropdownProps) => React.ReactNode;
+type RenderFilterDropdown = (props: RenderFilterDropdownProps) => React.ReactNode;
 interface RenderFilterDropdownProps {
     /** 临时筛选值,初始值为 `filteredValue` 或 `defaultFilteredValue`  */
     tempFilteredValue: any[];

+ 1 - 1
packages/semi-ui/table/ColumnFilter.tsx

@@ -256,7 +256,7 @@ export interface RenderDropdownProps extends FilterDropdownProps, RenderFilterDr
     filterDropdownVisible?: boolean;
     onSelect?: (data: OnSelectData) => void;
     onFilterDropdownVisibleChange?: OnFilterDropdownVisibleChange;
-    renderFilterDropdown?: (props?: RenderFilterDropdownProps) => React.ReactNode;
+    renderFilterDropdown?: (props: RenderFilterDropdownProps) => React.ReactNode;
     renderFilterDropdownItem?: RenderFilterDropdownItem
 }
 

+ 2 - 2
packages/semi-ui/table/_story/v2/FeatRenderFilterDropdown/index.tsx

@@ -42,8 +42,8 @@ export default function App() {
                     <Space vertical align='start' style={{ padding: 8 }}>
                         <Input ref={inputRef} value={tempFilteredValue[0]} onChange={handleChange}/>
                         <Space>
-                            <Button onClick={() => confirm({ closeDropdown: true })}>筛选+关闭</Button>
-                            <Button onClick={() => clear({ closeDropdown: true })}>清除+关闭</Button>
+                            <Button onClick={() => confirm({ closeDropdown: true })}>筛选 + 关闭</Button>
+                            <Button onClick={() => clear({ closeDropdown: true })}>清除 + 关闭</Button>
                             <Button onClick={() => close()}>直接关闭</Button>
                         </Space>
                     </Space>