internal_test.go 66 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267
  1. // Copyright (C) 2019-2022 Nicola Murino
  2. //
  3. // This program is free software: you can redistribute it and/or modify
  4. // it under the terms of the GNU Affero General Public License as published
  5. // by the Free Software Foundation, version 3.
  6. //
  7. // This program is distributed in the hope that it will be useful,
  8. // but WITHOUT ANY WARRANTY; without even the implied warranty of
  9. // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  10. // GNU Affero General Public License for more details.
  11. //
  12. // You should have received a copy of the GNU Affero General Public License
  13. // along with this program. If not, see <https://www.gnu.org/licenses/>.
  14. package sftpd
  15. import (
  16. "bytes"
  17. "errors"
  18. "fmt"
  19. "io"
  20. "net"
  21. "os"
  22. "path/filepath"
  23. "runtime"
  24. "testing"
  25. "time"
  26. "github.com/eikenb/pipeat"
  27. "github.com/pkg/sftp"
  28. "github.com/rs/xid"
  29. "github.com/sftpgo/sdk"
  30. "github.com/stretchr/testify/assert"
  31. "github.com/stretchr/testify/require"
  32. "golang.org/x/crypto/ssh"
  33. "github.com/drakkan/sftpgo/v2/internal/common"
  34. "github.com/drakkan/sftpgo/v2/internal/dataprovider"
  35. "github.com/drakkan/sftpgo/v2/internal/kms"
  36. "github.com/drakkan/sftpgo/v2/internal/util"
  37. "github.com/drakkan/sftpgo/v2/internal/vfs"
  38. )
  39. const (
  40. osWindows = "windows"
  41. )
  42. var (
  43. configDir = filepath.Join(".", "..", "..")
  44. )
  45. type MockChannel struct {
  46. Buffer *bytes.Buffer
  47. StdErrBuffer *bytes.Buffer
  48. ReadError error
  49. WriteError error
  50. ShortWriteErr bool
  51. }
  52. func (c *MockChannel) Read(data []byte) (int, error) {
  53. if c.ReadError != nil {
  54. return 0, c.ReadError
  55. }
  56. return c.Buffer.Read(data)
  57. }
  58. func (c *MockChannel) Write(data []byte) (int, error) {
  59. if c.WriteError != nil {
  60. return 0, c.WriteError
  61. }
  62. if c.ShortWriteErr {
  63. return 0, nil
  64. }
  65. return c.Buffer.Write(data)
  66. }
  67. func (c *MockChannel) Close() error {
  68. return nil
  69. }
  70. func (c *MockChannel) CloseWrite() error {
  71. return nil
  72. }
  73. func (c *MockChannel) SendRequest(name string, wantReply bool, payload []byte) (bool, error) {
  74. return true, nil
  75. }
  76. func (c *MockChannel) Stderr() io.ReadWriter {
  77. return c.StdErrBuffer
  78. }
  79. // MockOsFs mockable OsFs
  80. type MockOsFs struct {
  81. vfs.Fs
  82. err error
  83. statErr error
  84. isAtomicUploadSupported bool
  85. }
  86. // Name returns the name for the Fs implementation
  87. func (fs MockOsFs) Name() string {
  88. return "mockOsFs"
  89. }
  90. // IsUploadResumeSupported returns true if resuming uploads is supported
  91. func (MockOsFs) IsUploadResumeSupported() bool {
  92. return false
  93. }
  94. // IsAtomicUploadSupported returns true if atomic upload is supported
  95. func (fs MockOsFs) IsAtomicUploadSupported() bool {
  96. return fs.isAtomicUploadSupported
  97. }
  98. // Stat returns a FileInfo describing the named file
  99. func (fs MockOsFs) Stat(name string) (os.FileInfo, error) {
  100. if fs.statErr != nil {
  101. return nil, fs.statErr
  102. }
  103. return os.Stat(name)
  104. }
  105. // Lstat returns a FileInfo describing the named file
  106. func (fs MockOsFs) Lstat(name string) (os.FileInfo, error) {
  107. if fs.statErr != nil {
  108. return nil, fs.statErr
  109. }
  110. return os.Lstat(name)
  111. }
  112. // Remove removes the named file or (empty) directory.
  113. func (fs MockOsFs) Remove(name string, isDir bool) error {
  114. if fs.err != nil {
  115. return fs.err
  116. }
  117. return os.Remove(name)
  118. }
  119. // Rename renames (moves) source to target
  120. func (fs MockOsFs) Rename(source, target string) error {
  121. if fs.err != nil {
  122. return fs.err
  123. }
  124. return os.Rename(source, target)
  125. }
  126. func newMockOsFs(err, statErr error, atomicUpload bool, connectionID, rootDir string) vfs.Fs {
  127. return &MockOsFs{
  128. Fs: vfs.NewOsFs(connectionID, rootDir, ""),
  129. err: err,
  130. statErr: statErr,
  131. isAtomicUploadSupported: atomicUpload,
  132. }
  133. }
  134. func TestRemoveNonexistentQuotaScan(t *testing.T) {
  135. assert.False(t, common.QuotaScans.RemoveUserQuotaScan("username"))
  136. }
  137. func TestGetOSOpenFlags(t *testing.T) {
  138. var flags sftp.FileOpenFlags
  139. flags.Write = true
  140. flags.Excl = true
  141. osFlags := getOSOpenFlags(flags)
  142. assert.NotEqual(t, 0, osFlags&os.O_WRONLY)
  143. assert.NotEqual(t, 0, osFlags&os.O_EXCL)
  144. flags.Append = true
  145. // append flag should be ignored to allow resume
  146. assert.NotEqual(t, 0, osFlags&os.O_WRONLY)
  147. assert.NotEqual(t, 0, osFlags&os.O_EXCL)
  148. }
  149. func TestUploadResumeInvalidOffset(t *testing.T) {
  150. testfile := "testfile" //nolint:goconst
  151. file, err := os.Create(testfile)
  152. assert.NoError(t, err)
  153. user := dataprovider.User{
  154. BaseUser: sdk.BaseUser{
  155. Username: "testuser",
  156. },
  157. }
  158. fs := vfs.NewOsFs("", os.TempDir(), "")
  159. conn := common.NewBaseConnection("", common.ProtocolSFTP, "", "", user)
  160. baseTransfer := common.NewBaseTransfer(file, conn, nil, file.Name(), file.Name(), testfile,
  161. common.TransferUpload, 10, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  162. transfer := newTransfer(baseTransfer, nil, nil, nil)
  163. _, err = transfer.WriteAt([]byte("test"), 0)
  164. assert.Error(t, err, "upload with invalid offset must fail")
  165. if assert.Error(t, transfer.ErrTransfer) {
  166. assert.EqualError(t, err, transfer.ErrTransfer.Error())
  167. assert.Contains(t, transfer.ErrTransfer.Error(), "invalid write offset")
  168. }
  169. err = transfer.Close()
  170. if assert.Error(t, err) {
  171. assert.ErrorIs(t, err, sftp.ErrSSHFxFailure)
  172. }
  173. err = os.Remove(testfile)
  174. assert.NoError(t, err)
  175. }
  176. func TestReadWriteErrors(t *testing.T) {
  177. testfile := "testfile"
  178. file, err := os.Create(testfile)
  179. assert.NoError(t, err)
  180. user := dataprovider.User{
  181. BaseUser: sdk.BaseUser{
  182. Username: "testuser",
  183. },
  184. }
  185. fs := vfs.NewOsFs("", os.TempDir(), "")
  186. conn := common.NewBaseConnection("", common.ProtocolSFTP, "", "", user)
  187. baseTransfer := common.NewBaseTransfer(file, conn, nil, file.Name(), file.Name(), testfile, common.TransferDownload,
  188. 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  189. transfer := newTransfer(baseTransfer, nil, nil, nil)
  190. err = file.Close()
  191. assert.NoError(t, err)
  192. _, err = transfer.WriteAt([]byte("test"), 0)
  193. assert.Error(t, err, "writing to closed file must fail")
  194. buf := make([]byte, 32768)
  195. _, err = transfer.ReadAt(buf, 0)
  196. assert.Error(t, err, "reading from a closed file must fail")
  197. err = transfer.Close()
  198. assert.Error(t, err)
  199. r, _, err := pipeat.Pipe()
  200. assert.NoError(t, err)
  201. baseTransfer = common.NewBaseTransfer(nil, conn, nil, file.Name(), file.Name(), testfile, common.TransferDownload,
  202. 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  203. transfer = newTransfer(baseTransfer, nil, r, nil)
  204. err = transfer.Close()
  205. assert.NoError(t, err)
  206. _, err = transfer.ReadAt(buf, 0)
  207. assert.Error(t, err, "reading from a closed pipe must fail")
  208. r, w, err := pipeat.Pipe()
  209. assert.NoError(t, err)
  210. pipeWriter := vfs.NewPipeWriter(w)
  211. baseTransfer = common.NewBaseTransfer(nil, conn, nil, file.Name(), file.Name(), testfile, common.TransferDownload,
  212. 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  213. transfer = newTransfer(baseTransfer, pipeWriter, nil, nil)
  214. err = r.Close()
  215. assert.NoError(t, err)
  216. errFake := fmt.Errorf("fake upload error")
  217. go func() {
  218. time.Sleep(100 * time.Millisecond)
  219. pipeWriter.Done(errFake)
  220. }()
  221. err = transfer.closeIO()
  222. assert.EqualError(t, err, errFake.Error())
  223. _, err = transfer.WriteAt([]byte("test"), 0)
  224. assert.Error(t, err, "writing to closed pipe must fail")
  225. err = transfer.BaseTransfer.Close()
  226. assert.EqualError(t, err, errFake.Error())
  227. err = os.Remove(testfile)
  228. assert.NoError(t, err)
  229. assert.Len(t, conn.GetTransfers(), 0)
  230. }
  231. func TestUnsupportedListOP(t *testing.T) {
  232. conn := common.NewBaseConnection("", common.ProtocolSFTP, "", "", dataprovider.User{})
  233. sftpConn := Connection{
  234. BaseConnection: conn,
  235. }
  236. request := sftp.NewRequest("Unsupported", "")
  237. _, err := sftpConn.Filelist(request)
  238. assert.EqualError(t, err, sftp.ErrSSHFxOpUnsupported.Error())
  239. }
  240. func TestTransferCancelFn(t *testing.T) {
  241. testfile := "testfile"
  242. file, err := os.Create(testfile)
  243. assert.NoError(t, err)
  244. isCancelled := false
  245. cancelFn := func() {
  246. isCancelled = true
  247. }
  248. user := dataprovider.User{
  249. BaseUser: sdk.BaseUser{
  250. Username: "testuser",
  251. },
  252. }
  253. fs := vfs.NewOsFs("", os.TempDir(), "")
  254. conn := common.NewBaseConnection("", common.ProtocolSFTP, "", "", user)
  255. baseTransfer := common.NewBaseTransfer(file, conn, cancelFn, file.Name(), file.Name(), testfile, common.TransferDownload,
  256. 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  257. transfer := newTransfer(baseTransfer, nil, nil, nil)
  258. errFake := errors.New("fake error, this will trigger cancelFn")
  259. transfer.TransferError(errFake)
  260. err = transfer.Close()
  261. if assert.Error(t, err) {
  262. assert.ErrorIs(t, err, sftp.ErrSSHFxFailure)
  263. }
  264. if assert.Error(t, transfer.ErrTransfer) {
  265. assert.EqualError(t, transfer.ErrTransfer, errFake.Error())
  266. }
  267. assert.True(t, isCancelled, "cancelFn not called!")
  268. err = os.Remove(testfile)
  269. assert.NoError(t, err)
  270. }
  271. func TestUploadFiles(t *testing.T) {
  272. common.Config.UploadMode = common.UploadModeAtomic
  273. fs := vfs.NewOsFs("123", os.TempDir(), "")
  274. u := dataprovider.User{}
  275. c := Connection{
  276. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", u),
  277. }
  278. var flags sftp.FileOpenFlags
  279. flags.Write = true
  280. flags.Trunc = true
  281. _, err := c.handleSFTPUploadToExistingFile(fs, flags, "missing_path", "other_missing_path", 0, "/missing_path", nil)
  282. assert.Error(t, err, "upload to existing file must fail if one or both paths are invalid")
  283. common.Config.UploadMode = common.UploadModeStandard
  284. _, err = c.handleSFTPUploadToExistingFile(fs, flags, "missing_path", "other_missing_path", 0, "/missing_path", nil)
  285. assert.Error(t, err, "upload to existing file must fail if one or both paths are invalid")
  286. missingFile := "missing/relative/file.txt"
  287. if runtime.GOOS == osWindows {
  288. missingFile = "missing\\relative\\file.txt"
  289. }
  290. _, err = c.handleSFTPUploadToNewFile(fs, flags, ".", missingFile, "/missing", nil)
  291. assert.Error(t, err, "upload new file in missing path must fail")
  292. fs = newMockOsFs(nil, nil, false, "123", os.TempDir())
  293. f, err := os.CreateTemp("", "temp")
  294. assert.NoError(t, err)
  295. err = f.Close()
  296. assert.NoError(t, err)
  297. tr, err := c.handleSFTPUploadToExistingFile(fs, flags, f.Name(), f.Name(), 123, f.Name(), nil)
  298. if assert.NoError(t, err) {
  299. transfer := tr.(*transfer)
  300. transfers := c.GetTransfers()
  301. if assert.Equal(t, 1, len(transfers)) {
  302. assert.Equal(t, transfers[0].ID, transfer.GetID())
  303. assert.Equal(t, int64(123), transfer.InitialSize)
  304. err = transfer.Close()
  305. assert.NoError(t, err)
  306. assert.Equal(t, 0, len(c.GetTransfers()))
  307. }
  308. }
  309. err = os.Remove(f.Name())
  310. assert.NoError(t, err)
  311. common.Config.UploadMode = common.UploadModeAtomicWithResume
  312. }
  313. func TestWithInvalidHome(t *testing.T) {
  314. u := dataprovider.User{}
  315. u.HomeDir = "home_rel_path" //nolint:goconst
  316. _, err := loginUser(&u, dataprovider.LoginMethodPassword, "", nil)
  317. assert.Error(t, err, "login a user with an invalid home_dir must fail")
  318. u.HomeDir = os.TempDir()
  319. fs, err := u.GetFilesystem("123")
  320. assert.NoError(t, err)
  321. c := Connection{
  322. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", u),
  323. }
  324. _, err = fs.ResolvePath("../upper_path")
  325. assert.Error(t, err, "tested path is not a home subdir")
  326. _, err = c.StatVFS(&sftp.Request{
  327. Method: "StatVFS",
  328. Filepath: "../unresolvable-path",
  329. })
  330. assert.Error(t, err)
  331. }
  332. func TestResolveWithRootDir(t *testing.T) {
  333. u := dataprovider.User{}
  334. if runtime.GOOS == osWindows {
  335. u.HomeDir = "C:\\"
  336. } else {
  337. u.HomeDir = "/"
  338. }
  339. fs, err := u.GetFilesystem("")
  340. assert.NoError(t, err)
  341. rel, err := filepath.Rel(u.HomeDir, os.TempDir())
  342. assert.NoError(t, err)
  343. p, err := fs.ResolvePath(rel)
  344. assert.NoError(t, err, "path %v", p)
  345. }
  346. func TestSFTPGetUsedQuota(t *testing.T) {
  347. u := dataprovider.User{}
  348. u.HomeDir = "home_rel_path"
  349. u.Username = "test_invalid_user"
  350. u.QuotaSize = 4096
  351. u.QuotaFiles = 1
  352. u.Permissions = make(map[string][]string)
  353. u.Permissions["/"] = []string{dataprovider.PermAny}
  354. connection := Connection{
  355. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", u),
  356. }
  357. quotaResult, _ := connection.HasSpace(false, false, "/")
  358. assert.False(t, quotaResult.HasSpace)
  359. }
  360. func TestSupportedSSHCommands(t *testing.T) {
  361. cmds := GetSupportedSSHCommands()
  362. assert.Equal(t, len(supportedSSHCommands), len(cmds))
  363. for _, c := range cmds {
  364. assert.True(t, util.Contains(supportedSSHCommands, c))
  365. }
  366. }
  367. func TestSSHCommandPath(t *testing.T) {
  368. buf := make([]byte, 65535)
  369. stdErrBuf := make([]byte, 65535)
  370. mockSSHChannel := MockChannel{
  371. Buffer: bytes.NewBuffer(buf),
  372. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  373. ReadError: nil,
  374. }
  375. connection := &Connection{
  376. channel: &mockSSHChannel,
  377. BaseConnection: common.NewBaseConnection("", common.ProtocolSSH, "", "", dataprovider.User{}),
  378. }
  379. sshCommand := sshCommand{
  380. command: "test",
  381. connection: connection,
  382. args: []string{},
  383. }
  384. assert.Equal(t, "", sshCommand.getDestPath())
  385. sshCommand.args = []string{"-t", "/tmp/../path"}
  386. assert.Equal(t, "/path", sshCommand.getDestPath())
  387. sshCommand.args = []string{"-t", "/tmp/"}
  388. assert.Equal(t, "/tmp/", sshCommand.getDestPath())
  389. sshCommand.args = []string{"-t", "tmp/"}
  390. assert.Equal(t, "/tmp/", sshCommand.getDestPath())
  391. sshCommand.args = []string{"-t", "/tmp/../../../path"}
  392. assert.Equal(t, "/path", sshCommand.getDestPath())
  393. sshCommand.args = []string{"-t", ".."}
  394. assert.Equal(t, "/", sshCommand.getDestPath())
  395. sshCommand.args = []string{"-t", "."}
  396. assert.Equal(t, "/", sshCommand.getDestPath())
  397. sshCommand.args = []string{"-t", "//"}
  398. assert.Equal(t, "/", sshCommand.getDestPath())
  399. sshCommand.args = []string{"-t", "../.."}
  400. assert.Equal(t, "/", sshCommand.getDestPath())
  401. sshCommand.args = []string{"-t", "/.."}
  402. assert.Equal(t, "/", sshCommand.getDestPath())
  403. sshCommand.args = []string{"-f", "/a space.txt"}
  404. assert.Equal(t, "/a space.txt", sshCommand.getDestPath())
  405. }
  406. func TestSSHParseCommandPayload(t *testing.T) {
  407. cmd := "command -a -f /ab\\ à/some\\ spaces\\ \\ \\(\\).txt"
  408. name, args, _ := parseCommandPayload(cmd)
  409. assert.Equal(t, "command", name)
  410. assert.Equal(t, 3, len(args))
  411. assert.Equal(t, "/ab à/some spaces ().txt", args[2])
  412. _, _, err := parseCommandPayload("")
  413. assert.Error(t, err, "parsing invalid command must fail")
  414. }
  415. func TestSSHCommandErrors(t *testing.T) {
  416. buf := make([]byte, 65535)
  417. stdErrBuf := make([]byte, 65535)
  418. readErr := fmt.Errorf("test read error")
  419. mockSSHChannel := MockChannel{
  420. Buffer: bytes.NewBuffer(buf),
  421. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  422. ReadError: readErr,
  423. }
  424. server, client := net.Pipe()
  425. defer func() {
  426. err := server.Close()
  427. assert.NoError(t, err)
  428. }()
  429. defer func() {
  430. err := client.Close()
  431. assert.NoError(t, err)
  432. }()
  433. user := dataprovider.User{}
  434. user.Permissions = map[string][]string{
  435. "/": {dataprovider.PermAny},
  436. }
  437. connection := Connection{
  438. BaseConnection: common.NewBaseConnection("", common.ProtocolSSH, "", "", user),
  439. channel: &mockSSHChannel,
  440. }
  441. cmd := sshCommand{
  442. command: "md5sum",
  443. connection: &connection,
  444. args: []string{},
  445. }
  446. err := cmd.handle()
  447. assert.Error(t, err, "ssh command must fail, we are sending a fake error")
  448. cmd = sshCommand{
  449. command: "md5sum",
  450. connection: &connection,
  451. args: []string{"/../../test_file_ftp.dat"},
  452. }
  453. err = cmd.handle()
  454. assert.Error(t, err, "ssh command must fail, we are requesting an invalid path")
  455. cmd = sshCommand{
  456. command: "git-receive-pack",
  457. connection: &connection,
  458. args: []string{"/../../testrepo"},
  459. }
  460. err = cmd.handle()
  461. assert.Error(t, err, "ssh command must fail, we are requesting an invalid path")
  462. user = dataprovider.User{}
  463. user.Permissions = map[string][]string{
  464. "/": {dataprovider.PermAny},
  465. }
  466. user.HomeDir = filepath.Clean(os.TempDir())
  467. user.QuotaFiles = 1
  468. user.UsedQuotaFiles = 2
  469. cmd.connection.User = user
  470. fs, err := cmd.connection.User.GetFilesystem("123")
  471. assert.NoError(t, err)
  472. err = cmd.handle()
  473. assert.EqualError(t, err, common.ErrQuotaExceeded.Error())
  474. cmd.connection.User.QuotaFiles = 0
  475. cmd.connection.User.UsedQuotaFiles = 0
  476. cmd.connection.User.Permissions = make(map[string][]string)
  477. cmd.connection.User.Permissions["/"] = []string{dataprovider.PermListItems}
  478. err = cmd.handle()
  479. assert.EqualError(t, err, common.ErrPermissionDenied.Error())
  480. cmd.connection.User.Permissions["/"] = []string{dataprovider.PermAny}
  481. cmd.command = "invalid_command"
  482. command, err := cmd.getSystemCommand()
  483. assert.NoError(t, err)
  484. err = cmd.executeSystemCommand(command)
  485. assert.Error(t, err, "invalid command must fail")
  486. command, err = cmd.getSystemCommand()
  487. assert.NoError(t, err)
  488. _, err = command.cmd.StderrPipe()
  489. assert.NoError(t, err)
  490. err = cmd.executeSystemCommand(command)
  491. assert.Error(t, err, "command must fail, pipe was already assigned")
  492. err = cmd.executeSystemCommand(command)
  493. assert.Error(t, err, "command must fail, pipe was already assigned")
  494. command, err = cmd.getSystemCommand()
  495. assert.NoError(t, err)
  496. _, err = command.cmd.StdoutPipe()
  497. assert.NoError(t, err)
  498. err = cmd.executeSystemCommand(command)
  499. assert.Error(t, err, "command must fail, pipe was already assigned")
  500. cmd = sshCommand{
  501. command: "sftpgo-remove",
  502. connection: &connection,
  503. args: []string{"/../../src"},
  504. }
  505. err = cmd.handle()
  506. assert.Error(t, err, "ssh command must fail, we are requesting an invalid path")
  507. cmd = sshCommand{
  508. command: "sftpgo-copy",
  509. connection: &connection,
  510. args: []string{"/../../test_src", "."},
  511. }
  512. err = cmd.handle()
  513. assert.Error(t, err, "ssh command must fail, we are requesting an invalid path")
  514. cmd.connection.User.HomeDir = filepath.Clean(os.TempDir())
  515. cmd = sshCommand{
  516. command: "sftpgo-copy",
  517. connection: &connection,
  518. args: []string{"src", "dst"},
  519. }
  520. cmd.connection.User.Permissions = make(map[string][]string)
  521. cmd.connection.User.Permissions["/"] = []string{dataprovider.PermAny}
  522. if runtime.GOOS != osWindows {
  523. aDir := filepath.Join(os.TempDir(), "adir")
  524. err = os.MkdirAll(aDir, os.ModePerm)
  525. assert.NoError(t, err)
  526. tmpFile := filepath.Join(aDir, "testcopy")
  527. err = os.WriteFile(tmpFile, []byte("aaa"), os.ModePerm)
  528. assert.NoError(t, err)
  529. err = os.Chmod(aDir, 0001)
  530. assert.NoError(t, err)
  531. err = cmd.checkCopyDestination(fs, tmpFile)
  532. assert.Error(t, err)
  533. err = os.Chmod(aDir, os.ModePerm)
  534. assert.NoError(t, err)
  535. err = os.Remove(tmpFile)
  536. assert.NoError(t, err)
  537. }
  538. }
  539. func TestCommandsWithExtensionsFilter(t *testing.T) {
  540. buf := make([]byte, 65535)
  541. stdErrBuf := make([]byte, 65535)
  542. mockSSHChannel := MockChannel{
  543. Buffer: bytes.NewBuffer(buf),
  544. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  545. }
  546. server, client := net.Pipe()
  547. defer server.Close()
  548. defer client.Close()
  549. user := dataprovider.User{
  550. BaseUser: sdk.BaseUser{
  551. Username: "test",
  552. HomeDir: os.TempDir(),
  553. Status: 1,
  554. },
  555. }
  556. user.Filters.FilePatterns = []sdk.PatternsFilter{
  557. {
  558. Path: "/subdir",
  559. AllowedPatterns: []string{".jpg"},
  560. DeniedPatterns: []string{},
  561. },
  562. }
  563. connection := &Connection{
  564. BaseConnection: common.NewBaseConnection("", common.ProtocolSSH, "", "", user),
  565. channel: &mockSSHChannel,
  566. }
  567. cmd := sshCommand{
  568. command: "md5sum",
  569. connection: connection,
  570. args: []string{"subdir/test.png"},
  571. }
  572. err := cmd.handleHashCommands()
  573. assert.EqualError(t, err, common.ErrPermissionDenied.Error())
  574. cmd = sshCommand{
  575. command: "rsync",
  576. connection: connection,
  577. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  578. }
  579. _, err = cmd.getSystemCommand()
  580. assert.EqualError(t, err, errUnsupportedConfig.Error())
  581. cmd = sshCommand{
  582. command: "git-receive-pack",
  583. connection: connection,
  584. args: []string{"/subdir"},
  585. }
  586. _, err = cmd.getSystemCommand()
  587. assert.EqualError(t, err, errUnsupportedConfig.Error())
  588. cmd = sshCommand{
  589. command: "git-receive-pack",
  590. connection: connection,
  591. args: []string{"/subdir/dir"},
  592. }
  593. _, err = cmd.getSystemCommand()
  594. assert.EqualError(t, err, errUnsupportedConfig.Error())
  595. cmd = sshCommand{
  596. command: "git-receive-pack",
  597. connection: connection,
  598. args: []string{"/adir/subdir"},
  599. }
  600. _, err = cmd.getSystemCommand()
  601. assert.NoError(t, err)
  602. }
  603. func TestSSHCommandsRemoteFs(t *testing.T) {
  604. buf := make([]byte, 65535)
  605. stdErrBuf := make([]byte, 65535)
  606. mockSSHChannel := MockChannel{
  607. Buffer: bytes.NewBuffer(buf),
  608. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  609. }
  610. user := dataprovider.User{}
  611. user.FsConfig = vfs.Filesystem{
  612. Provider: sdk.S3FilesystemProvider,
  613. S3Config: vfs.S3FsConfig{
  614. BaseS3FsConfig: sdk.BaseS3FsConfig{
  615. Bucket: "s3bucket",
  616. Endpoint: "endpoint",
  617. Region: "eu-west-1",
  618. },
  619. },
  620. }
  621. connection := &Connection{
  622. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  623. channel: &mockSSHChannel,
  624. }
  625. cmd := sshCommand{
  626. command: "md5sum",
  627. connection: connection,
  628. args: []string{},
  629. }
  630. command, err := cmd.getSystemCommand()
  631. assert.NoError(t, err)
  632. err = cmd.executeSystemCommand(command)
  633. assert.Error(t, err, "command must fail for a non local filesystem")
  634. cmd = sshCommand{
  635. command: "sftpgo-copy",
  636. connection: connection,
  637. args: []string{},
  638. }
  639. err = cmd.handleSFTPGoCopy()
  640. assert.Error(t, err)
  641. cmd = sshCommand{
  642. command: "sftpgo-remove",
  643. connection: connection,
  644. args: []string{},
  645. }
  646. err = cmd.handleSFTPGoRemove()
  647. assert.Error(t, err)
  648. // the user has no permissions
  649. assert.False(t, cmd.hasCopyPermissions("", "", nil))
  650. }
  651. func TestSSHCmdGetFsErrors(t *testing.T) {
  652. buf := make([]byte, 65535)
  653. stdErrBuf := make([]byte, 65535)
  654. mockSSHChannel := MockChannel{
  655. Buffer: bytes.NewBuffer(buf),
  656. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  657. }
  658. user := dataprovider.User{
  659. BaseUser: sdk.BaseUser{
  660. HomeDir: "relative path",
  661. },
  662. }
  663. user.Permissions = map[string][]string{}
  664. user.Permissions["/"] = []string{dataprovider.PermAny}
  665. connection := &Connection{
  666. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  667. channel: &mockSSHChannel,
  668. }
  669. cmd := sshCommand{
  670. command: "sftpgo-remove",
  671. connection: connection,
  672. args: []string{"path"},
  673. }
  674. err := cmd.handleSFTPGoRemove()
  675. assert.Error(t, err)
  676. cmd = sshCommand{
  677. command: "sftpgo-copy",
  678. connection: connection,
  679. args: []string{"path1", "path2"},
  680. }
  681. _, _, _, _, _, _, err = cmd.getFsAndCopyPaths() //nolint:dogsled
  682. assert.Error(t, err)
  683. user = dataprovider.User{}
  684. user.HomeDir = filepath.Join(os.TempDir(), "home")
  685. user.VirtualFolders = append(connection.User.VirtualFolders, vfs.VirtualFolder{
  686. BaseVirtualFolder: vfs.BaseVirtualFolder{
  687. MappedPath: "relative",
  688. },
  689. VirtualPath: "/vpath",
  690. })
  691. connection.User = user
  692. err = os.MkdirAll(user.GetHomeDir(), os.ModePerm)
  693. assert.NoError(t, err)
  694. cmd = sshCommand{
  695. command: "sftpgo-copy",
  696. connection: connection,
  697. args: []string{"path1", "/vpath/path2"},
  698. }
  699. _, _, _, _, _, _, err = cmd.getFsAndCopyPaths() //nolint:dogsled
  700. assert.Error(t, err)
  701. err = os.Remove(user.GetHomeDir())
  702. assert.NoError(t, err)
  703. }
  704. func TestGitVirtualFolders(t *testing.T) {
  705. permissions := make(map[string][]string)
  706. permissions["/"] = []string{dataprovider.PermAny}
  707. user := dataprovider.User{
  708. BaseUser: sdk.BaseUser{
  709. Permissions: permissions,
  710. HomeDir: os.TempDir(),
  711. },
  712. }
  713. conn := &Connection{
  714. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  715. }
  716. cmd := sshCommand{
  717. command: "git-receive-pack",
  718. connection: conn,
  719. args: []string{"/vdir"},
  720. }
  721. cmd.connection.User.VirtualFolders = append(cmd.connection.User.VirtualFolders, vfs.VirtualFolder{
  722. BaseVirtualFolder: vfs.BaseVirtualFolder{
  723. MappedPath: os.TempDir(),
  724. },
  725. VirtualPath: "/vdir",
  726. })
  727. _, err := cmd.getSystemCommand()
  728. assert.NoError(t, err)
  729. cmd.args = []string{"/"}
  730. _, err = cmd.getSystemCommand()
  731. assert.EqualError(t, err, errUnsupportedConfig.Error())
  732. cmd.args = []string{"/vdir1"}
  733. _, err = cmd.getSystemCommand()
  734. assert.NoError(t, err)
  735. cmd.connection.User.VirtualFolders = nil
  736. cmd.connection.User.VirtualFolders = append(cmd.connection.User.VirtualFolders, vfs.VirtualFolder{
  737. BaseVirtualFolder: vfs.BaseVirtualFolder{
  738. MappedPath: os.TempDir(),
  739. },
  740. VirtualPath: "/vdir",
  741. })
  742. cmd.args = []string{"/vdir/subdir"}
  743. _, err = cmd.getSystemCommand()
  744. assert.NoError(t, err)
  745. cmd.args = []string{"/adir/subdir"}
  746. _, err = cmd.getSystemCommand()
  747. assert.NoError(t, err)
  748. }
  749. func TestRsyncOptions(t *testing.T) {
  750. permissions := make(map[string][]string)
  751. permissions["/"] = []string{dataprovider.PermAny}
  752. user := dataprovider.User{
  753. BaseUser: sdk.BaseUser{
  754. Permissions: permissions,
  755. HomeDir: os.TempDir(),
  756. },
  757. }
  758. conn := &Connection{
  759. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  760. }
  761. sshCmd := sshCommand{
  762. command: "rsync",
  763. connection: conn,
  764. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  765. }
  766. cmd, err := sshCmd.getSystemCommand()
  767. assert.NoError(t, err)
  768. assert.True(t, util.Contains(cmd.cmd.Args, "--safe-links"),
  769. "--safe-links must be added if the user has the create symlinks permission")
  770. permissions["/"] = []string{dataprovider.PermDownload, dataprovider.PermUpload, dataprovider.PermCreateDirs,
  771. dataprovider.PermListItems, dataprovider.PermOverwrite, dataprovider.PermDelete, dataprovider.PermRename}
  772. user.Permissions = permissions
  773. conn = &Connection{
  774. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  775. }
  776. sshCmd = sshCommand{
  777. command: "rsync",
  778. connection: conn,
  779. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  780. }
  781. cmd, err = sshCmd.getSystemCommand()
  782. assert.NoError(t, err)
  783. assert.True(t, util.Contains(cmd.cmd.Args, "--munge-links"),
  784. "--munge-links must be added if the user has the create symlinks permission")
  785. sshCmd.connection.User.VirtualFolders = append(sshCmd.connection.User.VirtualFolders, vfs.VirtualFolder{
  786. BaseVirtualFolder: vfs.BaseVirtualFolder{
  787. MappedPath: os.TempDir(),
  788. },
  789. VirtualPath: "/vdir",
  790. })
  791. _, err = sshCmd.getSystemCommand()
  792. assert.EqualError(t, err, errUnsupportedConfig.Error())
  793. }
  794. func TestSystemCommandSizeForPath(t *testing.T) {
  795. permissions := make(map[string][]string)
  796. permissions["/"] = []string{dataprovider.PermAny}
  797. user := dataprovider.User{
  798. BaseUser: sdk.BaseUser{
  799. Permissions: permissions,
  800. HomeDir: os.TempDir(),
  801. },
  802. }
  803. fs, err := user.GetFilesystem("123")
  804. assert.NoError(t, err)
  805. conn := &Connection{
  806. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  807. }
  808. sshCmd := sshCommand{
  809. command: "rsync",
  810. connection: conn,
  811. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  812. }
  813. _, _, err = sshCmd.getSizeForPath(fs, "missing path")
  814. assert.NoError(t, err)
  815. testDir := filepath.Join(os.TempDir(), "dir")
  816. err = os.MkdirAll(testDir, os.ModePerm)
  817. assert.NoError(t, err)
  818. testFile := filepath.Join(testDir, "testfile")
  819. err = os.WriteFile(testFile, []byte("test content"), os.ModePerm)
  820. assert.NoError(t, err)
  821. err = os.Symlink(testFile, testFile+".link")
  822. assert.NoError(t, err)
  823. numFiles, size, err := sshCmd.getSizeForPath(fs, testFile+".link")
  824. assert.NoError(t, err)
  825. assert.Equal(t, 0, numFiles)
  826. assert.Equal(t, int64(0), size)
  827. numFiles, size, err = sshCmd.getSizeForPath(fs, testFile)
  828. assert.NoError(t, err)
  829. assert.Equal(t, 1, numFiles)
  830. assert.Equal(t, int64(12), size)
  831. if runtime.GOOS != osWindows {
  832. err = os.Chmod(testDir, 0001)
  833. assert.NoError(t, err)
  834. _, _, err = sshCmd.getSizeForPath(fs, testFile)
  835. assert.Error(t, err)
  836. err = os.Chmod(testDir, os.ModePerm)
  837. assert.NoError(t, err)
  838. }
  839. err = os.RemoveAll(testDir)
  840. assert.NoError(t, err)
  841. }
  842. func TestSystemCommandErrors(t *testing.T) {
  843. buf := make([]byte, 65535)
  844. stdErrBuf := make([]byte, 65535)
  845. readErr := fmt.Errorf("test read error")
  846. writeErr := fmt.Errorf("test write error")
  847. mockSSHChannel := MockChannel{
  848. Buffer: bytes.NewBuffer(buf),
  849. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  850. ReadError: nil,
  851. WriteError: writeErr,
  852. }
  853. permissions := make(map[string][]string)
  854. permissions["/"] = []string{dataprovider.PermAny}
  855. homeDir := filepath.Join(os.TempDir(), "adir")
  856. err := os.MkdirAll(homeDir, os.ModePerm)
  857. assert.NoError(t, err)
  858. err = os.WriteFile(filepath.Join(homeDir, "afile"), []byte("content"), os.ModePerm)
  859. assert.NoError(t, err)
  860. user := dataprovider.User{
  861. BaseUser: sdk.BaseUser{
  862. Permissions: permissions,
  863. HomeDir: homeDir,
  864. },
  865. }
  866. fs, err := user.GetFilesystem("123")
  867. assert.NoError(t, err)
  868. connection := &Connection{
  869. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  870. channel: &mockSSHChannel,
  871. }
  872. var sshCmd sshCommand
  873. if runtime.GOOS == osWindows {
  874. sshCmd = sshCommand{
  875. command: "dir",
  876. connection: connection,
  877. args: []string{"/"},
  878. }
  879. } else {
  880. sshCmd = sshCommand{
  881. command: "ls",
  882. connection: connection,
  883. args: []string{"/"},
  884. }
  885. }
  886. systemCmd, err := sshCmd.getSystemCommand()
  887. assert.NoError(t, err)
  888. systemCmd.cmd.Dir = os.TempDir()
  889. // FIXME: the command completes but the fake client is unable to read the response
  890. // no error is reported in this case. We can see that the expected code is executed
  891. // reading the test coverage
  892. sshCmd.executeSystemCommand(systemCmd) //nolint:errcheck
  893. mockSSHChannel = MockChannel{
  894. Buffer: bytes.NewBuffer(buf),
  895. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  896. ReadError: readErr,
  897. WriteError: nil,
  898. }
  899. sshCmd.connection.channel = &mockSSHChannel
  900. baseTransfer := common.NewBaseTransfer(nil, sshCmd.connection.BaseConnection, nil, "", "", "",
  901. common.TransferUpload, 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  902. transfer := newTransfer(baseTransfer, nil, nil, nil)
  903. destBuff := make([]byte, 65535)
  904. dst := bytes.NewBuffer(destBuff)
  905. _, err = transfer.copyFromReaderToWriter(dst, sshCmd.connection.channel)
  906. assert.EqualError(t, err, readErr.Error())
  907. mockSSHChannel = MockChannel{
  908. Buffer: bytes.NewBuffer(buf),
  909. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  910. ReadError: nil,
  911. WriteError: nil,
  912. }
  913. sshCmd.connection.channel = &mockSSHChannel
  914. transfer.MaxWriteSize = 1
  915. _, err = transfer.copyFromReaderToWriter(dst, sshCmd.connection.channel)
  916. assert.True(t, transfer.Connection.IsQuotaExceededError(err))
  917. mockSSHChannel = MockChannel{
  918. Buffer: bytes.NewBuffer(buf),
  919. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  920. ReadError: nil,
  921. WriteError: nil,
  922. ShortWriteErr: true,
  923. }
  924. sshCmd.connection.channel = &mockSSHChannel
  925. _, err = transfer.copyFromReaderToWriter(sshCmd.connection.channel, dst)
  926. assert.EqualError(t, err, io.ErrShortWrite.Error())
  927. transfer.MaxWriteSize = -1
  928. _, err = transfer.copyFromReaderToWriter(sshCmd.connection.channel, dst)
  929. assert.True(t, transfer.Connection.IsQuotaExceededError(err))
  930. baseTransfer = common.NewBaseTransfer(nil, sshCmd.connection.BaseConnection, nil, "", "", "",
  931. common.TransferDownload, 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{
  932. AllowedDLSize: 1,
  933. })
  934. transfer = newTransfer(baseTransfer, nil, nil, nil)
  935. mockSSHChannel = MockChannel{
  936. Buffer: bytes.NewBuffer(buf),
  937. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  938. ReadError: nil,
  939. WriteError: nil,
  940. }
  941. sshCmd.connection.channel = &mockSSHChannel
  942. _, err = transfer.copyFromReaderToWriter(dst, sshCmd.connection.channel)
  943. if assert.Error(t, err) {
  944. assert.Contains(t, err.Error(), common.ErrReadQuotaExceeded.Error())
  945. }
  946. err = os.RemoveAll(homeDir)
  947. assert.NoError(t, err)
  948. }
  949. func TestCommandGetFsError(t *testing.T) {
  950. user := dataprovider.User{
  951. FsConfig: vfs.Filesystem{
  952. Provider: sdk.CryptedFilesystemProvider,
  953. },
  954. }
  955. conn := &Connection{
  956. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  957. }
  958. sshCmd := sshCommand{
  959. command: "rsync",
  960. connection: conn,
  961. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  962. }
  963. _, err := sshCmd.getSystemCommand()
  964. assert.Error(t, err)
  965. buf := make([]byte, 65535)
  966. stdErrBuf := make([]byte, 65535)
  967. mockSSHChannel := MockChannel{
  968. Buffer: bytes.NewBuffer(buf),
  969. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  970. ReadError: nil,
  971. }
  972. conn = &Connection{
  973. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", user),
  974. channel: &mockSSHChannel,
  975. }
  976. scpCommand := scpCommand{
  977. sshCommand: sshCommand{
  978. command: "scp",
  979. connection: conn,
  980. args: []string{"-t", "/tmp"},
  981. },
  982. }
  983. err = scpCommand.handleRecursiveUpload()
  984. assert.Error(t, err)
  985. err = scpCommand.handleDownload("")
  986. assert.Error(t, err)
  987. }
  988. func TestGetConnectionInfo(t *testing.T) {
  989. c := common.ConnectionStatus{
  990. Username: "test_user",
  991. ConnectionID: "123",
  992. ClientVersion: "client",
  993. RemoteAddress: "127.0.0.1:1234",
  994. Protocol: common.ProtocolSSH,
  995. Command: "sha1sum /test_file_ftp.dat",
  996. }
  997. info := c.GetConnectionInfo()
  998. assert.Contains(t, info, "sha1sum /test_file_ftp.dat")
  999. }
  1000. func TestSCPFileMode(t *testing.T) {
  1001. mode := getFileModeAsString(0, true)
  1002. assert.Equal(t, "0755", mode)
  1003. mode = getFileModeAsString(0700, true)
  1004. assert.Equal(t, "0700", mode)
  1005. mode = getFileModeAsString(0750, true)
  1006. assert.Equal(t, "0750", mode)
  1007. mode = getFileModeAsString(0777, true)
  1008. assert.Equal(t, "0777", mode)
  1009. mode = getFileModeAsString(0640, false)
  1010. assert.Equal(t, "0640", mode)
  1011. mode = getFileModeAsString(0600, false)
  1012. assert.Equal(t, "0600", mode)
  1013. mode = getFileModeAsString(0, false)
  1014. assert.Equal(t, "0644", mode)
  1015. fileMode := uint32(0777)
  1016. fileMode = fileMode | uint32(os.ModeSetgid)
  1017. fileMode = fileMode | uint32(os.ModeSetuid)
  1018. fileMode = fileMode | uint32(os.ModeSticky)
  1019. mode = getFileModeAsString(os.FileMode(fileMode), false)
  1020. assert.Equal(t, "7777", mode)
  1021. fileMode = uint32(0644)
  1022. fileMode = fileMode | uint32(os.ModeSetgid)
  1023. mode = getFileModeAsString(os.FileMode(fileMode), false)
  1024. assert.Equal(t, "4644", mode)
  1025. fileMode = uint32(0600)
  1026. fileMode = fileMode | uint32(os.ModeSetuid)
  1027. mode = getFileModeAsString(os.FileMode(fileMode), false)
  1028. assert.Equal(t, "2600", mode)
  1029. fileMode = uint32(0044)
  1030. fileMode = fileMode | uint32(os.ModeSticky)
  1031. mode = getFileModeAsString(os.FileMode(fileMode), false)
  1032. assert.Equal(t, "1044", mode)
  1033. }
  1034. func TestSCPUploadError(t *testing.T) {
  1035. buf := make([]byte, 65535)
  1036. stdErrBuf := make([]byte, 65535)
  1037. writeErr := fmt.Errorf("test write error")
  1038. mockSSHChannel := MockChannel{
  1039. Buffer: bytes.NewBuffer(buf),
  1040. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1041. ReadError: nil,
  1042. WriteError: writeErr,
  1043. }
  1044. user := dataprovider.User{
  1045. BaseUser: sdk.BaseUser{
  1046. HomeDir: filepath.Join(os.TempDir()),
  1047. Permissions: make(map[string][]string),
  1048. },
  1049. }
  1050. user.Permissions["/"] = []string{dataprovider.PermAny}
  1051. connection := &Connection{
  1052. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  1053. channel: &mockSSHChannel,
  1054. }
  1055. scpCommand := scpCommand{
  1056. sshCommand: sshCommand{
  1057. command: "scp",
  1058. connection: connection,
  1059. args: []string{"-t", "/"},
  1060. },
  1061. }
  1062. err := scpCommand.handle()
  1063. assert.EqualError(t, err, writeErr.Error())
  1064. mockSSHChannel = MockChannel{
  1065. Buffer: bytes.NewBuffer([]byte("D0755 0 testdir\n")),
  1066. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1067. ReadError: nil,
  1068. WriteError: writeErr,
  1069. }
  1070. err = scpCommand.handleRecursiveUpload()
  1071. assert.EqualError(t, err, writeErr.Error())
  1072. mockSSHChannel = MockChannel{
  1073. Buffer: bytes.NewBuffer([]byte("D0755 a testdir\n")),
  1074. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1075. ReadError: nil,
  1076. WriteError: nil,
  1077. }
  1078. err = scpCommand.handleRecursiveUpload()
  1079. assert.Error(t, err)
  1080. }
  1081. func TestSCPInvalidEndDir(t *testing.T) {
  1082. stdErrBuf := make([]byte, 65535)
  1083. mockSSHChannel := MockChannel{
  1084. Buffer: bytes.NewBuffer([]byte("E\n")),
  1085. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1086. }
  1087. connection := &Connection{
  1088. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", dataprovider.User{
  1089. BaseUser: sdk.BaseUser{
  1090. HomeDir: os.TempDir(),
  1091. },
  1092. }),
  1093. channel: &mockSSHChannel,
  1094. }
  1095. scpCommand := scpCommand{
  1096. sshCommand: sshCommand{
  1097. command: "scp",
  1098. connection: connection,
  1099. args: []string{"-t", "/tmp"},
  1100. },
  1101. }
  1102. err := scpCommand.handleRecursiveUpload()
  1103. assert.EqualError(t, err, "unacceptable end dir command")
  1104. }
  1105. func TestSCPParseUploadMessage(t *testing.T) {
  1106. buf := make([]byte, 65535)
  1107. stdErrBuf := make([]byte, 65535)
  1108. mockSSHChannel := MockChannel{
  1109. Buffer: bytes.NewBuffer(buf),
  1110. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1111. ReadError: nil,
  1112. }
  1113. fs := vfs.NewOsFs("", os.TempDir(), "")
  1114. connection := &Connection{
  1115. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", dataprovider.User{
  1116. BaseUser: sdk.BaseUser{
  1117. HomeDir: os.TempDir(),
  1118. },
  1119. }),
  1120. channel: &mockSSHChannel,
  1121. }
  1122. scpCommand := scpCommand{
  1123. sshCommand: sshCommand{
  1124. command: "scp",
  1125. connection: connection,
  1126. args: []string{"-t", "/tmp"},
  1127. },
  1128. }
  1129. _, _, err := scpCommand.parseUploadMessage(fs, "invalid")
  1130. assert.Error(t, err, "parsing invalid upload message must fail")
  1131. _, _, err = scpCommand.parseUploadMessage(fs, "D0755 0")
  1132. assert.Error(t, err, "parsing incomplete upload message must fail")
  1133. _, _, err = scpCommand.parseUploadMessage(fs, "D0755 invalidsize testdir")
  1134. assert.Error(t, err, "parsing upload message with invalid size must fail")
  1135. _, _, err = scpCommand.parseUploadMessage(fs, "D0755 0 ")
  1136. assert.Error(t, err, "parsing upload message with invalid name must fail")
  1137. }
  1138. func TestSCPProtocolMessages(t *testing.T) {
  1139. buf := make([]byte, 65535)
  1140. stdErrBuf := make([]byte, 65535)
  1141. readErr := fmt.Errorf("test read error")
  1142. writeErr := fmt.Errorf("test write error")
  1143. mockSSHChannel := MockChannel{
  1144. Buffer: bytes.NewBuffer(buf),
  1145. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1146. ReadError: readErr,
  1147. WriteError: writeErr,
  1148. }
  1149. connection := &Connection{
  1150. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{}),
  1151. channel: &mockSSHChannel,
  1152. }
  1153. scpCommand := scpCommand{
  1154. sshCommand: sshCommand{
  1155. command: "scp",
  1156. connection: connection,
  1157. args: []string{"-t", "/tmp"},
  1158. },
  1159. }
  1160. _, err := scpCommand.readProtocolMessage()
  1161. assert.EqualError(t, err, readErr.Error())
  1162. err = scpCommand.sendConfirmationMessage()
  1163. assert.EqualError(t, err, writeErr.Error())
  1164. err = scpCommand.sendProtocolMessage("E\n")
  1165. assert.EqualError(t, err, writeErr.Error())
  1166. _, err = scpCommand.getNextUploadProtocolMessage()
  1167. assert.EqualError(t, err, readErr.Error())
  1168. mockSSHChannel = MockChannel{
  1169. Buffer: bytes.NewBuffer([]byte("T1183832947 0 1183833773 0\n")),
  1170. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1171. ReadError: nil,
  1172. WriteError: writeErr,
  1173. }
  1174. scpCommand.connection.channel = &mockSSHChannel
  1175. _, err = scpCommand.getNextUploadProtocolMessage()
  1176. assert.EqualError(t, err, writeErr.Error())
  1177. respBuffer := []byte{0x02}
  1178. protocolErrorMsg := "protocol error msg"
  1179. respBuffer = append(respBuffer, protocolErrorMsg...)
  1180. respBuffer = append(respBuffer, 0x0A)
  1181. mockSSHChannel = MockChannel{
  1182. Buffer: bytes.NewBuffer(respBuffer),
  1183. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1184. ReadError: nil,
  1185. WriteError: nil,
  1186. }
  1187. scpCommand.connection.channel = &mockSSHChannel
  1188. err = scpCommand.readConfirmationMessage()
  1189. if assert.Error(t, err) {
  1190. assert.Equal(t, protocolErrorMsg, err.Error())
  1191. }
  1192. }
  1193. func TestSCPTestDownloadProtocolMessages(t *testing.T) {
  1194. buf := make([]byte, 65535)
  1195. stdErrBuf := make([]byte, 65535)
  1196. readErr := fmt.Errorf("test read error")
  1197. writeErr := fmt.Errorf("test write error")
  1198. mockSSHChannel := MockChannel{
  1199. Buffer: bytes.NewBuffer(buf),
  1200. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1201. ReadError: readErr,
  1202. WriteError: writeErr,
  1203. }
  1204. connection := &Connection{
  1205. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{}),
  1206. channel: &mockSSHChannel,
  1207. }
  1208. scpCommand := scpCommand{
  1209. sshCommand: sshCommand{
  1210. command: "scp",
  1211. connection: connection,
  1212. args: []string{"-f", "-p", "/tmp"},
  1213. },
  1214. }
  1215. path := "testDir"
  1216. err := os.Mkdir(path, os.ModePerm)
  1217. assert.NoError(t, err)
  1218. stat, err := os.Stat(path)
  1219. assert.NoError(t, err)
  1220. err = scpCommand.sendDownloadProtocolMessages(path, stat)
  1221. assert.EqualError(t, err, writeErr.Error())
  1222. mockSSHChannel = MockChannel{
  1223. Buffer: bytes.NewBuffer(buf),
  1224. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1225. ReadError: readErr,
  1226. WriteError: nil,
  1227. }
  1228. err = scpCommand.sendDownloadProtocolMessages(path, stat)
  1229. assert.EqualError(t, err, readErr.Error())
  1230. mockSSHChannel = MockChannel{
  1231. Buffer: bytes.NewBuffer(buf),
  1232. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1233. ReadError: readErr,
  1234. WriteError: writeErr,
  1235. }
  1236. scpCommand.args = []string{"-f", "/tmp"}
  1237. scpCommand.connection.channel = &mockSSHChannel
  1238. err = scpCommand.sendDownloadProtocolMessages(path, stat)
  1239. assert.EqualError(t, err, writeErr.Error())
  1240. mockSSHChannel = MockChannel{
  1241. Buffer: bytes.NewBuffer(buf),
  1242. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1243. ReadError: readErr,
  1244. WriteError: nil,
  1245. }
  1246. scpCommand.connection.channel = &mockSSHChannel
  1247. err = scpCommand.sendDownloadProtocolMessages(path, stat)
  1248. assert.EqualError(t, err, readErr.Error())
  1249. err = os.Remove(path)
  1250. assert.NoError(t, err)
  1251. }
  1252. func TestSCPCommandHandleErrors(t *testing.T) {
  1253. buf := make([]byte, 65535)
  1254. stdErrBuf := make([]byte, 65535)
  1255. readErr := fmt.Errorf("test read error")
  1256. writeErr := fmt.Errorf("test write error")
  1257. mockSSHChannel := MockChannel{
  1258. Buffer: bytes.NewBuffer(buf),
  1259. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1260. ReadError: readErr,
  1261. WriteError: writeErr,
  1262. }
  1263. server, client := net.Pipe()
  1264. defer func() {
  1265. err := server.Close()
  1266. assert.NoError(t, err)
  1267. }()
  1268. defer func() {
  1269. err := client.Close()
  1270. assert.NoError(t, err)
  1271. }()
  1272. connection := &Connection{
  1273. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{}),
  1274. channel: &mockSSHChannel,
  1275. }
  1276. scpCommand := scpCommand{
  1277. sshCommand: sshCommand{
  1278. command: "scp",
  1279. connection: connection,
  1280. args: []string{"-f", "/tmp"},
  1281. },
  1282. }
  1283. err := scpCommand.handle()
  1284. assert.EqualError(t, err, readErr.Error())
  1285. scpCommand.args = []string{"-i", "/tmp"}
  1286. err = scpCommand.handle()
  1287. assert.Error(t, err, "invalid scp command must fail")
  1288. }
  1289. func TestSCPErrorsMockFs(t *testing.T) {
  1290. errFake := errors.New("fake error")
  1291. u := dataprovider.User{}
  1292. u.Username = "test"
  1293. u.Permissions = make(map[string][]string)
  1294. u.Permissions["/"] = []string{dataprovider.PermAny}
  1295. u.HomeDir = os.TempDir()
  1296. buf := make([]byte, 65535)
  1297. stdErrBuf := make([]byte, 65535)
  1298. mockSSHChannel := MockChannel{
  1299. Buffer: bytes.NewBuffer(buf),
  1300. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1301. }
  1302. server, client := net.Pipe()
  1303. defer func() {
  1304. err := server.Close()
  1305. assert.NoError(t, err)
  1306. }()
  1307. defer func() {
  1308. err := client.Close()
  1309. assert.NoError(t, err)
  1310. }()
  1311. connection := &Connection{
  1312. channel: &mockSSHChannel,
  1313. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", u),
  1314. }
  1315. scpCommand := scpCommand{
  1316. sshCommand: sshCommand{
  1317. command: "scp",
  1318. connection: connection,
  1319. args: []string{"-r", "-t", "/tmp"},
  1320. },
  1321. }
  1322. testfile := filepath.Join(u.HomeDir, "testfile")
  1323. err := os.WriteFile(testfile, []byte("test"), os.ModePerm)
  1324. assert.NoError(t, err)
  1325. fs := newMockOsFs(errFake, nil, true, "123", os.TempDir())
  1326. err = scpCommand.handleUploadFile(fs, testfile, testfile, 0, false, 4, "/testfile")
  1327. assert.NoError(t, err)
  1328. err = os.Remove(testfile)
  1329. assert.NoError(t, err)
  1330. }
  1331. func TestSCPRecursiveDownloadErrors(t *testing.T) {
  1332. buf := make([]byte, 65535)
  1333. stdErrBuf := make([]byte, 65535)
  1334. readErr := fmt.Errorf("test read error")
  1335. writeErr := fmt.Errorf("test write error")
  1336. mockSSHChannel := MockChannel{
  1337. Buffer: bytes.NewBuffer(buf),
  1338. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1339. ReadError: readErr,
  1340. WriteError: writeErr,
  1341. }
  1342. server, client := net.Pipe()
  1343. defer func() {
  1344. err := server.Close()
  1345. assert.NoError(t, err)
  1346. }()
  1347. defer func() {
  1348. err := client.Close()
  1349. assert.NoError(t, err)
  1350. }()
  1351. fs := vfs.NewOsFs("123", os.TempDir(), "")
  1352. connection := &Connection{
  1353. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{
  1354. BaseUser: sdk.BaseUser{
  1355. HomeDir: os.TempDir(),
  1356. },
  1357. }),
  1358. channel: &mockSSHChannel,
  1359. }
  1360. scpCommand := scpCommand{
  1361. sshCommand: sshCommand{
  1362. command: "scp",
  1363. connection: connection,
  1364. args: []string{"-r", "-f", "/tmp"},
  1365. },
  1366. }
  1367. path := "testDir"
  1368. err := os.Mkdir(path, os.ModePerm)
  1369. assert.NoError(t, err)
  1370. stat, err := os.Stat(path)
  1371. assert.NoError(t, err)
  1372. err = scpCommand.handleRecursiveDownload(fs, "invalid_dir", "invalid_dir", stat)
  1373. assert.EqualError(t, err, writeErr.Error())
  1374. mockSSHChannel = MockChannel{
  1375. Buffer: bytes.NewBuffer(buf),
  1376. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1377. ReadError: nil,
  1378. WriteError: nil,
  1379. }
  1380. scpCommand.connection.channel = &mockSSHChannel
  1381. err = scpCommand.handleRecursiveDownload(fs, "invalid_dir", "invalid_dir", stat)
  1382. assert.Error(t, err, "recursive upload download must fail for a non existing dir")
  1383. err = os.Remove(path)
  1384. assert.NoError(t, err)
  1385. }
  1386. func TestSCPRecursiveUploadErrors(t *testing.T) {
  1387. buf := make([]byte, 65535)
  1388. stdErrBuf := make([]byte, 65535)
  1389. readErr := fmt.Errorf("test read error")
  1390. writeErr := fmt.Errorf("test write error")
  1391. mockSSHChannel := MockChannel{
  1392. Buffer: bytes.NewBuffer(buf),
  1393. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1394. ReadError: readErr,
  1395. WriteError: writeErr,
  1396. }
  1397. connection := &Connection{
  1398. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{}),
  1399. channel: &mockSSHChannel,
  1400. }
  1401. scpCommand := scpCommand{
  1402. sshCommand: sshCommand{
  1403. command: "scp",
  1404. connection: connection,
  1405. args: []string{"-r", "-t", "/tmp"},
  1406. },
  1407. }
  1408. err := scpCommand.handleRecursiveUpload()
  1409. assert.Error(t, err, "recursive upload must fail, we send a fake error message")
  1410. mockSSHChannel = MockChannel{
  1411. Buffer: bytes.NewBuffer(buf),
  1412. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1413. ReadError: readErr,
  1414. WriteError: nil,
  1415. }
  1416. scpCommand.connection.channel = &mockSSHChannel
  1417. err = scpCommand.handleRecursiveUpload()
  1418. assert.Error(t, err, "recursive upload must fail, we send a fake error message")
  1419. }
  1420. func TestSCPCreateDirs(t *testing.T) {
  1421. buf := make([]byte, 65535)
  1422. stdErrBuf := make([]byte, 65535)
  1423. u := dataprovider.User{}
  1424. u.HomeDir = "home_rel_path"
  1425. u.Username = "test"
  1426. u.Permissions = make(map[string][]string)
  1427. u.Permissions["/"] = []string{dataprovider.PermAny}
  1428. mockSSHChannel := MockChannel{
  1429. Buffer: bytes.NewBuffer(buf),
  1430. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1431. ReadError: nil,
  1432. WriteError: nil,
  1433. }
  1434. fs, err := u.GetFilesystem("123")
  1435. assert.NoError(t, err)
  1436. connection := &Connection{
  1437. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", u),
  1438. channel: &mockSSHChannel,
  1439. }
  1440. scpCommand := scpCommand{
  1441. sshCommand: sshCommand{
  1442. command: "scp",
  1443. connection: connection,
  1444. args: []string{"-r", "-t", "/tmp"},
  1445. },
  1446. }
  1447. err = scpCommand.handleCreateDir(fs, "invalid_dir")
  1448. assert.Error(t, err, "create invalid dir must fail")
  1449. }
  1450. func TestSCPDownloadFileData(t *testing.T) {
  1451. testfile := "testfile"
  1452. buf := make([]byte, 65535)
  1453. readErr := fmt.Errorf("test read error")
  1454. writeErr := fmt.Errorf("test write error")
  1455. stdErrBuf := make([]byte, 65535)
  1456. mockSSHChannelReadErr := MockChannel{
  1457. Buffer: bytes.NewBuffer(buf),
  1458. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1459. ReadError: readErr,
  1460. WriteError: nil,
  1461. }
  1462. mockSSHChannelWriteErr := MockChannel{
  1463. Buffer: bytes.NewBuffer(buf),
  1464. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1465. ReadError: nil,
  1466. WriteError: writeErr,
  1467. }
  1468. fs := vfs.NewOsFs("", os.TempDir(), "")
  1469. connection := &Connection{
  1470. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{BaseUser: sdk.BaseUser{HomeDir: os.TempDir()}}),
  1471. channel: &mockSSHChannelReadErr,
  1472. }
  1473. scpCommand := scpCommand{
  1474. sshCommand: sshCommand{
  1475. command: "scp",
  1476. connection: connection,
  1477. args: []string{"-r", "-f", "/tmp"},
  1478. },
  1479. }
  1480. err := os.WriteFile(testfile, []byte("test"), os.ModePerm)
  1481. assert.NoError(t, err)
  1482. stat, err := os.Stat(testfile)
  1483. assert.NoError(t, err)
  1484. err = scpCommand.sendDownloadFileData(fs, testfile, stat, nil)
  1485. assert.EqualError(t, err, readErr.Error())
  1486. scpCommand.connection.channel = &mockSSHChannelWriteErr
  1487. err = scpCommand.sendDownloadFileData(fs, testfile, stat, nil)
  1488. assert.EqualError(t, err, writeErr.Error())
  1489. scpCommand.args = []string{"-r", "-p", "-f", "/tmp"}
  1490. err = scpCommand.sendDownloadFileData(fs, testfile, stat, nil)
  1491. assert.EqualError(t, err, writeErr.Error())
  1492. scpCommand.connection.channel = &mockSSHChannelReadErr
  1493. err = scpCommand.sendDownloadFileData(fs, testfile, stat, nil)
  1494. assert.EqualError(t, err, readErr.Error())
  1495. err = os.Remove(testfile)
  1496. assert.NoError(t, err)
  1497. }
  1498. func TestSCPUploadFiledata(t *testing.T) {
  1499. testfile := "testfile"
  1500. buf := make([]byte, 65535)
  1501. stdErrBuf := make([]byte, 65535)
  1502. readErr := fmt.Errorf("test read error")
  1503. writeErr := fmt.Errorf("test write error")
  1504. mockSSHChannel := MockChannel{
  1505. Buffer: bytes.NewBuffer(buf),
  1506. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1507. ReadError: readErr,
  1508. WriteError: writeErr,
  1509. }
  1510. user := dataprovider.User{
  1511. BaseUser: sdk.BaseUser{
  1512. Username: "testuser",
  1513. },
  1514. }
  1515. fs := vfs.NewOsFs("", os.TempDir(), "")
  1516. connection := &Connection{
  1517. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", user),
  1518. channel: &mockSSHChannel,
  1519. }
  1520. scpCommand := scpCommand{
  1521. sshCommand: sshCommand{
  1522. command: "scp",
  1523. connection: connection,
  1524. args: []string{"-r", "-t", "/tmp"},
  1525. },
  1526. }
  1527. file, err := os.Create(testfile)
  1528. assert.NoError(t, err)
  1529. baseTransfer := common.NewBaseTransfer(file, scpCommand.connection.BaseConnection, nil, file.Name(), file.Name(),
  1530. "/"+testfile, common.TransferDownload, 0, 0, 0, 0, true, fs, dataprovider.TransferQuota{})
  1531. transfer := newTransfer(baseTransfer, nil, nil, nil)
  1532. err = scpCommand.getUploadFileData(2, transfer)
  1533. assert.Error(t, err, "upload must fail, we send a fake write error message")
  1534. mockSSHChannel = MockChannel{
  1535. Buffer: bytes.NewBuffer(buf),
  1536. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1537. ReadError: readErr,
  1538. WriteError: nil,
  1539. }
  1540. scpCommand.connection.channel = &mockSSHChannel
  1541. file, err = os.Create(testfile)
  1542. assert.NoError(t, err)
  1543. transfer.File = file
  1544. transfer.isFinished = false
  1545. transfer.Connection.AddTransfer(transfer)
  1546. err = scpCommand.getUploadFileData(2, transfer)
  1547. assert.Error(t, err, "upload must fail, we send a fake read error message")
  1548. respBuffer := []byte("12")
  1549. respBuffer = append(respBuffer, 0x02)
  1550. mockSSHChannel = MockChannel{
  1551. Buffer: bytes.NewBuffer(respBuffer),
  1552. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1553. ReadError: nil,
  1554. WriteError: nil,
  1555. }
  1556. scpCommand.connection.channel = &mockSSHChannel
  1557. file, err = os.Create(testfile)
  1558. assert.NoError(t, err)
  1559. baseTransfer.File = file
  1560. transfer = newTransfer(baseTransfer, nil, nil, nil)
  1561. transfer.Connection.AddTransfer(transfer)
  1562. err = scpCommand.getUploadFileData(2, transfer)
  1563. assert.Error(t, err, "upload must fail, we have not enough data to read")
  1564. // the file is already closed so we have an error on trasfer closing
  1565. mockSSHChannel = MockChannel{
  1566. Buffer: bytes.NewBuffer(buf),
  1567. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1568. ReadError: nil,
  1569. WriteError: nil,
  1570. }
  1571. transfer.Connection.AddTransfer(transfer)
  1572. err = scpCommand.getUploadFileData(0, transfer)
  1573. if assert.Error(t, err) {
  1574. assert.EqualError(t, err, common.ErrTransferClosed.Error())
  1575. }
  1576. mockSSHChannel = MockChannel{
  1577. Buffer: bytes.NewBuffer(buf),
  1578. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1579. ReadError: nil,
  1580. WriteError: nil,
  1581. }
  1582. transfer.Connection.AddTransfer(transfer)
  1583. err = scpCommand.getUploadFileData(2, transfer)
  1584. assert.True(t, errors.Is(err, os.ErrClosed))
  1585. err = os.Remove(testfile)
  1586. assert.NoError(t, err)
  1587. }
  1588. func TestUploadError(t *testing.T) {
  1589. common.Config.UploadMode = common.UploadModeAtomic
  1590. user := dataprovider.User{
  1591. BaseUser: sdk.BaseUser{
  1592. Username: "testuser",
  1593. },
  1594. }
  1595. fs := vfs.NewOsFs("", os.TempDir(), "")
  1596. connection := &Connection{
  1597. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", user),
  1598. }
  1599. testfile := "testfile"
  1600. fileTempName := "temptestfile"
  1601. file, err := os.Create(fileTempName)
  1602. assert.NoError(t, err)
  1603. baseTransfer := common.NewBaseTransfer(file, connection.BaseConnection, nil, testfile, file.Name(),
  1604. testfile, common.TransferUpload, 0, 0, 0, 0, true, fs, dataprovider.TransferQuota{})
  1605. transfer := newTransfer(baseTransfer, nil, nil, nil)
  1606. errFake := errors.New("fake error")
  1607. transfer.TransferError(errFake)
  1608. err = transfer.Close()
  1609. if assert.Error(t, err) {
  1610. assert.EqualError(t, err, common.ErrGenericFailure.Error())
  1611. }
  1612. if assert.Error(t, transfer.ErrTransfer) {
  1613. assert.EqualError(t, transfer.ErrTransfer, errFake.Error())
  1614. }
  1615. assert.Equal(t, int64(0), transfer.BytesReceived)
  1616. assert.NoFileExists(t, testfile)
  1617. assert.NoFileExists(t, fileTempName)
  1618. common.Config.UploadMode = common.UploadModeAtomicWithResume
  1619. }
  1620. func TestTransferFailingReader(t *testing.T) {
  1621. user := dataprovider.User{
  1622. BaseUser: sdk.BaseUser{
  1623. Username: "testuser",
  1624. HomeDir: os.TempDir(),
  1625. },
  1626. FsConfig: vfs.Filesystem{
  1627. Provider: sdk.CryptedFilesystemProvider,
  1628. CryptConfig: vfs.CryptFsConfig{
  1629. Passphrase: kms.NewPlainSecret("crypt secret"),
  1630. },
  1631. },
  1632. }
  1633. user.Permissions = make(map[string][]string)
  1634. user.Permissions["/"] = []string{dataprovider.PermAny}
  1635. fs := newMockOsFs(nil, nil, true, "", os.TempDir())
  1636. connection := &Connection{
  1637. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  1638. }
  1639. request := sftp.NewRequest("Open", "afile.txt")
  1640. request.Flags = 27 // read,write,create,truncate
  1641. transfer, err := connection.handleFilewrite(request)
  1642. require.NoError(t, err)
  1643. buf := make([]byte, 32)
  1644. _, err = transfer.ReadAt(buf, 0)
  1645. assert.EqualError(t, err, sftp.ErrSSHFxOpUnsupported.Error())
  1646. if c, ok := transfer.(io.Closer); ok {
  1647. err = c.Close()
  1648. assert.NoError(t, err)
  1649. }
  1650. fsPath := filepath.Join(os.TempDir(), "afile.txt")
  1651. r, _, err := pipeat.Pipe()
  1652. assert.NoError(t, err)
  1653. baseTransfer := common.NewBaseTransfer(nil, connection.BaseConnection, nil, fsPath, fsPath, filepath.Base(fsPath),
  1654. common.TransferUpload, 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  1655. errRead := errors.New("read is not allowed")
  1656. tr := newTransfer(baseTransfer, nil, r, errRead)
  1657. _, err = tr.ReadAt(buf, 0)
  1658. assert.EqualError(t, err, errRead.Error())
  1659. err = tr.Close()
  1660. assert.NoError(t, err)
  1661. tr = newTransfer(baseTransfer, nil, nil, errRead)
  1662. _, err = tr.ReadAt(buf, 0)
  1663. assert.EqualError(t, err, errRead.Error())
  1664. err = tr.Close()
  1665. assert.NoError(t, err)
  1666. err = os.Remove(fsPath)
  1667. assert.NoError(t, err)
  1668. assert.Len(t, connection.GetTransfers(), 0)
  1669. }
  1670. func TestConnectionStatusStruct(t *testing.T) {
  1671. var transfers []common.ConnectionTransfer
  1672. transferUL := common.ConnectionTransfer{
  1673. OperationType: "upload",
  1674. StartTime: util.GetTimeAsMsSinceEpoch(time.Now()),
  1675. Size: 123,
  1676. VirtualPath: "/test.upload",
  1677. }
  1678. transferDL := common.ConnectionTransfer{
  1679. OperationType: "download",
  1680. StartTime: util.GetTimeAsMsSinceEpoch(time.Now()),
  1681. Size: 123,
  1682. VirtualPath: "/test.download",
  1683. }
  1684. transfers = append(transfers, transferUL)
  1685. transfers = append(transfers, transferDL)
  1686. c := common.ConnectionStatus{
  1687. Username: "test",
  1688. ConnectionID: "123",
  1689. ClientVersion: "fakeClient-1.0.0",
  1690. RemoteAddress: "127.0.0.1:1234",
  1691. ConnectionTime: util.GetTimeAsMsSinceEpoch(time.Now()),
  1692. LastActivity: util.GetTimeAsMsSinceEpoch(time.Now()),
  1693. Protocol: "SFTP",
  1694. Transfers: transfers,
  1695. }
  1696. durationString := c.GetConnectionDuration()
  1697. assert.NotEqual(t, 0, len(durationString))
  1698. transfersString := c.GetTransfersAsString()
  1699. assert.NotEqual(t, 0, len(transfersString))
  1700. connInfo := c.GetConnectionInfo()
  1701. assert.NotEqual(t, 0, len(connInfo))
  1702. }
  1703. func TestSupportedSecurityOptions(t *testing.T) {
  1704. c := Configuration{
  1705. KexAlgorithms: supportedKexAlgos,
  1706. MACs: supportedMACs,
  1707. Ciphers: supportedCiphers,
  1708. }
  1709. serverConfig := &ssh.ServerConfig{}
  1710. err := c.configureSecurityOptions(serverConfig)
  1711. assert.NoError(t, err)
  1712. assert.Equal(t, supportedCiphers, serverConfig.Ciphers)
  1713. assert.Equal(t, supportedMACs, serverConfig.MACs)
  1714. assert.Equal(t, supportedKexAlgos, serverConfig.KeyExchanges)
  1715. c.KexAlgorithms = append(c.KexAlgorithms, "not a kex")
  1716. err = c.configureSecurityOptions(serverConfig)
  1717. assert.Error(t, err)
  1718. c.KexAlgorithms = supportedKexAlgos
  1719. c.MACs = []string{
  1720. " [email protected] ", "hmac-sha2-256",
  1721. " [email protected]", "hmac-sha2-512 ",
  1722. "hmac-sha1 ", " hmac-sha1-96",
  1723. }
  1724. err = c.configureSecurityOptions(serverConfig)
  1725. assert.NoError(t, err)
  1726. assert.Equal(t, supportedCiphers, serverConfig.Ciphers)
  1727. assert.Equal(t, supportedMACs, serverConfig.MACs)
  1728. assert.Equal(t, supportedKexAlgos, serverConfig.KeyExchanges)
  1729. }
  1730. func TestLoadHostKeys(t *testing.T) {
  1731. serverConfig := &ssh.ServerConfig{}
  1732. c := Configuration{}
  1733. c.HostKeys = []string{".", "missing file"}
  1734. err := c.checkAndLoadHostKeys(configDir, serverConfig)
  1735. assert.Error(t, err)
  1736. testfile := filepath.Join(os.TempDir(), "invalidkey")
  1737. err = os.WriteFile(testfile, []byte("some bytes"), os.ModePerm)
  1738. assert.NoError(t, err)
  1739. c.HostKeys = []string{testfile}
  1740. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1741. assert.Error(t, err)
  1742. err = os.Remove(testfile)
  1743. assert.NoError(t, err)
  1744. keysDir := filepath.Join(os.TempDir(), "keys")
  1745. err = os.MkdirAll(keysDir, os.ModePerm)
  1746. assert.NoError(t, err)
  1747. rsaKeyName := filepath.Join(keysDir, defaultPrivateRSAKeyName)
  1748. ecdsaKeyName := filepath.Join(keysDir, defaultPrivateECDSAKeyName)
  1749. ed25519KeyName := filepath.Join(keysDir, defaultPrivateEd25519KeyName)
  1750. nonDefaultKeyName := filepath.Join(keysDir, "akey")
  1751. c.HostKeys = []string{nonDefaultKeyName, rsaKeyName, ecdsaKeyName, ed25519KeyName}
  1752. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1753. assert.Error(t, err)
  1754. assert.FileExists(t, rsaKeyName)
  1755. assert.FileExists(t, ecdsaKeyName)
  1756. assert.FileExists(t, ed25519KeyName)
  1757. assert.NoFileExists(t, nonDefaultKeyName)
  1758. err = os.Remove(rsaKeyName)
  1759. assert.NoError(t, err)
  1760. err = os.Remove(ecdsaKeyName)
  1761. assert.NoError(t, err)
  1762. err = os.Remove(ed25519KeyName)
  1763. assert.NoError(t, err)
  1764. if runtime.GOOS != osWindows {
  1765. err = os.Chmod(keysDir, 0551)
  1766. assert.NoError(t, err)
  1767. c.HostKeys = nil
  1768. err = c.checkAndLoadHostKeys(keysDir, serverConfig)
  1769. assert.Error(t, err)
  1770. c.HostKeys = []string{rsaKeyName, ecdsaKeyName}
  1771. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1772. assert.Error(t, err)
  1773. c.HostKeys = []string{ecdsaKeyName, rsaKeyName}
  1774. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1775. assert.Error(t, err)
  1776. c.HostKeys = []string{ed25519KeyName}
  1777. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1778. assert.Error(t, err)
  1779. err = os.Chmod(keysDir, 0755)
  1780. assert.NoError(t, err)
  1781. }
  1782. err = os.RemoveAll(keysDir)
  1783. assert.NoError(t, err)
  1784. }
  1785. func TestCertCheckerInitErrors(t *testing.T) {
  1786. c := Configuration{}
  1787. c.TrustedUserCAKeys = []string{".", "missing file"}
  1788. err := c.initializeCertChecker("")
  1789. assert.Error(t, err)
  1790. testfile := filepath.Join(os.TempDir(), "invalidkey")
  1791. err = os.WriteFile(testfile, []byte("some bytes"), os.ModePerm)
  1792. assert.NoError(t, err)
  1793. c.TrustedUserCAKeys = []string{testfile}
  1794. err = c.initializeCertChecker("")
  1795. assert.Error(t, err)
  1796. err = os.Remove(testfile)
  1797. assert.NoError(t, err)
  1798. }
  1799. func TestRecursiveCopyErrors(t *testing.T) {
  1800. permissions := make(map[string][]string)
  1801. permissions["/"] = []string{dataprovider.PermAny}
  1802. user := dataprovider.User{
  1803. BaseUser: sdk.BaseUser{
  1804. Permissions: permissions,
  1805. HomeDir: os.TempDir(),
  1806. },
  1807. }
  1808. fs, err := user.GetFilesystem("123")
  1809. assert.NoError(t, err)
  1810. conn := &Connection{
  1811. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  1812. }
  1813. sshCmd := sshCommand{
  1814. command: "sftpgo-copy",
  1815. connection: conn,
  1816. args: []string{"adir", "another"},
  1817. }
  1818. // try to copy a missing directory
  1819. sshCmd.connection.User.Permissions["/another"] = []string{
  1820. dataprovider.PermCreateDirs,
  1821. dataprovider.PermCreateSymlinks,
  1822. dataprovider.PermListItems,
  1823. }
  1824. err = sshCmd.checkRecursiveCopyPermissions(fs, fs, "adir", "another/sub", "/adir", "/another/sub")
  1825. assert.Error(t, err)
  1826. sshCmd.connection.User.Permissions["/another"] = []string{
  1827. dataprovider.PermListItems,
  1828. dataprovider.PermCreateDirs,
  1829. }
  1830. err = sshCmd.checkRecursiveCopyPermissions(fs, fs, "adir", "another", "/adir/sub", "/another/sub/dir")
  1831. assert.Error(t, err)
  1832. }
  1833. func TestSFTPSubSystem(t *testing.T) {
  1834. permissions := make(map[string][]string)
  1835. permissions["/"] = []string{dataprovider.PermAny}
  1836. user := &dataprovider.User{
  1837. BaseUser: sdk.BaseUser{
  1838. Permissions: permissions,
  1839. HomeDir: os.TempDir(),
  1840. },
  1841. }
  1842. user.FsConfig.Provider = sdk.AzureBlobFilesystemProvider
  1843. err := ServeSubSystemConnection(user, "connID", nil, nil)
  1844. assert.Error(t, err)
  1845. user.FsConfig.Provider = sdk.LocalFilesystemProvider
  1846. buf := make([]byte, 0, 4096)
  1847. stdErrBuf := make([]byte, 0, 4096)
  1848. mockSSHChannel := &MockChannel{
  1849. Buffer: bytes.NewBuffer(buf),
  1850. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1851. }
  1852. // this is 327680 and it will result in packet too long error
  1853. _, err = mockSSHChannel.Write([]byte{0x00, 0x05, 0x00, 0x00, 0x00, 0x00})
  1854. assert.NoError(t, err)
  1855. err = ServeSubSystemConnection(user, "id", mockSSHChannel, mockSSHChannel)
  1856. assert.EqualError(t, err, "packet too long")
  1857. subsystemChannel := newSubsystemChannel(mockSSHChannel, mockSSHChannel)
  1858. n, err := subsystemChannel.Write([]byte{0x00})
  1859. assert.NoError(t, err)
  1860. assert.Equal(t, n, 1)
  1861. err = subsystemChannel.Close()
  1862. assert.NoError(t, err)
  1863. }
  1864. func TestRecoverer(t *testing.T) {
  1865. c := Configuration{}
  1866. c.AcceptInboundConnection(nil, nil)
  1867. connID := "connectionID"
  1868. connection := &Connection{
  1869. BaseConnection: common.NewBaseConnection(connID, common.ProtocolSFTP, "", "", dataprovider.User{}),
  1870. }
  1871. c.handleSftpConnection(nil, connection)
  1872. sshCmd := sshCommand{
  1873. command: "cd",
  1874. connection: connection,
  1875. }
  1876. err := sshCmd.handle()
  1877. assert.EqualError(t, err, common.ErrGenericFailure.Error())
  1878. scpCmd := scpCommand{
  1879. sshCommand: sshCommand{
  1880. command: "scp",
  1881. connection: connection,
  1882. },
  1883. }
  1884. err = scpCmd.handle()
  1885. assert.EqualError(t, err, common.ErrGenericFailure.Error())
  1886. assert.Len(t, common.Connections.GetStats(), 0)
  1887. }
  1888. func TestListernerAcceptErrors(t *testing.T) {
  1889. errFake := errors.New("a fake error")
  1890. listener := newFakeListener(errFake)
  1891. c := Configuration{}
  1892. err := c.serve(listener, nil)
  1893. require.EqualError(t, err, errFake.Error())
  1894. err = listener.Close()
  1895. require.NoError(t, err)
  1896. errNetFake := &fakeNetError{error: errFake}
  1897. listener = newFakeListener(errNetFake)
  1898. err = c.serve(listener, nil)
  1899. require.EqualError(t, err, errFake.Error())
  1900. err = listener.Close()
  1901. require.NoError(t, err)
  1902. }
  1903. type fakeNetError struct {
  1904. error
  1905. count int
  1906. }
  1907. func (e *fakeNetError) Timeout() bool {
  1908. return false
  1909. }
  1910. func (e *fakeNetError) Temporary() bool {
  1911. e.count++
  1912. return e.count < 10
  1913. }
  1914. func (e *fakeNetError) Error() string {
  1915. return e.error.Error()
  1916. }
  1917. type fakeListener struct {
  1918. server net.Conn
  1919. client net.Conn
  1920. err error
  1921. }
  1922. func (l *fakeListener) Accept() (net.Conn, error) {
  1923. return l.client, l.err
  1924. }
  1925. func (l *fakeListener) Close() error {
  1926. errClient := l.client.Close()
  1927. errServer := l.server.Close()
  1928. if errServer != nil {
  1929. return errServer
  1930. }
  1931. return errClient
  1932. }
  1933. func (l *fakeListener) Addr() net.Addr {
  1934. return l.server.LocalAddr()
  1935. }
  1936. func newFakeListener(err error) net.Listener {
  1937. server, client := net.Pipe()
  1938. return &fakeListener{
  1939. server: server,
  1940. client: client,
  1941. err: err,
  1942. }
  1943. }
  1944. func TestFolderPrefix(t *testing.T) {
  1945. c := Configuration{
  1946. FolderPrefix: "files",
  1947. }
  1948. c.checkFolderPrefix()
  1949. assert.Equal(t, "/files", c.FolderPrefix)
  1950. c.FolderPrefix = ""
  1951. c.checkFolderPrefix()
  1952. assert.Empty(t, c.FolderPrefix)
  1953. c.FolderPrefix = "/"
  1954. c.checkFolderPrefix()
  1955. assert.Empty(t, c.FolderPrefix)
  1956. c.FolderPrefix = "/."
  1957. c.checkFolderPrefix()
  1958. assert.Empty(t, c.FolderPrefix)
  1959. c.FolderPrefix = "."
  1960. c.checkFolderPrefix()
  1961. assert.Empty(t, c.FolderPrefix)
  1962. c.FolderPrefix = ".."
  1963. c.checkFolderPrefix()
  1964. assert.Empty(t, c.FolderPrefix)
  1965. }
  1966. func TestLoadRevokedUserCertsFile(t *testing.T) {
  1967. r := revokedCertificates{
  1968. certs: map[string]bool{},
  1969. }
  1970. err := r.load()
  1971. assert.NoError(t, err)
  1972. r.filePath = filepath.Join(os.TempDir(), "sub", "testrevoked")
  1973. err = os.MkdirAll(filepath.Dir(r.filePath), os.ModePerm)
  1974. assert.NoError(t, err)
  1975. err = os.WriteFile(r.filePath, []byte(`no json`), 0644)
  1976. assert.NoError(t, err)
  1977. err = r.load()
  1978. assert.Error(t, err)
  1979. r.filePath = filepath.Dir(r.filePath)
  1980. err = r.load()
  1981. assert.Error(t, err)
  1982. err = os.RemoveAll(r.filePath)
  1983. assert.NoError(t, err)
  1984. }
  1985. func TestMaxUserSessions(t *testing.T) {
  1986. connection := &Connection{
  1987. BaseConnection: common.NewBaseConnection(xid.New().String(), common.ProtocolSFTP, "", "", dataprovider.User{
  1988. BaseUser: sdk.BaseUser{
  1989. Username: "user_max_sessions",
  1990. HomeDir: filepath.Clean(os.TempDir()),
  1991. MaxSessions: 1,
  1992. },
  1993. }),
  1994. }
  1995. err := common.Connections.Add(connection)
  1996. assert.NoError(t, err)
  1997. c := Configuration{}
  1998. c.handleSftpConnection(nil, connection)
  1999. sshCmd := sshCommand{
  2000. command: "cd",
  2001. connection: connection,
  2002. }
  2003. err = sshCmd.handle()
  2004. if assert.Error(t, err) {
  2005. assert.Contains(t, err.Error(), "too many open sessions")
  2006. }
  2007. scpCmd := scpCommand{
  2008. sshCommand: sshCommand{
  2009. command: "scp",
  2010. connection: connection,
  2011. },
  2012. }
  2013. err = scpCmd.handle()
  2014. if assert.Error(t, err) {
  2015. assert.Contains(t, err.Error(), "too many open sessions")
  2016. }
  2017. err = ServeSubSystemConnection(&connection.User, connection.ID, nil, nil)
  2018. if assert.Error(t, err) {
  2019. assert.Contains(t, err.Error(), "too many open sessions")
  2020. }
  2021. common.Connections.Remove(connection.GetID())
  2022. assert.Len(t, common.Connections.GetStats(), 0)
  2023. }
  2024. func TestCanReadSymlink(t *testing.T) {
  2025. connection := &Connection{
  2026. BaseConnection: common.NewBaseConnection(xid.New().String(), common.ProtocolSFTP, "", "", dataprovider.User{
  2027. BaseUser: sdk.BaseUser{
  2028. Username: "user_can_read_symlink",
  2029. HomeDir: filepath.Clean(os.TempDir()),
  2030. Permissions: map[string][]string{
  2031. "/": {dataprovider.PermAny},
  2032. "/sub": {dataprovider.PermUpload},
  2033. },
  2034. },
  2035. Filters: dataprovider.UserFilters{
  2036. BaseUserFilters: sdk.BaseUserFilters{
  2037. FilePatterns: []sdk.PatternsFilter{
  2038. {
  2039. Path: "/denied",
  2040. DeniedPatterns: []string{"*.txt"},
  2041. DenyPolicy: sdk.DenyPolicyHide,
  2042. },
  2043. },
  2044. },
  2045. },
  2046. }),
  2047. }
  2048. err := connection.canReadLink("/sub/link")
  2049. assert.ErrorIs(t, err, sftp.ErrSSHFxPermissionDenied)
  2050. err = connection.canReadLink("/denied/file.txt")
  2051. assert.ErrorIs(t, err, sftp.ErrSSHFxNoSuchFile)
  2052. }