internal_test.go 67 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300
  1. // Copyright (C) 2019-2022 Nicola Murino
  2. //
  3. // This program is free software: you can redistribute it and/or modify
  4. // it under the terms of the GNU Affero General Public License as published
  5. // by the Free Software Foundation, version 3.
  6. //
  7. // This program is distributed in the hope that it will be useful,
  8. // but WITHOUT ANY WARRANTY; without even the implied warranty of
  9. // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  10. // GNU Affero General Public License for more details.
  11. //
  12. // You should have received a copy of the GNU Affero General Public License
  13. // along with this program. If not, see <https://www.gnu.org/licenses/>.
  14. package sftpd
  15. import (
  16. "bytes"
  17. "errors"
  18. "fmt"
  19. "io"
  20. "net"
  21. "os"
  22. "path/filepath"
  23. "runtime"
  24. "testing"
  25. "time"
  26. "github.com/eikenb/pipeat"
  27. "github.com/pkg/sftp"
  28. "github.com/rs/xid"
  29. "github.com/sftpgo/sdk"
  30. "github.com/stretchr/testify/assert"
  31. "github.com/stretchr/testify/require"
  32. "golang.org/x/crypto/ssh"
  33. "github.com/drakkan/sftpgo/v2/internal/common"
  34. "github.com/drakkan/sftpgo/v2/internal/dataprovider"
  35. "github.com/drakkan/sftpgo/v2/internal/kms"
  36. "github.com/drakkan/sftpgo/v2/internal/util"
  37. "github.com/drakkan/sftpgo/v2/internal/vfs"
  38. )
  39. const (
  40. osWindows = "windows"
  41. )
  42. var (
  43. configDir = filepath.Join(".", "..", "..")
  44. )
  45. type MockChannel struct {
  46. Buffer *bytes.Buffer
  47. StdErrBuffer *bytes.Buffer
  48. ReadError error
  49. WriteError error
  50. ShortWriteErr bool
  51. }
  52. func (c *MockChannel) Read(data []byte) (int, error) {
  53. if c.ReadError != nil {
  54. return 0, c.ReadError
  55. }
  56. return c.Buffer.Read(data)
  57. }
  58. func (c *MockChannel) Write(data []byte) (int, error) {
  59. if c.WriteError != nil {
  60. return 0, c.WriteError
  61. }
  62. if c.ShortWriteErr {
  63. return 0, nil
  64. }
  65. return c.Buffer.Write(data)
  66. }
  67. func (c *MockChannel) Close() error {
  68. return nil
  69. }
  70. func (c *MockChannel) CloseWrite() error {
  71. return nil
  72. }
  73. func (c *MockChannel) SendRequest(name string, wantReply bool, payload []byte) (bool, error) {
  74. return true, nil
  75. }
  76. func (c *MockChannel) Stderr() io.ReadWriter {
  77. return c.StdErrBuffer
  78. }
  79. // MockOsFs mockable OsFs
  80. type MockOsFs struct {
  81. vfs.Fs
  82. err error
  83. statErr error
  84. isAtomicUploadSupported bool
  85. }
  86. // Name returns the name for the Fs implementation
  87. func (fs MockOsFs) Name() string {
  88. return "mockOsFs"
  89. }
  90. // IsUploadResumeSupported returns true if resuming uploads is supported
  91. func (MockOsFs) IsUploadResumeSupported() bool {
  92. return false
  93. }
  94. // IsAtomicUploadSupported returns true if atomic upload is supported
  95. func (fs MockOsFs) IsAtomicUploadSupported() bool {
  96. return fs.isAtomicUploadSupported
  97. }
  98. // Stat returns a FileInfo describing the named file
  99. func (fs MockOsFs) Stat(name string) (os.FileInfo, error) {
  100. if fs.statErr != nil {
  101. return nil, fs.statErr
  102. }
  103. return os.Stat(name)
  104. }
  105. // Lstat returns a FileInfo describing the named file
  106. func (fs MockOsFs) Lstat(name string) (os.FileInfo, error) {
  107. if fs.statErr != nil {
  108. return nil, fs.statErr
  109. }
  110. return os.Lstat(name)
  111. }
  112. // Remove removes the named file or (empty) directory.
  113. func (fs MockOsFs) Remove(name string, isDir bool) error {
  114. if fs.err != nil {
  115. return fs.err
  116. }
  117. return os.Remove(name)
  118. }
  119. // Rename renames (moves) source to target
  120. func (fs MockOsFs) Rename(source, target string) error {
  121. if fs.err != nil {
  122. return fs.err
  123. }
  124. return os.Rename(source, target)
  125. }
  126. func newMockOsFs(err, statErr error, atomicUpload bool, connectionID, rootDir string) vfs.Fs {
  127. return &MockOsFs{
  128. Fs: vfs.NewOsFs(connectionID, rootDir, ""),
  129. err: err,
  130. statErr: statErr,
  131. isAtomicUploadSupported: atomicUpload,
  132. }
  133. }
  134. func TestRemoveNonexistentQuotaScan(t *testing.T) {
  135. assert.False(t, common.QuotaScans.RemoveUserQuotaScan("username"))
  136. }
  137. func TestGetOSOpenFlags(t *testing.T) {
  138. var flags sftp.FileOpenFlags
  139. flags.Write = true
  140. flags.Excl = true
  141. osFlags := getOSOpenFlags(flags)
  142. assert.NotEqual(t, 0, osFlags&os.O_WRONLY)
  143. assert.NotEqual(t, 0, osFlags&os.O_EXCL)
  144. flags.Append = true
  145. // append flag should be ignored to allow resume
  146. assert.NotEqual(t, 0, osFlags&os.O_WRONLY)
  147. assert.NotEqual(t, 0, osFlags&os.O_EXCL)
  148. }
  149. func TestUploadResumeInvalidOffset(t *testing.T) {
  150. testfile := "testfile" //nolint:goconst
  151. file, err := os.Create(testfile)
  152. assert.NoError(t, err)
  153. user := dataprovider.User{
  154. BaseUser: sdk.BaseUser{
  155. Username: "testuser",
  156. },
  157. }
  158. fs := vfs.NewOsFs("", os.TempDir(), "")
  159. conn := common.NewBaseConnection("", common.ProtocolSFTP, "", "", user)
  160. baseTransfer := common.NewBaseTransfer(file, conn, nil, file.Name(), file.Name(), testfile,
  161. common.TransferUpload, 10, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  162. transfer := newTransfer(baseTransfer, nil, nil, nil)
  163. _, err = transfer.WriteAt([]byte("test"), 0)
  164. assert.Error(t, err, "upload with invalid offset must fail")
  165. if assert.Error(t, transfer.ErrTransfer) {
  166. assert.EqualError(t, err, transfer.ErrTransfer.Error())
  167. assert.Contains(t, transfer.ErrTransfer.Error(), "invalid write offset")
  168. }
  169. err = transfer.Close()
  170. if assert.Error(t, err) {
  171. assert.ErrorIs(t, err, sftp.ErrSSHFxFailure)
  172. }
  173. err = os.Remove(testfile)
  174. assert.NoError(t, err)
  175. }
  176. func TestReadWriteErrors(t *testing.T) {
  177. testfile := "testfile"
  178. file, err := os.Create(testfile)
  179. assert.NoError(t, err)
  180. user := dataprovider.User{
  181. BaseUser: sdk.BaseUser{
  182. Username: "testuser",
  183. },
  184. }
  185. fs := vfs.NewOsFs("", os.TempDir(), "")
  186. conn := common.NewBaseConnection("", common.ProtocolSFTP, "", "", user)
  187. baseTransfer := common.NewBaseTransfer(file, conn, nil, file.Name(), file.Name(), testfile, common.TransferDownload,
  188. 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  189. transfer := newTransfer(baseTransfer, nil, nil, nil)
  190. err = file.Close()
  191. assert.NoError(t, err)
  192. _, err = transfer.WriteAt([]byte("test"), 0)
  193. assert.Error(t, err, "writing to closed file must fail")
  194. buf := make([]byte, 32768)
  195. _, err = transfer.ReadAt(buf, 0)
  196. assert.Error(t, err, "reading from a closed file must fail")
  197. err = transfer.Close()
  198. assert.Error(t, err)
  199. r, _, err := pipeat.Pipe()
  200. assert.NoError(t, err)
  201. baseTransfer = common.NewBaseTransfer(nil, conn, nil, file.Name(), file.Name(), testfile, common.TransferDownload,
  202. 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  203. transfer = newTransfer(baseTransfer, nil, r, nil)
  204. err = transfer.Close()
  205. assert.NoError(t, err)
  206. _, err = transfer.ReadAt(buf, 0)
  207. assert.Error(t, err, "reading from a closed pipe must fail")
  208. r, w, err := pipeat.Pipe()
  209. assert.NoError(t, err)
  210. pipeWriter := vfs.NewPipeWriter(w)
  211. baseTransfer = common.NewBaseTransfer(nil, conn, nil, file.Name(), file.Name(), testfile, common.TransferDownload,
  212. 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  213. transfer = newTransfer(baseTransfer, pipeWriter, nil, nil)
  214. err = r.Close()
  215. assert.NoError(t, err)
  216. errFake := fmt.Errorf("fake upload error")
  217. go func() {
  218. time.Sleep(100 * time.Millisecond)
  219. pipeWriter.Done(errFake)
  220. }()
  221. err = transfer.closeIO()
  222. assert.EqualError(t, err, errFake.Error())
  223. _, err = transfer.WriteAt([]byte("test"), 0)
  224. assert.Error(t, err, "writing to closed pipe must fail")
  225. err = transfer.BaseTransfer.Close()
  226. assert.EqualError(t, err, errFake.Error())
  227. err = os.Remove(testfile)
  228. assert.NoError(t, err)
  229. assert.Len(t, conn.GetTransfers(), 0)
  230. }
  231. func TestUnsupportedListOP(t *testing.T) {
  232. conn := common.NewBaseConnection("", common.ProtocolSFTP, "", "", dataprovider.User{})
  233. sftpConn := Connection{
  234. BaseConnection: conn,
  235. }
  236. request := sftp.NewRequest("Unsupported", "")
  237. _, err := sftpConn.Filelist(request)
  238. assert.EqualError(t, err, sftp.ErrSSHFxOpUnsupported.Error())
  239. }
  240. func TestTransferCancelFn(t *testing.T) {
  241. testfile := "testfile"
  242. file, err := os.Create(testfile)
  243. assert.NoError(t, err)
  244. isCancelled := false
  245. cancelFn := func() {
  246. isCancelled = true
  247. }
  248. user := dataprovider.User{
  249. BaseUser: sdk.BaseUser{
  250. Username: "testuser",
  251. },
  252. }
  253. fs := vfs.NewOsFs("", os.TempDir(), "")
  254. conn := common.NewBaseConnection("", common.ProtocolSFTP, "", "", user)
  255. baseTransfer := common.NewBaseTransfer(file, conn, cancelFn, file.Name(), file.Name(), testfile, common.TransferDownload,
  256. 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  257. transfer := newTransfer(baseTransfer, nil, nil, nil)
  258. errFake := errors.New("fake error, this will trigger cancelFn")
  259. transfer.TransferError(errFake)
  260. err = transfer.Close()
  261. if assert.Error(t, err) {
  262. assert.ErrorIs(t, err, sftp.ErrSSHFxFailure)
  263. }
  264. if assert.Error(t, transfer.ErrTransfer) {
  265. assert.EqualError(t, transfer.ErrTransfer, errFake.Error())
  266. }
  267. assert.True(t, isCancelled, "cancelFn not called!")
  268. err = os.Remove(testfile)
  269. assert.NoError(t, err)
  270. }
  271. func TestUploadFiles(t *testing.T) {
  272. common.Config.UploadMode = common.UploadModeAtomic
  273. fs := vfs.NewOsFs("123", os.TempDir(), "")
  274. u := dataprovider.User{}
  275. c := Connection{
  276. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", u),
  277. }
  278. var flags sftp.FileOpenFlags
  279. flags.Write = true
  280. flags.Trunc = true
  281. _, err := c.handleSFTPUploadToExistingFile(fs, flags, "missing_path", "other_missing_path", 0, "/missing_path", nil)
  282. assert.Error(t, err, "upload to existing file must fail if one or both paths are invalid")
  283. common.Config.UploadMode = common.UploadModeStandard
  284. _, err = c.handleSFTPUploadToExistingFile(fs, flags, "missing_path", "other_missing_path", 0, "/missing_path", nil)
  285. assert.Error(t, err, "upload to existing file must fail if one or both paths are invalid")
  286. missingFile := "missing/relative/file.txt"
  287. if runtime.GOOS == osWindows {
  288. missingFile = "missing\\relative\\file.txt"
  289. }
  290. _, err = c.handleSFTPUploadToNewFile(fs, flags, ".", missingFile, "/missing", nil)
  291. assert.Error(t, err, "upload new file in missing path must fail")
  292. fs = newMockOsFs(nil, nil, false, "123", os.TempDir())
  293. f, err := os.CreateTemp("", "temp")
  294. assert.NoError(t, err)
  295. err = f.Close()
  296. assert.NoError(t, err)
  297. tr, err := c.handleSFTPUploadToExistingFile(fs, flags, f.Name(), f.Name(), 123, f.Name(), nil)
  298. if assert.NoError(t, err) {
  299. transfer := tr.(*transfer)
  300. transfers := c.GetTransfers()
  301. if assert.Equal(t, 1, len(transfers)) {
  302. assert.Equal(t, transfers[0].ID, transfer.GetID())
  303. assert.Equal(t, int64(123), transfer.InitialSize)
  304. err = transfer.Close()
  305. assert.NoError(t, err)
  306. assert.Equal(t, 0, len(c.GetTransfers()))
  307. }
  308. }
  309. err = os.Remove(f.Name())
  310. assert.NoError(t, err)
  311. common.Config.UploadMode = common.UploadModeAtomicWithResume
  312. }
  313. func TestWithInvalidHome(t *testing.T) {
  314. u := dataprovider.User{}
  315. u.HomeDir = "home_rel_path" //nolint:goconst
  316. _, err := loginUser(&u, dataprovider.LoginMethodPassword, "", nil)
  317. assert.Error(t, err, "login a user with an invalid home_dir must fail")
  318. u.HomeDir = os.TempDir()
  319. fs, err := u.GetFilesystem("123")
  320. assert.NoError(t, err)
  321. c := Connection{
  322. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", u),
  323. }
  324. _, err = fs.ResolvePath("../upper_path")
  325. assert.Error(t, err, "tested path is not a home subdir")
  326. _, err = c.StatVFS(&sftp.Request{
  327. Method: "StatVFS",
  328. Filepath: "../unresolvable-path",
  329. })
  330. assert.Error(t, err)
  331. }
  332. func TestResolveWithRootDir(t *testing.T) {
  333. u := dataprovider.User{}
  334. if runtime.GOOS == osWindows {
  335. u.HomeDir = "C:\\"
  336. } else {
  337. u.HomeDir = "/"
  338. }
  339. fs, err := u.GetFilesystem("")
  340. assert.NoError(t, err)
  341. rel, err := filepath.Rel(u.HomeDir, os.TempDir())
  342. assert.NoError(t, err)
  343. p, err := fs.ResolvePath(rel)
  344. assert.NoError(t, err, "path %v", p)
  345. }
  346. func TestSFTPGetUsedQuota(t *testing.T) {
  347. u := dataprovider.User{}
  348. u.HomeDir = "home_rel_path"
  349. u.Username = "test_invalid_user"
  350. u.QuotaSize = 4096
  351. u.QuotaFiles = 1
  352. u.Permissions = make(map[string][]string)
  353. u.Permissions["/"] = []string{dataprovider.PermAny}
  354. connection := Connection{
  355. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", u),
  356. }
  357. quotaResult, _ := connection.HasSpace(false, false, "/")
  358. assert.False(t, quotaResult.HasSpace)
  359. }
  360. func TestSupportedSSHCommands(t *testing.T) {
  361. cmds := GetSupportedSSHCommands()
  362. assert.Equal(t, len(supportedSSHCommands), len(cmds))
  363. for _, c := range cmds {
  364. assert.True(t, util.Contains(supportedSSHCommands, c))
  365. }
  366. }
  367. func TestSSHCommandPath(t *testing.T) {
  368. buf := make([]byte, 65535)
  369. stdErrBuf := make([]byte, 65535)
  370. mockSSHChannel := MockChannel{
  371. Buffer: bytes.NewBuffer(buf),
  372. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  373. ReadError: nil,
  374. }
  375. connection := &Connection{
  376. channel: &mockSSHChannel,
  377. BaseConnection: common.NewBaseConnection("", common.ProtocolSSH, "", "", dataprovider.User{}),
  378. }
  379. sshCommand := sshCommand{
  380. command: "test",
  381. connection: connection,
  382. args: []string{},
  383. }
  384. assert.Equal(t, "", sshCommand.getDestPath())
  385. sshCommand.args = []string{"-t", "/tmp/../path"}
  386. assert.Equal(t, "/path", sshCommand.getDestPath())
  387. sshCommand.args = []string{"-t", "/tmp/"}
  388. assert.Equal(t, "/tmp/", sshCommand.getDestPath())
  389. sshCommand.args = []string{"-t", "tmp/"}
  390. assert.Equal(t, "/tmp/", sshCommand.getDestPath())
  391. sshCommand.args = []string{"-t", "/tmp/../../../path"}
  392. assert.Equal(t, "/path", sshCommand.getDestPath())
  393. sshCommand.args = []string{"-t", ".."}
  394. assert.Equal(t, "/", sshCommand.getDestPath())
  395. sshCommand.args = []string{"-t", "."}
  396. assert.Equal(t, "/", sshCommand.getDestPath())
  397. sshCommand.args = []string{"-t", "//"}
  398. assert.Equal(t, "/", sshCommand.getDestPath())
  399. sshCommand.args = []string{"-t", "../.."}
  400. assert.Equal(t, "/", sshCommand.getDestPath())
  401. sshCommand.args = []string{"-t", "/.."}
  402. assert.Equal(t, "/", sshCommand.getDestPath())
  403. sshCommand.args = []string{"-f", "/a space.txt"}
  404. assert.Equal(t, "/a space.txt", sshCommand.getDestPath())
  405. }
  406. func TestSSHParseCommandPayload(t *testing.T) {
  407. cmd := "command -a -f /ab\\ à/some\\ spaces\\ \\ \\(\\).txt"
  408. name, args, _ := parseCommandPayload(cmd)
  409. assert.Equal(t, "command", name)
  410. assert.Equal(t, 3, len(args))
  411. assert.Equal(t, "/ab à/some spaces ().txt", args[2])
  412. _, _, err := parseCommandPayload("")
  413. assert.Error(t, err, "parsing invalid command must fail")
  414. }
  415. func TestSSHCommandErrors(t *testing.T) {
  416. buf := make([]byte, 65535)
  417. stdErrBuf := make([]byte, 65535)
  418. readErr := fmt.Errorf("test read error")
  419. mockSSHChannel := MockChannel{
  420. Buffer: bytes.NewBuffer(buf),
  421. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  422. ReadError: readErr,
  423. }
  424. server, client := net.Pipe()
  425. defer func() {
  426. err := server.Close()
  427. assert.NoError(t, err)
  428. }()
  429. defer func() {
  430. err := client.Close()
  431. assert.NoError(t, err)
  432. }()
  433. user := dataprovider.User{}
  434. user.Permissions = map[string][]string{
  435. "/": {dataprovider.PermAny},
  436. }
  437. connection := Connection{
  438. BaseConnection: common.NewBaseConnection("", common.ProtocolSSH, "", "", user),
  439. channel: &mockSSHChannel,
  440. }
  441. cmd := sshCommand{
  442. command: "md5sum",
  443. connection: &connection,
  444. args: []string{},
  445. }
  446. err := cmd.handle()
  447. assert.Error(t, err, "ssh command must fail, we are sending a fake error")
  448. cmd = sshCommand{
  449. command: "md5sum",
  450. connection: &connection,
  451. args: []string{"/../../test_file_ftp.dat"},
  452. }
  453. err = cmd.handle()
  454. assert.Error(t, err, "ssh command must fail, we are requesting an invalid path")
  455. cmd = sshCommand{
  456. command: "git-receive-pack",
  457. connection: &connection,
  458. args: []string{"/../../testrepo"},
  459. }
  460. err = cmd.handle()
  461. assert.Error(t, err, "ssh command must fail, we are requesting an invalid path")
  462. user = dataprovider.User{}
  463. user.Permissions = map[string][]string{
  464. "/": {dataprovider.PermAny},
  465. }
  466. user.HomeDir = filepath.Clean(os.TempDir())
  467. user.QuotaFiles = 1
  468. user.UsedQuotaFiles = 2
  469. cmd.connection.User = user
  470. fs, err := cmd.connection.User.GetFilesystem("123")
  471. assert.NoError(t, err)
  472. err = cmd.handle()
  473. assert.EqualError(t, err, common.ErrQuotaExceeded.Error())
  474. cmd.connection.User.QuotaFiles = 0
  475. cmd.connection.User.UsedQuotaFiles = 0
  476. cmd.connection.User.Permissions = make(map[string][]string)
  477. cmd.connection.User.Permissions["/"] = []string{dataprovider.PermListItems}
  478. err = cmd.handle()
  479. assert.EqualError(t, err, common.ErrPermissionDenied.Error())
  480. cmd.connection.User.Permissions["/"] = []string{dataprovider.PermAny}
  481. cmd.command = "invalid_command"
  482. command, err := cmd.getSystemCommand()
  483. assert.NoError(t, err)
  484. err = cmd.executeSystemCommand(command)
  485. assert.Error(t, err, "invalid command must fail")
  486. command, err = cmd.getSystemCommand()
  487. assert.NoError(t, err)
  488. _, err = command.cmd.StderrPipe()
  489. assert.NoError(t, err)
  490. err = cmd.executeSystemCommand(command)
  491. assert.Error(t, err, "command must fail, pipe was already assigned")
  492. err = cmd.executeSystemCommand(command)
  493. assert.Error(t, err, "command must fail, pipe was already assigned")
  494. command, err = cmd.getSystemCommand()
  495. assert.NoError(t, err)
  496. _, err = command.cmd.StdoutPipe()
  497. assert.NoError(t, err)
  498. err = cmd.executeSystemCommand(command)
  499. assert.Error(t, err, "command must fail, pipe was already assigned")
  500. cmd = sshCommand{
  501. command: "sftpgo-remove",
  502. connection: &connection,
  503. args: []string{"/../../src"},
  504. }
  505. err = cmd.handle()
  506. assert.Error(t, err, "ssh command must fail, we are requesting an invalid path")
  507. cmd = sshCommand{
  508. command: "sftpgo-copy",
  509. connection: &connection,
  510. args: []string{"/../../test_src", "."},
  511. }
  512. err = cmd.handle()
  513. assert.Error(t, err, "ssh command must fail, we are requesting an invalid path")
  514. cmd.connection.User.HomeDir = filepath.Clean(os.TempDir())
  515. cmd = sshCommand{
  516. command: "sftpgo-copy",
  517. connection: &connection,
  518. args: []string{"src", "dst"},
  519. }
  520. cmd.connection.User.Permissions = make(map[string][]string)
  521. cmd.connection.User.Permissions["/"] = []string{dataprovider.PermAny}
  522. if runtime.GOOS != osWindows {
  523. aDir := filepath.Join(os.TempDir(), "adir")
  524. err = os.MkdirAll(aDir, os.ModePerm)
  525. assert.NoError(t, err)
  526. tmpFile := filepath.Join(aDir, "testcopy")
  527. err = os.WriteFile(tmpFile, []byte("aaa"), os.ModePerm)
  528. assert.NoError(t, err)
  529. err = os.Chmod(aDir, 0001)
  530. assert.NoError(t, err)
  531. err = cmd.checkCopyDestination(fs, tmpFile)
  532. assert.Error(t, err)
  533. err = os.Chmod(aDir, os.ModePerm)
  534. assert.NoError(t, err)
  535. err = os.Remove(tmpFile)
  536. assert.NoError(t, err)
  537. }
  538. common.WaitForTransfers(1)
  539. _, err = cmd.getSystemCommand()
  540. if assert.Error(t, err) {
  541. assert.Contains(t, err.Error(), common.ErrShuttingDown.Error())
  542. }
  543. err = common.Initialize(common.Config, 0)
  544. assert.NoError(t, err)
  545. }
  546. func TestCommandsWithExtensionsFilter(t *testing.T) {
  547. buf := make([]byte, 65535)
  548. stdErrBuf := make([]byte, 65535)
  549. mockSSHChannel := MockChannel{
  550. Buffer: bytes.NewBuffer(buf),
  551. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  552. }
  553. server, client := net.Pipe()
  554. defer server.Close()
  555. defer client.Close()
  556. user := dataprovider.User{
  557. BaseUser: sdk.BaseUser{
  558. Username: "test",
  559. HomeDir: os.TempDir(),
  560. Status: 1,
  561. },
  562. }
  563. user.Filters.FilePatterns = []sdk.PatternsFilter{
  564. {
  565. Path: "/subdir",
  566. AllowedPatterns: []string{".jpg"},
  567. DeniedPatterns: []string{},
  568. },
  569. }
  570. connection := &Connection{
  571. BaseConnection: common.NewBaseConnection("", common.ProtocolSSH, "", "", user),
  572. channel: &mockSSHChannel,
  573. }
  574. cmd := sshCommand{
  575. command: "md5sum",
  576. connection: connection,
  577. args: []string{"subdir/test.png"},
  578. }
  579. err := cmd.handleHashCommands()
  580. assert.EqualError(t, err, common.ErrPermissionDenied.Error())
  581. cmd = sshCommand{
  582. command: "rsync",
  583. connection: connection,
  584. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  585. }
  586. _, err = cmd.getSystemCommand()
  587. assert.EqualError(t, err, errUnsupportedConfig.Error())
  588. cmd = sshCommand{
  589. command: "git-receive-pack",
  590. connection: connection,
  591. args: []string{"/subdir"},
  592. }
  593. _, err = cmd.getSystemCommand()
  594. assert.EqualError(t, err, errUnsupportedConfig.Error())
  595. cmd = sshCommand{
  596. command: "git-receive-pack",
  597. connection: connection,
  598. args: []string{"/subdir/dir"},
  599. }
  600. _, err = cmd.getSystemCommand()
  601. assert.EqualError(t, err, errUnsupportedConfig.Error())
  602. cmd = sshCommand{
  603. command: "git-receive-pack",
  604. connection: connection,
  605. args: []string{"/adir/subdir"},
  606. }
  607. _, err = cmd.getSystemCommand()
  608. assert.NoError(t, err)
  609. }
  610. func TestSSHCommandsRemoteFs(t *testing.T) {
  611. buf := make([]byte, 65535)
  612. stdErrBuf := make([]byte, 65535)
  613. mockSSHChannel := MockChannel{
  614. Buffer: bytes.NewBuffer(buf),
  615. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  616. }
  617. user := dataprovider.User{}
  618. user.FsConfig = vfs.Filesystem{
  619. Provider: sdk.S3FilesystemProvider,
  620. S3Config: vfs.S3FsConfig{
  621. BaseS3FsConfig: sdk.BaseS3FsConfig{
  622. Bucket: "s3bucket",
  623. Endpoint: "endpoint",
  624. Region: "eu-west-1",
  625. },
  626. },
  627. }
  628. connection := &Connection{
  629. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  630. channel: &mockSSHChannel,
  631. }
  632. cmd := sshCommand{
  633. command: "md5sum",
  634. connection: connection,
  635. args: []string{},
  636. }
  637. command, err := cmd.getSystemCommand()
  638. assert.NoError(t, err)
  639. err = cmd.executeSystemCommand(command)
  640. assert.Error(t, err, "command must fail for a non local filesystem")
  641. cmd = sshCommand{
  642. command: "sftpgo-copy",
  643. connection: connection,
  644. args: []string{},
  645. }
  646. err = cmd.handleSFTPGoCopy()
  647. assert.Error(t, err)
  648. cmd = sshCommand{
  649. command: "sftpgo-remove",
  650. connection: connection,
  651. args: []string{},
  652. }
  653. err = cmd.handleSFTPGoRemove()
  654. assert.Error(t, err)
  655. // the user has no permissions
  656. assert.False(t, cmd.hasCopyPermissions("", "", nil))
  657. }
  658. func TestSSHCmdGetFsErrors(t *testing.T) {
  659. buf := make([]byte, 65535)
  660. stdErrBuf := make([]byte, 65535)
  661. mockSSHChannel := MockChannel{
  662. Buffer: bytes.NewBuffer(buf),
  663. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  664. }
  665. user := dataprovider.User{
  666. BaseUser: sdk.BaseUser{
  667. HomeDir: "relative path",
  668. },
  669. }
  670. user.Permissions = map[string][]string{}
  671. user.Permissions["/"] = []string{dataprovider.PermAny}
  672. connection := &Connection{
  673. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  674. channel: &mockSSHChannel,
  675. }
  676. cmd := sshCommand{
  677. command: "sftpgo-remove",
  678. connection: connection,
  679. args: []string{"path"},
  680. }
  681. err := cmd.handleSFTPGoRemove()
  682. assert.Error(t, err)
  683. cmd = sshCommand{
  684. command: "sftpgo-copy",
  685. connection: connection,
  686. args: []string{"path1", "path2"},
  687. }
  688. _, _, _, _, _, _, err = cmd.getFsAndCopyPaths() //nolint:dogsled
  689. assert.Error(t, err)
  690. user = dataprovider.User{}
  691. user.HomeDir = filepath.Join(os.TempDir(), "home")
  692. user.VirtualFolders = append(connection.User.VirtualFolders, vfs.VirtualFolder{
  693. BaseVirtualFolder: vfs.BaseVirtualFolder{
  694. MappedPath: "relative",
  695. },
  696. VirtualPath: "/vpath",
  697. })
  698. connection.User = user
  699. err = os.MkdirAll(user.GetHomeDir(), os.ModePerm)
  700. assert.NoError(t, err)
  701. cmd = sshCommand{
  702. command: "sftpgo-copy",
  703. connection: connection,
  704. args: []string{"path1", "/vpath/path2"},
  705. }
  706. _, _, _, _, _, _, err = cmd.getFsAndCopyPaths() //nolint:dogsled
  707. assert.Error(t, err)
  708. err = os.Remove(user.GetHomeDir())
  709. assert.NoError(t, err)
  710. }
  711. func TestGitVirtualFolders(t *testing.T) {
  712. permissions := make(map[string][]string)
  713. permissions["/"] = []string{dataprovider.PermAny}
  714. user := dataprovider.User{
  715. BaseUser: sdk.BaseUser{
  716. Permissions: permissions,
  717. HomeDir: os.TempDir(),
  718. },
  719. }
  720. conn := &Connection{
  721. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  722. }
  723. cmd := sshCommand{
  724. command: "git-receive-pack",
  725. connection: conn,
  726. args: []string{"/vdir"},
  727. }
  728. cmd.connection.User.VirtualFolders = append(cmd.connection.User.VirtualFolders, vfs.VirtualFolder{
  729. BaseVirtualFolder: vfs.BaseVirtualFolder{
  730. MappedPath: os.TempDir(),
  731. },
  732. VirtualPath: "/vdir",
  733. })
  734. _, err := cmd.getSystemCommand()
  735. assert.NoError(t, err)
  736. cmd.args = []string{"/"}
  737. _, err = cmd.getSystemCommand()
  738. assert.EqualError(t, err, errUnsupportedConfig.Error())
  739. cmd.args = []string{"/vdir1"}
  740. _, err = cmd.getSystemCommand()
  741. assert.NoError(t, err)
  742. cmd.connection.User.VirtualFolders = nil
  743. cmd.connection.User.VirtualFolders = append(cmd.connection.User.VirtualFolders, vfs.VirtualFolder{
  744. BaseVirtualFolder: vfs.BaseVirtualFolder{
  745. MappedPath: os.TempDir(),
  746. },
  747. VirtualPath: "/vdir",
  748. })
  749. cmd.args = []string{"/vdir/subdir"}
  750. _, err = cmd.getSystemCommand()
  751. assert.NoError(t, err)
  752. cmd.args = []string{"/adir/subdir"}
  753. _, err = cmd.getSystemCommand()
  754. assert.NoError(t, err)
  755. }
  756. func TestRsyncOptions(t *testing.T) {
  757. permissions := make(map[string][]string)
  758. permissions["/"] = []string{dataprovider.PermAny}
  759. user := dataprovider.User{
  760. BaseUser: sdk.BaseUser{
  761. Permissions: permissions,
  762. HomeDir: os.TempDir(),
  763. },
  764. }
  765. conn := &Connection{
  766. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  767. }
  768. sshCmd := sshCommand{
  769. command: "rsync",
  770. connection: conn,
  771. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  772. }
  773. cmd, err := sshCmd.getSystemCommand()
  774. assert.NoError(t, err)
  775. assert.True(t, util.Contains(cmd.cmd.Args, "--safe-links"),
  776. "--safe-links must be added if the user has the create symlinks permission")
  777. permissions["/"] = []string{dataprovider.PermDownload, dataprovider.PermUpload, dataprovider.PermCreateDirs,
  778. dataprovider.PermListItems, dataprovider.PermOverwrite, dataprovider.PermDelete, dataprovider.PermRename}
  779. user.Permissions = permissions
  780. conn = &Connection{
  781. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  782. }
  783. sshCmd = sshCommand{
  784. command: "rsync",
  785. connection: conn,
  786. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  787. }
  788. cmd, err = sshCmd.getSystemCommand()
  789. assert.NoError(t, err)
  790. assert.True(t, util.Contains(cmd.cmd.Args, "--munge-links"),
  791. "--munge-links must be added if the user has the create symlinks permission")
  792. sshCmd.connection.User.VirtualFolders = append(sshCmd.connection.User.VirtualFolders, vfs.VirtualFolder{
  793. BaseVirtualFolder: vfs.BaseVirtualFolder{
  794. MappedPath: os.TempDir(),
  795. },
  796. VirtualPath: "/vdir",
  797. })
  798. _, err = sshCmd.getSystemCommand()
  799. assert.EqualError(t, err, errUnsupportedConfig.Error())
  800. }
  801. func TestSystemCommandSizeForPath(t *testing.T) {
  802. permissions := make(map[string][]string)
  803. permissions["/"] = []string{dataprovider.PermAny}
  804. user := dataprovider.User{
  805. BaseUser: sdk.BaseUser{
  806. Permissions: permissions,
  807. HomeDir: os.TempDir(),
  808. },
  809. }
  810. fs, err := user.GetFilesystem("123")
  811. assert.NoError(t, err)
  812. conn := &Connection{
  813. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  814. }
  815. sshCmd := sshCommand{
  816. command: "rsync",
  817. connection: conn,
  818. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  819. }
  820. _, _, err = sshCmd.getSizeForPath(fs, "missing path")
  821. assert.NoError(t, err)
  822. testDir := filepath.Join(os.TempDir(), "dir")
  823. err = os.MkdirAll(testDir, os.ModePerm)
  824. assert.NoError(t, err)
  825. testFile := filepath.Join(testDir, "testfile")
  826. err = os.WriteFile(testFile, []byte("test content"), os.ModePerm)
  827. assert.NoError(t, err)
  828. err = os.Symlink(testFile, testFile+".link")
  829. assert.NoError(t, err)
  830. numFiles, size, err := sshCmd.getSizeForPath(fs, testFile+".link")
  831. assert.NoError(t, err)
  832. assert.Equal(t, 0, numFiles)
  833. assert.Equal(t, int64(0), size)
  834. numFiles, size, err = sshCmd.getSizeForPath(fs, testFile)
  835. assert.NoError(t, err)
  836. assert.Equal(t, 1, numFiles)
  837. assert.Equal(t, int64(12), size)
  838. if runtime.GOOS != osWindows {
  839. err = os.Chmod(testDir, 0001)
  840. assert.NoError(t, err)
  841. _, _, err = sshCmd.getSizeForPath(fs, testFile)
  842. assert.Error(t, err)
  843. err = os.Chmod(testDir, os.ModePerm)
  844. assert.NoError(t, err)
  845. }
  846. err = os.RemoveAll(testDir)
  847. assert.NoError(t, err)
  848. }
  849. func TestSystemCommandErrors(t *testing.T) {
  850. buf := make([]byte, 65535)
  851. stdErrBuf := make([]byte, 65535)
  852. readErr := fmt.Errorf("test read error")
  853. writeErr := fmt.Errorf("test write error")
  854. mockSSHChannel := MockChannel{
  855. Buffer: bytes.NewBuffer(buf),
  856. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  857. ReadError: nil,
  858. WriteError: writeErr,
  859. }
  860. permissions := make(map[string][]string)
  861. permissions["/"] = []string{dataprovider.PermAny}
  862. homeDir := filepath.Join(os.TempDir(), "adir")
  863. err := os.MkdirAll(homeDir, os.ModePerm)
  864. assert.NoError(t, err)
  865. err = os.WriteFile(filepath.Join(homeDir, "afile"), []byte("content"), os.ModePerm)
  866. assert.NoError(t, err)
  867. user := dataprovider.User{
  868. BaseUser: sdk.BaseUser{
  869. Permissions: permissions,
  870. HomeDir: homeDir,
  871. },
  872. }
  873. fs, err := user.GetFilesystem("123")
  874. assert.NoError(t, err)
  875. connection := &Connection{
  876. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  877. channel: &mockSSHChannel,
  878. }
  879. var sshCmd sshCommand
  880. if runtime.GOOS == osWindows {
  881. sshCmd = sshCommand{
  882. command: "dir",
  883. connection: connection,
  884. args: []string{"/"},
  885. }
  886. } else {
  887. sshCmd = sshCommand{
  888. command: "ls",
  889. connection: connection,
  890. args: []string{"/"},
  891. }
  892. }
  893. systemCmd, err := sshCmd.getSystemCommand()
  894. assert.NoError(t, err)
  895. systemCmd.cmd.Dir = os.TempDir()
  896. // FIXME: the command completes but the fake client is unable to read the response
  897. // no error is reported in this case. We can see that the expected code is executed
  898. // reading the test coverage
  899. sshCmd.executeSystemCommand(systemCmd) //nolint:errcheck
  900. mockSSHChannel = MockChannel{
  901. Buffer: bytes.NewBuffer(buf),
  902. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  903. ReadError: readErr,
  904. WriteError: nil,
  905. }
  906. sshCmd.connection.channel = &mockSSHChannel
  907. baseTransfer := common.NewBaseTransfer(nil, sshCmd.connection.BaseConnection, nil, "", "", "",
  908. common.TransferUpload, 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  909. transfer := newTransfer(baseTransfer, nil, nil, nil)
  910. destBuff := make([]byte, 65535)
  911. dst := bytes.NewBuffer(destBuff)
  912. _, err = transfer.copyFromReaderToWriter(dst, sshCmd.connection.channel)
  913. assert.EqualError(t, err, readErr.Error())
  914. mockSSHChannel = MockChannel{
  915. Buffer: bytes.NewBuffer(buf),
  916. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  917. ReadError: nil,
  918. WriteError: nil,
  919. }
  920. sshCmd.connection.channel = &mockSSHChannel
  921. transfer.MaxWriteSize = 1
  922. _, err = transfer.copyFromReaderToWriter(dst, sshCmd.connection.channel)
  923. assert.True(t, transfer.Connection.IsQuotaExceededError(err))
  924. mockSSHChannel = MockChannel{
  925. Buffer: bytes.NewBuffer(buf),
  926. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  927. ReadError: nil,
  928. WriteError: nil,
  929. ShortWriteErr: true,
  930. }
  931. sshCmd.connection.channel = &mockSSHChannel
  932. _, err = transfer.copyFromReaderToWriter(sshCmd.connection.channel, dst)
  933. assert.EqualError(t, err, io.ErrShortWrite.Error())
  934. transfer.MaxWriteSize = -1
  935. _, err = transfer.copyFromReaderToWriter(sshCmd.connection.channel, dst)
  936. assert.True(t, transfer.Connection.IsQuotaExceededError(err))
  937. baseTransfer = common.NewBaseTransfer(nil, sshCmd.connection.BaseConnection, nil, "", "", "",
  938. common.TransferDownload, 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{
  939. AllowedDLSize: 1,
  940. })
  941. transfer = newTransfer(baseTransfer, nil, nil, nil)
  942. mockSSHChannel = MockChannel{
  943. Buffer: bytes.NewBuffer(buf),
  944. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  945. ReadError: nil,
  946. WriteError: nil,
  947. }
  948. sshCmd.connection.channel = &mockSSHChannel
  949. _, err = transfer.copyFromReaderToWriter(dst, sshCmd.connection.channel)
  950. if assert.Error(t, err) {
  951. assert.Contains(t, err.Error(), common.ErrReadQuotaExceeded.Error())
  952. }
  953. err = os.RemoveAll(homeDir)
  954. assert.NoError(t, err)
  955. }
  956. func TestCommandGetFsError(t *testing.T) {
  957. user := dataprovider.User{
  958. FsConfig: vfs.Filesystem{
  959. Provider: sdk.CryptedFilesystemProvider,
  960. },
  961. }
  962. conn := &Connection{
  963. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  964. }
  965. sshCmd := sshCommand{
  966. command: "rsync",
  967. connection: conn,
  968. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  969. }
  970. _, err := sshCmd.getSystemCommand()
  971. assert.Error(t, err)
  972. buf := make([]byte, 65535)
  973. stdErrBuf := make([]byte, 65535)
  974. mockSSHChannel := MockChannel{
  975. Buffer: bytes.NewBuffer(buf),
  976. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  977. ReadError: nil,
  978. }
  979. conn = &Connection{
  980. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", user),
  981. channel: &mockSSHChannel,
  982. }
  983. scpCommand := scpCommand{
  984. sshCommand: sshCommand{
  985. command: "scp",
  986. connection: conn,
  987. args: []string{"-t", "/tmp"},
  988. },
  989. }
  990. err = scpCommand.handleRecursiveUpload()
  991. assert.Error(t, err)
  992. err = scpCommand.handleDownload("")
  993. assert.Error(t, err)
  994. }
  995. func TestGetConnectionInfo(t *testing.T) {
  996. c := common.ConnectionStatus{
  997. Username: "test_user",
  998. ConnectionID: "123",
  999. ClientVersion: "client",
  1000. RemoteAddress: "127.0.0.1:1234",
  1001. Protocol: common.ProtocolSSH,
  1002. Command: "sha1sum /test_file_ftp.dat",
  1003. }
  1004. info := c.GetConnectionInfo()
  1005. assert.Contains(t, info, "sha1sum /test_file_ftp.dat")
  1006. }
  1007. func TestSCPFileMode(t *testing.T) {
  1008. mode := getFileModeAsString(0, true)
  1009. assert.Equal(t, "0755", mode)
  1010. mode = getFileModeAsString(0700, true)
  1011. assert.Equal(t, "0700", mode)
  1012. mode = getFileModeAsString(0750, true)
  1013. assert.Equal(t, "0750", mode)
  1014. mode = getFileModeAsString(0777, true)
  1015. assert.Equal(t, "0777", mode)
  1016. mode = getFileModeAsString(0640, false)
  1017. assert.Equal(t, "0640", mode)
  1018. mode = getFileModeAsString(0600, false)
  1019. assert.Equal(t, "0600", mode)
  1020. mode = getFileModeAsString(0, false)
  1021. assert.Equal(t, "0644", mode)
  1022. fileMode := uint32(0777)
  1023. fileMode = fileMode | uint32(os.ModeSetgid)
  1024. fileMode = fileMode | uint32(os.ModeSetuid)
  1025. fileMode = fileMode | uint32(os.ModeSticky)
  1026. mode = getFileModeAsString(os.FileMode(fileMode), false)
  1027. assert.Equal(t, "7777", mode)
  1028. fileMode = uint32(0644)
  1029. fileMode = fileMode | uint32(os.ModeSetgid)
  1030. mode = getFileModeAsString(os.FileMode(fileMode), false)
  1031. assert.Equal(t, "4644", mode)
  1032. fileMode = uint32(0600)
  1033. fileMode = fileMode | uint32(os.ModeSetuid)
  1034. mode = getFileModeAsString(os.FileMode(fileMode), false)
  1035. assert.Equal(t, "2600", mode)
  1036. fileMode = uint32(0044)
  1037. fileMode = fileMode | uint32(os.ModeSticky)
  1038. mode = getFileModeAsString(os.FileMode(fileMode), false)
  1039. assert.Equal(t, "1044", mode)
  1040. }
  1041. func TestSCPUploadError(t *testing.T) {
  1042. buf := make([]byte, 65535)
  1043. stdErrBuf := make([]byte, 65535)
  1044. writeErr := fmt.Errorf("test write error")
  1045. mockSSHChannel := MockChannel{
  1046. Buffer: bytes.NewBuffer(buf),
  1047. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1048. ReadError: nil,
  1049. WriteError: writeErr,
  1050. }
  1051. user := dataprovider.User{
  1052. BaseUser: sdk.BaseUser{
  1053. HomeDir: filepath.Join(os.TempDir()),
  1054. Permissions: make(map[string][]string),
  1055. },
  1056. }
  1057. user.Permissions["/"] = []string{dataprovider.PermAny}
  1058. connection := &Connection{
  1059. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  1060. channel: &mockSSHChannel,
  1061. }
  1062. scpCommand := scpCommand{
  1063. sshCommand: sshCommand{
  1064. command: "scp",
  1065. connection: connection,
  1066. args: []string{"-t", "/"},
  1067. },
  1068. }
  1069. err := scpCommand.handle()
  1070. assert.EqualError(t, err, writeErr.Error())
  1071. mockSSHChannel = MockChannel{
  1072. Buffer: bytes.NewBuffer([]byte("D0755 0 testdir\n")),
  1073. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1074. ReadError: nil,
  1075. WriteError: writeErr,
  1076. }
  1077. err = scpCommand.handleRecursiveUpload()
  1078. assert.EqualError(t, err, writeErr.Error())
  1079. mockSSHChannel = MockChannel{
  1080. Buffer: bytes.NewBuffer([]byte("D0755 a testdir\n")),
  1081. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1082. ReadError: nil,
  1083. WriteError: nil,
  1084. }
  1085. err = scpCommand.handleRecursiveUpload()
  1086. assert.Error(t, err)
  1087. }
  1088. func TestSCPInvalidEndDir(t *testing.T) {
  1089. stdErrBuf := make([]byte, 65535)
  1090. mockSSHChannel := MockChannel{
  1091. Buffer: bytes.NewBuffer([]byte("E\n")),
  1092. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1093. }
  1094. connection := &Connection{
  1095. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", dataprovider.User{
  1096. BaseUser: sdk.BaseUser{
  1097. HomeDir: os.TempDir(),
  1098. },
  1099. }),
  1100. channel: &mockSSHChannel,
  1101. }
  1102. scpCommand := scpCommand{
  1103. sshCommand: sshCommand{
  1104. command: "scp",
  1105. connection: connection,
  1106. args: []string{"-t", "/tmp"},
  1107. },
  1108. }
  1109. err := scpCommand.handleRecursiveUpload()
  1110. assert.EqualError(t, err, "unacceptable end dir command")
  1111. }
  1112. func TestSCPParseUploadMessage(t *testing.T) {
  1113. buf := make([]byte, 65535)
  1114. stdErrBuf := make([]byte, 65535)
  1115. mockSSHChannel := MockChannel{
  1116. Buffer: bytes.NewBuffer(buf),
  1117. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1118. ReadError: nil,
  1119. }
  1120. fs := vfs.NewOsFs("", os.TempDir(), "")
  1121. connection := &Connection{
  1122. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", dataprovider.User{
  1123. BaseUser: sdk.BaseUser{
  1124. HomeDir: os.TempDir(),
  1125. },
  1126. }),
  1127. channel: &mockSSHChannel,
  1128. }
  1129. scpCommand := scpCommand{
  1130. sshCommand: sshCommand{
  1131. command: "scp",
  1132. connection: connection,
  1133. args: []string{"-t", "/tmp"},
  1134. },
  1135. }
  1136. _, _, err := scpCommand.parseUploadMessage(fs, "invalid")
  1137. assert.Error(t, err, "parsing invalid upload message must fail")
  1138. _, _, err = scpCommand.parseUploadMessage(fs, "D0755 0")
  1139. assert.Error(t, err, "parsing incomplete upload message must fail")
  1140. _, _, err = scpCommand.parseUploadMessage(fs, "D0755 invalidsize testdir")
  1141. assert.Error(t, err, "parsing upload message with invalid size must fail")
  1142. _, _, err = scpCommand.parseUploadMessage(fs, "D0755 0 ")
  1143. assert.Error(t, err, "parsing upload message with invalid name must fail")
  1144. }
  1145. func TestSCPProtocolMessages(t *testing.T) {
  1146. buf := make([]byte, 65535)
  1147. stdErrBuf := make([]byte, 65535)
  1148. readErr := fmt.Errorf("test read error")
  1149. writeErr := fmt.Errorf("test write error")
  1150. mockSSHChannel := MockChannel{
  1151. Buffer: bytes.NewBuffer(buf),
  1152. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1153. ReadError: readErr,
  1154. WriteError: writeErr,
  1155. }
  1156. connection := &Connection{
  1157. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{}),
  1158. channel: &mockSSHChannel,
  1159. }
  1160. scpCommand := scpCommand{
  1161. sshCommand: sshCommand{
  1162. command: "scp",
  1163. connection: connection,
  1164. args: []string{"-t", "/tmp"},
  1165. },
  1166. }
  1167. _, err := scpCommand.readProtocolMessage()
  1168. assert.EqualError(t, err, readErr.Error())
  1169. err = scpCommand.sendConfirmationMessage()
  1170. assert.EqualError(t, err, writeErr.Error())
  1171. err = scpCommand.sendProtocolMessage("E\n")
  1172. assert.EqualError(t, err, writeErr.Error())
  1173. _, err = scpCommand.getNextUploadProtocolMessage()
  1174. assert.EqualError(t, err, readErr.Error())
  1175. mockSSHChannel = MockChannel{
  1176. Buffer: bytes.NewBuffer([]byte("T1183832947 0 1183833773 0\n")),
  1177. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1178. ReadError: nil,
  1179. WriteError: writeErr,
  1180. }
  1181. scpCommand.connection.channel = &mockSSHChannel
  1182. _, err = scpCommand.getNextUploadProtocolMessage()
  1183. assert.EqualError(t, err, writeErr.Error())
  1184. respBuffer := []byte{0x02}
  1185. protocolErrorMsg := "protocol error msg"
  1186. respBuffer = append(respBuffer, protocolErrorMsg...)
  1187. respBuffer = append(respBuffer, 0x0A)
  1188. mockSSHChannel = MockChannel{
  1189. Buffer: bytes.NewBuffer(respBuffer),
  1190. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1191. ReadError: nil,
  1192. WriteError: nil,
  1193. }
  1194. scpCommand.connection.channel = &mockSSHChannel
  1195. err = scpCommand.readConfirmationMessage()
  1196. if assert.Error(t, err) {
  1197. assert.Equal(t, protocolErrorMsg, err.Error())
  1198. }
  1199. }
  1200. func TestSCPTestDownloadProtocolMessages(t *testing.T) {
  1201. buf := make([]byte, 65535)
  1202. stdErrBuf := make([]byte, 65535)
  1203. readErr := fmt.Errorf("test read error")
  1204. writeErr := fmt.Errorf("test write error")
  1205. mockSSHChannel := MockChannel{
  1206. Buffer: bytes.NewBuffer(buf),
  1207. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1208. ReadError: readErr,
  1209. WriteError: writeErr,
  1210. }
  1211. connection := &Connection{
  1212. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{}),
  1213. channel: &mockSSHChannel,
  1214. }
  1215. scpCommand := scpCommand{
  1216. sshCommand: sshCommand{
  1217. command: "scp",
  1218. connection: connection,
  1219. args: []string{"-f", "-p", "/tmp"},
  1220. },
  1221. }
  1222. path := "testDir"
  1223. err := os.Mkdir(path, os.ModePerm)
  1224. assert.NoError(t, err)
  1225. stat, err := os.Stat(path)
  1226. assert.NoError(t, err)
  1227. err = scpCommand.sendDownloadProtocolMessages(path, stat)
  1228. assert.EqualError(t, err, writeErr.Error())
  1229. mockSSHChannel = MockChannel{
  1230. Buffer: bytes.NewBuffer(buf),
  1231. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1232. ReadError: readErr,
  1233. WriteError: nil,
  1234. }
  1235. err = scpCommand.sendDownloadProtocolMessages(path, stat)
  1236. assert.EqualError(t, err, readErr.Error())
  1237. mockSSHChannel = MockChannel{
  1238. Buffer: bytes.NewBuffer(buf),
  1239. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1240. ReadError: readErr,
  1241. WriteError: writeErr,
  1242. }
  1243. scpCommand.args = []string{"-f", "/tmp"}
  1244. scpCommand.connection.channel = &mockSSHChannel
  1245. err = scpCommand.sendDownloadProtocolMessages(path, stat)
  1246. assert.EqualError(t, err, writeErr.Error())
  1247. mockSSHChannel = MockChannel{
  1248. Buffer: bytes.NewBuffer(buf),
  1249. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1250. ReadError: readErr,
  1251. WriteError: nil,
  1252. }
  1253. scpCommand.connection.channel = &mockSSHChannel
  1254. err = scpCommand.sendDownloadProtocolMessages(path, stat)
  1255. assert.EqualError(t, err, readErr.Error())
  1256. err = os.Remove(path)
  1257. assert.NoError(t, err)
  1258. }
  1259. func TestSCPCommandHandleErrors(t *testing.T) {
  1260. buf := make([]byte, 65535)
  1261. stdErrBuf := make([]byte, 65535)
  1262. readErr := fmt.Errorf("test read error")
  1263. writeErr := fmt.Errorf("test write error")
  1264. mockSSHChannel := MockChannel{
  1265. Buffer: bytes.NewBuffer(buf),
  1266. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1267. ReadError: readErr,
  1268. WriteError: writeErr,
  1269. }
  1270. server, client := net.Pipe()
  1271. defer func() {
  1272. err := server.Close()
  1273. assert.NoError(t, err)
  1274. }()
  1275. defer func() {
  1276. err := client.Close()
  1277. assert.NoError(t, err)
  1278. }()
  1279. connection := &Connection{
  1280. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{}),
  1281. channel: &mockSSHChannel,
  1282. }
  1283. scpCommand := scpCommand{
  1284. sshCommand: sshCommand{
  1285. command: "scp",
  1286. connection: connection,
  1287. args: []string{"-f", "/tmp"},
  1288. },
  1289. }
  1290. err := scpCommand.handle()
  1291. assert.EqualError(t, err, readErr.Error())
  1292. scpCommand.args = []string{"-i", "/tmp"}
  1293. err = scpCommand.handle()
  1294. assert.Error(t, err, "invalid scp command must fail")
  1295. }
  1296. func TestSCPErrorsMockFs(t *testing.T) {
  1297. errFake := errors.New("fake error")
  1298. u := dataprovider.User{}
  1299. u.Username = "test"
  1300. u.Permissions = make(map[string][]string)
  1301. u.Permissions["/"] = []string{dataprovider.PermAny}
  1302. u.HomeDir = os.TempDir()
  1303. buf := make([]byte, 65535)
  1304. stdErrBuf := make([]byte, 65535)
  1305. mockSSHChannel := MockChannel{
  1306. Buffer: bytes.NewBuffer(buf),
  1307. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1308. }
  1309. server, client := net.Pipe()
  1310. defer func() {
  1311. err := server.Close()
  1312. assert.NoError(t, err)
  1313. }()
  1314. defer func() {
  1315. err := client.Close()
  1316. assert.NoError(t, err)
  1317. }()
  1318. connection := &Connection{
  1319. channel: &mockSSHChannel,
  1320. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", u),
  1321. }
  1322. scpCommand := scpCommand{
  1323. sshCommand: sshCommand{
  1324. command: "scp",
  1325. connection: connection,
  1326. args: []string{"-r", "-t", "/tmp"},
  1327. },
  1328. }
  1329. testfile := filepath.Join(u.HomeDir, "testfile")
  1330. err := os.WriteFile(testfile, []byte("test"), os.ModePerm)
  1331. assert.NoError(t, err)
  1332. fs := newMockOsFs(errFake, nil, true, "123", os.TempDir())
  1333. err = scpCommand.handleUploadFile(fs, testfile, testfile, 0, false, 4, "/testfile")
  1334. assert.NoError(t, err)
  1335. err = os.Remove(testfile)
  1336. assert.NoError(t, err)
  1337. }
  1338. func TestSCPRecursiveDownloadErrors(t *testing.T) {
  1339. buf := make([]byte, 65535)
  1340. stdErrBuf := make([]byte, 65535)
  1341. readErr := fmt.Errorf("test read error")
  1342. writeErr := fmt.Errorf("test write error")
  1343. mockSSHChannel := MockChannel{
  1344. Buffer: bytes.NewBuffer(buf),
  1345. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1346. ReadError: readErr,
  1347. WriteError: writeErr,
  1348. }
  1349. server, client := net.Pipe()
  1350. defer func() {
  1351. err := server.Close()
  1352. assert.NoError(t, err)
  1353. }()
  1354. defer func() {
  1355. err := client.Close()
  1356. assert.NoError(t, err)
  1357. }()
  1358. fs := vfs.NewOsFs("123", os.TempDir(), "")
  1359. connection := &Connection{
  1360. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{
  1361. BaseUser: sdk.BaseUser{
  1362. HomeDir: os.TempDir(),
  1363. },
  1364. }),
  1365. channel: &mockSSHChannel,
  1366. }
  1367. scpCommand := scpCommand{
  1368. sshCommand: sshCommand{
  1369. command: "scp",
  1370. connection: connection,
  1371. args: []string{"-r", "-f", "/tmp"},
  1372. },
  1373. }
  1374. path := "testDir"
  1375. err := os.Mkdir(path, os.ModePerm)
  1376. assert.NoError(t, err)
  1377. stat, err := os.Stat(path)
  1378. assert.NoError(t, err)
  1379. err = scpCommand.handleRecursiveDownload(fs, "invalid_dir", "invalid_dir", stat)
  1380. assert.EqualError(t, err, writeErr.Error())
  1381. mockSSHChannel = MockChannel{
  1382. Buffer: bytes.NewBuffer(buf),
  1383. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1384. ReadError: nil,
  1385. WriteError: nil,
  1386. }
  1387. scpCommand.connection.channel = &mockSSHChannel
  1388. err = scpCommand.handleRecursiveDownload(fs, "invalid_dir", "invalid_dir", stat)
  1389. assert.Error(t, err, "recursive upload download must fail for a non existing dir")
  1390. err = os.Remove(path)
  1391. assert.NoError(t, err)
  1392. }
  1393. func TestSCPRecursiveUploadErrors(t *testing.T) {
  1394. buf := make([]byte, 65535)
  1395. stdErrBuf := make([]byte, 65535)
  1396. readErr := fmt.Errorf("test read error")
  1397. writeErr := fmt.Errorf("test write error")
  1398. mockSSHChannel := MockChannel{
  1399. Buffer: bytes.NewBuffer(buf),
  1400. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1401. ReadError: readErr,
  1402. WriteError: writeErr,
  1403. }
  1404. connection := &Connection{
  1405. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{}),
  1406. channel: &mockSSHChannel,
  1407. }
  1408. scpCommand := scpCommand{
  1409. sshCommand: sshCommand{
  1410. command: "scp",
  1411. connection: connection,
  1412. args: []string{"-r", "-t", "/tmp"},
  1413. },
  1414. }
  1415. err := scpCommand.handleRecursiveUpload()
  1416. assert.Error(t, err, "recursive upload must fail, we send a fake error message")
  1417. mockSSHChannel = MockChannel{
  1418. Buffer: bytes.NewBuffer(buf),
  1419. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1420. ReadError: readErr,
  1421. WriteError: nil,
  1422. }
  1423. scpCommand.connection.channel = &mockSSHChannel
  1424. err = scpCommand.handleRecursiveUpload()
  1425. assert.Error(t, err, "recursive upload must fail, we send a fake error message")
  1426. }
  1427. func TestSCPCreateDirs(t *testing.T) {
  1428. buf := make([]byte, 65535)
  1429. stdErrBuf := make([]byte, 65535)
  1430. u := dataprovider.User{}
  1431. u.HomeDir = "home_rel_path"
  1432. u.Username = "test"
  1433. u.Permissions = make(map[string][]string)
  1434. u.Permissions["/"] = []string{dataprovider.PermAny}
  1435. mockSSHChannel := MockChannel{
  1436. Buffer: bytes.NewBuffer(buf),
  1437. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1438. ReadError: nil,
  1439. WriteError: nil,
  1440. }
  1441. fs, err := u.GetFilesystem("123")
  1442. assert.NoError(t, err)
  1443. connection := &Connection{
  1444. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", u),
  1445. channel: &mockSSHChannel,
  1446. }
  1447. scpCommand := scpCommand{
  1448. sshCommand: sshCommand{
  1449. command: "scp",
  1450. connection: connection,
  1451. args: []string{"-r", "-t", "/tmp"},
  1452. },
  1453. }
  1454. err = scpCommand.handleCreateDir(fs, "invalid_dir")
  1455. assert.Error(t, err, "create invalid dir must fail")
  1456. }
  1457. func TestSCPDownloadFileData(t *testing.T) {
  1458. testfile := "testfile"
  1459. buf := make([]byte, 65535)
  1460. readErr := fmt.Errorf("test read error")
  1461. writeErr := fmt.Errorf("test write error")
  1462. stdErrBuf := make([]byte, 65535)
  1463. mockSSHChannelReadErr := MockChannel{
  1464. Buffer: bytes.NewBuffer(buf),
  1465. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1466. ReadError: readErr,
  1467. WriteError: nil,
  1468. }
  1469. mockSSHChannelWriteErr := MockChannel{
  1470. Buffer: bytes.NewBuffer(buf),
  1471. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1472. ReadError: nil,
  1473. WriteError: writeErr,
  1474. }
  1475. fs := vfs.NewOsFs("", os.TempDir(), "")
  1476. connection := &Connection{
  1477. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{BaseUser: sdk.BaseUser{HomeDir: os.TempDir()}}),
  1478. channel: &mockSSHChannelReadErr,
  1479. }
  1480. scpCommand := scpCommand{
  1481. sshCommand: sshCommand{
  1482. command: "scp",
  1483. connection: connection,
  1484. args: []string{"-r", "-f", "/tmp"},
  1485. },
  1486. }
  1487. err := os.WriteFile(testfile, []byte("test"), os.ModePerm)
  1488. assert.NoError(t, err)
  1489. stat, err := os.Stat(testfile)
  1490. assert.NoError(t, err)
  1491. err = scpCommand.sendDownloadFileData(fs, testfile, stat, nil)
  1492. assert.EqualError(t, err, readErr.Error())
  1493. scpCommand.connection.channel = &mockSSHChannelWriteErr
  1494. err = scpCommand.sendDownloadFileData(fs, testfile, stat, nil)
  1495. assert.EqualError(t, err, writeErr.Error())
  1496. scpCommand.args = []string{"-r", "-p", "-f", "/tmp"}
  1497. err = scpCommand.sendDownloadFileData(fs, testfile, stat, nil)
  1498. assert.EqualError(t, err, writeErr.Error())
  1499. scpCommand.connection.channel = &mockSSHChannelReadErr
  1500. err = scpCommand.sendDownloadFileData(fs, testfile, stat, nil)
  1501. assert.EqualError(t, err, readErr.Error())
  1502. err = os.Remove(testfile)
  1503. assert.NoError(t, err)
  1504. }
  1505. func TestSCPUploadFiledata(t *testing.T) {
  1506. testfile := "testfile"
  1507. buf := make([]byte, 65535)
  1508. stdErrBuf := make([]byte, 65535)
  1509. readErr := fmt.Errorf("test read error")
  1510. writeErr := fmt.Errorf("test write error")
  1511. mockSSHChannel := MockChannel{
  1512. Buffer: bytes.NewBuffer(buf),
  1513. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1514. ReadError: readErr,
  1515. WriteError: writeErr,
  1516. }
  1517. user := dataprovider.User{
  1518. BaseUser: sdk.BaseUser{
  1519. Username: "testuser",
  1520. },
  1521. }
  1522. fs := vfs.NewOsFs("", os.TempDir(), "")
  1523. connection := &Connection{
  1524. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", user),
  1525. channel: &mockSSHChannel,
  1526. }
  1527. scpCommand := scpCommand{
  1528. sshCommand: sshCommand{
  1529. command: "scp",
  1530. connection: connection,
  1531. args: []string{"-r", "-t", "/tmp"},
  1532. },
  1533. }
  1534. file, err := os.Create(testfile)
  1535. assert.NoError(t, err)
  1536. baseTransfer := common.NewBaseTransfer(file, scpCommand.connection.BaseConnection, nil, file.Name(), file.Name(),
  1537. "/"+testfile, common.TransferDownload, 0, 0, 0, 0, true, fs, dataprovider.TransferQuota{})
  1538. transfer := newTransfer(baseTransfer, nil, nil, nil)
  1539. err = scpCommand.getUploadFileData(2, transfer)
  1540. assert.Error(t, err, "upload must fail, we send a fake write error message")
  1541. mockSSHChannel = MockChannel{
  1542. Buffer: bytes.NewBuffer(buf),
  1543. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1544. ReadError: readErr,
  1545. WriteError: nil,
  1546. }
  1547. scpCommand.connection.channel = &mockSSHChannel
  1548. file, err = os.Create(testfile)
  1549. assert.NoError(t, err)
  1550. transfer.File = file
  1551. transfer.isFinished = false
  1552. transfer.Connection.AddTransfer(transfer)
  1553. err = scpCommand.getUploadFileData(2, transfer)
  1554. assert.Error(t, err, "upload must fail, we send a fake read error message")
  1555. respBuffer := []byte("12")
  1556. respBuffer = append(respBuffer, 0x02)
  1557. mockSSHChannel = MockChannel{
  1558. Buffer: bytes.NewBuffer(respBuffer),
  1559. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1560. ReadError: nil,
  1561. WriteError: nil,
  1562. }
  1563. scpCommand.connection.channel = &mockSSHChannel
  1564. file, err = os.Create(testfile)
  1565. assert.NoError(t, err)
  1566. baseTransfer.File = file
  1567. transfer = newTransfer(baseTransfer, nil, nil, nil)
  1568. transfer.Connection.AddTransfer(transfer)
  1569. err = scpCommand.getUploadFileData(2, transfer)
  1570. assert.Error(t, err, "upload must fail, we have not enough data to read")
  1571. // the file is already closed so we have an error on trasfer closing
  1572. mockSSHChannel = MockChannel{
  1573. Buffer: bytes.NewBuffer(buf),
  1574. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1575. ReadError: nil,
  1576. WriteError: nil,
  1577. }
  1578. transfer.Connection.AddTransfer(transfer)
  1579. err = scpCommand.getUploadFileData(0, transfer)
  1580. if assert.Error(t, err) {
  1581. assert.EqualError(t, err, common.ErrTransferClosed.Error())
  1582. }
  1583. mockSSHChannel = MockChannel{
  1584. Buffer: bytes.NewBuffer(buf),
  1585. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1586. ReadError: nil,
  1587. WriteError: nil,
  1588. }
  1589. transfer.Connection.AddTransfer(transfer)
  1590. err = scpCommand.getUploadFileData(2, transfer)
  1591. assert.True(t, errors.Is(err, os.ErrClosed))
  1592. err = os.Remove(testfile)
  1593. assert.NoError(t, err)
  1594. }
  1595. func TestUploadError(t *testing.T) {
  1596. common.Config.UploadMode = common.UploadModeAtomic
  1597. user := dataprovider.User{
  1598. BaseUser: sdk.BaseUser{
  1599. Username: "testuser",
  1600. },
  1601. }
  1602. fs := vfs.NewOsFs("", os.TempDir(), "")
  1603. connection := &Connection{
  1604. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", user),
  1605. }
  1606. testfile := "testfile"
  1607. fileTempName := "temptestfile"
  1608. file, err := os.Create(fileTempName)
  1609. assert.NoError(t, err)
  1610. baseTransfer := common.NewBaseTransfer(file, connection.BaseConnection, nil, testfile, file.Name(),
  1611. testfile, common.TransferUpload, 0, 0, 0, 0, true, fs, dataprovider.TransferQuota{})
  1612. transfer := newTransfer(baseTransfer, nil, nil, nil)
  1613. errFake := errors.New("fake error")
  1614. transfer.TransferError(errFake)
  1615. err = transfer.Close()
  1616. if assert.Error(t, err) {
  1617. assert.EqualError(t, err, common.ErrGenericFailure.Error())
  1618. }
  1619. if assert.Error(t, transfer.ErrTransfer) {
  1620. assert.EqualError(t, transfer.ErrTransfer, errFake.Error())
  1621. }
  1622. assert.Equal(t, int64(0), transfer.BytesReceived.Load())
  1623. assert.NoFileExists(t, testfile)
  1624. assert.NoFileExists(t, fileTempName)
  1625. common.Config.UploadMode = common.UploadModeAtomicWithResume
  1626. }
  1627. func TestTransferFailingReader(t *testing.T) {
  1628. user := dataprovider.User{
  1629. BaseUser: sdk.BaseUser{
  1630. Username: "testuser",
  1631. HomeDir: os.TempDir(),
  1632. },
  1633. FsConfig: vfs.Filesystem{
  1634. Provider: sdk.CryptedFilesystemProvider,
  1635. CryptConfig: vfs.CryptFsConfig{
  1636. Passphrase: kms.NewPlainSecret("crypt secret"),
  1637. },
  1638. },
  1639. }
  1640. user.Permissions = make(map[string][]string)
  1641. user.Permissions["/"] = []string{dataprovider.PermAny}
  1642. fs := newMockOsFs(nil, nil, true, "", os.TempDir())
  1643. connection := &Connection{
  1644. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  1645. }
  1646. request := sftp.NewRequest("Open", "afile.txt")
  1647. request.Flags = 27 // read,write,create,truncate
  1648. transfer, err := connection.handleFilewrite(request)
  1649. require.NoError(t, err)
  1650. buf := make([]byte, 32)
  1651. _, err = transfer.ReadAt(buf, 0)
  1652. assert.EqualError(t, err, sftp.ErrSSHFxOpUnsupported.Error())
  1653. if c, ok := transfer.(io.Closer); ok {
  1654. err = c.Close()
  1655. assert.NoError(t, err)
  1656. }
  1657. fsPath := filepath.Join(os.TempDir(), "afile.txt")
  1658. r, _, err := pipeat.Pipe()
  1659. assert.NoError(t, err)
  1660. baseTransfer := common.NewBaseTransfer(nil, connection.BaseConnection, nil, fsPath, fsPath, filepath.Base(fsPath),
  1661. common.TransferUpload, 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  1662. errRead := errors.New("read is not allowed")
  1663. tr := newTransfer(baseTransfer, nil, r, errRead)
  1664. _, err = tr.ReadAt(buf, 0)
  1665. assert.EqualError(t, err, errRead.Error())
  1666. err = tr.Close()
  1667. assert.NoError(t, err)
  1668. tr = newTransfer(baseTransfer, nil, nil, errRead)
  1669. _, err = tr.ReadAt(buf, 0)
  1670. assert.EqualError(t, err, errRead.Error())
  1671. err = tr.Close()
  1672. assert.NoError(t, err)
  1673. err = os.Remove(fsPath)
  1674. assert.NoError(t, err)
  1675. assert.Len(t, connection.GetTransfers(), 0)
  1676. }
  1677. func TestConnectionStatusStruct(t *testing.T) {
  1678. var transfers []common.ConnectionTransfer
  1679. transferUL := common.ConnectionTransfer{
  1680. OperationType: "upload",
  1681. StartTime: util.GetTimeAsMsSinceEpoch(time.Now()),
  1682. Size: 123,
  1683. VirtualPath: "/test.upload",
  1684. }
  1685. transferDL := common.ConnectionTransfer{
  1686. OperationType: "download",
  1687. StartTime: util.GetTimeAsMsSinceEpoch(time.Now()),
  1688. Size: 123,
  1689. VirtualPath: "/test.download",
  1690. }
  1691. transfers = append(transfers, transferUL)
  1692. transfers = append(transfers, transferDL)
  1693. c := common.ConnectionStatus{
  1694. Username: "test",
  1695. ConnectionID: "123",
  1696. ClientVersion: "fakeClient-1.0.0",
  1697. RemoteAddress: "127.0.0.1:1234",
  1698. ConnectionTime: util.GetTimeAsMsSinceEpoch(time.Now()),
  1699. LastActivity: util.GetTimeAsMsSinceEpoch(time.Now()),
  1700. Protocol: "SFTP",
  1701. Transfers: transfers,
  1702. }
  1703. durationString := c.GetConnectionDuration()
  1704. assert.NotEqual(t, 0, len(durationString))
  1705. transfersString := c.GetTransfersAsString()
  1706. assert.NotEqual(t, 0, len(transfersString))
  1707. connInfo := c.GetConnectionInfo()
  1708. assert.NotEqual(t, 0, len(connInfo))
  1709. }
  1710. func TestSupportedSecurityOptions(t *testing.T) {
  1711. c := Configuration{
  1712. KexAlgorithms: supportedKexAlgos,
  1713. MACs: supportedMACs,
  1714. Ciphers: supportedCiphers,
  1715. }
  1716. serverConfig := &ssh.ServerConfig{}
  1717. err := c.configureSecurityOptions(serverConfig)
  1718. assert.NoError(t, err)
  1719. assert.Equal(t, supportedCiphers, serverConfig.Ciphers)
  1720. assert.Equal(t, supportedMACs, serverConfig.MACs)
  1721. assert.Equal(t, supportedKexAlgos, serverConfig.KeyExchanges)
  1722. c.KexAlgorithms = append(c.KexAlgorithms, "not a kex")
  1723. err = c.configureSecurityOptions(serverConfig)
  1724. assert.Error(t, err)
  1725. c.KexAlgorithms = supportedKexAlgos
  1726. c.MACs = []string{
  1727. " [email protected] ", "hmac-sha2-256",
  1728. " [email protected]", "hmac-sha2-512 ",
  1729. "hmac-sha1 ", " hmac-sha1-96",
  1730. }
  1731. err = c.configureSecurityOptions(serverConfig)
  1732. assert.NoError(t, err)
  1733. assert.Equal(t, supportedCiphers, serverConfig.Ciphers)
  1734. assert.Equal(t, supportedMACs, serverConfig.MACs)
  1735. assert.Equal(t, supportedKexAlgos, serverConfig.KeyExchanges)
  1736. }
  1737. func TestLoadModuli(t *testing.T) {
  1738. dhGEXSha1 := "diffie-hellman-group-exchange-sha1"
  1739. dhGEXSha256 := "diffie-hellman-group-exchange-sha256"
  1740. c := Configuration{}
  1741. c.Moduli = []string{".", "missing file"}
  1742. err := c.loadModuli(configDir)
  1743. assert.Error(t, err)
  1744. assert.NotContains(t, supportedKexAlgos, dhGEXSha1)
  1745. assert.NotContains(t, supportedKexAlgos, dhGEXSha256)
  1746. assert.Len(t, supportedKexAlgos, 10)
  1747. moduli := []byte("20220414072358 2 6 100 2047 5 F19C2D09AD49978F8A0C1B84168A4011A26F9CD516815934764A319FDC5975FA514AAF11B747D8CA6B3919532BEFB68FA118079473895674F3770F71FBB742F176883841EB3DE679BEF53C6AFE437A662F228B03C1E34B5A0D3909F608CEAA16C1F8131DE11E67878EFD918A89205E5E4DE323054010CA4711F25D466BB7727A016DD3F9F53BDBCE093055A4F2497ADEFB5A2500F9C5C3B0BCD88C6489F4C1CBC7CFB67BA6EABA0195794E4188CE9060F431041AD52FB9BAC4DF7FA536F585FBE67746CD57BFAD67567E9706C24D95C49BE95B759657C6BB5151E2AEA32F4CD557C40298A5C402101520EE8AAB8DFEED6FFC11AAF8036D6345923CFB5D1B922F")
  1748. moduliFile := filepath.Join(os.TempDir(), "moduli")
  1749. err = os.WriteFile(moduliFile, moduli, 0600)
  1750. assert.NoError(t, err)
  1751. c.Moduli = []string{moduliFile}
  1752. err = c.loadModuli(configDir)
  1753. assert.NoError(t, err)
  1754. assert.Contains(t, supportedKexAlgos, dhGEXSha1)
  1755. assert.Contains(t, supportedKexAlgos, dhGEXSha256)
  1756. assert.Len(t, supportedKexAlgos, 12)
  1757. err = os.Remove(moduliFile)
  1758. assert.NoError(t, err)
  1759. }
  1760. func TestLoadHostKeys(t *testing.T) {
  1761. serverConfig := &ssh.ServerConfig{}
  1762. c := Configuration{}
  1763. c.HostKeys = []string{".", "missing file"}
  1764. err := c.checkAndLoadHostKeys(configDir, serverConfig)
  1765. assert.Error(t, err)
  1766. testfile := filepath.Join(os.TempDir(), "invalidkey")
  1767. err = os.WriteFile(testfile, []byte("some bytes"), os.ModePerm)
  1768. assert.NoError(t, err)
  1769. c.HostKeys = []string{testfile}
  1770. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1771. assert.Error(t, err)
  1772. err = os.Remove(testfile)
  1773. assert.NoError(t, err)
  1774. keysDir := filepath.Join(os.TempDir(), "keys")
  1775. err = os.MkdirAll(keysDir, os.ModePerm)
  1776. assert.NoError(t, err)
  1777. rsaKeyName := filepath.Join(keysDir, defaultPrivateRSAKeyName)
  1778. ecdsaKeyName := filepath.Join(keysDir, defaultPrivateECDSAKeyName)
  1779. ed25519KeyName := filepath.Join(keysDir, defaultPrivateEd25519KeyName)
  1780. nonDefaultKeyName := filepath.Join(keysDir, "akey")
  1781. c.HostKeys = []string{nonDefaultKeyName, rsaKeyName, ecdsaKeyName, ed25519KeyName}
  1782. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1783. assert.Error(t, err)
  1784. assert.FileExists(t, rsaKeyName)
  1785. assert.FileExists(t, ecdsaKeyName)
  1786. assert.FileExists(t, ed25519KeyName)
  1787. assert.NoFileExists(t, nonDefaultKeyName)
  1788. err = os.Remove(rsaKeyName)
  1789. assert.NoError(t, err)
  1790. err = os.Remove(ecdsaKeyName)
  1791. assert.NoError(t, err)
  1792. err = os.Remove(ed25519KeyName)
  1793. assert.NoError(t, err)
  1794. if runtime.GOOS != osWindows {
  1795. err = os.Chmod(keysDir, 0551)
  1796. assert.NoError(t, err)
  1797. c.HostKeys = nil
  1798. err = c.checkAndLoadHostKeys(keysDir, serverConfig)
  1799. assert.Error(t, err)
  1800. c.HostKeys = []string{rsaKeyName, ecdsaKeyName}
  1801. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1802. assert.Error(t, err)
  1803. c.HostKeys = []string{ecdsaKeyName, rsaKeyName}
  1804. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1805. assert.Error(t, err)
  1806. c.HostKeys = []string{ed25519KeyName}
  1807. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1808. assert.Error(t, err)
  1809. err = os.Chmod(keysDir, 0755)
  1810. assert.NoError(t, err)
  1811. }
  1812. err = os.RemoveAll(keysDir)
  1813. assert.NoError(t, err)
  1814. }
  1815. func TestCertCheckerInitErrors(t *testing.T) {
  1816. c := Configuration{}
  1817. c.TrustedUserCAKeys = []string{".", "missing file"}
  1818. err := c.initializeCertChecker("")
  1819. assert.Error(t, err)
  1820. testfile := filepath.Join(os.TempDir(), "invalidkey")
  1821. err = os.WriteFile(testfile, []byte("some bytes"), os.ModePerm)
  1822. assert.NoError(t, err)
  1823. c.TrustedUserCAKeys = []string{testfile}
  1824. err = c.initializeCertChecker("")
  1825. assert.Error(t, err)
  1826. err = os.Remove(testfile)
  1827. assert.NoError(t, err)
  1828. }
  1829. func TestRecursiveCopyErrors(t *testing.T) {
  1830. permissions := make(map[string][]string)
  1831. permissions["/"] = []string{dataprovider.PermAny}
  1832. user := dataprovider.User{
  1833. BaseUser: sdk.BaseUser{
  1834. Permissions: permissions,
  1835. HomeDir: os.TempDir(),
  1836. },
  1837. }
  1838. fs, err := user.GetFilesystem("123")
  1839. assert.NoError(t, err)
  1840. conn := &Connection{
  1841. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  1842. }
  1843. sshCmd := sshCommand{
  1844. command: "sftpgo-copy",
  1845. connection: conn,
  1846. args: []string{"adir", "another"},
  1847. }
  1848. // try to copy a missing directory
  1849. sshCmd.connection.User.Permissions["/another"] = []string{
  1850. dataprovider.PermCreateDirs,
  1851. dataprovider.PermCreateSymlinks,
  1852. dataprovider.PermListItems,
  1853. }
  1854. err = sshCmd.checkRecursiveCopyPermissions(fs, fs, "adir", "another/sub", "/adir", "/another/sub")
  1855. assert.Error(t, err)
  1856. sshCmd.connection.User.Permissions["/another"] = []string{
  1857. dataprovider.PermListItems,
  1858. dataprovider.PermCreateDirs,
  1859. }
  1860. err = sshCmd.checkRecursiveCopyPermissions(fs, fs, "adir", "another", "/adir/sub", "/another/sub/dir")
  1861. assert.Error(t, err)
  1862. }
  1863. func TestSFTPSubSystem(t *testing.T) {
  1864. permissions := make(map[string][]string)
  1865. permissions["/"] = []string{dataprovider.PermAny}
  1866. user := &dataprovider.User{
  1867. BaseUser: sdk.BaseUser{
  1868. Permissions: permissions,
  1869. HomeDir: os.TempDir(),
  1870. },
  1871. }
  1872. user.FsConfig.Provider = sdk.AzureBlobFilesystemProvider
  1873. err := ServeSubSystemConnection(user, "connID", nil, nil)
  1874. assert.Error(t, err)
  1875. user.FsConfig.Provider = sdk.LocalFilesystemProvider
  1876. buf := make([]byte, 0, 4096)
  1877. stdErrBuf := make([]byte, 0, 4096)
  1878. mockSSHChannel := &MockChannel{
  1879. Buffer: bytes.NewBuffer(buf),
  1880. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1881. }
  1882. // this is 327680 and it will result in packet too long error
  1883. _, err = mockSSHChannel.Write([]byte{0x00, 0x05, 0x00, 0x00, 0x00, 0x00})
  1884. assert.NoError(t, err)
  1885. err = ServeSubSystemConnection(user, "id", mockSSHChannel, mockSSHChannel)
  1886. assert.EqualError(t, err, "packet too long")
  1887. subsystemChannel := newSubsystemChannel(mockSSHChannel, mockSSHChannel)
  1888. n, err := subsystemChannel.Write([]byte{0x00})
  1889. assert.NoError(t, err)
  1890. assert.Equal(t, n, 1)
  1891. err = subsystemChannel.Close()
  1892. assert.NoError(t, err)
  1893. }
  1894. func TestRecoverer(t *testing.T) {
  1895. c := Configuration{}
  1896. c.AcceptInboundConnection(nil, nil)
  1897. connID := "connectionID"
  1898. connection := &Connection{
  1899. BaseConnection: common.NewBaseConnection(connID, common.ProtocolSFTP, "", "", dataprovider.User{}),
  1900. }
  1901. c.handleSftpConnection(nil, connection)
  1902. sshCmd := sshCommand{
  1903. command: "cd",
  1904. connection: connection,
  1905. }
  1906. err := sshCmd.handle()
  1907. assert.EqualError(t, err, common.ErrGenericFailure.Error())
  1908. scpCmd := scpCommand{
  1909. sshCommand: sshCommand{
  1910. command: "scp",
  1911. connection: connection,
  1912. },
  1913. }
  1914. err = scpCmd.handle()
  1915. assert.EqualError(t, err, common.ErrGenericFailure.Error())
  1916. assert.Len(t, common.Connections.GetStats(""), 0)
  1917. }
  1918. func TestListernerAcceptErrors(t *testing.T) {
  1919. errFake := errors.New("a fake error")
  1920. listener := newFakeListener(errFake)
  1921. c := Configuration{}
  1922. err := c.serve(listener, nil)
  1923. require.EqualError(t, err, errFake.Error())
  1924. err = listener.Close()
  1925. require.NoError(t, err)
  1926. errNetFake := &fakeNetError{error: errFake}
  1927. listener = newFakeListener(errNetFake)
  1928. err = c.serve(listener, nil)
  1929. require.EqualError(t, err, errFake.Error())
  1930. err = listener.Close()
  1931. require.NoError(t, err)
  1932. }
  1933. type fakeNetError struct {
  1934. error
  1935. count int
  1936. }
  1937. func (e *fakeNetError) Timeout() bool {
  1938. return false
  1939. }
  1940. func (e *fakeNetError) Temporary() bool {
  1941. e.count++
  1942. return e.count < 10
  1943. }
  1944. func (e *fakeNetError) Error() string {
  1945. return e.error.Error()
  1946. }
  1947. type fakeListener struct {
  1948. server net.Conn
  1949. client net.Conn
  1950. err error
  1951. }
  1952. func (l *fakeListener) Accept() (net.Conn, error) {
  1953. return l.client, l.err
  1954. }
  1955. func (l *fakeListener) Close() error {
  1956. errClient := l.client.Close()
  1957. errServer := l.server.Close()
  1958. if errServer != nil {
  1959. return errServer
  1960. }
  1961. return errClient
  1962. }
  1963. func (l *fakeListener) Addr() net.Addr {
  1964. return l.server.LocalAddr()
  1965. }
  1966. func newFakeListener(err error) net.Listener {
  1967. server, client := net.Pipe()
  1968. return &fakeListener{
  1969. server: server,
  1970. client: client,
  1971. err: err,
  1972. }
  1973. }
  1974. func TestFolderPrefix(t *testing.T) {
  1975. c := Configuration{
  1976. FolderPrefix: "files",
  1977. }
  1978. c.checkFolderPrefix()
  1979. assert.Equal(t, "/files", c.FolderPrefix)
  1980. c.FolderPrefix = ""
  1981. c.checkFolderPrefix()
  1982. assert.Empty(t, c.FolderPrefix)
  1983. c.FolderPrefix = "/"
  1984. c.checkFolderPrefix()
  1985. assert.Empty(t, c.FolderPrefix)
  1986. c.FolderPrefix = "/."
  1987. c.checkFolderPrefix()
  1988. assert.Empty(t, c.FolderPrefix)
  1989. c.FolderPrefix = "."
  1990. c.checkFolderPrefix()
  1991. assert.Empty(t, c.FolderPrefix)
  1992. c.FolderPrefix = ".."
  1993. c.checkFolderPrefix()
  1994. assert.Empty(t, c.FolderPrefix)
  1995. }
  1996. func TestLoadRevokedUserCertsFile(t *testing.T) {
  1997. r := revokedCertificates{
  1998. certs: map[string]bool{},
  1999. }
  2000. err := r.load()
  2001. assert.NoError(t, err)
  2002. r.filePath = filepath.Join(os.TempDir(), "sub", "testrevoked")
  2003. err = os.MkdirAll(filepath.Dir(r.filePath), os.ModePerm)
  2004. assert.NoError(t, err)
  2005. err = os.WriteFile(r.filePath, []byte(`no json`), 0644)
  2006. assert.NoError(t, err)
  2007. err = r.load()
  2008. assert.Error(t, err)
  2009. r.filePath = filepath.Dir(r.filePath)
  2010. err = r.load()
  2011. assert.Error(t, err)
  2012. err = os.RemoveAll(r.filePath)
  2013. assert.NoError(t, err)
  2014. }
  2015. func TestMaxUserSessions(t *testing.T) {
  2016. connection := &Connection{
  2017. BaseConnection: common.NewBaseConnection(xid.New().String(), common.ProtocolSFTP, "", "", dataprovider.User{
  2018. BaseUser: sdk.BaseUser{
  2019. Username: "user_max_sessions",
  2020. HomeDir: filepath.Clean(os.TempDir()),
  2021. MaxSessions: 1,
  2022. },
  2023. }),
  2024. }
  2025. err := common.Connections.Add(connection)
  2026. assert.NoError(t, err)
  2027. c := Configuration{}
  2028. c.handleSftpConnection(nil, connection)
  2029. sshCmd := sshCommand{
  2030. command: "cd",
  2031. connection: connection,
  2032. }
  2033. err = sshCmd.handle()
  2034. if assert.Error(t, err) {
  2035. assert.Contains(t, err.Error(), "too many open sessions")
  2036. }
  2037. scpCmd := scpCommand{
  2038. sshCommand: sshCommand{
  2039. command: "scp",
  2040. connection: connection,
  2041. },
  2042. }
  2043. err = scpCmd.handle()
  2044. if assert.Error(t, err) {
  2045. assert.Contains(t, err.Error(), "too many open sessions")
  2046. }
  2047. err = ServeSubSystemConnection(&connection.User, connection.ID, nil, nil)
  2048. if assert.Error(t, err) {
  2049. assert.Contains(t, err.Error(), "too many open sessions")
  2050. }
  2051. common.Connections.Remove(connection.GetID())
  2052. assert.Len(t, common.Connections.GetStats(""), 0)
  2053. }
  2054. func TestCanReadSymlink(t *testing.T) {
  2055. connection := &Connection{
  2056. BaseConnection: common.NewBaseConnection(xid.New().String(), common.ProtocolSFTP, "", "", dataprovider.User{
  2057. BaseUser: sdk.BaseUser{
  2058. Username: "user_can_read_symlink",
  2059. HomeDir: filepath.Clean(os.TempDir()),
  2060. Permissions: map[string][]string{
  2061. "/": {dataprovider.PermAny},
  2062. "/sub": {dataprovider.PermUpload},
  2063. },
  2064. },
  2065. Filters: dataprovider.UserFilters{
  2066. BaseUserFilters: sdk.BaseUserFilters{
  2067. FilePatterns: []sdk.PatternsFilter{
  2068. {
  2069. Path: "/denied",
  2070. DeniedPatterns: []string{"*.txt"},
  2071. DenyPolicy: sdk.DenyPolicyHide,
  2072. },
  2073. },
  2074. },
  2075. },
  2076. }),
  2077. }
  2078. err := connection.canReadLink("/sub/link")
  2079. assert.ErrorIs(t, err, sftp.ErrSSHFxPermissionDenied)
  2080. err = connection.canReadLink("/denied/file.txt")
  2081. assert.ErrorIs(t, err, sftp.ErrSSHFxNoSuchFile)
  2082. }