internal_test.go 66 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199
  1. // Copyright (C) 2019 Nicola Murino
  2. //
  3. // This program is free software: you can redistribute it and/or modify
  4. // it under the terms of the GNU Affero General Public License as published
  5. // by the Free Software Foundation, version 3.
  6. //
  7. // This program is distributed in the hope that it will be useful,
  8. // but WITHOUT ANY WARRANTY; without even the implied warranty of
  9. // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  10. // GNU Affero General Public License for more details.
  11. //
  12. // You should have received a copy of the GNU Affero General Public License
  13. // along with this program. If not, see <https://www.gnu.org/licenses/>.
  14. package sftpd
  15. import (
  16. "bytes"
  17. "errors"
  18. "fmt"
  19. "io"
  20. "io/fs"
  21. "net"
  22. "os"
  23. "path/filepath"
  24. "runtime"
  25. "slices"
  26. "testing"
  27. "time"
  28. "github.com/eikenb/pipeat"
  29. "github.com/pkg/sftp"
  30. "github.com/rs/xid"
  31. "github.com/sftpgo/sdk"
  32. "github.com/stretchr/testify/assert"
  33. "github.com/stretchr/testify/require"
  34. "golang.org/x/crypto/ssh"
  35. "github.com/drakkan/sftpgo/v2/internal/common"
  36. "github.com/drakkan/sftpgo/v2/internal/dataprovider"
  37. "github.com/drakkan/sftpgo/v2/internal/kms"
  38. "github.com/drakkan/sftpgo/v2/internal/util"
  39. "github.com/drakkan/sftpgo/v2/internal/vfs"
  40. )
  41. const (
  42. osWindows = "windows"
  43. )
  44. var (
  45. configDir = filepath.Join(".", "..", "..")
  46. )
  47. type MockChannel struct {
  48. Buffer *bytes.Buffer
  49. StdErrBuffer *bytes.Buffer
  50. ReadError error
  51. WriteError error
  52. ShortWriteErr bool
  53. }
  54. func (c *MockChannel) Read(data []byte) (int, error) {
  55. if c.ReadError != nil {
  56. return 0, c.ReadError
  57. }
  58. return c.Buffer.Read(data)
  59. }
  60. func (c *MockChannel) Write(data []byte) (int, error) {
  61. if c.WriteError != nil {
  62. return 0, c.WriteError
  63. }
  64. if c.ShortWriteErr {
  65. return 0, nil
  66. }
  67. return c.Buffer.Write(data)
  68. }
  69. func (c *MockChannel) Close() error {
  70. return nil
  71. }
  72. func (c *MockChannel) CloseWrite() error {
  73. return nil
  74. }
  75. func (c *MockChannel) SendRequest(_ string, _ bool, _ []byte) (bool, error) {
  76. return true, nil
  77. }
  78. func (c *MockChannel) Stderr() io.ReadWriter {
  79. return c.StdErrBuffer
  80. }
  81. // MockOsFs mockable OsFs
  82. type MockOsFs struct {
  83. vfs.Fs
  84. err error
  85. statErr error
  86. isAtomicUploadSupported bool
  87. }
  88. // Name returns the name for the Fs implementation
  89. func (fs MockOsFs) Name() string {
  90. return "mockOsFs"
  91. }
  92. // IsUploadResumeSupported returns true if resuming uploads is supported
  93. func (MockOsFs) IsUploadResumeSupported() bool {
  94. return false
  95. }
  96. // IsConditionalUploadResumeSupported returns if resuming uploads is supported
  97. // for the specified size
  98. func (MockOsFs) IsConditionalUploadResumeSupported(_ int64) bool {
  99. return false
  100. }
  101. // IsAtomicUploadSupported returns true if atomic upload is supported
  102. func (fs MockOsFs) IsAtomicUploadSupported() bool {
  103. return fs.isAtomicUploadSupported
  104. }
  105. // Stat returns a FileInfo describing the named file
  106. func (fs MockOsFs) Stat(name string) (os.FileInfo, error) {
  107. if fs.statErr != nil {
  108. return nil, fs.statErr
  109. }
  110. return os.Stat(name)
  111. }
  112. // Lstat returns a FileInfo describing the named file
  113. func (fs MockOsFs) Lstat(name string) (os.FileInfo, error) {
  114. if fs.statErr != nil {
  115. return nil, fs.statErr
  116. }
  117. return os.Lstat(name)
  118. }
  119. // Remove removes the named file or (empty) directory.
  120. func (fs MockOsFs) Remove(name string, _ bool) error {
  121. if fs.err != nil {
  122. return fs.err
  123. }
  124. return os.Remove(name)
  125. }
  126. // Rename renames (moves) source to target
  127. func (fs MockOsFs) Rename(source, target string, _ int) (int, int64, error) {
  128. if fs.err != nil {
  129. return -1, -1, fs.err
  130. }
  131. err := os.Rename(source, target)
  132. return -1, -1, err
  133. }
  134. func newMockOsFs(err, statErr error, atomicUpload bool, connectionID, rootDir string) vfs.Fs {
  135. return &MockOsFs{
  136. Fs: vfs.NewOsFs(connectionID, rootDir, "", nil),
  137. err: err,
  138. statErr: statErr,
  139. isAtomicUploadSupported: atomicUpload,
  140. }
  141. }
  142. func TestRemoveNonexistentQuotaScan(t *testing.T) {
  143. assert.False(t, common.QuotaScans.RemoveUserQuotaScan("username"))
  144. }
  145. func TestGetOSOpenFlags(t *testing.T) {
  146. var flags sftp.FileOpenFlags
  147. flags.Write = true
  148. flags.Excl = true
  149. osFlags := getOSOpenFlags(flags)
  150. assert.NotEqual(t, 0, osFlags&os.O_WRONLY)
  151. assert.NotEqual(t, 0, osFlags&os.O_EXCL)
  152. flags.Append = true
  153. // append flag should be ignored to allow resume
  154. assert.NotEqual(t, 0, osFlags&os.O_WRONLY)
  155. assert.NotEqual(t, 0, osFlags&os.O_EXCL)
  156. }
  157. func TestUploadResumeInvalidOffset(t *testing.T) {
  158. testfile := "testfile" //nolint:goconst
  159. file, err := os.Create(testfile)
  160. assert.NoError(t, err)
  161. user := dataprovider.User{
  162. BaseUser: sdk.BaseUser{
  163. Username: "testuser",
  164. },
  165. }
  166. fs := vfs.NewOsFs("", os.TempDir(), "", nil)
  167. conn := common.NewBaseConnection("", common.ProtocolSFTP, "", "", user)
  168. baseTransfer := common.NewBaseTransfer(file, conn, nil, file.Name(), file.Name(), testfile,
  169. common.TransferUpload, 10, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  170. transfer := newTransfer(baseTransfer, nil, nil, nil)
  171. _, err = transfer.WriteAt([]byte("test"), 0)
  172. assert.Error(t, err, "upload with invalid offset must fail")
  173. if assert.Error(t, transfer.ErrTransfer) {
  174. assert.EqualError(t, err, transfer.ErrTransfer.Error())
  175. assert.Contains(t, transfer.ErrTransfer.Error(), "invalid write offset")
  176. }
  177. err = transfer.Close()
  178. if assert.Error(t, err) {
  179. assert.ErrorIs(t, err, sftp.ErrSSHFxFailure)
  180. }
  181. err = os.Remove(testfile)
  182. assert.NoError(t, err)
  183. }
  184. func TestReadWriteErrors(t *testing.T) {
  185. testfile := "testfile"
  186. file, err := os.Create(testfile)
  187. assert.NoError(t, err)
  188. user := dataprovider.User{
  189. BaseUser: sdk.BaseUser{
  190. Username: "testuser",
  191. },
  192. }
  193. fs := vfs.NewOsFs("", os.TempDir(), "", nil)
  194. conn := common.NewBaseConnection("", common.ProtocolSFTP, "", "", user)
  195. baseTransfer := common.NewBaseTransfer(file, conn, nil, file.Name(), file.Name(), testfile, common.TransferDownload,
  196. 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  197. transfer := newTransfer(baseTransfer, nil, nil, nil)
  198. err = file.Close()
  199. assert.NoError(t, err)
  200. _, err = transfer.WriteAt([]byte("test"), 0)
  201. assert.Error(t, err, "writing to closed file must fail")
  202. buf := make([]byte, 32768)
  203. _, err = transfer.ReadAt(buf, 0)
  204. assert.Error(t, err, "reading from a closed file must fail")
  205. err = transfer.Close()
  206. assert.Error(t, err)
  207. r, _, err := pipeat.Pipe()
  208. assert.NoError(t, err)
  209. baseTransfer = common.NewBaseTransfer(nil, conn, nil, file.Name(), file.Name(), testfile, common.TransferDownload,
  210. 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  211. transfer = newTransfer(baseTransfer, nil, vfs.NewPipeReader(r), nil)
  212. err = transfer.Close()
  213. assert.NoError(t, err)
  214. _, err = transfer.ReadAt(buf, 0)
  215. assert.Error(t, err, "reading from a closed pipe must fail")
  216. r, w, err := pipeat.Pipe()
  217. assert.NoError(t, err)
  218. pipeWriter := vfs.NewPipeWriter(w)
  219. baseTransfer = common.NewBaseTransfer(nil, conn, nil, file.Name(), file.Name(), testfile, common.TransferDownload,
  220. 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  221. transfer = newTransfer(baseTransfer, pipeWriter, nil, nil)
  222. err = r.Close()
  223. assert.NoError(t, err)
  224. errFake := fmt.Errorf("fake upload error")
  225. go func() {
  226. time.Sleep(100 * time.Millisecond)
  227. pipeWriter.Done(errFake)
  228. }()
  229. err = transfer.closeIO()
  230. assert.EqualError(t, err, errFake.Error())
  231. _, err = transfer.WriteAt([]byte("test"), 0)
  232. assert.Error(t, err, "writing to closed pipe must fail")
  233. err = transfer.BaseTransfer.Close()
  234. assert.EqualError(t, err, errFake.Error())
  235. err = os.Remove(testfile)
  236. assert.NoError(t, err)
  237. assert.Len(t, conn.GetTransfers(), 0)
  238. assert.Equal(t, int32(0), common.Connections.GetTotalTransfers())
  239. }
  240. func TestUnsupportedListOP(t *testing.T) {
  241. conn := common.NewBaseConnection("", common.ProtocolSFTP, "", "", dataprovider.User{})
  242. sftpConn := Connection{
  243. BaseConnection: conn,
  244. }
  245. request := sftp.NewRequest("Unsupported", "")
  246. _, err := sftpConn.Filelist(request)
  247. assert.EqualError(t, err, sftp.ErrSSHFxOpUnsupported.Error())
  248. }
  249. func TestTransferCancelFn(t *testing.T) {
  250. testfile := "testfile"
  251. file, err := os.Create(testfile)
  252. assert.NoError(t, err)
  253. isCancelled := false
  254. cancelFn := func() {
  255. isCancelled = true
  256. }
  257. user := dataprovider.User{
  258. BaseUser: sdk.BaseUser{
  259. Username: "testuser",
  260. },
  261. }
  262. fs := vfs.NewOsFs("", os.TempDir(), "", nil)
  263. conn := common.NewBaseConnection("", common.ProtocolSFTP, "", "", user)
  264. baseTransfer := common.NewBaseTransfer(file, conn, cancelFn, file.Name(), file.Name(), testfile, common.TransferDownload,
  265. 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  266. transfer := newTransfer(baseTransfer, nil, nil, nil)
  267. errFake := errors.New("fake error, this will trigger cancelFn")
  268. transfer.TransferError(errFake)
  269. err = transfer.Close()
  270. if assert.Error(t, err) {
  271. assert.ErrorIs(t, err, sftp.ErrSSHFxFailure)
  272. }
  273. if assert.Error(t, transfer.ErrTransfer) {
  274. assert.EqualError(t, transfer.ErrTransfer, errFake.Error())
  275. }
  276. assert.True(t, isCancelled, "cancelFn not called!")
  277. err = os.Remove(testfile)
  278. assert.NoError(t, err)
  279. }
  280. func TestUploadFiles(t *testing.T) {
  281. common.Config.UploadMode = common.UploadModeAtomic
  282. fs := vfs.NewOsFs("123", os.TempDir(), "", nil)
  283. u := dataprovider.User{}
  284. c := Connection{
  285. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", u),
  286. }
  287. var flags sftp.FileOpenFlags
  288. flags.Write = true
  289. flags.Trunc = true
  290. _, err := c.handleSFTPUploadToExistingFile(fs, flags, "missing_path", "other_missing_path", 0, "/missing_path", nil)
  291. assert.Error(t, err, "upload to existing file must fail if one or both paths are invalid")
  292. common.Config.UploadMode = common.UploadModeStandard
  293. _, err = c.handleSFTPUploadToExistingFile(fs, flags, "missing_path", "other_missing_path", 0, "/missing_path", nil)
  294. assert.Error(t, err, "upload to existing file must fail if one or both paths are invalid")
  295. missingFile := "missing/relative/file.txt"
  296. if runtime.GOOS == osWindows {
  297. missingFile = "missing\\relative\\file.txt"
  298. }
  299. _, err = c.handleSFTPUploadToNewFile(fs, flags, ".", missingFile, "/missing", nil)
  300. assert.Error(t, err, "upload new file in missing path must fail")
  301. fs = newMockOsFs(nil, nil, false, "123", os.TempDir())
  302. f, err := os.CreateTemp("", "temp")
  303. assert.NoError(t, err)
  304. err = f.Close()
  305. assert.NoError(t, err)
  306. tr, err := c.handleSFTPUploadToExistingFile(fs, flags, f.Name(), f.Name(), 123, f.Name(), nil)
  307. if assert.NoError(t, err) {
  308. transfer := tr.(*transfer)
  309. transfers := c.GetTransfers()
  310. if assert.Equal(t, 1, len(transfers)) {
  311. assert.Equal(t, transfers[0].ID, transfer.GetID())
  312. assert.Equal(t, int64(123), transfer.InitialSize)
  313. err = transfer.Close()
  314. assert.NoError(t, err)
  315. assert.Equal(t, 0, len(c.GetTransfers()))
  316. }
  317. }
  318. err = os.Remove(f.Name())
  319. assert.NoError(t, err)
  320. common.Config.UploadMode = common.UploadModeAtomicWithResume
  321. }
  322. func TestWithInvalidHome(t *testing.T) {
  323. u := dataprovider.User{}
  324. u.HomeDir = "home_rel_path" //nolint:goconst
  325. _, err := loginUser(&u, dataprovider.LoginMethodPassword, "", nil)
  326. assert.Error(t, err, "login a user with an invalid home_dir must fail")
  327. u.HomeDir = os.TempDir()
  328. fs, err := u.GetFilesystem("123")
  329. assert.NoError(t, err)
  330. c := Connection{
  331. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", u),
  332. }
  333. _, err = fs.ResolvePath("../upper_path")
  334. assert.Error(t, err, "tested path is not a home subdir")
  335. _, err = c.StatVFS(&sftp.Request{
  336. Method: "StatVFS",
  337. Filepath: "../unresolvable-path",
  338. })
  339. assert.Error(t, err)
  340. }
  341. func TestResolveWithRootDir(t *testing.T) {
  342. u := dataprovider.User{}
  343. if runtime.GOOS == osWindows {
  344. u.HomeDir = "C:\\"
  345. } else {
  346. u.HomeDir = "/"
  347. }
  348. fs, err := u.GetFilesystem("")
  349. assert.NoError(t, err)
  350. rel, err := filepath.Rel(u.HomeDir, os.TempDir())
  351. assert.NoError(t, err)
  352. p, err := fs.ResolvePath(rel)
  353. assert.NoError(t, err, "path %v", p)
  354. }
  355. func TestSFTPGetUsedQuota(t *testing.T) {
  356. u := dataprovider.User{}
  357. u.HomeDir = "home_rel_path"
  358. u.Username = "test_invalid_user"
  359. u.QuotaSize = 4096
  360. u.QuotaFiles = 1
  361. u.Permissions = make(map[string][]string)
  362. u.Permissions["/"] = []string{dataprovider.PermAny}
  363. connection := Connection{
  364. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", u),
  365. }
  366. quotaResult, _ := connection.HasSpace(false, false, "/")
  367. assert.False(t, quotaResult.HasSpace)
  368. }
  369. func TestSupportedSSHCommands(t *testing.T) {
  370. cmds := GetSupportedSSHCommands()
  371. assert.Equal(t, len(supportedSSHCommands), len(cmds))
  372. for _, c := range cmds {
  373. assert.True(t, slices.Contains(supportedSSHCommands, c))
  374. }
  375. }
  376. func TestSSHCommandPath(t *testing.T) {
  377. buf := make([]byte, 65535)
  378. stdErrBuf := make([]byte, 65535)
  379. mockSSHChannel := MockChannel{
  380. Buffer: bytes.NewBuffer(buf),
  381. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  382. ReadError: nil,
  383. }
  384. connection := &Connection{
  385. channel: &mockSSHChannel,
  386. BaseConnection: common.NewBaseConnection("", common.ProtocolSSH, "", "", dataprovider.User{}),
  387. }
  388. sshCommand := sshCommand{
  389. command: "test",
  390. connection: connection,
  391. args: []string{},
  392. }
  393. assert.Equal(t, "", sshCommand.getDestPath())
  394. sshCommand.args = []string{"-t", "/tmp/../path"}
  395. assert.Equal(t, "/path", sshCommand.getDestPath())
  396. sshCommand.args = []string{"-t", "/tmp/"}
  397. assert.Equal(t, "/tmp/", sshCommand.getDestPath())
  398. sshCommand.args = []string{"-t", "tmp/"}
  399. assert.Equal(t, "/tmp/", sshCommand.getDestPath())
  400. sshCommand.args = []string{"-t", "/tmp/../../../path"}
  401. assert.Equal(t, "/path", sshCommand.getDestPath())
  402. sshCommand.args = []string{"-t", ".."}
  403. assert.Equal(t, "/", sshCommand.getDestPath())
  404. sshCommand.args = []string{"-t", "."}
  405. assert.Equal(t, "/", sshCommand.getDestPath())
  406. sshCommand.args = []string{"-t", "//"}
  407. assert.Equal(t, "/", sshCommand.getDestPath())
  408. sshCommand.args = []string{"-t", "../.."}
  409. assert.Equal(t, "/", sshCommand.getDestPath())
  410. sshCommand.args = []string{"-t", "/.."}
  411. assert.Equal(t, "/", sshCommand.getDestPath())
  412. sshCommand.args = []string{"-f", "/a space.txt"}
  413. assert.Equal(t, "/a space.txt", sshCommand.getDestPath())
  414. }
  415. func TestSSHParseCommandPayload(t *testing.T) {
  416. cmd := "command -a -f /ab\\ à/some\\ spaces\\ \\ \\(\\).txt"
  417. name, args, _ := parseCommandPayload(cmd)
  418. assert.Equal(t, "command", name)
  419. assert.Equal(t, 3, len(args))
  420. assert.Equal(t, "/ab à/some spaces ().txt", args[2])
  421. _, _, err := parseCommandPayload("")
  422. assert.Error(t, err, "parsing invalid command must fail")
  423. }
  424. func TestSSHCommandErrors(t *testing.T) {
  425. buf := make([]byte, 65535)
  426. stdErrBuf := make([]byte, 65535)
  427. readErr := fmt.Errorf("test read error")
  428. mockSSHChannel := MockChannel{
  429. Buffer: bytes.NewBuffer(buf),
  430. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  431. ReadError: readErr,
  432. }
  433. server, client := net.Pipe()
  434. defer func() {
  435. err := server.Close()
  436. assert.NoError(t, err)
  437. }()
  438. defer func() {
  439. err := client.Close()
  440. assert.NoError(t, err)
  441. }()
  442. user := dataprovider.User{}
  443. user.Permissions = map[string][]string{
  444. "/": {dataprovider.PermAny},
  445. }
  446. connection := Connection{
  447. BaseConnection: common.NewBaseConnection("", common.ProtocolSSH, "", "", user),
  448. channel: &mockSSHChannel,
  449. }
  450. cmd := sshCommand{
  451. command: "md5sum",
  452. connection: &connection,
  453. args: []string{},
  454. }
  455. err := cmd.handle()
  456. assert.Error(t, err, "ssh command must fail, we are sending a fake error")
  457. cmd = sshCommand{
  458. command: "md5sum",
  459. connection: &connection,
  460. args: []string{"/../../test_file_ftp.dat"},
  461. }
  462. err = cmd.handle()
  463. assert.Error(t, err, "ssh command must fail, we are requesting an invalid path")
  464. user = dataprovider.User{}
  465. user.Permissions = map[string][]string{
  466. "/": {dataprovider.PermAny},
  467. }
  468. user.HomeDir = filepath.Clean(os.TempDir())
  469. user.QuotaFiles = 1
  470. user.UsedQuotaFiles = 2
  471. cmd.connection.User = user
  472. _, err = cmd.connection.User.GetFilesystem("123")
  473. assert.NoError(t, err)
  474. cmd.command = "git-receive-pack"
  475. command, err := cmd.getSystemCommand()
  476. assert.NoError(t, err)
  477. err = cmd.executeSystemCommand(command)
  478. assert.Error(t, err, "invalid command must fail")
  479. command, err = cmd.getSystemCommand()
  480. assert.NoError(t, err)
  481. _, err = command.cmd.StderrPipe()
  482. assert.NoError(t, err)
  483. err = cmd.executeSystemCommand(command)
  484. assert.Error(t, err, "command must fail, pipe was already assigned")
  485. err = cmd.executeSystemCommand(command)
  486. assert.Error(t, err, "command must fail, pipe was already assigned")
  487. command, err = cmd.getSystemCommand()
  488. assert.NoError(t, err)
  489. _, err = command.cmd.StdoutPipe()
  490. assert.NoError(t, err)
  491. err = cmd.executeSystemCommand(command)
  492. assert.Error(t, err, "command must fail, pipe was already assigned")
  493. cmd = sshCommand{
  494. command: "sftpgo-remove",
  495. connection: &connection,
  496. args: []string{"/../../src"},
  497. }
  498. err = cmd.handle()
  499. assert.Error(t, err, "ssh command must fail, we are requesting an invalid path")
  500. cmd = sshCommand{
  501. command: "sftpgo-copy",
  502. connection: &connection,
  503. args: []string{"/../../test_src", "."},
  504. }
  505. err = cmd.handle()
  506. assert.Error(t, err, "ssh command must fail, we are requesting an invalid path")
  507. cmd.connection.User.HomeDir = filepath.Clean(os.TempDir())
  508. cmd = sshCommand{
  509. command: "sftpgo-copy",
  510. connection: &connection,
  511. args: []string{"src", "dst"},
  512. }
  513. cmd.connection.User.Permissions = make(map[string][]string)
  514. cmd.connection.User.Permissions["/"] = []string{dataprovider.PermAny}
  515. common.WaitForTransfers(1)
  516. _, err = cmd.getSystemCommand()
  517. if assert.Error(t, err) {
  518. assert.Contains(t, err.Error(), common.ErrShuttingDown.Error())
  519. }
  520. err = common.Initialize(common.Config, 0)
  521. assert.NoError(t, err)
  522. }
  523. func TestCommandsWithExtensionsFilter(t *testing.T) {
  524. buf := make([]byte, 65535)
  525. stdErrBuf := make([]byte, 65535)
  526. mockSSHChannel := MockChannel{
  527. Buffer: bytes.NewBuffer(buf),
  528. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  529. }
  530. server, client := net.Pipe()
  531. defer server.Close()
  532. defer client.Close()
  533. user := dataprovider.User{
  534. BaseUser: sdk.BaseUser{
  535. Username: "test",
  536. HomeDir: os.TempDir(),
  537. Status: 1,
  538. },
  539. }
  540. user.Filters.FilePatterns = []sdk.PatternsFilter{
  541. {
  542. Path: "/subdir",
  543. AllowedPatterns: []string{".jpg"},
  544. DeniedPatterns: []string{},
  545. },
  546. }
  547. connection := &Connection{
  548. BaseConnection: common.NewBaseConnection("", common.ProtocolSSH, "", "", user),
  549. channel: &mockSSHChannel,
  550. }
  551. cmd := sshCommand{
  552. command: "md5sum",
  553. connection: connection,
  554. args: []string{"subdir/test.png"},
  555. }
  556. err := cmd.handleHashCommands()
  557. assert.EqualError(t, err, common.ErrPermissionDenied.Error())
  558. cmd = sshCommand{
  559. command: "rsync",
  560. connection: connection,
  561. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  562. }
  563. _, err = cmd.getSystemCommand()
  564. assert.EqualError(t, err, errUnsupportedConfig.Error())
  565. }
  566. func TestSSHCommandsRemoteFs(t *testing.T) {
  567. buf := make([]byte, 65535)
  568. stdErrBuf := make([]byte, 65535)
  569. mockSSHChannel := MockChannel{
  570. Buffer: bytes.NewBuffer(buf),
  571. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  572. }
  573. user := dataprovider.User{}
  574. user.FsConfig = vfs.Filesystem{
  575. Provider: sdk.S3FilesystemProvider,
  576. S3Config: vfs.S3FsConfig{
  577. BaseS3FsConfig: sdk.BaseS3FsConfig{
  578. Bucket: "s3bucket",
  579. Endpoint: "endpoint",
  580. Region: "eu-west-1",
  581. },
  582. },
  583. }
  584. connection := &Connection{
  585. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  586. channel: &mockSSHChannel,
  587. }
  588. cmd := sshCommand{
  589. command: "md5sum",
  590. connection: connection,
  591. args: []string{},
  592. }
  593. command, err := cmd.getSystemCommand()
  594. assert.NoError(t, err)
  595. err = cmd.executeSystemCommand(command)
  596. assert.Error(t, err, "command must fail for a non local filesystem")
  597. cmd = sshCommand{
  598. command: "sftpgo-copy",
  599. connection: connection,
  600. args: []string{},
  601. }
  602. err = cmd.handleSFTPGoCopy()
  603. assert.Error(t, err)
  604. cmd = sshCommand{
  605. command: "sftpgo-remove",
  606. connection: connection,
  607. args: []string{},
  608. }
  609. err = cmd.handleSFTPGoRemove()
  610. assert.Error(t, err)
  611. }
  612. func TestSSHCmdGetFsErrors(t *testing.T) {
  613. buf := make([]byte, 65535)
  614. stdErrBuf := make([]byte, 65535)
  615. mockSSHChannel := MockChannel{
  616. Buffer: bytes.NewBuffer(buf),
  617. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  618. }
  619. user := dataprovider.User{
  620. BaseUser: sdk.BaseUser{
  621. HomeDir: "relative path",
  622. },
  623. }
  624. user.Permissions = map[string][]string{}
  625. user.Permissions["/"] = []string{dataprovider.PermAny}
  626. connection := &Connection{
  627. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  628. channel: &mockSSHChannel,
  629. }
  630. cmd := sshCommand{
  631. command: "sftpgo-remove",
  632. connection: connection,
  633. args: []string{"path"},
  634. }
  635. err := cmd.handleSFTPGoRemove()
  636. assert.Error(t, err)
  637. cmd = sshCommand{
  638. command: "sftpgo-copy",
  639. connection: connection,
  640. args: []string{"path1", "path2"},
  641. }
  642. err = cmd.handleSFTPGoCopy()
  643. assert.Error(t, err)
  644. err = os.RemoveAll(user.GetHomeDir())
  645. assert.NoError(t, err)
  646. }
  647. func TestRsyncOptions(t *testing.T) {
  648. permissions := make(map[string][]string)
  649. permissions["/"] = []string{dataprovider.PermAny}
  650. user := dataprovider.User{
  651. BaseUser: sdk.BaseUser{
  652. Permissions: permissions,
  653. HomeDir: filepath.Clean(os.TempDir()),
  654. },
  655. }
  656. conn := &Connection{
  657. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  658. }
  659. sshCmd := sshCommand{
  660. command: "rsync",
  661. connection: conn,
  662. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  663. }
  664. cmd, err := sshCmd.getSystemCommand()
  665. assert.NoError(t, err)
  666. assert.Equal(t, []string{"rsync", "--server", "-vlogDtprze.iLsfxC", "--safe-links", ".", user.HomeDir + string(os.PathSeparator)}, cmd.cmd.Args,
  667. "--safe-links must be added if the user has the create symlinks permission")
  668. permissions["/"] = []string{dataprovider.PermDownload, dataprovider.PermUpload, dataprovider.PermCreateDirs,
  669. dataprovider.PermListItems, dataprovider.PermOverwrite, dataprovider.PermDelete, dataprovider.PermRename}
  670. user.Permissions = permissions
  671. conn = &Connection{
  672. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  673. }
  674. sshCmd = sshCommand{
  675. command: "rsync",
  676. connection: conn,
  677. }
  678. _, err = sshCmd.getSystemCommand()
  679. assert.Error(t, err)
  680. sshCmd = sshCommand{
  681. command: "rsync",
  682. connection: conn,
  683. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  684. }
  685. cmd, err = sshCmd.getSystemCommand()
  686. assert.NoError(t, err)
  687. assert.Equal(t, []string{"rsync", "--server", "-vlogDtprze.iLsfxC", "--munge-links", ".", user.HomeDir + string(os.PathSeparator)}, cmd.cmd.Args,
  688. "--munge-links must be added if the user hasn't the create symlinks permission")
  689. sshCmd.connection.User.VirtualFolders = append(sshCmd.connection.User.VirtualFolders, vfs.VirtualFolder{
  690. BaseVirtualFolder: vfs.BaseVirtualFolder{
  691. MappedPath: os.TempDir(),
  692. },
  693. VirtualPath: "/vdir",
  694. })
  695. _, err = sshCmd.getSystemCommand()
  696. assert.EqualError(t, err, errUnsupportedConfig.Error())
  697. }
  698. func TestSystemCommandSizeForPath(t *testing.T) {
  699. permissions := make(map[string][]string)
  700. permissions["/"] = []string{dataprovider.PermAny}
  701. user := dataprovider.User{
  702. BaseUser: sdk.BaseUser{
  703. Permissions: permissions,
  704. HomeDir: os.TempDir(),
  705. },
  706. }
  707. fs, err := user.GetFilesystem("123")
  708. assert.NoError(t, err)
  709. conn := &Connection{
  710. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  711. }
  712. sshCmd := sshCommand{
  713. command: "rsync",
  714. connection: conn,
  715. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  716. }
  717. _, _, err = sshCmd.getSizeForPath(fs, "missing path")
  718. assert.NoError(t, err)
  719. testDir := filepath.Join(os.TempDir(), "dir")
  720. err = os.MkdirAll(testDir, os.ModePerm)
  721. assert.NoError(t, err)
  722. testFile := filepath.Join(testDir, "testfile")
  723. err = os.WriteFile(testFile, []byte("test content"), os.ModePerm)
  724. assert.NoError(t, err)
  725. err = os.Symlink(testFile, testFile+".link")
  726. assert.NoError(t, err)
  727. numFiles, size, err := sshCmd.getSizeForPath(fs, testFile+".link")
  728. assert.NoError(t, err)
  729. assert.Equal(t, 0, numFiles)
  730. assert.Equal(t, int64(0), size)
  731. numFiles, size, err = sshCmd.getSizeForPath(fs, testFile)
  732. assert.NoError(t, err)
  733. assert.Equal(t, 1, numFiles)
  734. assert.Equal(t, int64(12), size)
  735. if runtime.GOOS != osWindows {
  736. err = os.Chmod(testDir, 0001)
  737. assert.NoError(t, err)
  738. _, _, err = sshCmd.getSizeForPath(fs, testFile)
  739. assert.Error(t, err)
  740. err = os.Chmod(testDir, os.ModePerm)
  741. assert.NoError(t, err)
  742. }
  743. err = os.RemoveAll(testDir)
  744. assert.NoError(t, err)
  745. }
  746. func TestSystemCommandErrors(t *testing.T) {
  747. buf := make([]byte, 65535)
  748. stdErrBuf := make([]byte, 65535)
  749. readErr := fmt.Errorf("test read error")
  750. writeErr := fmt.Errorf("test write error")
  751. mockSSHChannel := MockChannel{
  752. Buffer: bytes.NewBuffer(buf),
  753. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  754. ReadError: nil,
  755. WriteError: writeErr,
  756. }
  757. permissions := make(map[string][]string)
  758. permissions["/"] = []string{dataprovider.PermAny}
  759. homeDir := filepath.Join(os.TempDir(), "adir")
  760. err := os.MkdirAll(homeDir, os.ModePerm)
  761. assert.NoError(t, err)
  762. err = os.WriteFile(filepath.Join(homeDir, "afile"), []byte("content"), os.ModePerm)
  763. assert.NoError(t, err)
  764. user := dataprovider.User{
  765. BaseUser: sdk.BaseUser{
  766. Permissions: permissions,
  767. HomeDir: homeDir,
  768. },
  769. }
  770. fs, err := user.GetFilesystem("123")
  771. assert.NoError(t, err)
  772. connection := &Connection{
  773. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  774. channel: &mockSSHChannel,
  775. }
  776. var sshCmd sshCommand
  777. if runtime.GOOS == osWindows {
  778. sshCmd = sshCommand{
  779. command: "dir",
  780. connection: connection,
  781. args: []string{"/"},
  782. }
  783. } else {
  784. sshCmd = sshCommand{
  785. command: "ls",
  786. connection: connection,
  787. args: []string{"/"},
  788. }
  789. }
  790. systemCmd, err := sshCmd.getSystemCommand()
  791. assert.NoError(t, err)
  792. systemCmd.cmd.Dir = os.TempDir()
  793. // FIXME: the command completes but the fake client is unable to read the response
  794. // no error is reported in this case. We can see that the expected code is executed
  795. // reading the test coverage
  796. sshCmd.executeSystemCommand(systemCmd) //nolint:errcheck
  797. mockSSHChannel = MockChannel{
  798. Buffer: bytes.NewBuffer(buf),
  799. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  800. ReadError: readErr,
  801. WriteError: nil,
  802. }
  803. sshCmd.connection.channel = &mockSSHChannel
  804. baseTransfer := common.NewBaseTransfer(nil, sshCmd.connection.BaseConnection, nil, "", "", "",
  805. common.TransferUpload, 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  806. transfer := newTransfer(baseTransfer, nil, nil, nil)
  807. destBuff := make([]byte, 65535)
  808. dst := bytes.NewBuffer(destBuff)
  809. _, err = transfer.copyFromReaderToWriter(dst, sshCmd.connection.channel)
  810. assert.EqualError(t, err, readErr.Error())
  811. mockSSHChannel = MockChannel{
  812. Buffer: bytes.NewBuffer(buf),
  813. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  814. ReadError: nil,
  815. WriteError: nil,
  816. }
  817. sshCmd.connection.channel = &mockSSHChannel
  818. transfer.MaxWriteSize = 1
  819. _, err = transfer.copyFromReaderToWriter(dst, sshCmd.connection.channel)
  820. assert.True(t, transfer.Connection.IsQuotaExceededError(err))
  821. mockSSHChannel = MockChannel{
  822. Buffer: bytes.NewBuffer(buf),
  823. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  824. ReadError: nil,
  825. WriteError: nil,
  826. ShortWriteErr: true,
  827. }
  828. sshCmd.connection.channel = &mockSSHChannel
  829. _, err = transfer.copyFromReaderToWriter(sshCmd.connection.channel, dst)
  830. assert.EqualError(t, err, io.ErrShortWrite.Error())
  831. transfer.MaxWriteSize = -1
  832. _, err = transfer.copyFromReaderToWriter(sshCmd.connection.channel, dst)
  833. assert.True(t, transfer.Connection.IsQuotaExceededError(err))
  834. err = transfer.Close()
  835. assert.Error(t, err)
  836. baseTransfer = common.NewBaseTransfer(nil, sshCmd.connection.BaseConnection, nil, "", "", "",
  837. common.TransferDownload, 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{
  838. AllowedDLSize: 1,
  839. })
  840. transfer = newTransfer(baseTransfer, nil, nil, nil)
  841. mockSSHChannel = MockChannel{
  842. Buffer: bytes.NewBuffer(buf),
  843. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  844. ReadError: nil,
  845. WriteError: nil,
  846. }
  847. sshCmd.connection.channel = &mockSSHChannel
  848. _, err = transfer.copyFromReaderToWriter(dst, sshCmd.connection.channel)
  849. if assert.Error(t, err) {
  850. assert.Contains(t, err.Error(), common.ErrReadQuotaExceeded.Error())
  851. }
  852. err = transfer.Close()
  853. assert.Error(t, err)
  854. err = os.RemoveAll(homeDir)
  855. assert.NoError(t, err)
  856. assert.Equal(t, int32(0), common.Connections.GetTotalTransfers())
  857. }
  858. func TestCommandGetFsError(t *testing.T) {
  859. user := dataprovider.User{
  860. FsConfig: vfs.Filesystem{
  861. Provider: sdk.CryptedFilesystemProvider,
  862. },
  863. }
  864. conn := &Connection{
  865. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  866. }
  867. sshCmd := sshCommand{
  868. command: "rsync",
  869. connection: conn,
  870. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  871. }
  872. _, err := sshCmd.getSystemCommand()
  873. assert.Error(t, err)
  874. buf := make([]byte, 65535)
  875. stdErrBuf := make([]byte, 65535)
  876. mockSSHChannel := MockChannel{
  877. Buffer: bytes.NewBuffer(buf),
  878. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  879. ReadError: nil,
  880. }
  881. conn = &Connection{
  882. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", user),
  883. channel: &mockSSHChannel,
  884. }
  885. scpCommand := scpCommand{
  886. sshCommand: sshCommand{
  887. command: "scp",
  888. connection: conn,
  889. args: []string{"-t", "/tmp"},
  890. },
  891. }
  892. err = scpCommand.handleRecursiveUpload()
  893. assert.Error(t, err)
  894. err = scpCommand.handleDownload("")
  895. assert.Error(t, err)
  896. }
  897. func TestSCPFileMode(t *testing.T) {
  898. mode := getFileModeAsString(0, true)
  899. assert.Equal(t, "0755", mode)
  900. mode = getFileModeAsString(0700, true)
  901. assert.Equal(t, "0700", mode)
  902. mode = getFileModeAsString(0750, true)
  903. assert.Equal(t, "0750", mode)
  904. mode = getFileModeAsString(0777, true)
  905. assert.Equal(t, "0777", mode)
  906. mode = getFileModeAsString(0640, false)
  907. assert.Equal(t, "0640", mode)
  908. mode = getFileModeAsString(0600, false)
  909. assert.Equal(t, "0600", mode)
  910. mode = getFileModeAsString(0, false)
  911. assert.Equal(t, "0644", mode)
  912. fileMode := uint32(0777)
  913. fileMode = fileMode | uint32(os.ModeSetgid)
  914. fileMode = fileMode | uint32(os.ModeSetuid)
  915. fileMode = fileMode | uint32(os.ModeSticky)
  916. mode = getFileModeAsString(os.FileMode(fileMode), false)
  917. assert.Equal(t, "7777", mode)
  918. fileMode = uint32(0644)
  919. fileMode = fileMode | uint32(os.ModeSetgid)
  920. mode = getFileModeAsString(os.FileMode(fileMode), false)
  921. assert.Equal(t, "4644", mode)
  922. fileMode = uint32(0600)
  923. fileMode = fileMode | uint32(os.ModeSetuid)
  924. mode = getFileModeAsString(os.FileMode(fileMode), false)
  925. assert.Equal(t, "2600", mode)
  926. fileMode = uint32(0044)
  927. fileMode = fileMode | uint32(os.ModeSticky)
  928. mode = getFileModeAsString(os.FileMode(fileMode), false)
  929. assert.Equal(t, "1044", mode)
  930. }
  931. func TestSCPUploadError(t *testing.T) {
  932. buf := make([]byte, 65535)
  933. stdErrBuf := make([]byte, 65535)
  934. writeErr := fmt.Errorf("test write error")
  935. mockSSHChannel := MockChannel{
  936. Buffer: bytes.NewBuffer(buf),
  937. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  938. ReadError: nil,
  939. WriteError: writeErr,
  940. }
  941. user := dataprovider.User{
  942. BaseUser: sdk.BaseUser{
  943. HomeDir: filepath.Join(os.TempDir()),
  944. Permissions: make(map[string][]string),
  945. },
  946. }
  947. user.Permissions["/"] = []string{dataprovider.PermAny}
  948. connection := &Connection{
  949. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  950. channel: &mockSSHChannel,
  951. }
  952. scpCommand := scpCommand{
  953. sshCommand: sshCommand{
  954. command: "scp",
  955. connection: connection,
  956. args: []string{"-t", "/"},
  957. },
  958. }
  959. err := scpCommand.handle()
  960. assert.EqualError(t, err, writeErr.Error())
  961. mockSSHChannel = MockChannel{
  962. Buffer: bytes.NewBuffer([]byte("D0755 0 testdir\n")),
  963. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  964. ReadError: nil,
  965. WriteError: writeErr,
  966. }
  967. err = scpCommand.handleRecursiveUpload()
  968. assert.EqualError(t, err, writeErr.Error())
  969. mockSSHChannel = MockChannel{
  970. Buffer: bytes.NewBuffer([]byte("D0755 a testdir\n")),
  971. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  972. ReadError: nil,
  973. WriteError: nil,
  974. }
  975. err = scpCommand.handleRecursiveUpload()
  976. assert.Error(t, err)
  977. }
  978. func TestSCPInvalidEndDir(t *testing.T) {
  979. stdErrBuf := make([]byte, 65535)
  980. mockSSHChannel := MockChannel{
  981. Buffer: bytes.NewBuffer([]byte("E\n")),
  982. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  983. }
  984. connection := &Connection{
  985. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", dataprovider.User{
  986. BaseUser: sdk.BaseUser{
  987. HomeDir: os.TempDir(),
  988. },
  989. }),
  990. channel: &mockSSHChannel,
  991. }
  992. scpCommand := scpCommand{
  993. sshCommand: sshCommand{
  994. command: "scp",
  995. connection: connection,
  996. args: []string{"-t", "/tmp"},
  997. },
  998. }
  999. err := scpCommand.handleRecursiveUpload()
  1000. assert.EqualError(t, err, "unacceptable end dir command")
  1001. }
  1002. func TestSCPParseUploadMessage(t *testing.T) {
  1003. buf := make([]byte, 65535)
  1004. stdErrBuf := make([]byte, 65535)
  1005. mockSSHChannel := MockChannel{
  1006. Buffer: bytes.NewBuffer(buf),
  1007. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1008. ReadError: nil,
  1009. }
  1010. fs := vfs.NewOsFs("", os.TempDir(), "", nil)
  1011. connection := &Connection{
  1012. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", dataprovider.User{
  1013. BaseUser: sdk.BaseUser{
  1014. HomeDir: os.TempDir(),
  1015. },
  1016. }),
  1017. channel: &mockSSHChannel,
  1018. }
  1019. scpCommand := scpCommand{
  1020. sshCommand: sshCommand{
  1021. command: "scp",
  1022. connection: connection,
  1023. args: []string{"-t", "/tmp"},
  1024. },
  1025. }
  1026. _, _, err := scpCommand.parseUploadMessage(fs, "invalid")
  1027. assert.Error(t, err, "parsing invalid upload message must fail")
  1028. _, _, err = scpCommand.parseUploadMessage(fs, "D0755 0")
  1029. assert.Error(t, err, "parsing incomplete upload message must fail")
  1030. _, _, err = scpCommand.parseUploadMessage(fs, "D0755 invalidsize testdir")
  1031. assert.Error(t, err, "parsing upload message with invalid size must fail")
  1032. _, _, err = scpCommand.parseUploadMessage(fs, "D0755 0 ")
  1033. assert.Error(t, err, "parsing upload message with invalid name must fail")
  1034. }
  1035. func TestSCPProtocolMessages(t *testing.T) {
  1036. buf := make([]byte, 65535)
  1037. stdErrBuf := make([]byte, 65535)
  1038. readErr := fmt.Errorf("test read error")
  1039. writeErr := fmt.Errorf("test write error")
  1040. mockSSHChannel := MockChannel{
  1041. Buffer: bytes.NewBuffer(buf),
  1042. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1043. ReadError: readErr,
  1044. WriteError: writeErr,
  1045. }
  1046. connection := &Connection{
  1047. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{}),
  1048. channel: &mockSSHChannel,
  1049. }
  1050. scpCommand := scpCommand{
  1051. sshCommand: sshCommand{
  1052. command: "scp",
  1053. connection: connection,
  1054. args: []string{"-t", "/tmp"},
  1055. },
  1056. }
  1057. _, err := scpCommand.readProtocolMessage()
  1058. assert.EqualError(t, err, readErr.Error())
  1059. err = scpCommand.sendConfirmationMessage()
  1060. assert.EqualError(t, err, writeErr.Error())
  1061. err = scpCommand.sendProtocolMessage("E\n")
  1062. assert.EqualError(t, err, writeErr.Error())
  1063. _, err = scpCommand.getNextUploadProtocolMessage()
  1064. assert.EqualError(t, err, readErr.Error())
  1065. mockSSHChannel = MockChannel{
  1066. Buffer: bytes.NewBuffer([]byte("T1183832947 0 1183833773 0\n")),
  1067. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1068. ReadError: nil,
  1069. WriteError: writeErr,
  1070. }
  1071. scpCommand.connection.channel = &mockSSHChannel
  1072. _, err = scpCommand.getNextUploadProtocolMessage()
  1073. assert.EqualError(t, err, writeErr.Error())
  1074. respBuffer := []byte{0x02}
  1075. protocolErrorMsg := "protocol error msg"
  1076. respBuffer = append(respBuffer, protocolErrorMsg...)
  1077. respBuffer = append(respBuffer, 0x0A)
  1078. mockSSHChannel = MockChannel{
  1079. Buffer: bytes.NewBuffer(respBuffer),
  1080. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1081. ReadError: nil,
  1082. WriteError: nil,
  1083. }
  1084. scpCommand.connection.channel = &mockSSHChannel
  1085. err = scpCommand.readConfirmationMessage()
  1086. if assert.Error(t, err) {
  1087. assert.Equal(t, protocolErrorMsg, err.Error())
  1088. }
  1089. mockSSHChannel = MockChannel{
  1090. Buffer: bytes.NewBuffer(respBuffer),
  1091. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1092. ReadError: nil,
  1093. WriteError: writeErr,
  1094. }
  1095. scpCommand.connection.channel = &mockSSHChannel
  1096. err = scpCommand.downloadDirs(nil, nil)
  1097. assert.ErrorIs(t, err, writeErr)
  1098. }
  1099. func TestSCPTestDownloadProtocolMessages(t *testing.T) {
  1100. buf := make([]byte, 65535)
  1101. stdErrBuf := make([]byte, 65535)
  1102. readErr := fmt.Errorf("test read error")
  1103. writeErr := fmt.Errorf("test write error")
  1104. mockSSHChannel := MockChannel{
  1105. Buffer: bytes.NewBuffer(buf),
  1106. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1107. ReadError: readErr,
  1108. WriteError: writeErr,
  1109. }
  1110. connection := &Connection{
  1111. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{}),
  1112. channel: &mockSSHChannel,
  1113. }
  1114. scpCommand := scpCommand{
  1115. sshCommand: sshCommand{
  1116. command: "scp",
  1117. connection: connection,
  1118. args: []string{"-f", "-p", "/tmp"},
  1119. },
  1120. }
  1121. path := "testDir"
  1122. err := os.Mkdir(path, os.ModePerm)
  1123. assert.NoError(t, err)
  1124. stat, err := os.Stat(path)
  1125. assert.NoError(t, err)
  1126. err = scpCommand.sendDownloadProtocolMessages(path, stat)
  1127. assert.EqualError(t, err, writeErr.Error())
  1128. mockSSHChannel = MockChannel{
  1129. Buffer: bytes.NewBuffer(buf),
  1130. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1131. ReadError: readErr,
  1132. WriteError: nil,
  1133. }
  1134. err = scpCommand.sendDownloadProtocolMessages(path, stat)
  1135. assert.EqualError(t, err, readErr.Error())
  1136. mockSSHChannel = MockChannel{
  1137. Buffer: bytes.NewBuffer(buf),
  1138. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1139. ReadError: readErr,
  1140. WriteError: writeErr,
  1141. }
  1142. scpCommand.args = []string{"-f", "/tmp"}
  1143. scpCommand.connection.channel = &mockSSHChannel
  1144. err = scpCommand.sendDownloadProtocolMessages(path, stat)
  1145. assert.EqualError(t, err, writeErr.Error())
  1146. mockSSHChannel = MockChannel{
  1147. Buffer: bytes.NewBuffer(buf),
  1148. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1149. ReadError: readErr,
  1150. WriteError: nil,
  1151. }
  1152. scpCommand.connection.channel = &mockSSHChannel
  1153. err = scpCommand.sendDownloadProtocolMessages(path, stat)
  1154. assert.EqualError(t, err, readErr.Error())
  1155. err = os.Remove(path)
  1156. assert.NoError(t, err)
  1157. }
  1158. func TestSCPCommandHandleErrors(t *testing.T) {
  1159. buf := make([]byte, 65535)
  1160. stdErrBuf := make([]byte, 65535)
  1161. readErr := fmt.Errorf("test read error")
  1162. writeErr := fmt.Errorf("test write error")
  1163. mockSSHChannel := MockChannel{
  1164. Buffer: bytes.NewBuffer(buf),
  1165. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1166. ReadError: readErr,
  1167. WriteError: writeErr,
  1168. }
  1169. server, client := net.Pipe()
  1170. defer func() {
  1171. err := server.Close()
  1172. assert.NoError(t, err)
  1173. }()
  1174. defer func() {
  1175. err := client.Close()
  1176. assert.NoError(t, err)
  1177. }()
  1178. connection := &Connection{
  1179. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{}),
  1180. channel: &mockSSHChannel,
  1181. }
  1182. scpCommand := scpCommand{
  1183. sshCommand: sshCommand{
  1184. command: "scp",
  1185. connection: connection,
  1186. args: []string{"-f", "/tmp"},
  1187. },
  1188. }
  1189. err := scpCommand.handle()
  1190. assert.EqualError(t, err, readErr.Error())
  1191. scpCommand.args = []string{"-i", "/tmp"}
  1192. err = scpCommand.handle()
  1193. assert.Error(t, err, "invalid scp command must fail")
  1194. }
  1195. func TestSCPErrorsMockFs(t *testing.T) {
  1196. errFake := errors.New("fake error")
  1197. u := dataprovider.User{}
  1198. u.Username = "test"
  1199. u.Permissions = make(map[string][]string)
  1200. u.Permissions["/"] = []string{dataprovider.PermAny}
  1201. u.HomeDir = os.TempDir()
  1202. buf := make([]byte, 65535)
  1203. stdErrBuf := make([]byte, 65535)
  1204. mockSSHChannel := MockChannel{
  1205. Buffer: bytes.NewBuffer(buf),
  1206. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1207. }
  1208. server, client := net.Pipe()
  1209. defer func() {
  1210. err := server.Close()
  1211. assert.NoError(t, err)
  1212. }()
  1213. defer func() {
  1214. err := client.Close()
  1215. assert.NoError(t, err)
  1216. }()
  1217. connection := &Connection{
  1218. channel: &mockSSHChannel,
  1219. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", u),
  1220. }
  1221. scpCommand := scpCommand{
  1222. sshCommand: sshCommand{
  1223. command: "scp",
  1224. connection: connection,
  1225. args: []string{"-r", "-t", "/tmp"},
  1226. },
  1227. }
  1228. testfile := filepath.Join(u.HomeDir, "testfile")
  1229. err := os.WriteFile(testfile, []byte("test"), os.ModePerm)
  1230. assert.NoError(t, err)
  1231. fs := newMockOsFs(errFake, nil, true, "123", os.TempDir())
  1232. err = scpCommand.handleUploadFile(fs, testfile, testfile, 0, false, 4, "/testfile")
  1233. assert.NoError(t, err)
  1234. err = os.Remove(testfile)
  1235. assert.NoError(t, err)
  1236. }
  1237. func TestSCPRecursiveDownloadErrors(t *testing.T) {
  1238. buf := make([]byte, 65535)
  1239. stdErrBuf := make([]byte, 65535)
  1240. readErr := fmt.Errorf("test read error")
  1241. writeErr := fmt.Errorf("test write error")
  1242. mockSSHChannel := MockChannel{
  1243. Buffer: bytes.NewBuffer(buf),
  1244. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1245. ReadError: readErr,
  1246. WriteError: writeErr,
  1247. }
  1248. server, client := net.Pipe()
  1249. defer func() {
  1250. err := server.Close()
  1251. assert.NoError(t, err)
  1252. }()
  1253. defer func() {
  1254. err := client.Close()
  1255. assert.NoError(t, err)
  1256. }()
  1257. fs := vfs.NewOsFs("123", os.TempDir(), "", nil)
  1258. connection := &Connection{
  1259. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{
  1260. BaseUser: sdk.BaseUser{
  1261. HomeDir: os.TempDir(),
  1262. },
  1263. }),
  1264. channel: &mockSSHChannel,
  1265. }
  1266. scpCommand := scpCommand{
  1267. sshCommand: sshCommand{
  1268. command: "scp",
  1269. connection: connection,
  1270. args: []string{"-r", "-f", "/tmp"},
  1271. },
  1272. }
  1273. path := "testDir"
  1274. err := os.Mkdir(path, os.ModePerm)
  1275. assert.NoError(t, err)
  1276. stat, err := os.Stat(path)
  1277. assert.NoError(t, err)
  1278. err = scpCommand.handleRecursiveDownload(fs, "invalid_dir", "invalid_dir", stat)
  1279. assert.EqualError(t, err, writeErr.Error())
  1280. mockSSHChannel = MockChannel{
  1281. Buffer: bytes.NewBuffer(buf),
  1282. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1283. ReadError: nil,
  1284. WriteError: nil,
  1285. }
  1286. scpCommand.connection.channel = &mockSSHChannel
  1287. err = scpCommand.handleRecursiveDownload(fs, "invalid_dir", "invalid_dir", stat)
  1288. assert.Error(t, err, "recursive upload download must fail for a non existing dir")
  1289. err = os.Remove(path)
  1290. assert.NoError(t, err)
  1291. }
  1292. func TestSCPRecursiveUploadErrors(t *testing.T) {
  1293. buf := make([]byte, 65535)
  1294. stdErrBuf := make([]byte, 65535)
  1295. readErr := fmt.Errorf("test read error")
  1296. writeErr := fmt.Errorf("test write error")
  1297. mockSSHChannel := MockChannel{
  1298. Buffer: bytes.NewBuffer(buf),
  1299. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1300. ReadError: readErr,
  1301. WriteError: writeErr,
  1302. }
  1303. connection := &Connection{
  1304. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{}),
  1305. channel: &mockSSHChannel,
  1306. }
  1307. scpCommand := scpCommand{
  1308. sshCommand: sshCommand{
  1309. command: "scp",
  1310. connection: connection,
  1311. args: []string{"-r", "-t", "/tmp"},
  1312. },
  1313. }
  1314. err := scpCommand.handleRecursiveUpload()
  1315. assert.Error(t, err, "recursive upload must fail, we send a fake error message")
  1316. mockSSHChannel = MockChannel{
  1317. Buffer: bytes.NewBuffer(buf),
  1318. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1319. ReadError: readErr,
  1320. WriteError: nil,
  1321. }
  1322. scpCommand.connection.channel = &mockSSHChannel
  1323. err = scpCommand.handleRecursiveUpload()
  1324. assert.Error(t, err, "recursive upload must fail, we send a fake error message")
  1325. }
  1326. func TestSCPCreateDirs(t *testing.T) {
  1327. buf := make([]byte, 65535)
  1328. stdErrBuf := make([]byte, 65535)
  1329. u := dataprovider.User{}
  1330. u.HomeDir = "home_rel_path"
  1331. u.Username = "test"
  1332. u.Permissions = make(map[string][]string)
  1333. u.Permissions["/"] = []string{dataprovider.PermAny}
  1334. mockSSHChannel := MockChannel{
  1335. Buffer: bytes.NewBuffer(buf),
  1336. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1337. ReadError: nil,
  1338. WriteError: nil,
  1339. }
  1340. fs, err := u.GetFilesystem("123")
  1341. assert.NoError(t, err)
  1342. connection := &Connection{
  1343. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", u),
  1344. channel: &mockSSHChannel,
  1345. }
  1346. scpCommand := scpCommand{
  1347. sshCommand: sshCommand{
  1348. command: "scp",
  1349. connection: connection,
  1350. args: []string{"-r", "-t", "/tmp"},
  1351. },
  1352. }
  1353. err = scpCommand.handleCreateDir(fs, "invalid_dir")
  1354. assert.Error(t, err, "create invalid dir must fail")
  1355. }
  1356. func TestSCPDownloadFileData(t *testing.T) {
  1357. testfile := "testfile"
  1358. buf := make([]byte, 65535)
  1359. readErr := fmt.Errorf("test read error")
  1360. writeErr := fmt.Errorf("test write error")
  1361. stdErrBuf := make([]byte, 65535)
  1362. mockSSHChannelReadErr := MockChannel{
  1363. Buffer: bytes.NewBuffer(buf),
  1364. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1365. ReadError: readErr,
  1366. WriteError: nil,
  1367. }
  1368. mockSSHChannelWriteErr := MockChannel{
  1369. Buffer: bytes.NewBuffer(buf),
  1370. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1371. ReadError: nil,
  1372. WriteError: writeErr,
  1373. }
  1374. fs := vfs.NewOsFs("", os.TempDir(), "", nil)
  1375. connection := &Connection{
  1376. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{BaseUser: sdk.BaseUser{HomeDir: os.TempDir()}}),
  1377. channel: &mockSSHChannelReadErr,
  1378. }
  1379. scpCommand := scpCommand{
  1380. sshCommand: sshCommand{
  1381. command: "scp",
  1382. connection: connection,
  1383. args: []string{"-r", "-f", "/tmp"},
  1384. },
  1385. }
  1386. err := os.WriteFile(testfile, []byte("test"), os.ModePerm)
  1387. assert.NoError(t, err)
  1388. stat, err := os.Stat(testfile)
  1389. assert.NoError(t, err)
  1390. err = scpCommand.sendDownloadFileData(fs, testfile, stat, nil)
  1391. assert.EqualError(t, err, readErr.Error())
  1392. scpCommand.connection.channel = &mockSSHChannelWriteErr
  1393. err = scpCommand.sendDownloadFileData(fs, testfile, stat, nil)
  1394. assert.EqualError(t, err, writeErr.Error())
  1395. scpCommand.args = []string{"-r", "-p", "-f", "/tmp"}
  1396. err = scpCommand.sendDownloadFileData(fs, testfile, stat, nil)
  1397. assert.EqualError(t, err, writeErr.Error())
  1398. scpCommand.connection.channel = &mockSSHChannelReadErr
  1399. err = scpCommand.sendDownloadFileData(fs, testfile, stat, nil)
  1400. assert.EqualError(t, err, readErr.Error())
  1401. err = os.Remove(testfile)
  1402. assert.NoError(t, err)
  1403. }
  1404. func TestSCPUploadFiledata(t *testing.T) {
  1405. testfile := "testfile"
  1406. buf := make([]byte, 65535)
  1407. stdErrBuf := make([]byte, 65535)
  1408. readErr := fmt.Errorf("test read error")
  1409. writeErr := fmt.Errorf("test write error")
  1410. mockSSHChannel := MockChannel{
  1411. Buffer: bytes.NewBuffer(buf),
  1412. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1413. ReadError: readErr,
  1414. WriteError: writeErr,
  1415. }
  1416. user := dataprovider.User{
  1417. BaseUser: sdk.BaseUser{
  1418. Username: "testuser",
  1419. },
  1420. }
  1421. fs := vfs.NewOsFs("", os.TempDir(), "", nil)
  1422. connection := &Connection{
  1423. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", user),
  1424. channel: &mockSSHChannel,
  1425. }
  1426. scpCommand := scpCommand{
  1427. sshCommand: sshCommand{
  1428. command: "scp",
  1429. connection: connection,
  1430. args: []string{"-r", "-t", "/tmp"},
  1431. },
  1432. }
  1433. file, err := os.Create(testfile)
  1434. assert.NoError(t, err)
  1435. baseTransfer := common.NewBaseTransfer(file, scpCommand.connection.BaseConnection, nil, file.Name(), file.Name(),
  1436. "/"+testfile, common.TransferDownload, 0, 0, 0, 0, true, fs, dataprovider.TransferQuota{})
  1437. transfer := newTransfer(baseTransfer, nil, nil, nil)
  1438. err = scpCommand.getUploadFileData(2, transfer)
  1439. assert.Error(t, err, "upload must fail, we send a fake write error message")
  1440. mockSSHChannel = MockChannel{
  1441. Buffer: bytes.NewBuffer(buf),
  1442. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1443. ReadError: readErr,
  1444. WriteError: nil,
  1445. }
  1446. scpCommand.connection.channel = &mockSSHChannel
  1447. file, err = os.Create(testfile)
  1448. assert.NoError(t, err)
  1449. transfer.File = file
  1450. transfer.isFinished = false
  1451. transfer.Connection.AddTransfer(transfer)
  1452. err = scpCommand.getUploadFileData(2, transfer)
  1453. assert.Error(t, err, "upload must fail, we send a fake read error message")
  1454. respBuffer := []byte("12")
  1455. respBuffer = append(respBuffer, 0x02)
  1456. mockSSHChannel = MockChannel{
  1457. Buffer: bytes.NewBuffer(respBuffer),
  1458. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1459. ReadError: nil,
  1460. WriteError: nil,
  1461. }
  1462. scpCommand.connection.channel = &mockSSHChannel
  1463. file, err = os.Create(testfile)
  1464. assert.NoError(t, err)
  1465. baseTransfer.File = file
  1466. transfer = newTransfer(baseTransfer, nil, nil, nil)
  1467. transfer.Connection.AddTransfer(transfer)
  1468. err = scpCommand.getUploadFileData(2, transfer)
  1469. assert.Error(t, err, "upload must fail, we have not enough data to read")
  1470. // the file is already closed so we have an error on trasfer closing
  1471. mockSSHChannel = MockChannel{
  1472. Buffer: bytes.NewBuffer(buf),
  1473. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1474. ReadError: nil,
  1475. WriteError: nil,
  1476. }
  1477. transfer.Connection.AddTransfer(transfer)
  1478. err = scpCommand.getUploadFileData(0, transfer)
  1479. if assert.Error(t, err) {
  1480. assert.EqualError(t, err, common.ErrTransferClosed.Error())
  1481. }
  1482. transfer.Connection.RemoveTransfer(transfer)
  1483. mockSSHChannel = MockChannel{
  1484. Buffer: bytes.NewBuffer(buf),
  1485. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1486. ReadError: nil,
  1487. WriteError: nil,
  1488. }
  1489. transfer.Connection.AddTransfer(transfer)
  1490. err = scpCommand.getUploadFileData(2, transfer)
  1491. assert.ErrorContains(t, err, os.ErrClosed.Error())
  1492. transfer.Connection.RemoveTransfer(transfer)
  1493. err = os.Remove(testfile)
  1494. assert.NoError(t, err)
  1495. assert.Equal(t, int32(0), common.Connections.GetTotalTransfers())
  1496. }
  1497. func TestUploadError(t *testing.T) {
  1498. common.Config.UploadMode = common.UploadModeAtomic
  1499. user := dataprovider.User{
  1500. BaseUser: sdk.BaseUser{
  1501. Username: "testuser",
  1502. },
  1503. }
  1504. fs := vfs.NewOsFs("", os.TempDir(), "", nil)
  1505. connection := &Connection{
  1506. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", user),
  1507. }
  1508. testfile := "testfile"
  1509. fileTempName := "temptestfile"
  1510. file, err := os.Create(fileTempName)
  1511. assert.NoError(t, err)
  1512. baseTransfer := common.NewBaseTransfer(file, connection.BaseConnection, nil, testfile, file.Name(),
  1513. testfile, common.TransferUpload, 0, 0, 0, 0, true, fs, dataprovider.TransferQuota{})
  1514. transfer := newTransfer(baseTransfer, nil, nil, nil)
  1515. errFake := errors.New("fake error")
  1516. transfer.TransferError(errFake)
  1517. err = transfer.Close()
  1518. if assert.Error(t, err) {
  1519. assert.EqualError(t, err, common.ErrGenericFailure.Error())
  1520. }
  1521. if assert.Error(t, transfer.ErrTransfer) {
  1522. assert.EqualError(t, transfer.ErrTransfer, errFake.Error())
  1523. }
  1524. assert.Equal(t, int64(0), transfer.BytesReceived.Load())
  1525. assert.NoFileExists(t, testfile)
  1526. assert.NoFileExists(t, fileTempName)
  1527. common.Config.UploadMode = common.UploadModeAtomicWithResume
  1528. }
  1529. func TestTransferFailingReader(t *testing.T) {
  1530. user := dataprovider.User{
  1531. BaseUser: sdk.BaseUser{
  1532. Username: "testuser",
  1533. HomeDir: os.TempDir(),
  1534. },
  1535. FsConfig: vfs.Filesystem{
  1536. Provider: sdk.CryptedFilesystemProvider,
  1537. CryptConfig: vfs.CryptFsConfig{
  1538. Passphrase: kms.NewPlainSecret("crypt secret"),
  1539. },
  1540. },
  1541. }
  1542. user.Permissions = make(map[string][]string)
  1543. user.Permissions["/"] = []string{dataprovider.PermAny}
  1544. fs := newMockOsFs(nil, nil, true, "", os.TempDir())
  1545. connection := &Connection{
  1546. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  1547. }
  1548. request := sftp.NewRequest("Open", "afile.txt")
  1549. request.Flags = 27 // read,write,create,truncate
  1550. transfer, err := connection.handleFilewrite(request)
  1551. require.NoError(t, err)
  1552. buf := make([]byte, 32)
  1553. _, err = transfer.ReadAt(buf, 0)
  1554. assert.ErrorIs(t, err, sftp.ErrSSHFxOpUnsupported)
  1555. if c, ok := transfer.(io.Closer); ok {
  1556. err = c.Close()
  1557. assert.NoError(t, err)
  1558. }
  1559. fsPath := filepath.Join(os.TempDir(), "afile.txt")
  1560. r, _, err := pipeat.Pipe()
  1561. assert.NoError(t, err)
  1562. baseTransfer := common.NewBaseTransfer(nil, connection.BaseConnection, nil, fsPath, fsPath, filepath.Base(fsPath),
  1563. common.TransferUpload, 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  1564. errRead := errors.New("read is not allowed")
  1565. tr := newTransfer(baseTransfer, nil, vfs.NewPipeReader(r), errRead)
  1566. _, err = tr.ReadAt(buf, 0)
  1567. assert.ErrorIs(t, err, sftp.ErrSSHFxFailure)
  1568. err = tr.Close()
  1569. assert.NoError(t, err)
  1570. tr = newTransfer(baseTransfer, nil, nil, errRead)
  1571. _, err = tr.ReadAt(buf, 0)
  1572. assert.ErrorIs(t, err, sftp.ErrSSHFxFailure)
  1573. err = tr.Close()
  1574. assert.NoError(t, err)
  1575. err = os.Remove(fsPath)
  1576. assert.NoError(t, err)
  1577. assert.Len(t, connection.GetTransfers(), 0)
  1578. }
  1579. func TestConfigsFromProvider(t *testing.T) {
  1580. err := dataprovider.UpdateConfigs(nil, "", "", "")
  1581. assert.NoError(t, err)
  1582. c := Configuration{}
  1583. err = c.loadFromProvider()
  1584. assert.NoError(t, err)
  1585. assert.Len(t, c.HostKeyAlgorithms, 0)
  1586. assert.Len(t, c.KexAlgorithms, 0)
  1587. assert.Len(t, c.Ciphers, 0)
  1588. assert.Len(t, c.MACs, 0)
  1589. assert.Len(t, c.PublicKeyAlgorithms, 0)
  1590. configs := dataprovider.Configs{
  1591. SFTPD: &dataprovider.SFTPDConfigs{
  1592. HostKeyAlgos: []string{ssh.KeyAlgoRSA},
  1593. KexAlgorithms: []string{ssh.InsecureKeyExchangeDHGEXSHA1},
  1594. Ciphers: []string{ssh.InsecureCipherAES128CBC},
  1595. MACs: []string{ssh.HMACSHA512ETM},
  1596. PublicKeyAlgos: []string{ssh.InsecureKeyAlgoDSA}, //nolint:staticcheck
  1597. },
  1598. }
  1599. err = dataprovider.UpdateConfigs(&configs, "", "", "")
  1600. assert.NoError(t, err)
  1601. err = c.loadFromProvider()
  1602. assert.NoError(t, err)
  1603. expectedHostKeyAlgos := append(preferredHostKeyAlgos, configs.SFTPD.HostKeyAlgos...)
  1604. expectedKEXs := append(preferredKexAlgos, configs.SFTPD.KexAlgorithms...)
  1605. expectedCiphers := append(preferredCiphers, configs.SFTPD.Ciphers...)
  1606. expectedMACs := append(preferredMACs, configs.SFTPD.MACs...)
  1607. expectedPublicKeyAlgos := append(preferredPublicKeyAlgos, configs.SFTPD.PublicKeyAlgos...)
  1608. assert.Equal(t, expectedHostKeyAlgos, c.HostKeyAlgorithms)
  1609. assert.Equal(t, expectedKEXs, c.KexAlgorithms)
  1610. assert.Equal(t, expectedCiphers, c.Ciphers)
  1611. assert.Equal(t, expectedMACs, c.MACs)
  1612. assert.Equal(t, expectedPublicKeyAlgos, c.PublicKeyAlgorithms)
  1613. err = dataprovider.UpdateConfigs(nil, "", "", "")
  1614. assert.NoError(t, err)
  1615. }
  1616. func TestSupportedSecurityOptions(t *testing.T) {
  1617. c := Configuration{
  1618. KexAlgorithms: supportedKexAlgos,
  1619. MACs: supportedMACs,
  1620. Ciphers: supportedCiphers,
  1621. }
  1622. var defaultKexs []string
  1623. for _, k := range supportedKexAlgos {
  1624. defaultKexs = append(defaultKexs, k)
  1625. if k == ssh.KeyExchangeCurve25519 {
  1626. defaultKexs = append(defaultKexs, keyExchangeCurve25519SHA256LibSSH)
  1627. }
  1628. }
  1629. serverConfig := &ssh.ServerConfig{}
  1630. err := c.configureSecurityOptions(serverConfig)
  1631. assert.NoError(t, err)
  1632. assert.Equal(t, supportedCiphers, serverConfig.Ciphers)
  1633. assert.Equal(t, supportedMACs, serverConfig.MACs)
  1634. assert.Equal(t, defaultKexs, serverConfig.KeyExchanges)
  1635. c.KexAlgorithms = append(c.KexAlgorithms, "not a kex")
  1636. err = c.configureSecurityOptions(serverConfig)
  1637. assert.Error(t, err)
  1638. c.KexAlgorithms = append(supportedKexAlgos, "diffie-hellman-group18-sha512")
  1639. c.MACs = []string{
  1640. " [email protected] ", " [email protected]",
  1641. "hmac-sha2-256", "hmac-sha2-512 ",
  1642. "hmac-sha1 ", " hmac-sha1-96",
  1643. }
  1644. err = c.configureSecurityOptions(serverConfig)
  1645. assert.NoError(t, err)
  1646. assert.Equal(t, supportedCiphers, serverConfig.Ciphers)
  1647. assert.Equal(t, supportedMACs, serverConfig.MACs)
  1648. assert.Equal(t, defaultKexs, serverConfig.KeyExchanges)
  1649. }
  1650. func TestLoadHostKeys(t *testing.T) {
  1651. serverConfig := &ssh.ServerConfig{}
  1652. c := Configuration{}
  1653. c.HostKeys = []string{".", "missing file"}
  1654. err := c.checkAndLoadHostKeys(configDir, serverConfig)
  1655. assert.Error(t, err)
  1656. testfile := filepath.Join(os.TempDir(), "invalidkey")
  1657. err = os.WriteFile(testfile, []byte("some bytes"), os.ModePerm)
  1658. assert.NoError(t, err)
  1659. c.HostKeys = []string{testfile}
  1660. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1661. assert.Error(t, err)
  1662. err = os.Remove(testfile)
  1663. assert.NoError(t, err)
  1664. keysDir := filepath.Join(os.TempDir(), "keys")
  1665. err = os.MkdirAll(keysDir, os.ModePerm)
  1666. assert.NoError(t, err)
  1667. rsaKeyName := filepath.Join(keysDir, defaultPrivateRSAKeyName)
  1668. ecdsaKeyName := filepath.Join(keysDir, defaultPrivateECDSAKeyName)
  1669. ed25519KeyName := filepath.Join(keysDir, defaultPrivateEd25519KeyName)
  1670. nonDefaultKeyName := filepath.Join(keysDir, "akey")
  1671. c.HostKeys = []string{nonDefaultKeyName, rsaKeyName, ecdsaKeyName, ed25519KeyName}
  1672. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1673. assert.Error(t, err)
  1674. c.HostKeyAlgorithms = []string{ssh.KeyAlgoRSASHA256}
  1675. c.HostKeys = []string{ecdsaKeyName}
  1676. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1677. assert.Error(t, err)
  1678. c.HostKeyAlgorithms = preferredHostKeyAlgos
  1679. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1680. assert.NoError(t, err)
  1681. assert.FileExists(t, rsaKeyName)
  1682. assert.FileExists(t, ecdsaKeyName)
  1683. assert.FileExists(t, ed25519KeyName)
  1684. assert.NoFileExists(t, nonDefaultKeyName)
  1685. err = os.Remove(rsaKeyName)
  1686. assert.NoError(t, err)
  1687. err = os.Remove(ecdsaKeyName)
  1688. assert.NoError(t, err)
  1689. err = os.Remove(ed25519KeyName)
  1690. assert.NoError(t, err)
  1691. if runtime.GOOS != osWindows {
  1692. err = os.Chmod(keysDir, 0551)
  1693. assert.NoError(t, err)
  1694. c.HostKeys = nil
  1695. err = c.checkAndLoadHostKeys(keysDir, serverConfig)
  1696. assert.Error(t, err)
  1697. c.HostKeys = []string{rsaKeyName, ecdsaKeyName}
  1698. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1699. assert.Error(t, err)
  1700. c.HostKeys = []string{ecdsaKeyName, rsaKeyName}
  1701. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1702. assert.Error(t, err)
  1703. c.HostKeys = []string{ed25519KeyName}
  1704. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1705. assert.Error(t, err)
  1706. err = os.Chmod(keysDir, 0755)
  1707. assert.NoError(t, err)
  1708. }
  1709. err = os.RemoveAll(keysDir)
  1710. assert.NoError(t, err)
  1711. }
  1712. func TestCertCheckerInitErrors(t *testing.T) {
  1713. c := Configuration{}
  1714. c.TrustedUserCAKeys = []string{".", "missing file"}
  1715. err := c.initializeCertChecker("")
  1716. assert.Error(t, err)
  1717. testfile := filepath.Join(os.TempDir(), "invalidkey")
  1718. err = os.WriteFile(testfile, []byte("some bytes"), os.ModePerm)
  1719. assert.NoError(t, err)
  1720. c.TrustedUserCAKeys = []string{testfile}
  1721. err = c.initializeCertChecker("")
  1722. assert.Error(t, err)
  1723. err = os.Remove(testfile)
  1724. assert.NoError(t, err)
  1725. }
  1726. func TestSFTPSubSystem(t *testing.T) {
  1727. permissions := make(map[string][]string)
  1728. permissions["/"] = []string{dataprovider.PermAny}
  1729. user := &dataprovider.User{
  1730. BaseUser: sdk.BaseUser{
  1731. Permissions: permissions,
  1732. HomeDir: os.TempDir(),
  1733. },
  1734. }
  1735. user.FsConfig.Provider = sdk.AzureBlobFilesystemProvider
  1736. err := ServeSubSystemConnection(user, "connID", nil, nil)
  1737. assert.Error(t, err)
  1738. user.FsConfig.Provider = sdk.LocalFilesystemProvider
  1739. buf := make([]byte, 0, 4096)
  1740. stdErrBuf := make([]byte, 0, 4096)
  1741. mockSSHChannel := &MockChannel{
  1742. Buffer: bytes.NewBuffer(buf),
  1743. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1744. }
  1745. // this is 327680 and it will result in packet too long error
  1746. _, err = mockSSHChannel.Write([]byte{0x00, 0x05, 0x00, 0x00, 0x00, 0x00})
  1747. assert.NoError(t, err)
  1748. err = ServeSubSystemConnection(user, "id", mockSSHChannel, mockSSHChannel)
  1749. assert.EqualError(t, err, "packet too long")
  1750. subsystemChannel := newSubsystemChannel(mockSSHChannel, mockSSHChannel)
  1751. n, err := subsystemChannel.Write([]byte{0x00})
  1752. assert.NoError(t, err)
  1753. assert.Equal(t, n, 1)
  1754. err = subsystemChannel.Close()
  1755. assert.NoError(t, err)
  1756. }
  1757. func TestRecoverer(t *testing.T) {
  1758. c := Configuration{}
  1759. c.AcceptInboundConnection(nil, nil)
  1760. connID := "connectionID"
  1761. connection := &Connection{
  1762. BaseConnection: common.NewBaseConnection(connID, common.ProtocolSFTP, "", "", dataprovider.User{}),
  1763. }
  1764. c.handleSftpConnection(nil, connection)
  1765. sshCmd := sshCommand{
  1766. command: "cd",
  1767. connection: connection,
  1768. }
  1769. err := sshCmd.handle()
  1770. assert.EqualError(t, err, common.ErrGenericFailure.Error())
  1771. scpCmd := scpCommand{
  1772. sshCommand: sshCommand{
  1773. command: "scp",
  1774. connection: connection,
  1775. },
  1776. }
  1777. err = scpCmd.handle()
  1778. assert.EqualError(t, err, common.ErrGenericFailure.Error())
  1779. assert.Len(t, common.Connections.GetStats(""), 0)
  1780. assert.Equal(t, int32(0), common.Connections.GetTotalTransfers())
  1781. }
  1782. func TestListernerAcceptErrors(t *testing.T) {
  1783. errFake := errors.New("a fake error")
  1784. listener := newFakeListener(errFake)
  1785. c := Configuration{}
  1786. err := c.serve(listener, nil)
  1787. require.EqualError(t, err, errFake.Error())
  1788. err = listener.Close()
  1789. require.NoError(t, err)
  1790. errNetFake := &fakeNetError{error: errFake}
  1791. listener = newFakeListener(errNetFake)
  1792. err = c.serve(listener, nil)
  1793. require.EqualError(t, err, errFake.Error())
  1794. err = listener.Close()
  1795. require.NoError(t, err)
  1796. }
  1797. type fakeNetError struct {
  1798. error
  1799. count int
  1800. }
  1801. func (e *fakeNetError) Timeout() bool {
  1802. return false
  1803. }
  1804. func (e *fakeNetError) Temporary() bool {
  1805. e.count++
  1806. return e.count < 10
  1807. }
  1808. func (e *fakeNetError) Error() string {
  1809. return e.error.Error()
  1810. }
  1811. type fakeListener struct {
  1812. server net.Conn
  1813. client net.Conn
  1814. err error
  1815. }
  1816. func (l *fakeListener) Accept() (net.Conn, error) {
  1817. return l.client, l.err
  1818. }
  1819. func (l *fakeListener) Close() error {
  1820. errClient := l.client.Close()
  1821. errServer := l.server.Close()
  1822. if errServer != nil {
  1823. return errServer
  1824. }
  1825. return errClient
  1826. }
  1827. func (l *fakeListener) Addr() net.Addr {
  1828. return l.server.LocalAddr()
  1829. }
  1830. func newFakeListener(err error) net.Listener {
  1831. server, client := net.Pipe()
  1832. return &fakeListener{
  1833. server: server,
  1834. client: client,
  1835. err: err,
  1836. }
  1837. }
  1838. func TestLoadRevokedUserCertsFile(t *testing.T) {
  1839. r := revokedCertificates{
  1840. certs: map[string]bool{},
  1841. }
  1842. err := r.load()
  1843. assert.NoError(t, err)
  1844. r.filePath = filepath.Join(os.TempDir(), "sub", "testrevoked")
  1845. err = os.MkdirAll(filepath.Dir(r.filePath), os.ModePerm)
  1846. assert.NoError(t, err)
  1847. err = os.WriteFile(r.filePath, []byte(`no json`), 0644)
  1848. assert.NoError(t, err)
  1849. err = r.load()
  1850. assert.Error(t, err)
  1851. r.filePath = filepath.Dir(r.filePath)
  1852. err = r.load()
  1853. assert.Error(t, err)
  1854. err = os.RemoveAll(r.filePath)
  1855. assert.NoError(t, err)
  1856. }
  1857. func TestMaxUserSessions(t *testing.T) {
  1858. connection := &Connection{
  1859. BaseConnection: common.NewBaseConnection(xid.New().String(), common.ProtocolSFTP, "", "", dataprovider.User{
  1860. BaseUser: sdk.BaseUser{
  1861. Username: "user_max_sessions",
  1862. HomeDir: filepath.Clean(os.TempDir()),
  1863. MaxSessions: 1,
  1864. },
  1865. }),
  1866. }
  1867. err := common.Connections.Add(connection)
  1868. assert.NoError(t, err)
  1869. c := Configuration{}
  1870. c.handleSftpConnection(nil, connection)
  1871. sshCmd := sshCommand{
  1872. command: "cd",
  1873. connection: connection,
  1874. }
  1875. err = sshCmd.handle()
  1876. if assert.Error(t, err) {
  1877. assert.Contains(t, err.Error(), "too many open sessions")
  1878. }
  1879. scpCmd := scpCommand{
  1880. sshCommand: sshCommand{
  1881. command: "scp",
  1882. connection: connection,
  1883. },
  1884. }
  1885. err = scpCmd.handle()
  1886. if assert.Error(t, err) {
  1887. assert.Contains(t, err.Error(), "too many open sessions")
  1888. }
  1889. err = ServeSubSystemConnection(&connection.User, connection.ID, nil, nil)
  1890. if assert.Error(t, err) {
  1891. assert.Contains(t, err.Error(), "too many open sessions")
  1892. }
  1893. common.Connections.Remove(connection.GetID())
  1894. assert.Len(t, common.Connections.GetStats(""), 0)
  1895. assert.Equal(t, int32(0), common.Connections.GetTotalTransfers())
  1896. }
  1897. func TestCanReadSymlink(t *testing.T) {
  1898. connection := &Connection{
  1899. BaseConnection: common.NewBaseConnection(xid.New().String(), common.ProtocolSFTP, "", "", dataprovider.User{
  1900. BaseUser: sdk.BaseUser{
  1901. Username: "user_can_read_symlink",
  1902. HomeDir: filepath.Clean(os.TempDir()),
  1903. Permissions: map[string][]string{
  1904. "/": {dataprovider.PermAny},
  1905. "/sub": {dataprovider.PermUpload},
  1906. },
  1907. },
  1908. Filters: dataprovider.UserFilters{
  1909. BaseUserFilters: sdk.BaseUserFilters{
  1910. FilePatterns: []sdk.PatternsFilter{
  1911. {
  1912. Path: "/denied",
  1913. DeniedPatterns: []string{"*.txt"},
  1914. DenyPolicy: sdk.DenyPolicyHide,
  1915. },
  1916. },
  1917. },
  1918. },
  1919. }),
  1920. }
  1921. err := connection.canReadLink("/sub/link")
  1922. assert.ErrorIs(t, err, sftp.ErrSSHFxPermissionDenied)
  1923. err = connection.canReadLink("/denied/file.txt")
  1924. assert.ErrorIs(t, err, sftp.ErrSSHFxNoSuchFile)
  1925. }
  1926. func TestAuthenticationErrors(t *testing.T) {
  1927. loginMethod := dataprovider.SSHLoginMethodPassword
  1928. username := "test user"
  1929. err := newAuthenticationError(fmt.Errorf("cannot validate credentials: %w", util.NewRecordNotFoundError("not found")),
  1930. loginMethod, username)
  1931. assert.ErrorIs(t, err, sftpAuthError)
  1932. assert.ErrorIs(t, err, util.ErrNotFound)
  1933. var sftpAuthErr *authenticationError
  1934. if assert.ErrorAs(t, err, &sftpAuthErr) {
  1935. assert.Equal(t, loginMethod, sftpAuthErr.getLoginMethod())
  1936. assert.Equal(t, username, sftpAuthErr.getUsername())
  1937. }
  1938. err = newAuthenticationError(fmt.Errorf("cannot validate credentials: %w", fs.ErrPermission), loginMethod, username)
  1939. assert.ErrorIs(t, err, sftpAuthError)
  1940. assert.NotErrorIs(t, err, util.ErrNotFound)
  1941. err = newAuthenticationError(fmt.Errorf("cert has wrong type %d", ssh.HostCert), loginMethod, username)
  1942. assert.ErrorIs(t, err, sftpAuthError)
  1943. assert.NotErrorIs(t, err, util.ErrNotFound)
  1944. err = newAuthenticationError(errors.New("ssh: certificate signed by unrecognized authority"), loginMethod, username)
  1945. assert.ErrorIs(t, err, sftpAuthError)
  1946. assert.NotErrorIs(t, err, util.ErrNotFound)
  1947. err = newAuthenticationError(nil, loginMethod, username)
  1948. assert.ErrorIs(t, err, sftpAuthError)
  1949. assert.NotErrorIs(t, err, util.ErrNotFound)
  1950. }
  1951. func TestRsyncArguments(t *testing.T) {
  1952. assert.False(t, canAcceptRsyncArgs(nil))
  1953. args := []string{"-e", "--server"}
  1954. assert.False(t, canAcceptRsyncArgs(args))
  1955. args = []string{"--server", "--sender", "-vlogDtpre.iLsfxCIvu", ".", "."}
  1956. assert.True(t, canAcceptRsyncArgs(args))
  1957. args = []string{"--server", "--sender", "--server", "-vlogDtpre.iLsfxCIvu", ".", "."}
  1958. assert.False(t, canAcceptRsyncArgs(args))
  1959. args = []string{"--server", "..", "/"}
  1960. assert.False(t, canAcceptRsyncArgs(args))
  1961. args = []string{"--server", ".", "/"}
  1962. assert.False(t, canAcceptRsyncArgs(args))
  1963. args = []string{"--server", "--sender", "-vlogDtpre.iLsfxCIvu", ".", "."}
  1964. assert.True(t, canAcceptRsyncArgs(args))
  1965. args = []string{"--server", "--sender", "-vlogDtpre.iLsfxCIvu", "--delete", ".", "/"}
  1966. assert.True(t, canAcceptRsyncArgs(args))
  1967. args = []string{"--server", "-vlogDtpre.iLsfxCIvu", "--delete", ".", "/"}
  1968. assert.True(t, canAcceptRsyncArgs(args))
  1969. args = []string{"--server", "-vlogDtpre.iLsfxCIvu", "--delete", "/", ".", "/"}
  1970. assert.False(t, canAcceptRsyncArgs(args))
  1971. args = []string{"--server", "--sender", "-vlogDtpre.iLsfxCIvu", ".", "path1", "path2"}
  1972. assert.False(t, canAcceptRsyncArgs(args))
  1973. args = []string{"--server", "--sender", "-vlogDtpre.iLsfxCIvu", "."}
  1974. assert.False(t, canAcceptRsyncArgs(args))
  1975. args = []string{"--sender", "-vlogDtpre.iLsfxCIvu", "--delete", ".", "/"}
  1976. assert.False(t, canAcceptRsyncArgs(args))
  1977. args = []string{"--server", "-vlogDtpre.", "--delete", ".", "/"}
  1978. assert.False(t, canAcceptRsyncArgs(args))
  1979. args = []string{"--server", "--sender", "-vlogDtpre.", "--delete", ".", "/"}
  1980. assert.False(t, canAcceptRsyncArgs(args))
  1981. args = []string{"--server", "--sender", "-e.iLsfxCIvu", ".", "/"}
  1982. assert.True(t, canAcceptRsyncArgs(args))
  1983. args = []string{"--server", "-vlogDtpre.iLsfxCIvu", "--delete", "/"}
  1984. assert.False(t, canAcceptRsyncArgs(args))
  1985. args = []string{"--server", "-vlogDtpre.iLsfxCIvu", "--delete", "--safe-links"}
  1986. assert.False(t, canAcceptRsyncArgs(args))
  1987. args = []string{"--server", "-vlogDtpre.iLsfxCIvu", "--unsupported-option", ".", "/"}
  1988. assert.False(t, canAcceptRsyncArgs(args))
  1989. }