Browse Source

cmd/ursrv, lib/scanner: Remove unnecessary slicing of slices (#7491)

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
deepsource-autofix[bot] 4 years ago
parent
commit
0930bccf88
2 changed files with 7 additions and 7 deletions
  1. 1 1
      cmd/ursrv/main.go
  2. 6 6
      lib/scanner/blocks_test.go

+ 1 - 1
cmd/ursrv/main.go

@@ -89,7 +89,7 @@ var funcs = map[string]interface{}{
 			parts = append(parts, part)
 		}
 		if len(input) > 0 {
-			parts = append(parts, input[:])
+			parts = append(parts, input)
 		}
 		return parts[whichPart-1]
 	},

+ 6 - 6
lib/scanner/blocks_test.go

@@ -195,17 +195,17 @@ func BenchmarkValidate(b *testing.B) {
 	for i := 0; i < blocksPerType; i++ {
 		var b block
 		b.data = make([]byte, 128<<10)
-		r.Read(b.data[:])
-		b.hash = sha256.Sum256(b.data[:])
-		b.weakhash = origAdler32.Checksum(b.data[:])
+		r.Read(b.data)
+		b.hash = sha256.Sum256(b.data)
+		b.weakhash = origAdler32.Checksum(b.data)
 		blocks = append(blocks, b)
 	}
 	// Blocks where the hash matches, but the weakhash doesn't.
 	for i := 0; i < blocksPerType; i++ {
 		var b block
 		b.data = make([]byte, 128<<10)
-		r.Read(b.data[:])
-		b.hash = sha256.Sum256(b.data[:])
+		r.Read(b.data)
+		b.hash = sha256.Sum256(b.data)
 		b.weakhash = 1 // Zeros causes Validate to skip the weakhash.
 		blocks = append(blocks, b)
 	}
@@ -215,7 +215,7 @@ func BenchmarkValidate(b *testing.B) {
 
 	for i := 0; i < b.N; i++ {
 		for _, b := range blocks {
-			Validate(b.data[:], b.hash[:], b.weakhash)
+			Validate(b.data, b.hash[:], b.weakhash)
 		}
 	}
 }