Bläddra i källkod

Fix compiler recognition regexp for new format

Jakob Borg 9 år sedan
förälder
incheckning
13f9702a41
2 ändrade filer med 26 tillägg och 1 borttagningar
  1. 25 0
      cmd/ursrv/compiler_test.go
  2. 1 1
      cmd/ursrv/main.go

+ 25 - 0
cmd/ursrv/compiler_test.go

@@ -0,0 +1,25 @@
+package main
+
+import "testing"
+
+func TestCompilerRe(t *testing.T) {
+	tests := [][3]string{
+		{`syncthing v0.11.0 (xgcc (Ubuntu 4.9.3-0ubuntu4) 4.9.3 linux-amd64 default) niklas@Niklas-Netbook 2015-04-26 13:15:08 UTC`, "xgcc (Ubuntu 4.9.3-0ubuntu4) 4.9.3", "niklas@Niklas-Netbook"},
+		{`syncthing v0.12.0-rc5 "Beryllium Bedbug" (go1.4.2 linux-arm android) unknown-user@Felix-T420 2015-10-22 18:32:15 UTC`, "go1.4.2", "unknown-user@Felix-T420"},
+		{`syncthing v0.13.0-beta.0+39-ge267bf3 "Copper Cockroach" (go1.4.2 linux-amd64) [email protected] 2016-01-20 08:41:52 UTC`, "go1.4.2", "[email protected]"},
+	}
+
+	for _, tc := range tests {
+		m := compilerRe.FindStringSubmatch(tc[0])
+		if len(m) != 3 {
+			t.Errorf("Regexp didn't match %q", tc[0])
+			continue
+		}
+		if m[1] != tc[1] {
+			t.Errorf("Compiler %q != %q", m[1], tc[1])
+		}
+		if m[2] != tc[2] {
+			t.Errorf("Builder %q != %q", m[2], tc[2])
+		}
+	}
+}

+ 1 - 1
cmd/ursrv/main.go

@@ -27,7 +27,7 @@ var (
 	dbConn            = getEnvDefault("UR_DB_URL", "postgres://user:password@localhost/ur?sslmode=disable")
 	listenAddr        = getEnvDefault("UR_LISTEN", "0.0.0.0:8443")
 	tpl               *template.Template
-	compilerRe        = regexp.MustCompile(`\(([A-Za-z0-9()., -]+) [\w-]+ \w+\) ([\w@-]+)`)
+	compilerRe        = regexp.MustCompile(`\(([A-Za-z0-9()., -]+) \w+-\w+(?:| android| default)\) ([\w@.-]+)`)
 	aggregateVersions = []string{"v0.7", "v0.8", "v0.9", "v0.10"}
 )