浏览代码

cmd/stcrashreceiver: Don't crash on nil err

Jakob Borg 5 年之前
父节点
当前提交
2286a6ebef
共有 1 个文件被更改,包括 6 次插入2 次删除
  1. 6 2
      cmd/stcrashreceiver/sourcecodeloader.go

+ 6 - 2
cmd/stcrashreceiver/sourcecodeloader.go

@@ -72,8 +72,12 @@ func (l *githubSourceCodeLoader) Load(filename string, line, context int) ([][]b
 		url := urlPrefix + l.version + filename[idx:]
 		url := urlPrefix + l.version + filename[idx:]
 		resp, err := l.client.Get(url)
 		resp, err := l.client.Get(url)
 
 
-		if err != nil || resp.StatusCode != http.StatusOK {
-			fmt.Println("Loading source:", err.Error())
+		if err != nil {
+			fmt.Println("Loading source:", err)
+			return nil, 0
+		}
+		if resp.StatusCode != http.StatusOK {
+			fmt.Println("Loading source:", resp.Status)
 			return nil, 0
 			return nil, 0
 		}
 		}
 		data, err := ioutil.ReadAll(resp.Body)
 		data, err := ioutil.ReadAll(resp.Body)