Sfoglia il codice sorgente

Response with Bad Request to bad config posts, not Internal Server Errors

The error is the clients fault, or so we think, so we should not accept
the blame.
Jakob Borg 10 anni fa
parent
commit
415415b5b2
1 ha cambiato i file con 2 aggiunte e 2 eliminazioni
  1. 2 2
      cmd/syncthing/gui.go

+ 2 - 2
cmd/syncthing/gui.go

@@ -578,7 +578,7 @@ func (s *apiSvc) postSystemConfig(w http.ResponseWriter, r *http.Request) {
 	to, err := config.ReadJSON(r.Body, myID)
 	if err != nil {
 		l.Warnln("decoding posted config:", err)
-		http.Error(w, err.Error(), 500)
+		http.Error(w, err.Error(), http.StatusBadRequest)
 		return
 	}
 
@@ -587,7 +587,7 @@ func (s *apiSvc) postSystemConfig(w http.ResponseWriter, r *http.Request) {
 			hash, err := bcrypt.GenerateFromPassword([]byte(to.GUI.Password), 0)
 			if err != nil {
 				l.Warnln("bcrypting password:", err)
-				http.Error(w, err.Error(), 500)
+				http.Error(w, err.Error(), http.StatusInternalServerError)
 				return
 			}