Browse Source

chore(protocol): don't start connection routines a second time (#10146)

Simon Frei 4 tháng trước cách đây
mục cha
commit
4fb8ee6a6f
1 tập tin đã thay đổi với 4 bổ sung1 xóa
  1. 4 1
      lib/protocol/protocol.go

+ 4 - 1
lib/protocol/protocol.go

@@ -265,12 +265,15 @@ func newRawConnection(deviceID DeviceID, reader io.Reader, writer io.Writer, clo
 }
 
 // Start creates the goroutines for sending and receiving of messages. It must
-// be called exactly once after creating a connection.
+// be called once after creating a connection. It should only be called once,
+// subsequent calls will have no effect.
 func (c *rawConnection) Start() {
 	c.startStopMut.Lock()
 	defer c.startStopMut.Unlock()
 
 	select {
+	case <-c.started:
+		return
 	case <-c.closed:
 		// we have already closed the connection before starting processing
 		// on it.