Browse Source

lib/api: Missing error handling in API delete-device (#7494)

Jakob Borg 4 years ago
parent
commit
f39477bbd5
1 changed files with 4 additions and 0 deletions
  1. 4 0
      lib/api/confighandler.go

+ 4 - 0
lib/api/confighandler.go

@@ -187,6 +187,10 @@ func (c *configMuxBuilder) registerDevice(path string) {
 
 
 	c.Handle(http.MethodDelete, path, func(w http.ResponseWriter, _ *http.Request, p httprouter.Params) {
 	c.Handle(http.MethodDelete, path, func(w http.ResponseWriter, _ *http.Request, p httprouter.Params) {
 		id, err := protocol.DeviceIDFromString(p.ByName("id"))
 		id, err := protocol.DeviceIDFromString(p.ByName("id"))
+		if err != nil {
+			http.Error(w, err.Error(), http.StatusBadRequest)
+			return
+		}
 		waiter, err := c.cfg.RemoveDevice(id)
 		waiter, err := c.cfg.RemoveDevice(id)
 		if err != nil {
 		if err != nil {
 			http.Error(w, err.Error(), http.StatusBadRequest)
 			http.Error(w, err.Error(), http.StatusBadRequest)