Browse Source

v2.4.1.5

Fixed table error with Query Store and Auto Tuning sections when features are not enabled.
pmasl 6 years ago
parent
commit
0cf9694132
2 changed files with 11 additions and 11 deletions
  1. 2 1
      BPCheck/Changelog.txt
  2. 9 10
      BPCheck/Check_BP_Servers.sql

+ 2 - 1
BPCheck/Changelog.txt

@@ -373,4 +373,5 @@ v2.4.1.2 - 04/17/2019 - Improved Max Server Memory section to account for new, s
 						Fixed new MaxDOP recommendation.
 v2.4.1.4 - 06/05/2019 - Fixed Automatic Tuning recommendations section;
 						Fixed MaxDOP check as per new documented recommendation;
-						Fixed issue with MS-shipped DBs exclusion with SQL 2019.
+						Fixed issue with MS-shipped DBs exclusion with SQL 2019.
+v2.4.1.5 - 06/06/2019 - Fixed table error with Query Store and Auto Tuning sections when features are not enabled.

+ 9 - 10
BPCheck/Check_BP_Servers.sql

@@ -6371,6 +6371,11 @@ IF @sqlmajorver > 12
 BEGIN
 	RAISERROR (N'  |-Starting Query Store info', 10, 1) WITH NOWAIT
 	
+	IF EXISTS (SELECT [object_id] FROM tempdb.sys.objects (NOLOCK) WHERE [object_id] = OBJECT_ID('tempdb.dbo.#tblQStoreInfo'))
+	DROP TABLE #tblQStoreInfo;
+	IF NOT EXISTS (SELECT [object_id] FROM tempdb.sys.objects (NOLOCK) WHERE [object_id] = OBJECT_ID('tempdb.dbo.#tblQStoreInfo'))
+	CREATE TABLE #tblQStoreInfo ([DBName] sysname, Actual_State NVARCHAR(60), Flush_Interval_Sec bigint, Interval_Length_Min bigint, Query_CaptureMode NVARCHAR(60), Max_Storage_Size_MB bigint, Current_Storage_Size_MB bigint);
+
 	UPDATE #tmpdbs0
 	SET isdone = 0;
 
@@ -6388,11 +6393,6 @@ BEGIN
 	
 	IF (SELECT COUNT(id) FROM #tmpdbs0 WHERE isdone = 0) > 0
 	BEGIN	
-		IF EXISTS (SELECT [object_id] FROM tempdb.sys.objects (NOLOCK) WHERE [object_id] = OBJECT_ID('tempdb.dbo.#tblQStoreInfo'))
-		DROP TABLE #tblQStoreInfo;
-		IF NOT EXISTS (SELECT [object_id] FROM tempdb.sys.objects (NOLOCK) WHERE [object_id] = OBJECT_ID('tempdb.dbo.#tblQStoreInfo'))
-		CREATE TABLE #tblQStoreInfo ([DBName] sysname, Actual_State NVARCHAR(60), Flush_Interval_Sec bigint, Interval_Length_Min bigint, Query_CaptureMode NVARCHAR(60), Max_Storage_Size_MB bigint, Current_Storage_Size_MB bigint);
-
 		WHILE (SELECT COUNT(id) FROM #tmpdbs0 WHERE isdone = 0) > 0
 		BEGIN
 			SELECT TOP 1 @dbname = [dbname], @dbid = [dbid] FROM #tmpdbs0 WHERE isdone = 0
@@ -6437,6 +6437,10 @@ RAISERROR (N'  |-Starting Automatic Tuning info', 10, 1) WITH NOWAIT
 
 IF @sqlmajorver > 13
 BEGIN
+	IF EXISTS (SELECT [object_id] FROM tempdb.sys.objects (NOLOCK) WHERE [object_id] = OBJECT_ID('tempdb.dbo.#tblAutoTuningInfo'))
+	DROP TABLE #tblAutoTuningInfo;
+	IF NOT EXISTS (SELECT [object_id] FROM tempdb.sys.objects (NOLOCK) WHERE [object_id] = OBJECT_ID('tempdb.dbo.#tblAutoTuningInfo'))
+	CREATE TABLE #tblAutoTuningInfo ([DBName] sysname, AutoTuning_Option NVARCHAR(128), Desired_State NVARCHAR(60), Actual_State NVARCHAR(60), Desired_diff_Actual_reason NVARCHAR(60));
 	
 	UPDATE #tmpdbs0
 	SET isdone = 0;
@@ -6451,11 +6455,6 @@ BEGIN
 	
 	IF (SELECT COUNT(id) FROM #tmpdbs0 WHERE isdone = 0) > 0
 	BEGIN	
-		IF EXISTS (SELECT [object_id] FROM tempdb.sys.objects (NOLOCK) WHERE [object_id] = OBJECT_ID('tempdb.dbo.#tblAutoTuningInfo'))
-		DROP TABLE #tblAutoTuningInfo;
-		IF NOT EXISTS (SELECT [object_id] FROM tempdb.sys.objects (NOLOCK) WHERE [object_id] = OBJECT_ID('tempdb.dbo.#tblAutoTuningInfo'))
-		CREATE TABLE #tblAutoTuningInfo ([DBName] sysname, AutoTuning_Option NVARCHAR(128), Desired_State NVARCHAR(60), Actual_State NVARCHAR(60), Desired_diff_Actual_reason NVARCHAR(60));
-
 		WHILE (SELECT COUNT(id) FROM #tmpdbs0 WHERE isdone = 0) > 0
 		BEGIN
 			SELECT TOP 1 @dbname = [dbname], @dbid = [dbid] FROM #tmpdbs0 WHERE isdone = 0