Explorar o código

Merge pull request #1779 from jjlin/last-known-rev-warning

Avoid `Error parsing LastKnownRevisionDate` warning for mobile clients
Mathijs van Veluw %!s(int64=4) %!d(string=hai) anos
pai
achega
82fee0ede3
Modificáronse 1 ficheiros con 7 adicións e 1 borrados
  1. 7 1
      src/api/core/ciphers.rs

+ 7 - 1
src/api/core/ciphers.rs

@@ -268,7 +268,13 @@ fn post_ciphers_create(data: JsonUpcase<ShareCipherData>, headers: Headers, conn
 /// Called when creating a new user-owned cipher.
 #[post("/ciphers", data = "<data>")]
 fn post_ciphers(data: JsonUpcase<CipherData>, headers: Headers, conn: DbConn, nt: Notify) -> JsonResult {
-    let data: CipherData = data.into_inner().data;
+    let mut data: CipherData = data.into_inner().data;
+
+    // The web/browser clients set this field to null as expected, but the
+    // mobile clients seem to set the invalid value `0001-01-01T00:00:00`,
+    // which results in a warning message being logged. This field isn't
+    // needed when creating a new cipher, so just ignore it unconditionally.
+    data.LastKnownRevisionDate = None;
 
     let mut cipher = Cipher::new(data.Type, data.Name.clone());
     update_cipher_from_data(&mut cipher, data, &headers, false, &conn, &nt, UpdateType::CipherCreate)?;