فهرست منبع

fix: only register properly configured sync services

Gerald 6 ماه پیش
والد
کامیت
1a708508be
4فایلهای تغییر یافته به همراه4 افزوده شده و 12 حذف شده
  1. 1 9
      README.md
  2. 1 1
      src/background/sync/dropbox.js
  3. 1 1
      src/background/sync/googledrive.js
  4. 1 1
      src/background/sync/onedrive.js

+ 1 - 9
README.md

@@ -3,7 +3,6 @@
 [![Chrome Web Store](https://img.shields.io/chrome-web-store/v/jinjaccalgkegednnccohejagnlnfdag.svg)](https://chrome.google.com/webstore/detail/violentmonkey/jinjaccalgkegednnccohejagnlnfdag)
 [![Firefox Add-ons](https://img.shields.io/amo/v/violentmonkey.svg)](https://addons.mozilla.org/firefox/addon/violentmonkey)
 [![Microsoft Edge Add-on](https://img.shields.io/badge/dynamic/json?label=microsoft%20edge%20add-on&query=%24.version&url=https%3A%2F%2Fmicrosoftedge.microsoft.com%2Faddons%2Fgetproductdetailsbycrxid%2Feeagobfjdenkkddmbclomhiblgggliao)](https://microsoftedge.microsoft.com/addons/detail/eeagobfjdenkkddmbclomhiblgggliao)
-[![Subreddit subscribers](https://img.shields.io/reddit/subreddit-subscribers/ViolentMonkey)](https://www.reddit.com/r/ViolentMonkey/)
 
 Violentmonkey provides userscripts support for browsers.
 It works on browsers with [WebExtensions](https://developer.mozilla.org/en-US/Add-ons/WebExtensions) support.
@@ -18,18 +17,11 @@ Join our Discord server:
 
 A test build is generated automatically for changes between beta releases. It can be installed as an unpacked extension in Chrome and Chromium-based browsers or as a temporary extension in Firefox. It's likely to have bugs so do an export in Violentmonkey settings first. This zip is available only if you're logged-in on GitHub site. Open an entry in the [CI workflows](https://github.com/violentmonkey/violentmonkey/actions/workflows/ci.yml) table and click the `Violentmonkey-...` link at the bottom to download it.
 
-## Environment Variables
-
-The following environment variables will be injected at compilation time for some features to work:
-
-- `SYNC_GOOGLE_CLIENT_ID` / `SYNC_GOOGLE_CLIENT_SECRET` - Google sync service
-- `SYNC_ONEDRIVE_CLIENT_ID` / `SYNC_ONEDRIVE_CLIENT_SECRET` - OneDrive sync service
-
 ## Workflows
 
 ### Development
 
-Install [Node.js](https://nodejs.org/) and Yarn v1.x.  
+Install [Node.js](https://nodejs.org/) and Yarn v1.x.
 The version of Node.js should match `"node"` key in `package.json`.
 
 ``` sh

+ 1 - 1
src/background/sync/dropbox.js

@@ -174,7 +174,7 @@ const Dropbox = BaseService.extend({
     return this.prepare();
   },
 });
-register(Dropbox);
+if (config.client_id) register(Dropbox);
 
 function normalize(item) {
   return {

+ 1 - 1
src/background/sync/googledrive.js

@@ -217,7 +217,7 @@ const GoogleDrive = BaseService.extend({
     });
   },
 });
-register(GoogleDrive);
+if (config.client_id && config.client_secret) register(GoogleDrive);
 
 function normalize(item) {
   return {

+ 1 - 1
src/background/sync/onedrive.js

@@ -156,7 +156,7 @@ const OneDrive = BaseService.extend({
     });
   },
 });
-register(OneDrive);
+if (config.client_id && config.client_secret) register(OneDrive);
 
 function normalize(item) {
   return {