Sfoglia il codice sorgente

fix: set icon when `isApplied` changed

Gerald 8 anni fa
parent
commit
6a3f7ab6be
2 ha cambiato i file con 6 aggiunte e 8 eliminazioni
  1. 6 2
      src/background/app.js
  2. 0 6
      src/popup/views/menu.js

+ 6 - 2
src/background/app.js

@@ -12,6 +12,9 @@ var vmdb = exports.vmdb = new VMDB;
 var VM_VER = chrome.app.getDetails().version;
 
 options.hook(function (changes) {
+  if ('isApplied' in changes) {
+    setIcon(changes.isApplied);
+  }
   _.messenger.post({
     cmd: 'UpdateOptions',
     data: changes,
@@ -290,14 +293,15 @@ _.messenger = function () {
   };
 }();
 
-!function (isApplied) {
+function setIcon(isApplied) {
   chrome.browserAction.setIcon({
     path: {
       19: '/images/icon19' + (isApplied ? '' : 'w') + '.png',
       38: '/images/icon38' + (isApplied ? '' : 'w') + '.png'
     },
   });
-}(options.get('isApplied'));
+}
+setIcon(options.get('isApplied'));
 
 chrome.notifications.onClicked.addListener(function (id) {
   if (id == 'VM-NoGrantWarning') {

+ 0 - 6
src/popup/views/menu.js

@@ -64,12 +64,6 @@ module.exports = {
           options.disabled = !_.options.get('isApplied');
           options.name = options.disabled ? _.i18n('menuScriptDisabled') : _.i18n('menuScriptEnabled');
           options.symbol = options.disabled ? 'remove' : 'check';
-          chrome.browserAction.setIcon({
-            path: {
-              19: '/images/icon19' + (options.disabled ? 'w' : '') + '.png',
-              38: '/images/icon38' + (options.disabled ? 'w' : '') + '.png',
-            },
-          });
         },
         onClick: function (options) {
           _.options.set('isApplied', options.disabled);