fix: remove the deprecated options_page

* we already have options_ui which is supported since Chrome 40, FF 48
* fixes #1794

src/common/safe-globals.js

@@ -26,5 +26,5 @@ export const extensionRoot = chrome.runtime.getURL('/');
 export const extensionOrigin = extensionRoot.slice(0, -1);
 export const extensionManifest = chrome.runtime.getManifest();
 // Using getURL because in Firefox manifest contains resolved (full) URLs
-export const extensionOptionsPage = chrome.runtime.getURL(extensionManifest.options_page);
+export const extensionOptionsPage = chrome.runtime.getURL(extensionManifest.options_ui.page);
 export const ICON_PREFIX = chrome.runtime.getURL(extensionManifest.icons[16].replace("16.png", ""));

src/manifest.yml

@@ -18,7 +18,6 @@ browser_action:
   default_popup: popup/index.html
 background:
   scripts: []
-options_page: options/index.html
 options_ui:
   page: options/index.html
   open_in_tab: true

test/mock/polyfill.js

@@ -18,6 +18,7 @@ global.browser = {
     getURL: path => path,
     getManifest: () => ({
       icons: { 16: '' },
+      options_ui: {},
     }),
   },
 };