Browse Source

fix: use tabindex=0 instead of href=#

...to avoid a useless and confusing tooltip shown by the browser for the dummy url e.g. chrome-extension://bhlejohahnjoegdhipncajfeefppembn/options/index.html#
tophf 4 years ago
parent
commit
d151e52115
2 changed files with 5 additions and 5 deletions
  1. 3 3
      src/options/views/edit/values.vue
  2. 2 2
      src/options/views/tab-installed.vue

+ 3 - 3
src/options/views/edit/values.vue

@@ -29,9 +29,9 @@
         v-for="key in pageKeys"
         :key="key"
         class="edit-values-row flex"
-        href="#"
+        tabindex="0"
         @keydown.delete.ctrl.exact="onRemove(key)"
-        @click.prevent="onEdit(key)">
+        @click="onEdit(key)">
         <div class="ellipsis">
           <span v-text="key"></span>
           <div class="edit-values-btn" @click.stop.prevent="onRemove(key)">
@@ -317,7 +317,7 @@ export default {
   &-row {
     border: 1px solid var(--fill-2);
     color: unset;
-    text-decoration: none;
+    cursor: pointer;
     &:not(:first-child) {
       border-top: 0;
     }

+ 2 - 2
src/options/views/tab-installed.vue

@@ -104,8 +104,8 @@
       </header>
       <div v-if="showRecycle" class="trash-hint mx-1 my-1 flex flex-col">
         <span v-text="i18n('hintRecycleBin')"/>
-        <a v-if="trash.length" v-text="i18n('buttonEmptyRecycleBin')" href="#"
-           @click.prevent="emptyRecycleBin"/>
+        <a v-if="trash.length" v-text="i18n('buttonEmptyRecycleBin')" tabindex="0"
+           @click="emptyRecycleBin"/>
       </div>
       <div class="scripts flex-auto"
            ref="scriptList"