Browse Source

IsInternalException check in DoExceptNotify is not just optimization anymore, once we call AppendExceptionStackTraceAndForget in ExceptionMessageDialog unconditionally

Source commit: 20aeb31e48411113165fc079d2717ac1898736e7
Martin Prikryl 9 năm trước cách đây
mục cha
commit
5ea2d11292
1 tập tin đã thay đổi với 1 bổ sung1 xóa
  1. 1 1
      source/windows/WinInterface.cpp

+ 1 - 1
source/windows/WinInterface.cpp

@@ -668,7 +668,7 @@ static void __fastcall DoExceptNotify(TObject * ExceptObj, void * ExceptAddr,
   if (ExceptObj != NULL)
   if (ExceptObj != NULL)
   {
   {
     Exception * E = dynamic_cast<Exception *>(ExceptObj);
     Exception * E = dynamic_cast<Exception *>(ExceptObj);
-    if ((E != NULL) && IsInternalException(E)) // optimization
+    if ((E != NULL) && IsInternalException(E))
     {
     {
       DoExceptionStackTrace(ExceptObj, ExceptAddr, OSException, BaseOfStack);
       DoExceptionStackTrace(ExceptObj, ExceptAddr, OSException, BaseOfStack);