Browse Source

Comment on unwanted side-effect of SaveSession call

Source commit: 8459ad3d04c8179315bb52823000e8bed05aa217
Martin Prikryl 6 years ago
parent
commit
793ad25b2c
1 changed files with 1 additions and 0 deletions
  1. 1 0
      source/forms/SiteAdvanced.cpp

+ 1 - 0
source/forms/SiteAdvanced.cpp

@@ -1543,6 +1543,7 @@ void __fastcall TSiteAdvancedDialog::PrivateKeyGenerateItemClick(TObject * /*Sen
 //---------------------------------------------------------------------------
 void __fastcall TSiteAdvancedDialog::PrivateKeyUploadItemClick(TObject * /*Sender*/)
 {
+  // This has an unwanted side effect of persisting the values, as if the dialog was submitted.
   SaveSession();
   FSessionData->FSProtocol = fsSFTPonly; // no SCP fallback, as SCP does not implement GetHomeDirectory
   FSessionData->RemoteDirectory = UnicodeString();