Explorar o código

Comment about socket closing

Source commit: 3a6334b18550a892ae2723145c078428af9bd840
Martin Prikryl %!s(int64=7) %!d(string=hai) anos
pai
achega
e360e03db6
Modificáronse 1 ficheiros con 3 adicións e 0 borrados
  1. 3 0
      source/filezilla/TransferSocket.cpp

+ 3 - 0
source/filezilla/TransferSocket.cpp

@@ -1141,6 +1141,9 @@ void CTransferSocket::CloseOnShutDownOrError(int Mode)
 {
 {
   if (ShutDown())
   if (ShutDown())
   {
   {
+    // It would probably be correct to remove this call, and wait for OnClose (FD_CLOSE),
+    // where CloseAndEnsureSendClose is called too.
+    // See https://docs.microsoft.com/en-us/windows/desktop/winsock/graceful-shutdown-linger-options-and-socket-closure-2
     CloseAndEnsureSendClose(Mode);
     CloseAndEnsureSendClose(Mode);
   }
   }
   else
   else