1
0

x509_cmp.c 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598
  1. /*
  2. * Copyright 1995-2025 The OpenSSL Project Authors. All Rights Reserved.
  3. *
  4. * Licensed under the Apache License 2.0 (the "License"). You may not use
  5. * this file except in compliance with the License. You can obtain a copy
  6. * in the file LICENSE in the source distribution or at
  7. * https://www.openssl.org/source/license.html
  8. */
  9. #include <stdio.h>
  10. #include "internal/cryptlib.h"
  11. #include <openssl/asn1.h>
  12. #include <openssl/objects.h>
  13. #include <openssl/x509.h>
  14. #include <openssl/x509v3.h>
  15. #include <openssl/core_names.h>
  16. #include "crypto/x509.h"
  17. int X509_issuer_and_serial_cmp(const X509 *a, const X509 *b)
  18. {
  19. int i;
  20. const X509_CINF *ai, *bi;
  21. if (b == NULL)
  22. return a != NULL;
  23. if (a == NULL)
  24. return -1;
  25. ai = &a->cert_info;
  26. bi = &b->cert_info;
  27. i = ASN1_INTEGER_cmp(&ai->serialNumber, &bi->serialNumber);
  28. if (i != 0)
  29. return i < 0 ? -1 : 1;
  30. return X509_NAME_cmp(ai->issuer, bi->issuer);
  31. }
  32. #ifndef OPENSSL_NO_MD5
  33. unsigned long X509_issuer_and_serial_hash(X509 *a)
  34. {
  35. unsigned long ret = 0;
  36. EVP_MD_CTX *ctx = EVP_MD_CTX_new();
  37. unsigned char md[16];
  38. char *f = NULL;
  39. EVP_MD *digest = NULL;
  40. if (ctx == NULL)
  41. goto err;
  42. f = X509_NAME_oneline(a->cert_info.issuer, NULL, 0);
  43. if (f == NULL)
  44. goto err;
  45. digest = EVP_MD_fetch(a->libctx, SN_md5, a->propq);
  46. if (digest == NULL)
  47. goto err;
  48. if (!EVP_DigestInit_ex(ctx, digest, NULL))
  49. goto err;
  50. if (!EVP_DigestUpdate(ctx, (unsigned char *)f, strlen(f)))
  51. goto err;
  52. if (!EVP_DigestUpdate
  53. (ctx, (unsigned char *)a->cert_info.serialNumber.data,
  54. (unsigned long)a->cert_info.serialNumber.length))
  55. goto err;
  56. if (!EVP_DigestFinal_ex(ctx, &(md[0]), NULL))
  57. goto err;
  58. ret = (((unsigned long)md[0]) | ((unsigned long)md[1] << 8L) |
  59. ((unsigned long)md[2] << 16L) | ((unsigned long)md[3] << 24L)
  60. ) & 0xffffffffL;
  61. err:
  62. OPENSSL_free(f);
  63. EVP_MD_free(digest);
  64. EVP_MD_CTX_free(ctx);
  65. return ret;
  66. }
  67. #endif
  68. int X509_issuer_name_cmp(const X509 *a, const X509 *b)
  69. {
  70. return X509_NAME_cmp(a->cert_info.issuer, b->cert_info.issuer);
  71. }
  72. int X509_subject_name_cmp(const X509 *a, const X509 *b)
  73. {
  74. return X509_NAME_cmp(a->cert_info.subject, b->cert_info.subject);
  75. }
  76. int X509_CRL_cmp(const X509_CRL *a, const X509_CRL *b)
  77. {
  78. return X509_NAME_cmp(a->crl.issuer, b->crl.issuer);
  79. }
  80. int X509_CRL_match(const X509_CRL *a, const X509_CRL *b)
  81. {
  82. int rv;
  83. if ((a->flags & EXFLAG_NO_FINGERPRINT) == 0
  84. && (b->flags & EXFLAG_NO_FINGERPRINT) == 0)
  85. rv = memcmp(a->sha1_hash, b->sha1_hash, SHA_DIGEST_LENGTH);
  86. else
  87. return -2;
  88. return rv < 0 ? -1 : rv > 0;
  89. }
  90. X509_NAME *X509_get_issuer_name(const X509 *a)
  91. {
  92. return a->cert_info.issuer;
  93. }
  94. unsigned long X509_issuer_name_hash(X509 *x)
  95. {
  96. return X509_NAME_hash_ex(x->cert_info.issuer, NULL, NULL, NULL);
  97. }
  98. #ifndef OPENSSL_NO_MD5
  99. unsigned long X509_issuer_name_hash_old(X509 *x)
  100. {
  101. return X509_NAME_hash_old(x->cert_info.issuer);
  102. }
  103. #endif
  104. X509_NAME *X509_get_subject_name(const X509 *a)
  105. {
  106. return a->cert_info.subject;
  107. }
  108. ASN1_INTEGER *X509_get_serialNumber(X509 *a)
  109. {
  110. return &a->cert_info.serialNumber;
  111. }
  112. const ASN1_INTEGER *X509_get0_serialNumber(const X509 *a)
  113. {
  114. return &a->cert_info.serialNumber;
  115. }
  116. unsigned long X509_subject_name_hash(X509 *x)
  117. {
  118. return X509_NAME_hash_ex(x->cert_info.subject, NULL, NULL, NULL);
  119. }
  120. #ifndef OPENSSL_NO_MD5
  121. unsigned long X509_subject_name_hash_old(X509 *x)
  122. {
  123. return X509_NAME_hash_old(x->cert_info.subject);
  124. }
  125. #endif
  126. /*
  127. * Compare two certificates: they must be identical for this to work. NB:
  128. * Although "cmp" operations are generally prototyped to take "const"
  129. * arguments (eg. for use in STACKs), the way X509 handling is - these
  130. * operations may involve ensuring the hashes are up-to-date and ensuring
  131. * certain cert information is cached. So this is the point where the
  132. * "depth-first" constification tree has to halt with an evil cast.
  133. */
  134. int X509_cmp(const X509 *a, const X509 *b)
  135. {
  136. int rv = 0;
  137. if (a == b) /* for efficiency */
  138. return 0;
  139. /* attempt to compute cert hash */
  140. (void)X509_check_purpose((X509 *)a, -1, 0);
  141. (void)X509_check_purpose((X509 *)b, -1, 0);
  142. if ((a->ex_flags & EXFLAG_NO_FINGERPRINT) == 0
  143. && (b->ex_flags & EXFLAG_NO_FINGERPRINT) == 0)
  144. rv = memcmp(a->sha1_hash, b->sha1_hash, SHA_DIGEST_LENGTH);
  145. if (rv != 0)
  146. return rv < 0 ? -1 : 1;
  147. /* Check for match against stored encoding too */
  148. if (!a->cert_info.enc.modified && !b->cert_info.enc.modified) {
  149. if (a->cert_info.enc.len < b->cert_info.enc.len)
  150. return -1;
  151. if (a->cert_info.enc.len > b->cert_info.enc.len)
  152. return 1;
  153. rv = memcmp(a->cert_info.enc.enc,
  154. b->cert_info.enc.enc, a->cert_info.enc.len);
  155. }
  156. return rv < 0 ? -1 : rv > 0;
  157. }
  158. int ossl_x509_add_cert_new(STACK_OF(X509) **p_sk, X509 *cert, int flags)
  159. {
  160. if (*p_sk == NULL && (*p_sk = sk_X509_new_null()) == NULL) {
  161. ERR_raise(ERR_LIB_X509, ERR_R_CRYPTO_LIB);
  162. return 0;
  163. }
  164. return X509_add_cert(*p_sk, cert, flags);
  165. }
  166. int X509_add_cert(STACK_OF(X509) *sk, X509 *cert, int flags)
  167. {
  168. if (sk == NULL) {
  169. ERR_raise(ERR_LIB_X509, ERR_R_PASSED_NULL_PARAMETER);
  170. return 0;
  171. }
  172. if (cert == NULL)
  173. return 0;
  174. if ((flags & X509_ADD_FLAG_NO_DUP) != 0) {
  175. /*
  176. * not using sk_X509_set_cmp_func() and sk_X509_find()
  177. * because this re-orders the certs on the stack
  178. */
  179. int i;
  180. for (i = 0; i < sk_X509_num(sk); i++) {
  181. if (X509_cmp(sk_X509_value(sk, i), cert) == 0)
  182. return 1;
  183. }
  184. }
  185. if ((flags & X509_ADD_FLAG_NO_SS) != 0) {
  186. int ret = X509_self_signed(cert, 0);
  187. if (ret != 0)
  188. return ret > 0 ? 1 : 0;
  189. }
  190. if (!sk_X509_insert(sk, cert,
  191. (flags & X509_ADD_FLAG_PREPEND) != 0 ? 0 : -1)) {
  192. ERR_raise(ERR_LIB_X509, ERR_R_CRYPTO_LIB);
  193. return 0;
  194. }
  195. if ((flags & X509_ADD_FLAG_UP_REF) != 0)
  196. (void)X509_up_ref(cert);
  197. return 1;
  198. }
  199. int X509_add_certs(STACK_OF(X509) *sk, STACK_OF(X509) *certs, int flags)
  200. /* compiler would allow 'const' for the certs, yet they may get up-ref'ed */
  201. {
  202. if (sk == NULL) {
  203. ERR_raise(ERR_LIB_X509, ERR_R_PASSED_NULL_PARAMETER);
  204. return 0;
  205. }
  206. return ossl_x509_add_certs_new(&sk, certs, flags);
  207. }
  208. int ossl_x509_add_certs_new(STACK_OF(X509) **p_sk, STACK_OF(X509) *certs,
  209. int flags)
  210. /* compiler would allow 'const' for the certs, yet they may get up-ref'ed */
  211. {
  212. int n = sk_X509_num(certs /* may be NULL */);
  213. int i;
  214. for (i = 0; i < n; i++) {
  215. int j = (flags & X509_ADD_FLAG_PREPEND) == 0 ? i : n - 1 - i;
  216. /* if prepend, add certs in reverse order to keep original order */
  217. if (!ossl_x509_add_cert_new(p_sk, sk_X509_value(certs, j), flags))
  218. return 0;
  219. }
  220. return 1;
  221. }
  222. int X509_NAME_cmp(const X509_NAME *a, const X509_NAME *b)
  223. {
  224. int ret;
  225. if (b == NULL)
  226. return a != NULL;
  227. if (a == NULL)
  228. return -1;
  229. /* Ensure canonical encoding is present and up to date */
  230. if (a->canon_enc == NULL || a->modified) {
  231. ret = i2d_X509_NAME((X509_NAME *)a, NULL);
  232. if (ret < 0)
  233. return -2;
  234. }
  235. if (b->canon_enc == NULL || b->modified) {
  236. ret = i2d_X509_NAME((X509_NAME *)b, NULL);
  237. if (ret < 0)
  238. return -2;
  239. }
  240. ret = a->canon_enclen - b->canon_enclen;
  241. if (ret == 0 && a->canon_enclen == 0)
  242. return 0;
  243. if (ret == 0) {
  244. if (a->canon_enc == NULL || b->canon_enc == NULL)
  245. return -2;
  246. ret = memcmp(a->canon_enc, b->canon_enc, a->canon_enclen);
  247. }
  248. return ret < 0 ? -1 : ret > 0;
  249. }
  250. unsigned long X509_NAME_hash_ex(const X509_NAME *x, OSSL_LIB_CTX *libctx,
  251. const char *propq, int *ok)
  252. {
  253. unsigned long ret = 0;
  254. unsigned char md[SHA_DIGEST_LENGTH];
  255. EVP_MD *sha1 = EVP_MD_fetch(libctx, "SHA1", propq);
  256. int i2d_ret;
  257. /* Make sure X509_NAME structure contains valid cached encoding */
  258. i2d_ret = i2d_X509_NAME(x, NULL);
  259. if (ok != NULL)
  260. *ok = 0;
  261. if (i2d_ret >= 0 && sha1 != NULL
  262. && EVP_Digest(x->canon_enc, x->canon_enclen, md, NULL, sha1, NULL)) {
  263. ret = (((unsigned long)md[0]) | ((unsigned long)md[1] << 8L) |
  264. ((unsigned long)md[2] << 16L) | ((unsigned long)md[3] << 24L)
  265. ) & 0xffffffffL;
  266. if (ok != NULL)
  267. *ok = 1;
  268. }
  269. EVP_MD_free(sha1);
  270. return ret;
  271. }
  272. #ifndef OPENSSL_NO_MD5
  273. /*
  274. * I now DER encode the name and hash it. Since I cache the DER encoding,
  275. * this is reasonably efficient.
  276. */
  277. unsigned long X509_NAME_hash_old(const X509_NAME *x)
  278. {
  279. EVP_MD *md5 = EVP_MD_fetch(NULL, OSSL_DIGEST_NAME_MD5, "-fips");
  280. EVP_MD_CTX *md_ctx = EVP_MD_CTX_new();
  281. unsigned long ret = 0;
  282. unsigned char md[16];
  283. if (md5 == NULL || md_ctx == NULL)
  284. goto end;
  285. /* Make sure X509_NAME structure contains valid cached encoding */
  286. if (i2d_X509_NAME(x, NULL) < 0)
  287. goto end;
  288. if (EVP_DigestInit_ex(md_ctx, md5, NULL)
  289. && EVP_DigestUpdate(md_ctx, x->bytes->data, x->bytes->length)
  290. && EVP_DigestFinal_ex(md_ctx, md, NULL))
  291. ret = (((unsigned long)md[0]) | ((unsigned long)md[1] << 8L) |
  292. ((unsigned long)md[2] << 16L) | ((unsigned long)md[3] << 24L)
  293. ) & 0xffffffffL;
  294. end:
  295. EVP_MD_CTX_free(md_ctx);
  296. EVP_MD_free(md5);
  297. return ret;
  298. }
  299. #endif
  300. /* Search a stack of X509 for a match */
  301. X509 *X509_find_by_issuer_and_serial(STACK_OF(X509) *sk, const X509_NAME *name,
  302. const ASN1_INTEGER *serial)
  303. {
  304. int i;
  305. X509 x, *x509 = NULL;
  306. if (!sk)
  307. return NULL;
  308. x.cert_info.serialNumber = *serial;
  309. x.cert_info.issuer = (X509_NAME *)name; /* won't modify it */
  310. for (i = 0; i < sk_X509_num(sk); i++) {
  311. x509 = sk_X509_value(sk, i);
  312. if (X509_issuer_and_serial_cmp(x509, &x) == 0)
  313. return x509;
  314. }
  315. return NULL;
  316. }
  317. X509 *X509_find_by_subject(STACK_OF(X509) *sk, const X509_NAME *name)
  318. {
  319. X509 *x509;
  320. int i;
  321. for (i = 0; i < sk_X509_num(sk); i++) {
  322. x509 = sk_X509_value(sk, i);
  323. if (X509_NAME_cmp(X509_get_subject_name(x509), name) == 0)
  324. return x509;
  325. }
  326. return NULL;
  327. }
  328. EVP_PKEY *X509_get0_pubkey(const X509 *x)
  329. {
  330. if (x == NULL)
  331. return NULL;
  332. return X509_PUBKEY_get0(x->cert_info.key);
  333. }
  334. EVP_PKEY *X509_get_pubkey(X509 *x)
  335. {
  336. if (x == NULL)
  337. return NULL;
  338. return X509_PUBKEY_get(x->cert_info.key);
  339. }
  340. int X509_check_private_key(const X509 *cert, const EVP_PKEY *pkey)
  341. {
  342. const EVP_PKEY *xk = X509_get0_pubkey(cert);
  343. if (xk == NULL) {
  344. ERR_raise(ERR_LIB_X509, X509_R_UNABLE_TO_GET_CERTS_PUBLIC_KEY);
  345. return 0;
  346. }
  347. return ossl_x509_check_private_key(xk, pkey);
  348. }
  349. int ossl_x509_check_private_key(const EVP_PKEY *x, const EVP_PKEY *pkey)
  350. {
  351. if (x == NULL) {
  352. ERR_raise(ERR_LIB_X509, ERR_R_PASSED_NULL_PARAMETER);
  353. return 0;
  354. }
  355. switch (EVP_PKEY_eq(x, pkey)) {
  356. case 1:
  357. return 1;
  358. case 0:
  359. ERR_raise(ERR_LIB_X509, X509_R_KEY_VALUES_MISMATCH);
  360. return 0;
  361. case -1:
  362. ERR_raise(ERR_LIB_X509, X509_R_KEY_TYPE_MISMATCH);
  363. return 0;
  364. case -2:
  365. ERR_raise(ERR_LIB_X509, X509_R_UNKNOWN_KEY_TYPE);
  366. /* fall thru */
  367. default:
  368. return 0;
  369. }
  370. }
  371. /*
  372. * Check a suite B algorithm is permitted: pass in a public key and the NID
  373. * of its signature (or 0 if no signature). The pflags is a pointer to a
  374. * flags field which must contain the suite B verification flags.
  375. */
  376. #ifndef OPENSSL_NO_EC
  377. static int check_suite_b(EVP_PKEY *pkey, int sign_nid, unsigned long *pflags)
  378. {
  379. char curve_name[80];
  380. size_t curve_name_len;
  381. int curve_nid;
  382. if (pkey == NULL || !EVP_PKEY_is_a(pkey, "EC"))
  383. return X509_V_ERR_SUITE_B_INVALID_ALGORITHM;
  384. if (!EVP_PKEY_get_group_name(pkey, curve_name, sizeof(curve_name),
  385. &curve_name_len))
  386. return X509_V_ERR_SUITE_B_INVALID_CURVE;
  387. curve_nid = OBJ_txt2nid(curve_name);
  388. /* Check curve is consistent with LOS */
  389. if (curve_nid == NID_secp384r1) { /* P-384 */
  390. /*
  391. * Check signature algorithm is consistent with curve.
  392. */
  393. if (sign_nid != -1 && sign_nid != NID_ecdsa_with_SHA384)
  394. return X509_V_ERR_SUITE_B_INVALID_SIGNATURE_ALGORITHM;
  395. if (!(*pflags & X509_V_FLAG_SUITEB_192_LOS))
  396. return X509_V_ERR_SUITE_B_LOS_NOT_ALLOWED;
  397. /* If we encounter P-384 we cannot use P-256 later */
  398. *pflags &= ~X509_V_FLAG_SUITEB_128_LOS_ONLY;
  399. } else if (curve_nid == NID_X9_62_prime256v1) { /* P-256 */
  400. if (sign_nid != -1 && sign_nid != NID_ecdsa_with_SHA256)
  401. return X509_V_ERR_SUITE_B_INVALID_SIGNATURE_ALGORITHM;
  402. if (!(*pflags & X509_V_FLAG_SUITEB_128_LOS_ONLY))
  403. return X509_V_ERR_SUITE_B_LOS_NOT_ALLOWED;
  404. } else {
  405. return X509_V_ERR_SUITE_B_INVALID_CURVE;
  406. }
  407. return X509_V_OK;
  408. }
  409. int X509_chain_check_suiteb(int *perror_depth, X509 *x, STACK_OF(X509) *chain,
  410. unsigned long flags)
  411. {
  412. int rv, i, sign_nid;
  413. EVP_PKEY *pk;
  414. unsigned long tflags = flags;
  415. if (!(flags & X509_V_FLAG_SUITEB_128_LOS))
  416. return X509_V_OK;
  417. /* If no EE certificate passed in must be first in chain */
  418. if (x == NULL) {
  419. x = sk_X509_value(chain, 0);
  420. i = 1;
  421. } else {
  422. i = 0;
  423. }
  424. pk = X509_get0_pubkey(x);
  425. /*
  426. * With DANE-EE(3) success, or DANE-EE(3)/PKIX-EE(1) failure we don't build
  427. * a chain all, just report trust success or failure, but must also report
  428. * Suite-B errors if applicable. This is indicated via a NULL chain
  429. * pointer. All we need to do is check the leaf key algorithm.
  430. */
  431. if (chain == NULL)
  432. return check_suite_b(pk, -1, &tflags);
  433. if (X509_get_version(x) != X509_VERSION_3) {
  434. rv = X509_V_ERR_SUITE_B_INVALID_VERSION;
  435. /* Correct error depth */
  436. i = 0;
  437. goto end;
  438. }
  439. /* Check EE key only */
  440. rv = check_suite_b(pk, -1, &tflags);
  441. if (rv != X509_V_OK) {
  442. /* Correct error depth */
  443. i = 0;
  444. goto end;
  445. }
  446. for (; i < sk_X509_num(chain); i++) {
  447. sign_nid = X509_get_signature_nid(x);
  448. x = sk_X509_value(chain, i);
  449. if (X509_get_version(x) != X509_VERSION_3) {
  450. rv = X509_V_ERR_SUITE_B_INVALID_VERSION;
  451. goto end;
  452. }
  453. pk = X509_get0_pubkey(x);
  454. rv = check_suite_b(pk, sign_nid, &tflags);
  455. if (rv != X509_V_OK)
  456. goto end;
  457. }
  458. /* Final check: root CA signature */
  459. rv = check_suite_b(pk, X509_get_signature_nid(x), &tflags);
  460. end:
  461. if (rv != X509_V_OK) {
  462. /* Invalid signature or LOS errors are for previous cert */
  463. if ((rv == X509_V_ERR_SUITE_B_INVALID_SIGNATURE_ALGORITHM
  464. || rv == X509_V_ERR_SUITE_B_LOS_NOT_ALLOWED) && i)
  465. i--;
  466. /*
  467. * If we have LOS error and flags changed then we are signing P-384
  468. * with P-256. Use more meaningful error.
  469. */
  470. if (rv == X509_V_ERR_SUITE_B_LOS_NOT_ALLOWED && flags != tflags)
  471. rv = X509_V_ERR_SUITE_B_CANNOT_SIGN_P_384_WITH_P_256;
  472. if (perror_depth)
  473. *perror_depth = i;
  474. }
  475. return rv;
  476. }
  477. int X509_CRL_check_suiteb(X509_CRL *crl, EVP_PKEY *pk, unsigned long flags)
  478. {
  479. int sign_nid;
  480. if (!(flags & X509_V_FLAG_SUITEB_128_LOS))
  481. return X509_V_OK;
  482. sign_nid = OBJ_obj2nid(crl->crl.sig_alg.algorithm);
  483. return check_suite_b(pk, sign_nid, &flags);
  484. }
  485. #else
  486. int X509_chain_check_suiteb(int *perror_depth, X509 *x, STACK_OF(X509) *chain,
  487. unsigned long flags)
  488. {
  489. return 0;
  490. }
  491. int X509_CRL_check_suiteb(X509_CRL *crl, EVP_PKEY *pk, unsigned long flags)
  492. {
  493. return 0;
  494. }
  495. #endif
  496. /*
  497. * Not strictly speaking an "up_ref" as a STACK doesn't have a reference
  498. * count but it has the same effect by duping the STACK and upping the ref of
  499. * each X509 structure.
  500. */
  501. STACK_OF(X509) *X509_chain_up_ref(STACK_OF(X509) *chain)
  502. {
  503. STACK_OF(X509) *ret = sk_X509_dup(chain);
  504. int i;
  505. if (ret == NULL)
  506. return NULL;
  507. for (i = 0; i < sk_X509_num(ret); i++) {
  508. X509 *x = sk_X509_value(ret, i);
  509. if (!X509_up_ref(x))
  510. goto err;
  511. }
  512. return ret;
  513. err:
  514. while (i-- > 0)
  515. X509_free(sk_X509_value(ret, i));
  516. sk_X509_free(ret);
  517. return NULL;
  518. }