Browse Source

route navigation no longer happening in typable areas (#1862)

Rishabh kalra 4 years ago
parent
commit
0394deaeef
1 changed files with 2 additions and 4 deletions
  1. 2 4
      packages/hoppscotch-app/helpers/keybindings.ts

+ 2 - 4
packages/hoppscotch-app/helpers/keybindings.ts

@@ -95,9 +95,8 @@ function generateKeybindingString(ev: KeyboardEvent): ShortcutKey | null {
   const modifierKey = getActiveModifier(ev)
 
   const target = ev.target
-
-  if (!modifierKey && !(isDOMElement(target) && isTypableElement(target))) {
-    // Check if we are having singulars instead
+  // override default behaviour if element is typable
+  if (modifierKey && isDOMElement(target) && isTypableElement(target)) {
     const key = getPressedKey(ev)
 
     if (!key) return null
@@ -112,7 +111,6 @@ function generateKeybindingString(ev: KeyboardEvent): ShortcutKey | null {
 
 function getPressedKey(ev: KeyboardEvent): Key | null {
   const val = ev.key.toLowerCase()
-
   // Check arrow keys
   if (val === "arrowup") return "up"
   else if (val === "arrowdown") return "down"