Forráskód Böngészése

Entities are now non-copyable

Ivan Savenko 1 éve
szülő
commit
0d427980bc
2 módosított fájl, 1 hozzáadás és 6 törlés
  1. 1 1
      include/vcmi/Entity.h
  2. 0 5
      lib/battle/CObstacleInstance.cpp

+ 1 - 1
include/vcmi/Entity.h

@@ -30,7 +30,7 @@ public:
 	virtual bool isNativeTerrain(TerrainId terrain) const;
 	virtual bool isNativeTerrain(TerrainId terrain) const;
 };
 };
 
 
-class DLL_LINKAGE Entity
+class DLL_LINKAGE Entity : boost::noncopyable
 {
 {
 public:
 public:
 	using IconRegistar = std::function<void(int32_t index, int32_t group, const std::string & listName, const std::string & imageName)>;
 	using IconRegistar = std::function<void(int32_t index, int32_t group, const std::string & listName, const std::string & imageName)>;

+ 0 - 5
lib/battle/CObstacleInstance.cpp

@@ -107,7 +107,6 @@ SpellID CObstacleInstance::getTrigger() const
 
 
 void CObstacleInstance::serializeJson(JsonSerializeFormat & handler)
 void CObstacleInstance::serializeJson(JsonSerializeFormat & handler)
 {
 {
-	auto obstacleInfo = getInfo();
 	auto hidden = false;
 	auto hidden = false;
 	auto needAnimationOffsetFix = obstacleType == CObstacleInstance::USUAL;
 	auto needAnimationOffsetFix = obstacleType == CObstacleInstance::USUAL;
 	int animationYOffset = 0;
 	int animationYOffset = 0;
@@ -117,11 +116,7 @@ void CObstacleInstance::serializeJson(JsonSerializeFormat & handler)
 
 
 	//We need only a subset of obstacle info for correct render
 	//We need only a subset of obstacle info for correct render
 	handler.serializeInt("position", pos);
 	handler.serializeInt("position", pos);
-	handler.serializeStruct("appearSound", obstacleInfo.appearSound);
-	handler.serializeStruct("appearAnimation", obstacleInfo.appearAnimation);
-	handler.serializeStruct("animation", obstacleInfo.animation);
 	handler.serializeInt("animationYOffset", animationYOffset);
 	handler.serializeInt("animationYOffset", animationYOffset);
-
 	handler.serializeBool("hidden", hidden);
 	handler.serializeBool("hidden", hidden);
 	handler.serializeBool("needAnimationOffsetFix", needAnimationOffsetFix);
 	handler.serializeBool("needAnimationOffsetFix", needAnimationOffsetFix);
 }
 }