Browse Source

CBattleHero::clickRight: more elegant code for side detection

Arseniy Shestakov 8 years ago
parent
commit
4a302d4fe5
1 changed files with 2 additions and 5 deletions
  1. 2 5
      client/battle/CBattleInterfaceClasses.cpp

+ 2 - 5
client/battle/CBattleInterfaceClasses.cpp

@@ -214,11 +214,8 @@ void CBattleHero::clickRight(tribool down, bool previousState)
 
 	if (down && myOwner->myTurn)
 	{
-		if (myHero != nullptr)
-			targetHero.initFromHero(myHero, InfoAboutHero::EInfoLevel::INBATTLE);
-		else
-			targetHero = myOwner->enemyHero();
-
+		auto h = flip ? myOwner->defendingHeroInstance : myOwner->attackingHeroInstance;
+		targetHero.initFromHero(h, InfoAboutHero::EInfoLevel::INBATTLE);
 		GH.pushInt(new CHeroInfoWindow(targetHero, &windowPosition));
 	}
 }