code review

client/adventureMap/CList.cpp

@@ -315,7 +315,7 @@ void CHeroList::CHeroItem::keyPressed(EShortcut key)
 
 	auto & heroes = LOCPLINT->localState->getWanderingHeroes();
 
-	if(key == EShortcut::LIST_HERO_DELETE)
+	if(key == EShortcut::LIST_HERO_DISMISS)
 	{
 		LOCPLINT->showYesNoDialog(CGI->generaltexth->allTexts[22], [=](){ LOCPLINT->cb->dismissHero(hero); }, nullptr);
 		return;

client/gui/Shortcut.h

@@ -297,7 +297,7 @@ enum class EShortcut
 	LIST_HERO_DOWN,
 	LIST_HERO_TOP,
 	LIST_HERO_BOTTOM,
-	LIST_HERO_DELETE,
+	LIST_HERO_DISMISS,
 	LIST_TOWN_UP,
 	LIST_TOWN_DOWN,
 	LIST_TOWN_TOP,

client/gui/ShortcutHandler.cpp

@@ -279,7 +279,7 @@ EShortcut ShortcutHandler::findShortcut(const std::string & identifier ) const
 		{"listHeroDown",             EShortcut::LIST_HERO_DOWN            },
 		{"listHeroTop",              EShortcut::LIST_HERO_TOP             },
 		{"listHeroBottom",           EShortcut::LIST_HERO_BOTTOM          },
-		{"listHeroDelete",           EShortcut::LIST_HERO_DELETE          },
+		{"listHeroDismiss",          EShortcut::LIST_HERO_DISMISS         },
 		{"listTownUp",               EShortcut::LIST_TOWN_UP              },
 		{"listTownDown",             EShortcut::LIST_TOWN_DOWN            },
 		{"listTownTop",              EShortcut::LIST_TOWN_TOP             },

config/shortcutsConfig.json

@@ -246,7 +246,7 @@
 		"listHeroDown":             "Ctrl+PageDown",
 		"listHeroTop":              "Ctrl+Home",
 		"listHeroBottom":           "Ctrl+End",
-		"listHeroDelete":           "Delete",
+		"listHeroDismiss":          "Delete",
 		"listTownUp":               "Ctrl+PageUp",
 		"listTownDown":             "Ctrl+PageDown",
 		"listTownTop":              "Ctrl+Home",