Browse Source

remove todo

Laserlicht 3 weeks ago
parent
commit
7314bb2d06
3 changed files with 5 additions and 13 deletions
  1. 1 1
      client/widgets/MiscWidgets.cpp
  2. 1 1
      lib/gameState/GameStatistics.cpp
  3. 3 11
      lib/json/JsonRandom.cpp

+ 1 - 1
client/widgets/MiscWidgets.cpp

@@ -227,7 +227,7 @@ void CMinorResDataBar::showAll(Canvas & to)
 {
 {
 	CIntObject::showAll(to);
 	CIntObject::showAll(to);
 
 
-	for (GameResID i=EGameResID::WOOD; i<=EGameResID::GOLD; ++i) //todo: configurable resource support
+	for (GameResID i=EGameResID::WOOD; i<=EGameResID::GOLD; ++i)
 	{
 	{
 		std::string text = std::to_string(GAME->interface()->cb->getResourceAmount(i));
 		std::string text = std::to_string(GAME->interface()->cb->getResourceAmount(i));
 
 

+ 1 - 1
lib/gameState/GameStatistics.cpp

@@ -159,7 +159,7 @@ std::string StatisticDataSet::toCsv(std::string sep) const
 {
 {
 	std::stringstream ss;
 	std::stringstream ss;
 
 
-	auto resources = std::vector<EGameResID>{EGameResID::GOLD, EGameResID::WOOD, EGameResID::MERCURY, EGameResID::ORE, EGameResID::SULFUR, EGameResID::CRYSTAL, EGameResID::GEMS}; //todo: configurable resource support
+	auto resources = LIBRARY->resourceTypeHandler->getAllObjects();
 
 
 	ss << "Map" << sep;
 	ss << "Map" << sep;
 	ss << "Timestamp" << sep;
 	ss << "Timestamp" << sep;

+ 3 - 11
lib/json/JsonRandom.cpp

@@ -308,17 +308,9 @@ JsonRandom::JsonRandom(IGameInfoCallback * cb, IGameRandomizer & gameRandomizer)
 
 
 	TResources JsonRandom::loadResource(const JsonNode & value, const Variables & variables)
 	TResources JsonRandom::loadResource(const JsonNode & value, const Variables & variables)
 	{
 	{
-		std::set<GameResID> defaultResources{
-			GameResID::WOOD,
-			GameResID::MERCURY,
-			GameResID::ORE,
-			GameResID::SULFUR,
-			GameResID::CRYSTAL,
-			GameResID::GEMS,
-			GameResID::GOLD
-		}; //todo: configurable resource support
-
-		std::set<GameResID> potentialPicks = filterKeys(value, defaultResources, variables);
+		auto defaultResources = LIBRARY->resourceTypeHandler->getAllObjects();
+
+		std::set<GameResID> potentialPicks = filterKeys(value, std::set<GameResID>(defaultResources.begin(), defaultResources.end()), variables);
 		GameResID resourceID = *RandomGeneratorUtil::nextItem(potentialPicks, rng);
 		GameResID resourceID = *RandomGeneratorUtil::nextItem(potentialPicks, rng);
 		si32 resourceAmount = loadValue(value, variables, 0);
 		si32 resourceAmount = loadValue(value, variables, 0);