Jelajahi Sumber

Throw exception instead of crash on accessing non-existing setting

Ivan Savenko 1 tahun lalu
induk
melakukan
aadfde27bc
1 mengubah file dengan 2 tambahan dan 3 penghapusan
  1. 2 3
      lib/GameSettings.cpp

+ 2 - 3
lib/GameSettings.cpp

@@ -118,11 +118,10 @@ void GameSettings::load(const JsonNode & input)
 
 const JsonNode & GameSettings::getValue(EGameSettings option) const
 {
-	assert(option < EGameSettings::OPTIONS_COUNT);
 	auto index = static_cast<size_t>(option);
 
-	assert(!gameSettings[index].isNull());
-	return gameSettings[index];
+	assert(!gameSettings.at(index).isNull());
+	return gameSettings.at(index);
 }
 
 VCMI_LIB_NAMESPACE_END