vcmi: remove unused-but-set-variables

client/battle/BattleInterface.cpp

@@ -207,11 +207,8 @@ void BattleInterface::stacksAreAttacked(std::vector<StackAttackedInfo> attackedI
 
 	std::array<int, 2> killedBySide = {0, 0};
 
-	int targets = 0;
 	for(const StackAttackedInfo & attackedInfo : attackedInfos)
 	{
-		++targets;
-
 		ui8 side = attackedInfo.defender->side;
 		killedBySide.at(side) += attackedInfo.amountKilled;
 	}

client/lobby/CBonusSelection.cpp

@@ -119,7 +119,6 @@ CBonusSelection::CBonusSelection()
 void CBonusSelection::loadPositionsOfGraphics()
 {
 	const JsonNode config(ResourceID("config/campaign_regions.json"));
-	int idx = 0;
 
 	for(const JsonNode & campaign : config["campaign_regions"].Vector())
 	{
@@ -140,7 +139,6 @@ void CBonusSelection::loadPositionsOfGraphics()
 
 		campDescriptions.push_back(sc);
 
-		idx++;
 	}
 }
 

client/mainmenu/CMainMenu.cpp

@@ -439,11 +439,6 @@ CMultiPlayers::CMultiPlayers(const std::string & firstPlayer, ESelectionScreen S
 
 void CMultiPlayers::onChange(std::string newText)
 {
-	size_t namesCount = 0;
-
-	for(auto & elem : inputNames)
-		if(!elem->getText().empty())
-			namesCount++;
 }
 
 void CMultiPlayers::enterSelectionScreen()

lib/rmg/CMapGenOptions.cpp

@@ -322,7 +322,7 @@ void CMapGenOptions::finalize(CRandomGenerator & rand)
 	//setWidth(50);
 
 	logGlobal->trace("Player config:");
-	int humanPlayers = 0, cpuOnlyPlayers = 0, AIplayers = 0;
+	int cpuOnlyPlayers = 0;
 	for (auto player : players)
 	{
 		std::string playerType;
@@ -330,7 +330,6 @@ void CMapGenOptions::finalize(CRandomGenerator & rand)
 		{
 		case EPlayerType::AI:
 			playerType = "AI";
-			AIplayers++;
 			break;
 		case EPlayerType::COMP_ONLY:
 			playerType = "computer only";
@@ -338,7 +337,6 @@ void CMapGenOptions::finalize(CRandomGenerator & rand)
 			break;
 		case EPlayerType::HUMAN:
 			playerType = "human only";
-			humanPlayers++;
 			break;
 			default:
 				assert(false);