apply review comments for CAndroidVMHelper

client/CServerHandler.cpp

@@ -155,9 +155,10 @@ void CServerHandler::startLocalServerAndConnect()
 
 	th->update();
 #ifdef VCMI_ANDROID
-	CAndroidVMHelper envHelper;
-	envHelper.callStaticVoidMethod(CAndroidVMHelper::NATIVE_METHODS_DEFAULT_CLASS, "startServer", true);
-	envHelper.Detach();
+	{
+		CAndroidVMHelper envHelper;
+		envHelper.callStaticVoidMethod(CAndroidVMHelper::NATIVE_METHODS_DEFAULT_CLASS, "startServer", true);
+	}
 #else
 	threadRunLocalServer = std::make_shared<boost::thread>(&CServerHandler::threadRunServer, this); //runs server executable;
 #endif

lib/CAndroidVMHelper.cpp

@@ -43,11 +43,6 @@ CAndroidVMHelper::CAndroidVMHelper()
 	}
 }
 CAndroidVMHelper::~CAndroidVMHelper()
-{
-	Detach();
-}
-
-void CAndroidVMHelper::Detach()
 {
 	if(envPtr && detachInDestructor)
 	{

lib/CAndroidVMHelper.h

@@ -29,8 +29,6 @@ public:
 
 	~CAndroidVMHelper();
 
-	void Detach();
-
 	JNIEnv * get();
 
 	jclass findClassloadedClass(const std::string & name);

server/CVCMIServer.cpp

@@ -179,7 +179,6 @@ void CVCMIServer::run()
 #else
 		CAndroidVMHelper vmHelper;
 		vmHelper.callStaticVoidMethod(CAndroidVMHelper::NATIVE_METHODS_DEFAULT_CLASS, "onServerReady");
-		vmHelper.Detach();
 #endif
 	}