Browse Source

firewall: properly clear hooks in fw_stop() to prevent extensions from being called twice after fw_restart()

SVN-Revision: 21488
Jo-Philipp Wich 15 years ago
parent
commit
18a79362e9
1 changed files with 8 additions and 1 deletions
  1. 8 1
      package/firewall/files/lib/core.sh

+ 8 - 1
package/firewall/files/lib/core.sh

@@ -66,6 +66,11 @@ fw_stop() {
 
 	uci_revert_state firewall
 	config_clear
+
+	local h
+	for h in $FW_HOOKS; do unset $h; done
+
+	unset FW_HOOKS
 	unset FW_INITIALIZED
 }
 
@@ -126,8 +131,10 @@ fw_init() {
 		. $file
 		for hk in $hooks; do
 			for pp in pre post; do
-				type ${lib}_${pp}_${hk}_cb >/dev/null &&
+				type ${lib}_${pp}_${hk}_cb >/dev/null && {
 					append FW_CB_${pp}_${hk} ${lib}
+					append FW_HOOKS FW_CB_${pp}_${hk}
+				}
 			done
 		done
 	done