Browse Source

ead: fix resource leak in tinysrp

Add call to fclose for file pointer fp in function t_openpw.
The resource leak could happen during an error handling.

Signed-off-by: Andrea Dalla Costa <[email protected]>
Andrea Dalla Costa 5 years ago
parent
commit
52f0b0913d
1 changed files with 3 additions and 1 deletions
  1. 3 1
      package/network/services/ead/src/tinysrp/t_pw.c

+ 3 - 1
package/network/services/ead/src/tinysrp/t_pw.c

@@ -94,8 +94,10 @@ t_openpw(fp)
   else
     close_flag = 0;
 
-  if((tpw = malloc(sizeof(struct t_pw))) == NULL)
+  if((tpw = malloc(sizeof(struct t_pw))) == NULL) {
+    fclose(fp);
     return NULL;
+  }
   tpw->instream = fp;
   tpw->close_on_exit = close_flag;
   tpw->state = FILE_ONLY;