Browse Source

generic: ar8216: don't probe the chip multiple times

It is only needed when the private data is allocated.

Signed-off-by: Gabor Juhos <[email protected]>

SVN-Revision: 35538
Gabor Juhos 13 years ago
parent
commit
5ed480598d
1 changed files with 8 additions and 8 deletions
  1. 8 8
      target/linux/generic/files/drivers/net/phy/ar8216.c

+ 8 - 8
target/linux/generic/files/drivers/net/phy/ar8216.c

@@ -1780,17 +1780,17 @@ ar8216_config_init(struct phy_device *pdev)
 		priv = kzalloc(sizeof(struct ar8216_priv), GFP_KERNEL);
 		if (priv == NULL)
 			return -ENOMEM;
-	}
 
-	priv->mii_bus = pdev->bus;
-	priv->read = ar8216_mii_read;
-	priv->write = ar8216_mii_write;
+		priv->mii_bus = pdev->bus;
+		priv->read = ar8216_mii_read;
+		priv->write = ar8216_mii_write;
 
-	priv->phy = pdev;
+		ret = ar8216_id_chip(priv);
+		if (ret)
+			goto err_free_priv;
+	}
 
-	ret = ar8216_id_chip(priv);
-	if (ret)
-		goto err_free_priv;
+	priv->phy = pdev;
 
 	if (ar8xxx_has_gige(priv))
 		pdev->supported = SUPPORTED_1000baseT_Full;