Browse Source

base-files-network: configure vlan interface name type immediately before the vconfig add calls, fixes race condition (#11127)

SVN-Revision: 30919
Jo-Philipp Wich 14 years ago
parent
commit
95edc71814

+ 2 - 2
package/base-files-network/Makefile

@@ -1,5 +1,5 @@
 #
-# Copyright (C) 2007-2011 OpenWrt.org
+# Copyright (C) 2007-2012 OpenWrt.org
 #
 # This is free software, licensed under the GNU General Public License v2.
 # See /LICENSE for more information.
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
 include $(INCLUDE_DIR)/kernel.mk
 
 PKG_NAME:=base-files-network
-PKG_RELEASE:=3
+PKG_RELEASE:=4
 
 PKG_BUILD_DEPENDS:=opkg/host
 

+ 3 - 1
package/base-files-network/files/lib/network/config.sh

@@ -83,6 +83,7 @@ add_vlan() {
 
 	[ "$1" = "$vif" ] || ifconfig "$1" >/dev/null 2>/dev/null || {
 		ifconfig "$vif" up 2>/dev/null >/dev/null || add_vlan "$vif"
+		$DEBUG vconfig set_name_type DEV_PLUS_VID_NO_PAD
 		$DEBUG vconfig add "$vif" "${1##*\.}"
 		return 0
 	}
@@ -218,7 +219,8 @@ prepare_interface() {
 					$DEBUG brctl addif "br-$config" "$iface"
 					$DEBUG brctl stp "br-$config" $stp
 					[ -z "$macaddr" ] && macaddr="$(cat /sys/class/net/$iface/address)"
-					echo $igmp_snooping > /sys/devices/virtual/net/br-$config/bridge/multicast_snooping 2>/dev/null
+					[ -e /sys/devices/virtual/net/br-$config/bridge/multicast_snooping ] && \
+						echo $igmp_snooping > /sys/devices/virtual/net/br-$config/bridge/multicast_snooping
 					$DEBUG ifconfig "br-$config" hw ether $macaddr up
 					# Creating the bridge here will have triggered a hotplug event, which will
 					# result in another setup_interface() call, so we simply stop processing