|
@@ -0,0 +1,51 @@
|
|
|
+From cd8e1f340c3e571b78952d4ca2c128d183a47cc2 Mon Sep 17 00:00:00 2001
|
|
|
+From: Daniel Golle <[email protected]>
|
|
|
+Date: Wed, 28 Sep 2022 02:17:02 +0100
|
|
|
+Subject: [PATCH] net: ethernet: mtk_eth_soc: fix state in
|
|
|
+ __mtk_foe_entry_clear
|
|
|
+To: [email protected],
|
|
|
+ [email protected],
|
|
|
+ Lorenzo Bianconi <[email protected]>
|
|
|
+Cc: Sujuan Chen <[email protected]>,
|
|
|
+ Bo Jiao <[email protected]>,
|
|
|
+ Felix Fietkau <[email protected]>,
|
|
|
+ John Crispin <[email protected]>,
|
|
|
+ Sean Wang <[email protected]>,
|
|
|
+ Mark Lee <[email protected]>,
|
|
|
+ David S. Miller <[email protected]>,
|
|
|
+ Eric Dumazet <[email protected]>,
|
|
|
+ Jakub Kicinski <[email protected]>,
|
|
|
+ Paolo Abeni <[email protected]>,
|
|
|
+ Matthias Brugger <[email protected]>,
|
|
|
+ Chen Minqiang <[email protected]>,
|
|
|
+ Thomas Hühn <[email protected]>
|
|
|
+
|
|
|
+Setting ib1 state to MTK_FOE_STATE_UNBIND in __mtk_foe_entry_clear
|
|
|
+routine as done by commit 0e80707d94e4c8 ("net: ethernet: mtk_eth_soc:
|
|
|
+fix typo in __mtk_foe_entry_clear") breaks flow offloading, at least
|
|
|
+on older MTK_NETSYS_V1 SoCs, OpenWrt users have confirmed the bug on
|
|
|
+MT7622 and MT7621 systems.
|
|
|
+Felix Fietkau suggested to use MTK_FOE_STATE_INVALID instead which
|
|
|
+works well on both, MTK_NETSYS_V1 and MTK_NETSYS_V2.
|
|
|
+
|
|
|
+Tested on MT7622 (Linksys E8450) and MT7986 (BananaPi BPI-R3).
|
|
|
+
|
|
|
+Suggested-by: Felix Fietkau <[email protected]>
|
|
|
+Fixes: 0e80707d94e4c8 ("net: ethernet: mtk_eth_soc: fix typo in __mtk_foe_entry_clear")
|
|
|
+Fixes: 33fc42de33278 ("net: ethernet: mtk_eth_soc: support creating mac address based offload entries")
|
|
|
+Signed-off-by: Daniel Golle <[email protected]>
|
|
|
+---
|
|
|
+ drivers/net/ethernet/mediatek/mtk_ppe.c | 2 +-
|
|
|
+ 1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
+
|
|
|
+--- a/drivers/net/ethernet/mediatek/mtk_ppe.c
|
|
|
++++ b/drivers/net/ethernet/mediatek/mtk_ppe.c
|
|
|
+@@ -442,7 +442,7 @@ __mtk_foe_entry_clear(struct mtk_ppe *pp
|
|
|
+ struct mtk_foe_entry *hwe = mtk_foe_get_entry(ppe, entry->hash);
|
|
|
+
|
|
|
+ hwe->ib1 &= ~MTK_FOE_IB1_STATE;
|
|
|
+- hwe->ib1 |= FIELD_PREP(MTK_FOE_IB1_STATE, MTK_FOE_STATE_UNBIND);
|
|
|
++ hwe->ib1 |= FIELD_PREP(MTK_FOE_IB1_STATE, MTK_FOE_STATE_INVALID);
|
|
|
+ dma_wmb();
|
|
|
+ }
|
|
|
+ entry->hash = 0xffff;
|