|
@@ -0,0 +1,46 @@
|
|
|
+From fc516d3a6aa2c6ffe27d0da8818d13839e023e7e Mon Sep 17 00:00:00 2001
|
|
|
+From: Florian Fainelli <[email protected]>
|
|
|
+Date: Fri, 21 May 2021 10:46:14 -0700
|
|
|
+Subject: [PATCH] net: dsa: bcm_sf2: Fix bcm_sf2_reg_rgmii_cntrl() call for
|
|
|
+ non-RGMII port
|
|
|
+MIME-Version: 1.0
|
|
|
+Content-Type: text/plain; charset=UTF-8
|
|
|
+Content-Transfer-Encoding: 8bit
|
|
|
+
|
|
|
+We cannot call bcm_sf2_reg_rgmii_cntrl() for a port that is not RGMII,
|
|
|
+yet we do that in bcm_sf2_sw_mac_link_up() irrespective of the port's
|
|
|
+interface. Move that read until we have properly qualified the PHY
|
|
|
+interface mode. This avoids triggering a warning on 7278 platforms that
|
|
|
+have GMII ports.
|
|
|
+
|
|
|
+Fixes: 55cfeb396965 ("net: dsa: bcm_sf2: add function finding RGMII register")
|
|
|
+Signed-off-by: Florian Fainelli <[email protected]>
|
|
|
+Acked-by: Rafał Miłecki <[email protected]>
|
|
|
+Signed-off-by: David S. Miller <[email protected]>
|
|
|
+---
|
|
|
+ drivers/net/dsa/bcm_sf2.c | 5 ++---
|
|
|
+ 1 file changed, 2 insertions(+), 3 deletions(-)
|
|
|
+
|
|
|
+--- a/drivers/net/dsa/bcm_sf2.c
|
|
|
++++ b/drivers/net/dsa/bcm_sf2.c
|
|
|
+@@ -821,11 +821,9 @@ static void bcm_sf2_sw_mac_link_up(struc
|
|
|
+ bcm_sf2_sw_mac_link_set(ds, port, interface, true);
|
|
|
+
|
|
|
+ if (port != core_readl(priv, CORE_IMP0_PRT_ID)) {
|
|
|
+- u32 reg_rgmii_ctrl;
|
|
|
++ u32 reg_rgmii_ctrl = 0;
|
|
|
+ u32 reg, offset;
|
|
|
+
|
|
|
+- reg_rgmii_ctrl = bcm_sf2_reg_rgmii_cntrl(priv, port);
|
|
|
+-
|
|
|
+ if (priv->type == BCM4908_DEVICE_ID ||
|
|
|
+ priv->type == BCM7445_DEVICE_ID)
|
|
|
+ offset = CORE_STS_OVERRIDE_GMIIP_PORT(port);
|
|
|
+@@ -836,6 +834,7 @@ static void bcm_sf2_sw_mac_link_up(struc
|
|
|
+ interface == PHY_INTERFACE_MODE_RGMII_TXID ||
|
|
|
+ interface == PHY_INTERFACE_MODE_MII ||
|
|
|
+ interface == PHY_INTERFACE_MODE_REVMII) {
|
|
|
++ reg_rgmii_ctrl = bcm_sf2_reg_rgmii_cntrl(priv, port);
|
|
|
+ reg = reg_readl(priv, reg_rgmii_ctrl);
|
|
|
+ reg &= ~(RX_PAUSE_EN | TX_PAUSE_EN);
|
|
|
+
|