Browse Source

nvram: improve argument check when program start

print help message when argument count is less
than 2.

Signed-off-by: BangLang Huang <[email protected]>
BangLang Huang 9 years ago
parent
commit
c7e2a6fe92
1 changed files with 9 additions and 8 deletions
  1. 9 8
      package/utils/nvram/src/cli.c

+ 9 - 8
package/utils/nvram/src/cli.c

@@ -155,15 +155,16 @@ int main( int argc, const char *argv[] )
 	int done = 0;
 	int i;
 
+	if( argc < 2 ) {
+		usage();
+		return 1;
+	}
+
 	/* Ugly... iterate over arguments to see whether we can expect a write */
-	for( i = 1; i < argc; i++ )
-		if( ( !strcmp(argv[i], "set")   && ++i < argc ) ||
-			( !strcmp(argv[i], "unset") && ++i < argc ) ||
-			!strcmp(argv[i], "commit") )
-		{
-			write = 1;
-			break;
-		}
+	if( ( !strcmp(argv[1], "set")  && 2 < argc ) ||
+		( !strcmp(argv[1], "unset") && 2 < argc ) ||
+		!strcmp(argv[1], "commit") )
+		write = 1;
 
 
 	nvram = write ? nvram_open_staging() : nvram_open_rdonly();