101-dmaengine-img-mdc-Handle-early-status-read.patch 2.0 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768
  1. From a2dd154377c9aa6ddda00d39b8c7c334e4fa16ff Mon Sep 17 00:00:00 2001
  2. From: Damien Horsley <[email protected]>
  3. Date: Tue, 22 Mar 2016 12:46:09 +0000
  4. Subject: dmaengine: img-mdc: Handle early status read
  5. It is possible that mdc_tx_status may be called before the first
  6. node has been read from memory.
  7. In this case, the residue value stored in the register is undefined.
  8. Return the transfer size instead.
  9. Signed-off-by: Damien Horsley <[email protected]>
  10. ---
  11. drivers/dma/img-mdc-dma.c | 40 ++++++++++++++++++++++++----------------
  12. 1 file changed, 24 insertions(+), 16 deletions(-)
  13. --- a/drivers/dma/img-mdc-dma.c
  14. +++ b/drivers/dma/img-mdc-dma.c
  15. @@ -618,25 +618,33 @@ static enum dma_status mdc_tx_status(str
  16. (MDC_CMDS_PROCESSED_CMDS_DONE_MASK + 1);
  17. /*
  18. - * If the command loaded event hasn't been processed yet, then
  19. - * the difference above includes an extra command.
  20. + * If the first node has not yet been read from memory,
  21. + * the residue register value is undefined
  22. */
  23. - if (!mdesc->cmd_loaded)
  24. - cmds--;
  25. - else
  26. - cmds += mdesc->list_cmds_done;
  27. -
  28. - bytes = mdesc->list_xfer_size;
  29. - ldesc = mdesc->list;
  30. - for (i = 0; i < cmds; i++) {
  31. - bytes -= ldesc->xfer_size + 1;
  32. - ldesc = ldesc->next_desc;
  33. - }
  34. - if (ldesc) {
  35. - if (residue != MDC_TRANSFER_SIZE_MASK)
  36. - bytes -= ldesc->xfer_size - residue;
  37. + if (!mdesc->cmd_loaded && !cmds) {
  38. + bytes = mdesc->list_xfer_size;
  39. + } else {
  40. + /*
  41. + * If the command loaded event hasn't been processed yet, then
  42. + * the difference above includes an extra command.
  43. + */
  44. + if (!mdesc->cmd_loaded)
  45. + cmds--;
  46. else
  47. + cmds += mdesc->list_cmds_done;
  48. +
  49. + bytes = mdesc->list_xfer_size;
  50. + ldesc = mdesc->list;
  51. + for (i = 0; i < cmds; i++) {
  52. bytes -= ldesc->xfer_size + 1;
  53. + ldesc = ldesc->next_desc;
  54. + }
  55. + if (ldesc) {
  56. + if (residue != MDC_TRANSFER_SIZE_MASK)
  57. + bytes -= ldesc->xfer_size - residue;
  58. + else
  59. + bytes -= ldesc->xfer_size + 1;
  60. + }
  61. }
  62. }
  63. spin_unlock_irqrestore(&mchan->vc.lock, flags);