009-rt2x00-rt2800lib-mark-expected-switch-fall-throughs.patch 1.5 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344
  1. From 916e6bbcfcff6cc5d7d33bba8557a30f3af50326 Mon Sep 17 00:00:00 2001
  2. From: "Gustavo A. R. Silva" <[email protected]>
  3. Date: Mon, 22 Oct 2018 22:46:03 +0200
  4. Subject: [PATCH 09/28] rt2x00: rt2800lib: mark expected switch fall-throughs
  5. In preparation to enabling -Wimplicit-fallthrough, mark switch cases
  6. where we are expecting to fall through.
  7. Addresses-Coverity-ID: 145198 ("Missing break in switch")
  8. Signed-off-by: Gustavo A. R. Silva <[email protected]>
  9. Signed-off-by: Kalle Valo <[email protected]>
  10. ---
  11. drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 4 ++++
  12. 1 file changed, 4 insertions(+)
  13. --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
  14. +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
  15. @@ -2482,6 +2482,7 @@ static void rt2800_config_channel_rf3052
  16. switch (rt2x00dev->default_ant.tx_chain_num) {
  17. case 1:
  18. rt2x00_set_field8(&rfcsr, RFCSR1_TX1_PD, 1);
  19. + /* fall through */
  20. case 2:
  21. rt2x00_set_field8(&rfcsr, RFCSR1_TX2_PD, 1);
  22. break;
  23. @@ -2490,6 +2491,7 @@ static void rt2800_config_channel_rf3052
  24. switch (rt2x00dev->default_ant.rx_chain_num) {
  25. case 1:
  26. rt2x00_set_field8(&rfcsr, RFCSR1_RX1_PD, 1);
  27. + /* fall through */
  28. case 2:
  29. rt2x00_set_field8(&rfcsr, RFCSR1_RX2_PD, 1);
  30. break;
  31. @@ -9457,8 +9459,10 @@ static int rt2800_probe_hw_mode(struct r
  32. switch (rx_chains) {
  33. case 3:
  34. spec->ht.mcs.rx_mask[2] = 0xff;
  35. + /* fall through */
  36. case 2:
  37. spec->ht.mcs.rx_mask[1] = 0xff;
  38. + /* fall through */
  39. case 1:
  40. spec->ht.mcs.rx_mask[0] = 0xff;
  41. spec->ht.mcs.rx_mask[4] = 0x1; /* MCS32 */