| 12345678910111213141516171819202122232425262728293031323334353637383940414243 |
- From patchwork Tue Mar 12 09:51:43 2019
- Content-Type: text/plain; charset="utf-8"
- MIME-Version: 1.0
- Content-Transfer-Encoding: 7bit
- X-Patchwork-Submitter: Stanislaw Gruszka <[email protected]>
- X-Patchwork-Id: 10848963
- X-Patchwork-Delegate: [email protected]
- From: Stanislaw Gruszka <[email protected]>
- To: [email protected]
- Cc: =?utf-8?q?Tomislav_Po=C5=BEega?= <[email protected]>,
- Daniel Golle <[email protected]>, Felix Fietkau <[email protected]>,
- Mathias Kresin <[email protected]>
- Subject: [PATCH v3 4/4] rt2x00: do not print error when queue is full
- Date: Tue, 12 Mar 2019 10:51:43 +0100
- Message-Id: <[email protected]>
- In-Reply-To: <[email protected]>
- References: <[email protected]>
- For unknown reasons printk() on some context can cause CPU hung on
- embedded MT7620 AP/router MIPS platforms. What can result on wifi
- disconnects.
- This patch move queue full messages to debug level what is consistent
- with other mac80211 drivers which drop packet silently if tx queue is
- full. This make MT7620 OpenWRT routers more stable, what was reported
- by various users.
- Signed-off-by: Stanislaw Gruszka <[email protected]>
- ---
- drivers/net/wireless/ralink/rt2x00/rt2x00queue.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
- --- a/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c
- +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c
- @@ -671,7 +671,7 @@ int rt2x00queue_write_tx_frame(struct da
- spin_lock(&queue->tx_lock);
-
- if (unlikely(rt2x00queue_full(queue))) {
- - rt2x00_err(queue->rt2x00dev, "Dropping frame due to full tx queue %d\n",
- + rt2x00_dbg(queue->rt2x00dev, "Dropping frame due to full tx queue %d\n",
- queue->qid);
- ret = -ENOBUFS;
- goto out;
|
