0033-soc-mediatek-PMIC-wrap-add-wrapper-callbacks-for-ini.patch 3.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127
  1. From 4265837216132e2b1c04b23e77281c1a4feb6ca8 Mon Sep 17 00:00:00 2001
  2. From: John Crispin <[email protected]>
  3. Date: Wed, 20 Jan 2016 05:27:17 +0100
  4. Subject: [PATCH 33/90] soc: mediatek: PMIC wrap: add wrapper callbacks for
  5. init_reg_clock
  6. Split init_reg_clock up into SoC specific callbacks. The patch also
  7. reorders the code to avoid the need for callback function prototypes.
  8. Signed-off-by: John Crispin <[email protected]>
  9. ---
  10. drivers/soc/mediatek/mtk-pmic-wrap.c | 70 ++++++++++++++++++----------------
  11. 1 file changed, 38 insertions(+), 32 deletions(-)
  12. diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
  13. index 340c4b5..b22b664 100644
  14. --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
  15. +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
  16. @@ -354,24 +354,6 @@ enum pwrap_type {
  17. PWRAP_MT8173,
  18. };
  19. -struct pmic_wrapper_type {
  20. - int *regs;
  21. - enum pwrap_type type;
  22. - u32 arb_en_all;
  23. -};
  24. -
  25. -static struct pmic_wrapper_type pwrap_mt8135 = {
  26. - .regs = mt8135_regs,
  27. - .type = PWRAP_MT8135,
  28. - .arb_en_all = 0x1ff,
  29. -};
  30. -
  31. -static struct pmic_wrapper_type pwrap_mt8173 = {
  32. - .regs = mt8173_regs,
  33. - .type = PWRAP_MT8173,
  34. - .arb_en_all = 0x3f,
  35. -};
  36. -
  37. struct pmic_wrapper {
  38. struct device *dev;
  39. void __iomem *base;
  40. @@ -385,6 +367,13 @@ struct pmic_wrapper {
  41. void __iomem *bridge_base;
  42. };
  43. +struct pmic_wrapper_type {
  44. + int *regs;
  45. + enum pwrap_type type;
  46. + u32 arb_en_all;
  47. + int (*init_reg_clock)(struct pmic_wrapper *wrp);
  48. +};
  49. +
  50. static inline int pwrap_is_mt8135(struct pmic_wrapper *wrp)
  51. {
  52. return wrp->master->type == PWRAP_MT8135;
  53. @@ -578,20 +567,23 @@ static int pwrap_init_sidly(struct pmic_wrapper *wrp)
  54. return 0;
  55. }
  56. -static int pwrap_init_reg_clock(struct pmic_wrapper *wrp)
  57. +static int pwrap_mt8135_init_reg_clock(struct pmic_wrapper *wrp)
  58. {
  59. - if (pwrap_is_mt8135(wrp)) {
  60. - pwrap_writel(wrp, 0x4, PWRAP_CSHEXT);
  61. - pwrap_writel(wrp, 0x0, PWRAP_CSHEXT_WRITE);
  62. - pwrap_writel(wrp, 0x4, PWRAP_CSHEXT_READ);
  63. - pwrap_writel(wrp, 0x0, PWRAP_CSLEXT_START);
  64. - pwrap_writel(wrp, 0x0, PWRAP_CSLEXT_END);
  65. - } else {
  66. - pwrap_writel(wrp, 0x0, PWRAP_CSHEXT_WRITE);
  67. - pwrap_writel(wrp, 0x4, PWRAP_CSHEXT_READ);
  68. - pwrap_writel(wrp, 0x2, PWRAP_CSLEXT_START);
  69. - pwrap_writel(wrp, 0x2, PWRAP_CSLEXT_END);
  70. - }
  71. + pwrap_writel(wrp, 0x4, PWRAP_CSHEXT);
  72. + pwrap_writel(wrp, 0x0, PWRAP_CSHEXT_WRITE);
  73. + pwrap_writel(wrp, 0x4, PWRAP_CSHEXT_READ);
  74. + pwrap_writel(wrp, 0x0, PWRAP_CSLEXT_START);
  75. + pwrap_writel(wrp, 0x0, PWRAP_CSLEXT_END);
  76. +
  77. + return 0;
  78. +}
  79. +
  80. +static int pwrap_mt8173_init_reg_clock(struct pmic_wrapper *wrp)
  81. +{
  82. + pwrap_writel(wrp, 0x0, PWRAP_CSHEXT_WRITE);
  83. + pwrap_writel(wrp, 0x4, PWRAP_CSHEXT_READ);
  84. + pwrap_writel(wrp, 0x2, PWRAP_CSLEXT_START);
  85. + pwrap_writel(wrp, 0x2, PWRAP_CSLEXT_END);
  86. return 0;
  87. }
  88. @@ -699,7 +691,7 @@ static int pwrap_init(struct pmic_wrapper *wrp)
  89. pwrap_writel(wrp, 1, PWRAP_WACS2_EN);
  90. - ret = pwrap_init_reg_clock(wrp);
  91. + ret = wrp->master->init_reg_clock(wrp);
  92. if (ret)
  93. return ret;
  94. @@ -814,6 +806,20 @@ static const struct regmap_config pwrap_regmap_config = {
  95. .max_register = 0xffff,
  96. };
  97. +static struct pmic_wrapper_type pwrap_mt8135 = {
  98. + .regs = mt8135_regs,
  99. + .type = PWRAP_MT8135,
  100. + .arb_en_all = 0x1ff,
  101. + .init_reg_clock = pwrap_mt8135_init_reg_clock,
  102. +};
  103. +
  104. +static struct pmic_wrapper_type pwrap_mt8173 = {
  105. + .regs = mt8173_regs,
  106. + .type = PWRAP_MT8173,
  107. + .arb_en_all = 0x3f,
  108. + .init_reg_clock = pwrap_mt8173_init_reg_clock,
  109. +};
  110. +
  111. static struct of_device_id of_pwrap_match_tbl[] = {
  112. {
  113. .compatible = "mediatek,mt8135-pwrap",
  114. --
  115. 1.7.10.4