815-v6.4-02-net-dsa-qca8k-add-LEDs-basic-support.patch 13 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435
  1. From 1e264f9d2918b5737023c44a23ae04def1095210 Mon Sep 17 00:00:00 2001
  2. From: Christian Marangi <[email protected]>
  3. Date: Mon, 17 Apr 2023 17:17:24 +0200
  4. Subject: [PATCH 2/9] net: dsa: qca8k: add LEDs basic support
  5. Add LEDs basic support for qca8k Switch Family by adding basic
  6. brightness_set() support.
  7. Since these LEDs refelect port status, the default label is set to
  8. ":port". DT binding should describe the color and function of the
  9. LEDs using standard LEDs api.
  10. Each LED always have the device name as prefix. The device name is
  11. composed from the mii bus id and the PHY addr resulting in example
  12. names like:
  13. - qca8k-0.0:00:amber:lan
  14. - qca8k-0.0:00:white:lan
  15. - qca8k-0.0:01:amber:lan
  16. - qca8k-0.0:01:white:lan
  17. These LEDs supports only blocking variant of the brightness_set()
  18. function since they can sleep during access of the switch leds to set
  19. the brightness.
  20. While at it add to the qca8k header file each mode defined by the Switch
  21. Documentation for future use.
  22. Signed-off-by: Christian Marangi <[email protected]>
  23. Reviewed-by: Florian Fainelli <[email protected]>
  24. Signed-off-by: David S. Miller <[email protected]>
  25. ---
  26. drivers/net/dsa/qca/Kconfig | 8 ++
  27. drivers/net/dsa/qca/Makefile | 3 +
  28. drivers/net/dsa/qca/qca8k-8xxx.c | 5 +
  29. drivers/net/dsa/qca/qca8k-leds.c | 239 +++++++++++++++++++++++++++++++
  30. drivers/net/dsa/qca/qca8k.h | 60 ++++++++
  31. drivers/net/dsa/qca/qca8k_leds.h | 16 +++
  32. 6 files changed, 331 insertions(+)
  33. create mode 100644 drivers/net/dsa/qca/qca8k-leds.c
  34. create mode 100644 drivers/net/dsa/qca/qca8k_leds.h
  35. --- a/drivers/net/dsa/qca/Kconfig
  36. +++ b/drivers/net/dsa/qca/Kconfig
  37. @@ -15,3 +15,11 @@ config NET_DSA_QCA8K
  38. help
  39. This enables support for the Qualcomm Atheros QCA8K Ethernet
  40. switch chips.
  41. +
  42. +config NET_DSA_QCA8K_LEDS_SUPPORT
  43. + bool "Qualcomm Atheros QCA8K Ethernet switch family LEDs support"
  44. + depends on NET_DSA_QCA8K
  45. + depends on LEDS_CLASS
  46. + help
  47. + This enabled support for LEDs present on the Qualcomm Atheros
  48. + QCA8K Ethernet switch chips.
  49. --- a/drivers/net/dsa/qca/Makefile
  50. +++ b/drivers/net/dsa/qca/Makefile
  51. @@ -2,3 +2,6 @@
  52. obj-$(CONFIG_NET_DSA_AR9331) += ar9331.o
  53. obj-$(CONFIG_NET_DSA_QCA8K) += qca8k.o
  54. qca8k-y += qca8k-common.o qca8k-8xxx.o
  55. +ifdef CONFIG_NET_DSA_QCA8K_LEDS_SUPPORT
  56. +qca8k-y += qca8k-leds.o
  57. +endif
  58. --- a/drivers/net/dsa/qca/qca8k-8xxx.c
  59. +++ b/drivers/net/dsa/qca/qca8k-8xxx.c
  60. @@ -22,6 +22,7 @@
  61. #include <linux/dsa/tag_qca.h>
  62. #include "qca8k.h"
  63. +#include "qca8k_leds.h"
  64. static void
  65. qca8k_split_addr(u32 regaddr, u16 *r1, u16 *r2, u16 *page)
  66. @@ -1185,6 +1186,10 @@ qca8k_setup(struct dsa_switch *ds)
  67. if (ret)
  68. return ret;
  69. + ret = qca8k_setup_led_ctrl(priv);
  70. + if (ret)
  71. + return ret;
  72. +
  73. /* Make sure MAC06 is disabled */
  74. ret = regmap_clear_bits(priv->regmap, QCA8K_REG_PORT0_PAD_CTRL,
  75. QCA8K_PORT0_PAD_MAC06_EXCHANGE_EN);
  76. --- /dev/null
  77. +++ b/drivers/net/dsa/qca/qca8k-leds.c
  78. @@ -0,0 +1,239 @@
  79. +// SPDX-License-Identifier: GPL-2.0
  80. +#include <linux/regmap.h>
  81. +#include <net/dsa.h>
  82. +
  83. +#include "qca8k.h"
  84. +#include "qca8k_leds.h"
  85. +
  86. +static int
  87. +qca8k_get_enable_led_reg(int port_num, int led_num, struct qca8k_led_pattern_en *reg_info)
  88. +{
  89. + switch (port_num) {
  90. + case 0:
  91. + reg_info->reg = QCA8K_LED_CTRL_REG(led_num);
  92. + reg_info->shift = QCA8K_LED_PHY0123_CONTROL_RULE_SHIFT;
  93. + break;
  94. + case 1:
  95. + case 2:
  96. + case 3:
  97. + /* Port 123 are controlled on a different reg */
  98. + reg_info->reg = QCA8K_LED_CTRL3_REG;
  99. + reg_info->shift = QCA8K_LED_PHY123_PATTERN_EN_SHIFT(port_num, led_num);
  100. + break;
  101. + case 4:
  102. + reg_info->reg = QCA8K_LED_CTRL_REG(led_num);
  103. + reg_info->shift = QCA8K_LED_PHY4_CONTROL_RULE_SHIFT;
  104. + break;
  105. + default:
  106. + return -EINVAL;
  107. + }
  108. +
  109. + return 0;
  110. +}
  111. +
  112. +static int
  113. +qca8k_led_brightness_set(struct qca8k_led *led,
  114. + enum led_brightness brightness)
  115. +{
  116. + struct qca8k_led_pattern_en reg_info;
  117. + struct qca8k_priv *priv = led->priv;
  118. + u32 mask, val;
  119. +
  120. + qca8k_get_enable_led_reg(led->port_num, led->led_num, &reg_info);
  121. +
  122. + val = QCA8K_LED_ALWAYS_OFF;
  123. + if (brightness)
  124. + val = QCA8K_LED_ALWAYS_ON;
  125. +
  126. + /* HW regs to control brightness is special and port 1-2-3
  127. + * are placed in a different reg.
  128. + *
  129. + * To control port 0 brightness:
  130. + * - the 2 bit (15, 14) of:
  131. + * - QCA8K_LED_CTRL0_REG for led1
  132. + * - QCA8K_LED_CTRL1_REG for led2
  133. + * - QCA8K_LED_CTRL2_REG for led3
  134. + *
  135. + * To control port 4:
  136. + * - the 2 bit (31, 30) of:
  137. + * - QCA8K_LED_CTRL0_REG for led1
  138. + * - QCA8K_LED_CTRL1_REG for led2
  139. + * - QCA8K_LED_CTRL2_REG for led3
  140. + *
  141. + * To control port 1:
  142. + * - the 2 bit at (9, 8) of QCA8K_LED_CTRL3_REG are used for led1
  143. + * - the 2 bit at (11, 10) of QCA8K_LED_CTRL3_REG are used for led2
  144. + * - the 2 bit at (13, 12) of QCA8K_LED_CTRL3_REG are used for led3
  145. + *
  146. + * To control port 2:
  147. + * - the 2 bit at (15, 14) of QCA8K_LED_CTRL3_REG are used for led1
  148. + * - the 2 bit at (17, 16) of QCA8K_LED_CTRL3_REG are used for led2
  149. + * - the 2 bit at (19, 18) of QCA8K_LED_CTRL3_REG are used for led3
  150. + *
  151. + * To control port 3:
  152. + * - the 2 bit at (21, 20) of QCA8K_LED_CTRL3_REG are used for led1
  153. + * - the 2 bit at (23, 22) of QCA8K_LED_CTRL3_REG are used for led2
  154. + * - the 2 bit at (25, 24) of QCA8K_LED_CTRL3_REG are used for led3
  155. + *
  156. + * To abstract this and have less code, we use the port and led numm
  157. + * to calculate the shift and the correct reg due to this problem of
  158. + * not having a 1:1 map of LED with the regs.
  159. + */
  160. + if (led->port_num == 0 || led->port_num == 4) {
  161. + mask = QCA8K_LED_PATTERN_EN_MASK;
  162. + val <<= QCA8K_LED_PATTERN_EN_SHIFT;
  163. + } else {
  164. + mask = QCA8K_LED_PHY123_PATTERN_EN_MASK;
  165. + }
  166. +
  167. + return regmap_update_bits(priv->regmap, reg_info.reg,
  168. + mask << reg_info.shift,
  169. + val << reg_info.shift);
  170. +}
  171. +
  172. +static int
  173. +qca8k_cled_brightness_set_blocking(struct led_classdev *ldev,
  174. + enum led_brightness brightness)
  175. +{
  176. + struct qca8k_led *led = container_of(ldev, struct qca8k_led, cdev);
  177. +
  178. + return qca8k_led_brightness_set(led, brightness);
  179. +}
  180. +
  181. +static enum led_brightness
  182. +qca8k_led_brightness_get(struct qca8k_led *led)
  183. +{
  184. + struct qca8k_led_pattern_en reg_info;
  185. + struct qca8k_priv *priv = led->priv;
  186. + u32 val;
  187. + int ret;
  188. +
  189. + qca8k_get_enable_led_reg(led->port_num, led->led_num, &reg_info);
  190. +
  191. + ret = regmap_read(priv->regmap, reg_info.reg, &val);
  192. + if (ret)
  193. + return 0;
  194. +
  195. + val >>= reg_info.shift;
  196. +
  197. + if (led->port_num == 0 || led->port_num == 4) {
  198. + val &= QCA8K_LED_PATTERN_EN_MASK;
  199. + val >>= QCA8K_LED_PATTERN_EN_SHIFT;
  200. + } else {
  201. + val &= QCA8K_LED_PHY123_PATTERN_EN_MASK;
  202. + }
  203. +
  204. + /* Assume brightness ON only when the LED is set to always ON */
  205. + return val == QCA8K_LED_ALWAYS_ON;
  206. +}
  207. +
  208. +static int
  209. +qca8k_parse_port_leds(struct qca8k_priv *priv, struct fwnode_handle *port, int port_num)
  210. +{
  211. + struct fwnode_handle *led = NULL, *leds = NULL;
  212. + struct led_init_data init_data = { };
  213. + struct dsa_switch *ds = priv->ds;
  214. + enum led_default_state state;
  215. + struct qca8k_led *port_led;
  216. + int led_num, led_index;
  217. + int ret;
  218. +
  219. + leds = fwnode_get_named_child_node(port, "leds");
  220. + if (!leds) {
  221. + dev_dbg(priv->dev, "No Leds node specified in device tree for port %d!\n",
  222. + port_num);
  223. + return 0;
  224. + }
  225. +
  226. + fwnode_for_each_child_node(leds, led) {
  227. + /* Reg represent the led number of the port.
  228. + * Each port can have at most 3 leds attached
  229. + * Commonly:
  230. + * 1. is gigabit led
  231. + * 2. is mbit led
  232. + * 3. additional status led
  233. + */
  234. + if (fwnode_property_read_u32(led, "reg", &led_num))
  235. + continue;
  236. +
  237. + if (led_num >= QCA8K_LED_PORT_COUNT) {
  238. + dev_warn(priv->dev, "Invalid LED reg %d defined for port %d",
  239. + led_num, port_num);
  240. + continue;
  241. + }
  242. +
  243. + led_index = QCA8K_LED_PORT_INDEX(port_num, led_num);
  244. +
  245. + port_led = &priv->ports_led[led_index];
  246. + port_led->port_num = port_num;
  247. + port_led->led_num = led_num;
  248. + port_led->priv = priv;
  249. +
  250. + state = led_init_default_state_get(led);
  251. + switch (state) {
  252. + case LEDS_DEFSTATE_ON:
  253. + port_led->cdev.brightness = 1;
  254. + qca8k_led_brightness_set(port_led, 1);
  255. + break;
  256. + case LEDS_DEFSTATE_KEEP:
  257. + port_led->cdev.brightness =
  258. + qca8k_led_brightness_get(port_led);
  259. + break;
  260. + default:
  261. + port_led->cdev.brightness = 0;
  262. + qca8k_led_brightness_set(port_led, 0);
  263. + }
  264. +
  265. + port_led->cdev.max_brightness = 1;
  266. + port_led->cdev.brightness_set_blocking = qca8k_cled_brightness_set_blocking;
  267. + init_data.default_label = ":port";
  268. + init_data.fwnode = led;
  269. + init_data.devname_mandatory = true;
  270. + init_data.devicename = kasprintf(GFP_KERNEL, "%s:0%d", ds->slave_mii_bus->id,
  271. + port_num);
  272. + if (!init_data.devicename)
  273. + return -ENOMEM;
  274. +
  275. + ret = devm_led_classdev_register_ext(priv->dev, &port_led->cdev, &init_data);
  276. + if (ret)
  277. + dev_warn(priv->dev, "Failed to init LED %d for port %d", led_num, port_num);
  278. +
  279. + kfree(init_data.devicename);
  280. + }
  281. +
  282. + return 0;
  283. +}
  284. +
  285. +int
  286. +qca8k_setup_led_ctrl(struct qca8k_priv *priv)
  287. +{
  288. + struct fwnode_handle *ports, *port;
  289. + int port_num;
  290. + int ret;
  291. +
  292. + ports = device_get_named_child_node(priv->dev, "ports");
  293. + if (!ports) {
  294. + dev_info(priv->dev, "No ports node specified in device tree!");
  295. + return 0;
  296. + }
  297. +
  298. + fwnode_for_each_child_node(ports, port) {
  299. + if (fwnode_property_read_u32(port, "reg", &port_num))
  300. + continue;
  301. +
  302. + /* Skip checking for CPU port 0 and CPU port 6 as not supported */
  303. + if (port_num == 0 || port_num == 6)
  304. + continue;
  305. +
  306. + /* Each port can have at most 3 different leds attached.
  307. + * Switch port starts from 0 to 6, but port 0 and 6 are CPU
  308. + * port. The port index needs to be decreased by one to identify
  309. + * the correct port for LED setup.
  310. + */
  311. + ret = qca8k_parse_port_leds(priv, port, qca8k_port_to_phy(port_num));
  312. + if (ret)
  313. + return ret;
  314. + }
  315. +
  316. + return 0;
  317. +}
  318. --- a/drivers/net/dsa/qca/qca8k.h
  319. +++ b/drivers/net/dsa/qca/qca8k.h
  320. @@ -11,6 +11,7 @@
  321. #include <linux/delay.h>
  322. #include <linux/regmap.h>
  323. #include <linux/gpio.h>
  324. +#include <linux/leds.h>
  325. #include <linux/dsa/tag_qca.h>
  326. #define QCA8K_ETHERNET_MDIO_PRIORITY 7
  327. @@ -85,6 +86,51 @@
  328. #define QCA8K_MDIO_MASTER_DATA(x) FIELD_PREP(QCA8K_MDIO_MASTER_DATA_MASK, x)
  329. #define QCA8K_MDIO_MASTER_MAX_PORTS 5
  330. #define QCA8K_MDIO_MASTER_MAX_REG 32
  331. +
  332. +/* LED control register */
  333. +#define QCA8K_LED_PORT_COUNT 3
  334. +#define QCA8K_LED_COUNT ((QCA8K_NUM_PORTS - QCA8K_NUM_CPU_PORTS) * QCA8K_LED_PORT_COUNT)
  335. +#define QCA8K_LED_RULE_COUNT 6
  336. +#define QCA8K_LED_RULE_MAX 11
  337. +#define QCA8K_LED_PORT_INDEX(_phy, _led) (((_phy) * QCA8K_LED_PORT_COUNT) + (_led))
  338. +
  339. +#define QCA8K_LED_PHY123_PATTERN_EN_SHIFT(_phy, _led) ((((_phy) - 1) * 6) + 8 + (2 * (_led)))
  340. +#define QCA8K_LED_PHY123_PATTERN_EN_MASK GENMASK(1, 0)
  341. +
  342. +#define QCA8K_LED_PHY0123_CONTROL_RULE_SHIFT 0
  343. +#define QCA8K_LED_PHY4_CONTROL_RULE_SHIFT 16
  344. +
  345. +#define QCA8K_LED_CTRL_REG(_i) (0x050 + (_i) * 4)
  346. +#define QCA8K_LED_CTRL0_REG 0x50
  347. +#define QCA8K_LED_CTRL1_REG 0x54
  348. +#define QCA8K_LED_CTRL2_REG 0x58
  349. +#define QCA8K_LED_CTRL3_REG 0x5C
  350. +#define QCA8K_LED_CTRL_SHIFT(_i) (((_i) % 2) * 16)
  351. +#define QCA8K_LED_CTRL_MASK GENMASK(15, 0)
  352. +#define QCA8K_LED_RULE_MASK GENMASK(13, 0)
  353. +#define QCA8K_LED_BLINK_FREQ_MASK GENMASK(1, 0)
  354. +#define QCA8K_LED_BLINK_FREQ_SHITF 0
  355. +#define QCA8K_LED_BLINK_2HZ 0
  356. +#define QCA8K_LED_BLINK_4HZ 1
  357. +#define QCA8K_LED_BLINK_8HZ 2
  358. +#define QCA8K_LED_BLINK_AUTO 3
  359. +#define QCA8K_LED_LINKUP_OVER_MASK BIT(2)
  360. +#define QCA8K_LED_TX_BLINK_MASK BIT(4)
  361. +#define QCA8K_LED_RX_BLINK_MASK BIT(5)
  362. +#define QCA8K_LED_COL_BLINK_MASK BIT(7)
  363. +#define QCA8K_LED_LINK_10M_EN_MASK BIT(8)
  364. +#define QCA8K_LED_LINK_100M_EN_MASK BIT(9)
  365. +#define QCA8K_LED_LINK_1000M_EN_MASK BIT(10)
  366. +#define QCA8K_LED_POWER_ON_LIGHT_MASK BIT(11)
  367. +#define QCA8K_LED_HALF_DUPLEX_MASK BIT(12)
  368. +#define QCA8K_LED_FULL_DUPLEX_MASK BIT(13)
  369. +#define QCA8K_LED_PATTERN_EN_MASK GENMASK(15, 14)
  370. +#define QCA8K_LED_PATTERN_EN_SHIFT 14
  371. +#define QCA8K_LED_ALWAYS_OFF 0
  372. +#define QCA8K_LED_ALWAYS_BLINK_4HZ 1
  373. +#define QCA8K_LED_ALWAYS_ON 2
  374. +#define QCA8K_LED_RULE_CONTROLLED 3
  375. +
  376. #define QCA8K_GOL_MAC_ADDR0 0x60
  377. #define QCA8K_GOL_MAC_ADDR1 0x64
  378. #define QCA8K_MAX_FRAME_SIZE 0x78
  379. @@ -377,6 +423,19 @@ struct qca8k_mdio_cache {
  380. u16 page;
  381. };
  382. +struct qca8k_led_pattern_en {
  383. + u32 reg;
  384. + u8 shift;
  385. +};
  386. +
  387. +struct qca8k_led {
  388. + u8 port_num;
  389. + u8 led_num;
  390. + u16 old_rule;
  391. + struct qca8k_priv *priv;
  392. + struct led_classdev cdev;
  393. +};
  394. +
  395. struct qca8k_priv {
  396. u8 switch_id;
  397. u8 switch_revision;
  398. @@ -399,6 +458,7 @@ struct qca8k_priv {
  399. struct qca8k_mib_eth_data mib_eth_data;
  400. struct qca8k_mdio_cache mdio_cache;
  401. const struct qca8k_match_data *info;
  402. + struct qca8k_led ports_led[QCA8K_LED_COUNT];
  403. };
  404. struct qca8k_mib_desc {
  405. --- /dev/null
  406. +++ b/drivers/net/dsa/qca/qca8k_leds.h
  407. @@ -0,0 +1,16 @@
  408. +/* SPDX-License-Identifier: GPL-2.0-only */
  409. +
  410. +#ifndef __QCA8K_LEDS_H
  411. +#define __QCA8K_LEDS_H
  412. +
  413. +/* Leds Support function */
  414. +#ifdef CONFIG_NET_DSA_QCA8K_LEDS_SUPPORT
  415. +int qca8k_setup_led_ctrl(struct qca8k_priv *priv);
  416. +#else
  417. +static inline int qca8k_setup_led_ctrl(struct qca8k_priv *priv)
  418. +{
  419. + return 0;
  420. +}
  421. +#endif
  422. +
  423. +#endif /* __QCA8K_LEDS_H */