020-20-rt2x00-reverse-external-PA-capability-flag-logic.patch 4.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121
  1. From 1f242a3de702d5a19c479685d35b050837122724 Mon Sep 17 00:00:00 2001
  2. From: Daniel Golle <[email protected]>
  3. Date: Mon, 10 Apr 2017 15:29:45 +0200
  4. Subject: [PATCH] rt2x00: reverse external PA capability flag logic
  5. Consequently refer to external PA instead of inverting the logic and
  6. use an internal PA capability flag which is a bit confusing.
  7. Currently this is used for Rt3352 only, but MT7620A also allows for an
  8. external PA which will be supported by a follow up patch.
  9. Signed-off-by: Daniel Golle <[email protected]>
  10. Acked-by: Stanislaw Gruszka <[email protected]>
  11. Signed-off-by: Kalle Valo <[email protected]>
  12. ---
  13. drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 40 +++++++++++++-------------
  14. drivers/net/wireless/ralink/rt2x00/rt2x00.h | 4 +--
  15. 2 files changed, 22 insertions(+), 22 deletions(-)
  16. --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
  17. +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
  18. @@ -7014,9 +7014,9 @@ static void rt2800_init_rfcsr_3290(struc
  19. static void rt2800_init_rfcsr_3352(struct rt2x00_dev *rt2x00dev)
  20. {
  21. - int tx0_int_pa = test_bit(CAPABILITY_INTERNAL_PA_TX0,
  22. + int tx0_ext_pa = test_bit(CAPABILITY_EXTERNAL_PA_TX0,
  23. &rt2x00dev->cap_flags);
  24. - int tx1_int_pa = test_bit(CAPABILITY_INTERNAL_PA_TX1,
  25. + int tx1_ext_pa = test_bit(CAPABILITY_EXTERNAL_PA_TX1,
  26. &rt2x00dev->cap_flags);
  27. u8 rfcsr;
  28. @@ -7056,9 +7056,9 @@ static void rt2800_init_rfcsr_3352(struc
  29. rt2800_rfcsr_write(rt2x00dev, 32, 0x80);
  30. rt2800_rfcsr_write(rt2x00dev, 33, 0x00);
  31. rfcsr = 0x01;
  32. - if (!tx0_int_pa)
  33. + if (tx0_ext_pa)
  34. rt2x00_set_field8(&rfcsr, RFCSR34_TX0_EXT_PA, 1);
  35. - if (!tx1_int_pa)
  36. + if (tx1_ext_pa)
  37. rt2x00_set_field8(&rfcsr, RFCSR34_TX1_EXT_PA, 1);
  38. rt2800_rfcsr_write(rt2x00dev, 34, rfcsr);
  39. rt2800_rfcsr_write(rt2x00dev, 35, 0x03);
  40. @@ -7068,13 +7068,13 @@ static void rt2800_init_rfcsr_3352(struc
  41. rt2800_rfcsr_write(rt2x00dev, 39, 0xc5);
  42. rt2800_rfcsr_write(rt2x00dev, 40, 0x33);
  43. rfcsr = 0x52;
  44. - if (tx0_int_pa) {
  45. + if (!tx0_ext_pa) {
  46. rt2x00_set_field8(&rfcsr, RFCSR41_BIT1, 1);
  47. rt2x00_set_field8(&rfcsr, RFCSR41_BIT4, 1);
  48. }
  49. rt2800_rfcsr_write(rt2x00dev, 41, rfcsr);
  50. rfcsr = 0x52;
  51. - if (tx1_int_pa) {
  52. + if (!tx1_ext_pa) {
  53. rt2x00_set_field8(&rfcsr, RFCSR42_BIT1, 1);
  54. rt2x00_set_field8(&rfcsr, RFCSR42_BIT4, 1);
  55. }
  56. @@ -7087,19 +7087,19 @@ static void rt2800_init_rfcsr_3352(struc
  57. rt2800_rfcsr_write(rt2x00dev, 48, 0x14);
  58. rt2800_rfcsr_write(rt2x00dev, 49, 0x00);
  59. rfcsr = 0x2d;
  60. - if (!tx0_int_pa)
  61. + if (tx0_ext_pa)
  62. rt2x00_set_field8(&rfcsr, RFCSR50_TX0_EXT_PA, 1);
  63. - if (!tx1_int_pa)
  64. + if (tx1_ext_pa)
  65. rt2x00_set_field8(&rfcsr, RFCSR50_TX1_EXT_PA, 1);
  66. rt2800_rfcsr_write(rt2x00dev, 50, rfcsr);
  67. - rt2800_rfcsr_write(rt2x00dev, 51, (tx0_int_pa ? 0x7f : 0x52));
  68. - rt2800_rfcsr_write(rt2x00dev, 52, (tx0_int_pa ? 0x00 : 0xc0));
  69. - rt2800_rfcsr_write(rt2x00dev, 53, (tx0_int_pa ? 0x52 : 0xd2));
  70. - rt2800_rfcsr_write(rt2x00dev, 54, (tx0_int_pa ? 0x1b : 0xc0));
  71. - rt2800_rfcsr_write(rt2x00dev, 55, (tx1_int_pa ? 0x7f : 0x52));
  72. - rt2800_rfcsr_write(rt2x00dev, 56, (tx1_int_pa ? 0x00 : 0xc0));
  73. - rt2800_rfcsr_write(rt2x00dev, 57, (tx0_int_pa ? 0x52 : 0x49));
  74. - rt2800_rfcsr_write(rt2x00dev, 58, (tx1_int_pa ? 0x1b : 0xc0));
  75. + rt2800_rfcsr_write(rt2x00dev, 51, (tx0_ext_pa ? 0x52 : 0x7f));
  76. + rt2800_rfcsr_write(rt2x00dev, 52, (tx0_ext_pa ? 0xc0 : 0x00));
  77. + rt2800_rfcsr_write(rt2x00dev, 53, (tx0_ext_pa ? 0xd2 : 0x52));
  78. + rt2800_rfcsr_write(rt2x00dev, 54, (tx0_ext_pa ? 0xc0 : 0x1b));
  79. + rt2800_rfcsr_write(rt2x00dev, 55, (tx1_ext_pa ? 0x52 : 0x7f));
  80. + rt2800_rfcsr_write(rt2x00dev, 56, (tx1_ext_pa ? 0xc0 : 0x00));
  81. + rt2800_rfcsr_write(rt2x00dev, 57, (tx0_ext_pa ? 0x49 : 0x52));
  82. + rt2800_rfcsr_write(rt2x00dev, 58, (tx1_ext_pa ? 0xc0 : 0x1b));
  83. rt2800_rfcsr_write(rt2x00dev, 59, 0x00);
  84. rt2800_rfcsr_write(rt2x00dev, 60, 0x00);
  85. rt2800_rfcsr_write(rt2x00dev, 61, 0x00);
  86. @@ -8782,13 +8782,13 @@ static int rt2800_init_eeprom(struct rt2
  87. rt2800_eeprom_read(rt2x00dev, EEPROM_NIC_CONF1, &eeprom);
  88. if (rt2x00_rt(rt2x00dev, RT3352)) {
  89. - if (!rt2x00_get_field16(eeprom,
  90. + if (rt2x00_get_field16(eeprom,
  91. EEPROM_NIC_CONF1_EXTERNAL_TX0_PA_3352))
  92. - __set_bit(CAPABILITY_INTERNAL_PA_TX0,
  93. + __set_bit(CAPABILITY_EXTERNAL_PA_TX0,
  94. &rt2x00dev->cap_flags);
  95. - if (!rt2x00_get_field16(eeprom,
  96. + if (rt2x00_get_field16(eeprom,
  97. EEPROM_NIC_CONF1_EXTERNAL_TX1_PA_3352))
  98. - __set_bit(CAPABILITY_INTERNAL_PA_TX1,
  99. + __set_bit(CAPABILITY_EXTERNAL_PA_TX1,
  100. &rt2x00dev->cap_flags);
  101. }
  102. --- a/drivers/net/wireless/ralink/rt2x00/rt2x00.h
  103. +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00.h
  104. @@ -719,8 +719,8 @@ enum rt2x00_capability_flags {
  105. CAPABILITY_DOUBLE_ANTENNA,
  106. CAPABILITY_BT_COEXIST,
  107. CAPABILITY_VCO_RECALIBRATION,
  108. - CAPABILITY_INTERNAL_PA_TX0,
  109. - CAPABILITY_INTERNAL_PA_TX1,
  110. + CAPABILITY_EXTERNAL_PA_TX0,
  111. + CAPABILITY_EXTERNAL_PA_TX1,
  112. };
  113. /*